From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132EAC282C1 for ; Fri, 28 Feb 2025 16:34:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A005E6B0085; Fri, 28 Feb 2025 11:34:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AF65280003; Fri, 28 Feb 2025 11:34:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 876E0280001; Fri, 28 Feb 2025 11:34:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 689426B0085 for ; Fri, 28 Feb 2025 11:34:46 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EE8CF120EDD for ; Fri, 28 Feb 2025 16:34:45 +0000 (UTC) X-FDA: 83169902130.21.4614533 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf22.hostedemail.com (Postfix) with ESMTP id DFBDAC0002 for ; Fri, 28 Feb 2025 16:34:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=19KGV9AI; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740760484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dpU0lFGqtYRoNFVEtOP+JUt2h03+aqvi8yFjGxhcirQ=; b=DGgkSIZHj932jL9G6SdGzw/zOJYuvMHyo/6wmExWt/OVidISPGrDeGuaxe3wEf2WnAHp+4 gcH4G0w/lYaUF2p8bwYF2WhdqF0leqB6kjJtAq1OelcwqvkoFIRt9+lffZPJcprUGtPPo1 BWHJnbs2ksJo8oSxCNeuA28/BdhjYiA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=19KGV9AI; spf=pass (imf22.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740760484; a=rsa-sha256; cv=none; b=X0hGSU4Zu+//5NWNk6bsdORfHaklQXPhNq7hJBJXRc7LAgD6dewh3Ny3545p/PLQFdBId/ wylCMd3hnubeCopLhnJ3Qou9qhsPJlMcdJnP+kHJcmQAur1hKPoduZAqorCXNdtUNJ/9TN YwcSKxG0D4RXoYQFRSl9Fc7WZBCuG9M= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7c0b24cc566so190777585a.1 for ; Fri, 28 Feb 2025 08:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1740760483; x=1741365283; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dpU0lFGqtYRoNFVEtOP+JUt2h03+aqvi8yFjGxhcirQ=; b=19KGV9AIO3UM3K8SQ36B0IzmvI/vUS4l8DeLzUYBtlwG4mtKTNU+hglfG6JTEqNiwn NxflbWjFvIO5hjJdJaaPVWXjvbJXQ8/gOPWV0c97KkhGU5onNEGTwGlr+ACOE/Upjm2F BjABXH5kxCfNTqd8OQlxxt8o+Dgtj1R3wazhq7Wp6Qzs1DWqyRDRzUtIo6/zWav6uY01 /pxssoCANDXZ6AltzufgMd1B33qdWfqfsM9OpPafOBce5pDuKjY2XXICW9Uaj/0iHpko OW5kAa8o3LqrCmJeQm+nyzdkd9sWJu1xKQqmtIghKPWCS83LwFV/QMMIcxMsVwOe680R mp6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740760483; x=1741365283; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dpU0lFGqtYRoNFVEtOP+JUt2h03+aqvi8yFjGxhcirQ=; b=neac5/ADInerWAd7N4cwtASUDoF6PHxYy70rNr9TdWSNu0TEDNP1Zd9spf5+jpikC0 VhlDhwVjIRo0KT9Hh3hBlp9xGd53wPl3jYh2B83NpUx5kvmroyM4K1MFI8M6kR4EE7l1 v1cRKnAtVVzrK5i9JybY6xBtbKOljYob+Ytagib20YminG6o6alYbqk4eM0qSWm8fp96 dJ7Evqk/OPEzwNdpZJr5LqQmSzB0KsnKWEMNQahBrJKj5WLCH7Wd6bYwT9iU30xq3lQA dqVTUJf0Exa3UYEQNhU0HgznQ3ypHf8F7xAUxYu0FM2F7GPCR3Ihgb1XdV1oxYME1YcG biYg== X-Gm-Message-State: AOJu0YwPvWN+YZXzjR8JjVbYg5J5tX0nXMX7dILz5qRD3egc0gUfMPUW EDFR225pvy0mk8TKmAUbkROtZXxKqACDxOvg3X3rzofz0JpqbQR4N4zi5ELEY8k= X-Gm-Gg: ASbGncu/NKNh3ODesKYbEagt266Cb8BGbNGotX6N+ehqA1sT6FfzScn085lZo246a5i CIMNA1SD5jqzPdhwWT8gkyWQPAsFZ1I2iyf0qZTcNJQQsKdf4VdNxU8yxbObxY9qyyebnzMwJPq ZEPisJQ9kx82uuJOdC2d5vnHu7eoJ6/NWS3Y3Iiu9TueHKqNAMNl3N4Tf4sdEKaSgAJVNPXD3tp QrIcJByPHFKsTNhki726bjYU1TWkFfR+mqNHrGvY7MbjLWKCUge/kjJ/I7kXiAUA1aPSAw1Ww66 ZFCzrXjSk7Ryf25HnOB25DWT X-Google-Smtp-Source: AGHT+IGs98QG38PFOIvhi9Q2DrId4CvvnHTPHutGzhdKJFG61jxDasInVyfMwknWb3z7PFlqcE6/bw== X-Received: by 2002:a05:620a:3902:b0:7c0:6419:8bd3 with SMTP id af79cd13be357-7c39c4b678bmr526356785a.22.1740760482937; Fri, 28 Feb 2025 08:34:42 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c378dacd0bsm263161385a.90.2025.02.28.08.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 08:34:41 -0800 (PST) Date: Fri, 28 Feb 2025 11:34:37 -0500 From: Johannes Weiner To: Jingxiang Zeng Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, david@redhat.com, vbabka@suse.cz, muchun.song@linux.dev, chengming.zhou@linux.dev, kasong@tencent.com, lkp@intel.com, Zeng Jingxiang Subject: Re: [PATCH] mm/list_lru: allocate on first insert instead of allocation Message-ID: <20250228163437.GA120597@cmpxchg.org> References: <20250228113836.136318-1-jingxiangzeng.cas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250228113836.136318-1-jingxiangzeng.cas@gmail.com> X-Stat-Signature: ibhcey88n7eo5t7sfxqbcnwhzfkyoy81 X-Rspamd-Queue-Id: DFBDAC0002 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740760483-423099 X-HE-Meta: U2FsdGVkX1+d4maFcyZm7Zxm87hKOks6JyJa23IXzgE+3PBaTQFVKUnTJeRI28DmJERIISv9udANLAuQotvjxYl5Xa6dj5r0nOHgohY3Dgojx0YIZPGuzxLieiCgI4+zHD01YJ5aq22/fU8vsC+dUhrAPPI9pXM5D8c8dgHce9D8znxmBdEGtNUm+pA3z+ierDlmXdHTrUGCjs6JZsURdI0jx60k0BEZX+dPps3/sqTQAP+EHdsDbBXVHDrjdDPrZiozK6dpSfo/qSlS6m/ojagF1cW/fQpT27k9zXziiOOoUFzDZEbG3nNywr158j7XAjLoH/MXLg1NXoxCq/FutXJANRXlosV2uN3lzxIzAGvb1YYQLPwpYzaFTWZFYfJEuPeBXPJxlzf9PhGm6YIB0PTyX0r+rdjd9vRMluJCL4D+3Sp9CCnrDR9ZG7nKqk3K4DwvK4S0ac+wocBEgGlQiUgZ76IpHjYzhZb+8f9BLPgO7iohcohWlUSN8WU8Yjp/WdDJIz4jCUYkhtTgEPCOvyvkPiZb8bg9JxIMpKZFs0ZKidbKvoI1yaCoIvUVmr+5mAAeVPKk2ZMvcWVvINn9z8eEbt3qxXJSELiSAq4GrG1onIcqFFq7dpX0odrLYLfMTstckFr9IQ3NAmbpe/vNuxpxdCcMH1333iV8MTGWzIO1aFBc/xe8PDTL05irA5A6/y7AYy/ftt4TK/+YDoy4y7kRN30ZNz841cMnxdDRQGwyHMZIs1fC2530JL2Eq6eVoI3CY95EX4wyvR4tTYrPHPjQ48m36iD17uwa1SX1Yb866xFF9tJTyl1Yj9rf/lrFiO3PCq/UoGqMHV9AXP/1JkP8JVAhlX7t8hyfSJKfa1NrzqA0LRfI93mLflKqt1ONb7VP+KhziUcXBIXYV/tOBsATJdxBTM3/EKP7VMfaAU3yUFypPI/f9O8QTCgei4nRXzOLbKOGT0+GYrxTAt3 sKDI41p7 r3nu5mwc23xCtLlAeLsU5Br0wQVj05jeIj67TphTEQ9Ws4FbRocq0wBzDXxqvyMRWGlOmhOx8+JdEy90asRUiqmcVmHlinr+C3Gwmxig1tcWuHLtihDnXGO45jYdhdd41ysqTyb/e+QKyn9/moECz2tcEwM4lyaLsXFha8XirXB2Kkj/CvPgL65QjDWt+dkO28Qt2x0nzf4qALg4PwJhhAl5x1UP2Y9N4Vt9tVcZWhpjOhXK6wBUjkQdw/Bp+codz6N0KZbTng7V/ffiMOUPyEYZAOvhrRD+h9oEmX5068LgfJ/LrZw9w4TlIj/WLJ6uNCAY7/IkkU/I9KJiYxddCbhEaHFjdG/7IMWpR7UhjMDjUBrAUXfcUoIH6l/JJuxRLfxxAz9dMiPk2YCupH5zLVDIE5Z/Jxrn8xHqiXvj6BFd6wtw0As2fFByvdCHdJKzQky1uXyQli1ndzvRh/ozS1ueoF99XMsH5ClDY9G3Cwpl0QU5S0hCUTHAMt76TZDM0Rz75nE8KstaC4fbNQytXzRNSNg7akAAqigCWX2iRNj1nGU3i2SyoMfJf3TTmNLhr3U+iUpSIWrI2BT4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025 at 07:38:36PM +0800, Jingxiang Zeng wrote: > @@ -84,6 +86,9 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, struct mem_cgroup *memcg, > spin_unlock_irq(&l->lock); > else > spin_unlock(&l->lock); > + } else { > + if (!memcg_list_lru_alloc(memcg, lru)) > + goto again; > } Unfortunately, you can't do allocations from this path :( list_lru_add() is called from many places with spinlocks, rcu locks etc. held.