From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78BDCC282D0 for ; Fri, 28 Feb 2025 16:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0608280001; Fri, 28 Feb 2025 11:21:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5CD6B0082; Fri, 28 Feb 2025 11:21:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97D23280001; Fri, 28 Feb 2025 11:21:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7A3386B007B for ; Fri, 28 Feb 2025 11:21:48 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFC91120EC6 for ; Fri, 28 Feb 2025 16:21:47 +0000 (UTC) X-FDA: 83169869454.03.ADD6321 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf02.hostedemail.com (Postfix) with ESMTP id 3A57080019 for ; Fri, 28 Feb 2025 16:21:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=ipE7YCAF; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740759706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4hiEodTIpOmuJ8vfIFQijFMswHXDQSYENIDtnab/Kdk=; b=WbUrVu+gUHT6I0nygDYDPsywZZzlnpuHeq/hDe5jYfsa9nNT49Hal1D0o/xdCpL0hBGu+K OH4Mc9md0QfmSBfklItQx3oRVzPZUdKifLBW1+FZDuUI4X8clEky8GLfdiywa0mq2y6srj t6xOhEL9p7jSqoFvIAYxepgMjuc/yzw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740759706; a=rsa-sha256; cv=none; b=5kEAs8ddgWReG0ellntOObtCxsUW/HDYdZ6/uR3RQmUh6oA/G0iVq+k1pXNVSLd/HcjCPT SE7I8JSt37RuJTjantTlr9ME2ZG/OgfDwnmgmjZtofyA/OsULD1E3Zl7bNp9dIgyCs+7T9 FcMKlj+eO92ZLXk/rpqPR62Jao38VCA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=ipE7YCAF; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 777E540E01AE; Fri, 28 Feb 2025 16:21:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZYzTotK-1T7L; Fri, 28 Feb 2025 16:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740759697; bh=4hiEodTIpOmuJ8vfIFQijFMswHXDQSYENIDtnab/Kdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipE7YCAFjk5cfaw6WeoHw2lVk7Fn97RoqLBxrkPgO0Ijh2q89I0LqCTNuVXUoXRX5 JypU7ab8057PMwrz0T/yds2nsmTezlEvPdrwvp2RrDfFy7t3kZA6UrTVp3lxm/JYCl Icii/svJuKMZoeKFsV+DC5wafEMe4baMqGqedw0EyaEdEQpeejO0/y3E27IJOvUznS g3+CLD+1CXg2pjv6xyE2VviykBw/dip8AXX6eeV5DH1N6M18Q7WxgF7wZJcw5fv33I zJaoIx2vZGEjSeX1iFgmw7/2mC72Ja/BbGFCKRZSDRsy4HlTBVaxNja1moFN876SEl KSduva/5Mr9vvXKVcy2uM1pAR+nM3l+cK4yan55zJuGgoQQqKohuuzWr8s1yVD29fS HcQ1IxHFNmMV7m0l41r324ZWrKG5znLu0CKT1XUTqnmOuT1sJW0TUn+GPDv4Mcul/z 901ny9/+YY8CxOevlKEYeuzBe5nnatLAfjYiwdZsAmqXtfJWBiQUj7/myxhG/PoHx4 DTp5Dpv4yLfMwXq0XCHguxZpeplQYAEMr1flPLlykdymc7TedN4lqJj4c/u3SxaxR/ SDfJ8KCrwiaaF3Pl6YsroueEDNlCbvWFqrbioLHDUwTKTZQHP3K8RBZs9UuUudoisw cPdlArekptvQbS8tvYvfmCWs= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id ED27040E0173; Fri, 28 Feb 2025 16:21:18 +0000 (UTC) Date: Fri, 28 Feb 2025 17:21:12 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org, Dave Hansen Subject: Re: [PATCH v14 02/13] x86/mm: get INVLPGB count max from CPUID Message-ID: <20250228162112.GDZ8HieAio1EVer94Q@fat_crate.local> References: <20250226030129.530345-1-riel@surriel.com> <20250226030129.530345-3-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250226030129.530345-3-riel@surriel.com> X-Stat-Signature: x9ugxxdmzat6dfs45kx9tcte6tj7mwoy X-Rspamd-Queue-Id: 3A57080019 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740759704-939870 X-HE-Meta: U2FsdGVkX1+RK0blUoWRD6NtvsmRPDf+R3aRWQuwaCrlNRc0P6yVqxPpDnx9VgWi7WIiRllbFhB2UiZ+dpjm7BSN7+SsAKE7v1qPO4V/10xeHhXNFRuNeeA7Qh+lhvnu0bifMeBOsn+azHzkzapMLXOGOXwE/bXN/22/1b3zqFIbQCkfBg3ShbLOdELIAKPzkpLOSWixmO9AC64F7+aFSPmICa4kKZvo4g8dnW6RSgCkA9NXqxZrrsjJZC4U6ybXeXxNQL2z8fcSKl+e47OcaxuiWOY4z8qKN3xJiHvXeDQJ02awTROaQ1TKgoc4LkITnwHcc/W0qnJabng4kCF0AnhSVsCp1HQ4VMW0pR6Ext3etmarfXKA1mxL+f6H0/ryqmFIDMWKyxrTGQmntlviulsFK5uChByYW64oojvZdOyK0zEQoNoxmSLkwV9+oyxjlLl3quRAu+XpYYBcVh/pxH48YEp4JPDrmLer0Co30Nt2W64Kck2WbFGwbD+/DXmv4cRvOmpj4WOZpcwkgaN8pislHghmmSb6mCzBB+mliZywJxDfRaUwCL2qrRuM3a2dZtEGZVrirAWVC0dvkggtTl/vXRwWZ+OsGzXjjSKVMycpGBATY7JVPSd47IyTdC1S4YSSYnj0JvzWWsbIHdpmNmKJskoPnM+Mw4RLUqeJ6nDtdj29dkkzV4GkMgnWyLlt5NEEv6Y8npX9Zh51rQUxaNSwtRC2Hr93GPtMcs779dZPiyPwO5Nh+PJeQ12QtFa+PwYnCT+vueVulUr7ROVx1BIYFUKx7fWQD6ysEWhkAWLRsTOBOTcJou+K8Sf8sdkgcb3tx2jEWjnLuryKWefgaYAm1wd6pjSB1hy6Z2PG0ama1roSGH3qUfki8pMxgIkJT+XQCpIfzvU6/+okWOq8xa/wqSg9qVgSrENSdwVTkuJZr27WXdoAMAsU9XdK62v0RNJ1iCdcB65mw8vP3k0 hgBwBwB6 /QhGyL6TXm9FD7qhHTXiMGdGsYeuIBckKbqphWu1vlwjSPhmcR7pzpGCWp3++aGhjdz06DqU/3stD4D5Ohz6vyf0eyXNKn79bz+yOqOfCWhdym3CsrKteqj1ByrYXEpVhAs8QKMBXhFX9YFlen/PmBCdKMNzBPRUtE3x5pPtlnuNBK+znRM0i4kH9velEV+X6OoW81fdkBv8hnTEI87lTRRd7Wc61mCW0qpASpXcYIP33xU0CRKJ3BHz8Wk7dDTLb+/GkL/BIQByA/68U3xnMPcypm0xmckN0oPiU/pX2OylKkxfiCTNjB4ejTzkLgO/b/D2gMiFnLEWfFsw8FTJIlLO31Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 10:00:37PM -0500, Rik van Riel wrote: > @@ -1139,6 +1141,10 @@ static void cpu_detect_tlb_amd(struct cpuinfo_x86 *c) > tlb_lli_2m[ENTRIES] = eax & mask; > > tlb_lli_4m[ENTRIES] = tlb_lli_2m[ENTRIES] >> 1; > + > + /* Max number of pages INVLPGB can invalidate in one shot */ > + if (boot_cpu_has(X86_FEATURE_INVLPGB)) ^^^^^^^^^^^^^ I even sent you an *actual* hunk which you could've merged ontop of yours! https://lore.kernel.org/r/20250224120029.GDZ7xfXV3jMjnbdbGl@fat_crate.local What is the best way to convey to you what needs to be done? Next diff ontop: --- diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 9f48596da4f0..0e2e9af18cef 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -1143,7 +1143,7 @@ static void cpu_detect_tlb_amd(struct cpuinfo_x86 *c) tlb_lli_4m[ENTRIES] = tlb_lli_2m[ENTRIES] >> 1; /* Max number of pages INVLPGB can invalidate in one shot */ - if (boot_cpu_has(X86_FEATURE_INVLPGB)) + if (cpu_has(c, X86_FEATURE_INVLPGB)) invlpgb_count_max = (cpuid_edx(0x80000008) & 0xffff) + 1; } Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette