From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA6CC282C6 for ; Fri, 28 Feb 2025 16:55:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50AD46B0093; Fri, 28 Feb 2025 11:55:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49157280002; Fri, 28 Feb 2025 11:55:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2979C280001; Fri, 28 Feb 2025 11:55:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3B566B0093 for ; Fri, 28 Feb 2025 11:55:11 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9C996C0EE8 for ; Fri, 28 Feb 2025 16:55:11 +0000 (UTC) X-FDA: 83169953622.27.7519E53 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf23.hostedemail.com (Postfix) with ESMTP id C683214001B for ; Fri, 28 Feb 2025 16:55:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PY33vEU5; spf=pass (imf23.hostedemail.com: domain of 3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=0X+2AXQuGo/AQGx2WFxcMycOWEuq+Ugu/95Q7oSUWt5Iedv2zZVFKDmquBVx9Pb9z6hmff 7IUOMdhe3LEZ3YpQEYMgESQDv+X8diVLOICj+AqbLPH2apS2hEtMf03gwxYjHWShvLA5qn qrLzvHgCZfun/tU/ggciMNfkHidyx+w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PY33vEU5; spf=pass (imf23.hostedemail.com: domain of 3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761709; a=rsa-sha256; cv=none; b=wbrh1fS7gRKUS1yQXjoRKucOaNvHKvnpVCVi2d7SNKuGrr6fkD9e1edT0rNLIZjPvZqpo3 n25rvA4kWjUC/AyMzX7GQPb4QfSvd5dRgB6TK0dkmcsqyN+NoUQDx7pyJ0irlJODsaWnNP xZbUPHA6jWDlLXn9u418yxxPCHf22j0= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4393e89e910so13767985e9.0 for ; Fri, 28 Feb 2025 08:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761708; x=1741366508; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=PY33vEU5R/L8IfcYR8S/YZebRfAtU67WzVZ8PtnOg8ZByxFlQc2HyVKqM7cOXI6eav BE519CR7IKNAqR8edKlCuAzXLazHMySJGJDHxuDWFrqBY9ejQxQAaFAPlsTqeBAhxEqI 4VjnhMVFcFcj/7WBzYDD29bMyFT6O8sTuzWiOwVD71+QQGfZGofrdUmA+kFMzKwYqOfa j/PnFGBp3uEHfMS17L1SekQwqnp6sjAYmj2PqFoOWl9TFu3FLonT3r/tlvghyi5V0YYz GzjjOXAgrBJma2Ab0okYavHancbUVqpYetU0p4FMdV2EkkehH2Xta7Fr8qWgzVesxZUA G5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761708; x=1741366508; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=HGMo0jBsiPDfaMoxZfz23ayAWoitIYwNtScdLcS5JI9t3zUwg4b+Yygcfl/CVZg/i+ /H6MZWmK578FtQgwThXMmqFrQwLIVj3961ieFtq1Rj1GV8cb4o/CJfeXfUH9pSIsw+je +/nMPLpCULXA665yG7BO9kxmjbBMWcaIqy6pNIGCmS+m+v9BYPUfMtFa+8oCpyutnPxZ hvhLisIVEED0qmmz4YCr/7jMZ4xUYraeJWYFugXkeDIPrZ47mI2fDszngKhaTFn9no+w eyTx3e2Xy5uZpBZ2RJmcCPYP22bXMUsGNyijfK5PZ13Vi81BbnkZ/fArtrUe4fUFUmvV QpuQ== X-Forwarded-Encrypted: i=1; AJvYcCW9QiGSNx+M3uTHje84bJj6gIXRJyl7IsI7wYMrLxPlQlOVkRgA0I38pPu3e8Gm+ochRGu4r9rH/Q==@kvack.org X-Gm-Message-State: AOJu0Yz+eEfG/zhWRvihWdSJQBw80wesByrFJapXQosGukF6JeRAFQin +/aPFQ/ldtYA8whgUIh+s9DBbn1+HtfJK/pXj7PmDALozqAVj8ZqvhHZHrv0zw/zcFvE0gtgyfA 16uNt7FbBSw== X-Google-Smtp-Source: AGHT+IH0ZM4UbMAKoXYRYVdsI8CLX+kx9xcCfgVmPw0K5PMtIeLgyJejHV/DAB6TfrrXG9WhtZl/va8I0oxrQA== X-Received: from wmqa14.prod.google.com ([2002:a05:600c:348e:b0:43b:6943:f013]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:444d:b0:43b:8198:f6fc with SMTP id 5b1f17b1804b1-43ba66e6d07mr42105885e9.11.1740761708569; Fri, 28 Feb 2025 08:55:08 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:54 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-6-958e3b6f0203@google.com> Subject: [PATCH v3 06/10] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman , Mateusz Guzik Content-Type: text/plain; charset="utf-8" X-Rspam-User: X-Stat-Signature: 7zi5y76jmohtaqqs8agw8zn5fpa5fwsb X-Rspamd-Queue-Id: C683214001B X-Rspamd-Server: rspam07 X-HE-Tag: 1740761709-733720 X-HE-Meta: U2FsdGVkX19sTFpFu2gbh0J7XUfkiw0z/tpjEhVe/UKhf38EDwfeLrl9kwBf6yD13IvDgohv9+bPpLN1jx74vA79RV95qi2Fl+xP7M3saMn8b8MMT7RogZTWpRCuvSdoOjeZ3QWH2EuFgSX2yAwiypEHeeWYIMyFhGrqS7V3c4wFzo9b/BBgbYnHk0XxIJq5gnP3rtFdSQNHho86x6dw5OlAvWPFLbDnf3wMaISnlIv7XELh8fNo+ZhGxGHLCnzOciqORZw4+AGgs6lNQnZiYJ1tj7RYI7CflUdnKL4S7kvb8q1guys4/WxhXnLJnS4PNukeYgx/GK25tkQqCZhw5f3gY1OeUbJajhplWfrWh/YT7mAmZtWdq0fELiDxHZoU88EqChCgpAn7KQkR57uu9EHWy/DBSUrQo7xT3D/WVUTX37A5A/BZWEuAnA1GGr+IY4NXiTTCEa0sT6zPt66lqjNOFCi0nhOA8aJV225ZEdnyigU9X6hCHJnN0lgvJZxxHoZJCUhs2I+oEVS8eMyVqjYpPM8k9ZmUpbQCpozdq80ArWRWTudL0X/eKYGSmTR//1aUmRf3pFoKJYV7TVanTKG7+jva/mb0CPDVwbvsNxQZphf97cuB4gFWhsQdj/whZpdnyqY13BQ5MpbeEvd0CBFZBDQJX5Nj0K1KfJX6sLFN1/6eeoRHQGKn7I3k6zJLJJINj4RBjZLyOb3j+s7geQLCLA0hd+tbsA19/uXwokUZDAyV/6z1gpquqAnKs5rokAqlFihOkARL1J2nX7fiDYNQSxvM1Q4+97xeUWQJipLw1bq5Wjf0/kXltgpZFfVwkVsCoV8PnTzp0yZQ9g4gdPmjWkOTzUkgfPiY2A+No3Vj4Rq6J9dWkFPTWxuRAEERZCjOKRcUQn6HCbSFL+i3tvaIlUsbARE0POqWKa0r3epl6NL2VXxkItApQ6QYMp8orFZbe/LVJRhOr1f5oPN kTpKUrvJ 0RqE7BuyJh36Pgmxm+e80PjPkeCh+b3ZWkQn8OQgbNBixKSuboX3LXw1ns+J/7KY7i9On9we46NLA+E5zTsAxnN+TvTCkIz31sgDqdD2dDNBe4+PC/oZA5ZREeJugRxTOrWnCMK0g9UbQ1de1QeVNjmzcUb6EYGT70mpDHG2yfkHexgDg6VQn3CYalNY+7wK6GxEDMIDinR1TcpWHCTFURym8IfBwCGwy/8l9vW4AvyibgQbDhaX8O0VKKKb8C2rGAHA2m0FrULNaLClA0NIuJOK4itr8Znx3E8AL5uupE3btG/Gxfx0InCDpm2aVK5ri6cY+pvnAyzSFmHKkzcTPphqzdp8CMb5N2ZKcd/0CZ3AWNCbwK4qlATqaWKKoPIi6XwiAxZ1P8gJvwoVTHgx8SJ+AyRkP+21k/aXtNXtFg/oxGEZb6MVW0aoF9F5iAcfxR5nL/6aDPORrwQRkYrWZbVuUbREH9dWxvHeivDDnOKbB7m8UUEYqNnAZAUxfGnU+OiyjvQD5KNiTTCAr2SOy6iACtbwc1HBQQYgQt4+QkXjR2Pbel07oJ68RKTddzslrmgjerGhAaWIaH18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010455, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index efe2051c393096e237d942c04a264b6611a6e127..5656128590373ed376b3b5d9259e5ca3867a4099 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -434,6 +434,7 @@ static void sigalrm(int sig) int main(int argc, char **argv) { + unsigned long nr_cpus; size_t bytes; if (argc < 4) @@ -452,7 +453,15 @@ int main(int argc, char **argv) return KSFT_SKIP; } - nr_threads = sysconf(_SC_NPROCESSORS_ONLN); + nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + ksft_print_msg("_SC_NPROCESSORS_ONLN (%lu) too large, capping nr_threads to 32\n", + nr_cpus); + nr_threads = 32; + } else { + nr_cpus = nr_threads; + } nr_pages_per_cpu = bytes / page_size / nr_threads; if (!nr_pages_per_cpu) { -- 2.48.1.711.g2feabab25a-goog