From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2D2BC1B087 for ; Thu, 27 Feb 2025 18:38:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B3146B0083; Thu, 27 Feb 2025 13:38:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 362826B0085; Thu, 27 Feb 2025 13:38:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251B06B0088; Thu, 27 Feb 2025 13:38:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06FC16B0083 for ; Thu, 27 Feb 2025 13:38:52 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B2DE3B7308 for ; Thu, 27 Feb 2025 18:38:51 +0000 (UTC) X-FDA: 83166586062.28.0DB9727 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 2A06A18000D for ; Thu, 27 Feb 2025 18:38:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZHlOGBaf; spf=pass (imf06.hostedemail.com: domain of ebiggers@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740681530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n+xWcfC2YqG14vAH14GgMuTbJmqJyYbu2llgUedG6j4=; b=itUv4TAYjZXhUOeWd/7hAup1buOhqg4GQ+rqN6MSJiraOlrJUtkM2k7mUI+rvAU4UAYlIZ lJ/pA3DLkTEaO+ZmNDQCvtTxzHS7SJ+vED/kbrb4iXu+x2qwd+SauY9WNeouEhr8qwHjmI iq/YTNusinwfZxc5RE75xiaozNliS90= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740681530; a=rsa-sha256; cv=none; b=Wn/uUyHwxgRAUFt6lh6d+oBHbmbwNP122xGoVpctSD9bNTO68VDwdnpVk8alZA+u7Eb4pv /IzOudAoI8NsIZcP9HgdJUx2u/xHhNxEnRmvopi8ttC1k3tMN/DewipLzN0SViuvqfV9e1 8RYyLtnYBpT86vBkOs8FE/LiVQPdwYA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZHlOGBaf; spf=pass (imf06.hostedemail.com: domain of ebiggers@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0B03D61F3D; Thu, 27 Feb 2025 18:38:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12400C4CEDD; Thu, 27 Feb 2025 18:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740681529; bh=1nZUm+Rnpk+A01u11Gmh6kUxXiy9OKofXp9SJwE/j6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZHlOGBafezUqsI91KyFECvRZEwFT3kOrqQ95sNC1quz3fDoiugK23z6NhgR8QCTJ9 +KP4Niv2w7IqaHHpdA9kySMnoX6n1XRpkT4geDoBuWJD1629fL9Hks/cvHafy6ZdoB BReEidZDGw5bfrQebgpKaTWdccq9LJZ5qLnvQZ+7ww9N1Ix6NNBcaYWsDvjZg8F1fB 8bLSJP8kSqVj/RoAKGTDw1JigwiOTjrCOWUFjNs1nczX+KitBYmDYrmkvGgji6kanY ufZi2t8cp1K653fq0pPiGlxMOMzmdd7fsN8YGiZx4sXpjqomHGfn1MCr5cvjM5JaUR 2yHZHSwRG7zRQ== Date: Thu, 27 Feb 2025 10:38:47 -0800 From: Eric Biggers To: Yosry Ahmed Cc: Herbert Xu , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: <20250227183847.GB1613@sol.localdomain> References: <153c340a52090f2ff82f8f066203186a932d3f99.1740651138.git.herbert@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Stat-Signature: gfhge7t7qgtz4kkueg8sg83mqxe9io5k X-Rspamd-Queue-Id: 2A06A18000D X-Rspam-User: X-HE-Tag: 1740681530-297834 X-HE-Meta: U2FsdGVkX1+S129FiQ4RxfQrT05rBlBaC6umkLkJ8mzNTB9jir+7sTVxwlf8pQ+5jG0OFvhFBknFSo7r1A48AFRDx2+V69o214kbAy5ot7nDDL4ropwndNEKcuW9zkhL9QMgBYUfKbqGLNJ8tW/X4WBEJUIX1pobWA1PaAjcALn+XKMEEwYGyfTjY09Kd9aIn5suScDNxwLu1KA3VmIDu9ekPCSkA++8LOpO9ph6ZJOV68iKs+N0fTT+WigjtK+eZl34mnH8CMDWoY3WvPcI/inqfq+5g/Ipa0WaUJzljRkQOXy4M+FBkHZ3mcqejBt264vOcoJ/Ev/ixNFCu7VP51eVufc1cQyIDOMKTzzEV0jDkF+XzPBpiHcwWTNmzhFjZKx+7f5J7KQ6wZrlxtqvrNkL3Hf25oWId7+hJZZ/fC14I3hflLnTlrxTUUlx/d7bQhjrivf6f5gcOeFsvQrL4CIixSgKuucbz2+BJAcBwF1yZGWpCrx6C6ZTNxK8nNhmAIdfX8E3nzNGL/wlw7M0qjTs+4dS/cYEXfAlg1b01RkEM7ck98TjTkjzAjoALxVXxWe1r4o7E95DuSegCLFqn6pzUn2sR0jxRNN+tla3ECkT010b9wcWE2ffbIjIk1VcfwZBwd4hhl9AvB09IOGJuSkaUIz60IDhJDS9vGC5bgiXHnnMGyaUkMyG7UaDIuV/6uBUEhFXCIoR0v7TY6L36pCZ1cN/HwgOqLe5LyJs56dq1Eyxjk60SuckvjH4XsJiS/Sp/HcPhzlOQ8It92eDtK1+N/tmsJexjBXuxM5S7dVfqOtpKMB6+3s+aJP62J3TQYQOpzMo4KiusR7vl0gddBbHKkkT5OXt7ZZzQlEiA8c9lh+zrnqCJ9qkceKhnWyazsbmzfbo24mYQJHhIlBb9m2tWR6YlY+dbFH7ldt2SW8mRVcL1O8LTrKwd5wVB7FJeAT3gznqAcNP63SriUl qYgcPw5q FS87KOLKXWsUKDoG0JJI29OfXNU8zM8fpkh65aoBD2jqzf1I5FYtRz9UNvmh3T+945yEbpH95vAKHTiQCX72x80vpgzyVUYPJ0DJlyIS9sSYoOR6nzQx8TJtS4s8PxuBYT0/3R+YUSMXOzqm7wQW3UggRM4d7Iodk+dYdvAJuuem0x3DGJ5tAx2ZZG515F+EV1kVfusHe7MNqYfLNvcBHN3o5Qr7ZOZp509MZXDGaSA8NIttD3b6xT/ORG3XstJlyY238oQbNyynYbeA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 06:11:04PM +0000, Yosry Ahmed wrote: > On Thu, Feb 27, 2025 at 06:15:09PM +0800, Herbert Xu wrote: > > Use the acomp virtual address interface. > > > > Signed-off-by: Herbert Xu > > I can't speak to the rest of the series, but I like what this patch is > doing in zswap. Together with the recent zsmalloc changes, we should be > able to drop the alternative memcpy path completely, without needing to > use kmap_to_page() or removing the warning the highmem code. > > Thanks for doing this! Well, unfortunately this patchset still uses sg_init_one() on the virtual address, so AFAICS it doesn't work with arbitrary virtual addresses. - Eric