From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8337AC19F32 for ; Thu, 27 Feb 2025 18:33:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD8D36B007B; Thu, 27 Feb 2025 13:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5F1E6B0082; Thu, 27 Feb 2025 13:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFF3C6B0083; Thu, 27 Feb 2025 13:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 908BD6B007B for ; Thu, 27 Feb 2025 13:33:51 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 42A0D51C14 for ; Thu, 27 Feb 2025 18:33:51 +0000 (UTC) X-FDA: 83166573462.27.3CF027E Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf18.hostedemail.com (Postfix) with ESMTP id 197251C0004 for ; Thu, 27 Feb 2025 18:33:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kw4cOzQl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ebiggers@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740681229; a=rsa-sha256; cv=none; b=cASBrEKrtbTxltlX1Xj6+B7462jkwQha7rbVuf8RQsnJSRbROsSpUVhybzbUIqz6JVJhVF beMOOzR+Vcftax4slrsOCv9+trprPkkYNUvYBQbfG9kPRqhtMRoTFdwBekWHZv7oi7QK62 0sEvfXWn+57XFqXCzaztijCYMD1mHgs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kw4cOzQl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ebiggers@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740681229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s0R5Cs22NNzE3aARuIPRHC6jjRt3aGs4U8ooIoVrpG0=; b=B8e3lHC/73ew1Hz5BObmqH2dRf4PDaESXAG5GGpS0FNN9eqt0WK7TQNWYG7GZgSv8uCR9D r06dTL29yDNzn0XJ4UKtU7d22GITfBFIk6w1wQtt7wXWFarGMDlEraHxhOmjolrHIepKb6 x1vYXtRxRpO56e1tEm8UljldoNepM78= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id EEDC761F3D; Thu, 27 Feb 2025 18:33:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F34DEC4CEDD; Thu, 27 Feb 2025 18:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740681228; bh=aC3m1LSDHVrfSOBH0I/OhRkU4TX84vtl9CGdv3j+9vQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kw4cOzQlRpeV9zSODW3BUkesE402bhPte/7wM4moaYwIj9YKXXE2jtophmaR/PPHX 25kdWlVcG/YUl/UwDr02UlpkFpt0Oq4QUsiCj9NX9dr+2ZAU646ibwflnkEI2XKcTn P8jyjpLdiM5sFVSrVBg5HnCKyG0x+OgCXuieO4KmVhoEP9nxyHPwuSNofzvVfIPXQN RVO7H/fYcg+YNb06p5P7nzhEXek0/eu7JkDM0QBdyN7Mua5kio/r0iZDcbL/pZsSlX ET9aUY0gU/1zOFpBj4DiZS1rWg9VApQic1ZDTcJ1qx8QJ13xBlgeTpv70dLfuBARvm pFrSC68vQ/NOA== Date: Thu, 27 Feb 2025 10:33:46 -0800 From: Eric Biggers To: Herbert Xu Cc: Linux Crypto Mailing List , linux-mm@kvack.org, Yosry Ahmed Subject: Re: [PATCH 3/7] crypto: acomp - Add request chaining and virtual addresses Message-ID: <20250227183346.GA1613@sol.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 197251C0004 X-Stat-Signature: gat53ppbd8cpadh8jmnfosu7keb5qty1 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740681228-480379 X-HE-Meta: U2FsdGVkX1/9BJDwcQvg/IbQOibDnEP1gerS0RAfL0NDj2up2cRGy+9/sdj1veT+3SgaihPvO+GhZQ5V4Opf5pdOF9m9K7SJgqbS0T+xPiqn87/aukDfKa7uvw0+BC/uHAU7nHRsQ9itzaaj0IJK3k5MMx80fknr4T1d7CQp37tE+OtP70A0scShlDVJtXWQQTW6tbIxK2kxdmSgNv6ULptelm810GCZrr/P+jOnFnTxZXr5OaSXJA52xSsdjY4EZ1cZ+VNvFG6PRgH0FKdHhTvWXO3CWHVWewlLS8yL6R7dwooecItYg9H8wMGWq8K/tq8peMU4NK3XrRT13szv0CHME1CR5QHpUSuKXwNWcW/zlwSiGwPBMao4tepFqJKcwLI3QAaLZIvxwtvcL7qjj8UmnIr4+9+KD+KW3YiKP6Pc9GyR1Pw2JYqz3rvubDdela6KITYvIqXPe8hhz8RzDsJXU4LIbVJ8NBpcqUoar8Vt1Hy9CFt9t9TI8+vQLm1SrWAApI+GDVIb6aqdkxi+MknlavrZr/qru30lBk2KeEHnl/ilxerphDaqIKA17loTClv9J/KTopD7jNz0+orXzcCVUcEAEqoySqcdGwDZ5IxUT/u5XgvgIboz2vBpBQt1KyML4CYOamhWOyhPfSaIHceO85cxqV9eL9uLvWFOoWtGD3AYv3D8yYW/BL2AT1/zHbKzMfkUkjXFZHJ076WSHhLdPZMAoIZpzYdd74SXMscN68HmofEAT5YCcy0MNHWUusMDcok79XvnVvKAS9amhvMPubwQhOL0v8+LNeIq/mpo4+52vcwGgujNuYeGDi2n7Qbw7EejtHgTZxKcdqhicbgqbMwc9fWEYH4/e7KIDB1Mr4QyOffkwGMYjETNuuM1AMiGdTMVO7Ml7sLg9Kenq0k7BczFAkXwXuS8DubtBxt6viApCLUdv+ozT2TUQuaHibd193AmdBBL3HAGMaY ghQFrhIV KEk3aFpxTjEM8CmFqXpmQY3OqaQsniw3FOqmkAOmH6qfQ6bOfxJVI6+sBxX0TIcEoNKKgcRBU8S2eztZNSHATX/qnpJTceJXBmEKJuyaRzPAUFoZSRTlrAC27tzxZyi0LJ0KLBk64+JbAiMlRjGsz1Q+9e0on+/cOZZzEurBEz+ZpWTZ8DsJxgt0cZlA3Q1zIJiPFFenRSfiRi7eTW+LVDDcmFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 06:15:00PM +0800, Herbert Xu wrote: > This adds request chaining and virtual address support to the > acomp interface. > > It is identical to the ahash interface, except that a new flag > CRYPTO_ACOMP_REQ_NONDMA has been added to indicate that the > virtual addresses are not suitable for DMA. This is because As with ahash, the request chaining support is a huge mistake. The problem is much better solved by adding methods that explicitly take an array of data buffers (i.e., batch_compress and batch_decompress in the case of compression). "Request chaining" is unnecessarily complex and creates a lot of edge cases and ambiguities. E.g. it would make it ambiguous whether every function operates on a single request or on the whole list of requests. It also doesn't even work in the expected way, as submitting a list of requests won't be equivalent to submitting them individually. And as usual for your submissions it's also undocumented and has no tests. - Eric