linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: ying chen <yc1082463@gmail.com>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: when the swappiness is set to 0, memory swapping should be prohibited during the global reclaim process
Date: Thu, 27 Feb 2025 11:19:34 -0500	[thread overview]
Message-ID: <20250227161934.GA115948@cmpxchg.org> (raw)
In-Reply-To: <20250227155431.2534325-1-joshua.hahnjy@gmail.com>

Hello,

On Thu, Feb 27, 2025 at 07:54:27AM -0800, Joshua Hahn wrote:
> On Thu, 27 Feb 2025 22:34:51 +0800 ying chen <yc1082463@gmail.com> wrote:

> Previously, when the system is under a lot of memory pressure and is
> facing OOMs, global reclaim can create space for the system and prevent
> going out of memory by swapping, even when swappiness is 0. If this patch
> removes that check, it would mean that global reclaim can no longer
> "bypass" the swappiness == 0 condition.
> 
> I am also CCing Johannes, who is the original author of this section [1],
> who clarified in the patch that swappiness == 0 has different meanings for
> global reclaim and memory cgroup reclaim.

Yes. It's been the behavior for decades that swappiness is merely a
preference, and that the VM *will* swap to avert OOM. You would break
users making this change.

If you want to hard-exempt cgroups, set memory.swap.max=0.

[ Yes, it's inconsistent. But it's really cgroup_reclaim() that is the
  oddball in this. Also for historical reasons... ]

> > when the vm.swappiness is set to 0, global reclaim should also refrain
> > from memory swapping, just like these cgroups.
> > 
> > Signed-off-by: yc1082463 <yc1082463@gmail.com>

Nacked-by: Johannes Weiner <hannes@cmpxchg.org>


  reply	other threads:[~2025-02-27 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 14:34 ying chen
2025-02-27 15:54 ` Joshua Hahn
2025-02-27 16:19   ` Johannes Weiner [this message]
2025-02-28  3:18     ` ying chen
2025-02-28  3:21     ` Yafang Shao
2025-02-28  3:16   ` ying chen
2025-02-27 19:12 ` Shakeel Butt
2025-02-28  2:48   ` ying chen
2025-03-03 12:07 ` Michal Hocko
  -- strict thread matches above, loose matches on Subject: below --
2025-02-27  7:51 ying chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227161934.GA115948@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=joshua.hahnjy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yc1082463@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox