From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CA5C19776 for ; Thu, 27 Feb 2025 01:58:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D94D3280006; Wed, 26 Feb 2025 20:58:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1C33280003; Wed, 26 Feb 2025 20:58:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9531280006; Wed, 26 Feb 2025 20:58:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E329280003 for ; Wed, 26 Feb 2025 20:58:11 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0CAE3A39D0 for ; Thu, 27 Feb 2025 01:58:11 +0000 (UTC) X-FDA: 83164064382.02.98BB82C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 775BA100004 for ; Thu, 27 Feb 2025 01:58:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RjWj45f8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740621489; a=rsa-sha256; cv=none; b=f9D6T1nXtNBfhOgxgDGPfSNBpNqy82iMYeLSTktmDpB7DhYt7G4Emf13vLrUGVzG3W+nfS 1OXOkxUb3+DUNmRHLogSrm3W9Oj+38BMLOWQ/dDoF6Fg/NdHVjk4VqVPJY0F14IstBcqFu tPwumLMbKEG3gHsKg1NDZiwcUNmnbN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740621489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f94hiwllHBLFolcQHf26wLj0O6QKa4c01rZLHw7hc+Q=; b=GFChiRuu2ZfGoqfuMK8r82YhYhHxgO5eTA+c8P/nZw5z7LaRUwy7udINoSW1vuD9BWeeZM IqT7qd/c4qWQUk+gaIG9GzWz+J0X52Wv8AMX7hO+NfdJDYlmS8AT6gwcAFLU5hLNJljUDp 9D5JY10L15JNUR9Ko+6sM6NXRAnl2q8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RjWj45f8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5CFF35C7622; Thu, 27 Feb 2025 01:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C248FC4CED6; Thu, 27 Feb 2025 01:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740621489; bh=o7Tb1fqSTBTcTFBCmPVioCKVuRP26jC84n9gdZN/Nso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RjWj45f8qr9qybW6WhIY7KWi/G9KlZfLpHRUkMdyTAbkuEei4cWOQ3htE9tfpt9yM La6TSblyuWFzAtcsqfzTo//ggqbrT3jquB0NjWz35ZhFhKRT+fcmhqDlWyO44XmENh 1c20ENmIjra3EJ2LCQ7QJheQo8AylmISq4gXx95fJ4NrieksEzbjyuVUQBRp2zClyZ NN/uFghaiRogYtUyrVFzf2AtQKC6tI3kqCXvTa7aNoUKF0pmVRiWz/kzD3wmIj2igS yJvd3XrlexS0UxTYRE2f/3aI4wfT16zwn3fCurB10mcV4wYOpSHMMLFoUkHTaknxgc 5B7O5uX1B4r9Q== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 7/9] mm/damon/core: set damos_filter default allowance behavior based on installed filters Date: Wed, 26 Feb 2025 17:57:52 -0800 Message-Id: <20250227015754.38789-8-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250227015754.38789-1-sj@kernel.org> References: <20250227015754.38789-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 775BA100004 X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: p5mjnqzppwb1iq4oywcdhs4wow4i6w5s X-HE-Tag: 1740621489-382210 X-HE-Meta: U2FsdGVkX185JAx5ziu1vwsfZKHwThT0skZ06d6T205PpLhudQ8qQA2cxdYt+9jqQ02jhfXN3jSa1wq+tvVU2DlmBvloDiYetzjsXAVK+fR8BcqRp7P+mQw5wq1ZlBdWvs7ovk2O0+uW1W7OG6740mgByF51VaZDxUgZChJtD8urrQvgj/fx7jlZRGrzA+C6vJFysWdStTt2nDAnHBQrJjZIoDb7A30SYmi3Js2xSEcGK1seV6YSqGuvBUAje0yWkNBNBQS3p5Z5GLDMpunpgQS+VhcWbQvsAsgFhwcvRnPzszfr0zQmxcsdtzK9Ff2eP7qtD7Hcy9naFSJUtpshEz6qeaeklWykCHLh5rqiPLg3PEF4E3opnx8j+Puofub+SWxnw3hS+nYkiH0FYGZwk1oh+MK00Ca79wzVegsjN6WkH8DNBl3JpQC2W6wvnVFJf7F9BmjleAN/CKd44GCiFZGMFD/IDeuaqHe0WwweJe1Z7W9szJYwLoD3PGIEBlRw7+FfSPIgIQ5fmJp+DhZXvg5xPRy9bXo740ULqGKKXE2rzItpjAkGeKzkXE4A7IQVrwBU4V2k6p9q8vnAjjiAstgxSO/bIWnWANj5oN2/RLLNQYSyB8e0rVLnz+V8Uq9ZcXEoibZq87Yhxdjaqfa+WcHFT1Kf5jAz8hE8D49gk/TGZ1qY8pFVbrtQ76Ny5pfYosus+bozO/GAOxx4oIgEDlJt8Qp9EIFm3VIxACJWt5RNV4qnNYaxOuaZ7B10k5plWjZc7IfSq7cj5d5ji0+tXcJh2DBnVPHWTnbhgigm2xEQPvr473g7AfIostNcixKAj/Y8Gt6G4wHG4kEnJwSfNBaQ0oXB7gAAzycdtXRS5hphQ5gnvch3M8HLhvRyqVEqOhqTyedBCE8so1nEyjkjVQTAK52XyOsjILYmr7IWPq8BaEV9ZCatxko/SI7ORZPTvjk5iGugL6lBRLdcun6 /2mPSNYQ ZjmzTziABLcbYSZ+l5oBkxNdmQ1wUlW3GOqXBVAl2uI8DseCHaurTsztHpX/8kyX80/XK71S8ZSJ9WA6NoEjvpIsz/iUTVvc4pDMAwlYSQ/r952agzZtnfPaG4mfrYMcxAP10J5jNDukX3eNgg1gRiVZGgCW8kqZ5ijWKvfpYt7gahQCIorcAPpJWuCKg6wIb8LoRAYig52Ady0zT+WpqUwZpQQPszCT6kks2lTCCcJ8Sg94pBRYIcqV7AIVX+jYhCfkBGIIOWSGEEh8+PIyemF1zCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Decide whether to allow or reject by default on core and opertions layer handled filters evaluation stages. It is decided as the opposite of the last installed filter's behavior. If there is no filter at all, allow by default. If there is any operations layer handled filters, core layer's filtering stage sets allowing as the default behavior regardless of the last filter of core layer-handling ones, since the last filter of core layer handled filters in the case is not really the last filter of the entire filtering stage. Also, make the core layer's DAMOS filters handling stage uses the newly set behavior field. Signed-off-by: SeongJae Park --- mm/damon/core.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 78126a5145fd..8661f64ab1b4 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -864,6 +864,32 @@ static int damos_commit_ops_filters(struct damos *dst, struct damos *src) return 0; } +/** + * damos_filters_default_reject() - decide whether to reject memory that didn't + * match with any given filter. + * @filters: Given DAMOS filters of a group. + */ +static bool damos_filters_default_reject(struct list_head *filters) +{ + struct damos_filter *last_filter; + + if (list_empty(filters)) + return false; + last_filter = list_last_entry(filters, struct damos_filter, list); + return last_filter->allow; +} + +static void damos_set_filters_default_reject(struct damos *s) +{ + if (!list_empty(&s->ops_filters)) + s->core_filters_default_reject = false; + else + s->core_filters_default_reject = + damos_filters_default_reject(&s->filters); + s->ops_filters_default_reject = + damos_filters_default_reject(&s->ops_filters); +} + static int damos_commit_filters(struct damos *dst, struct damos *src) { int err; @@ -871,7 +897,11 @@ static int damos_commit_filters(struct damos *dst, struct damos *src) err = damos_commit_core_filters(dst, src); if (err) return err; - return damos_commit_ops_filters(dst, src); + err = damos_commit_ops_filters(dst, src); + if (err) + return err; + damos_set_filters_default_reject(dst); + return 0; } static struct damos *damon_nth_scheme(int n, struct damon_ctx *ctx) @@ -1490,7 +1520,7 @@ static bool damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, if (damos_filter_match(ctx, t, r, filter)) return !filter->allow; } - return false; + return s->core_filters_default_reject; } /* -- 2.39.5