From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A028C19776 for ; Thu, 27 Feb 2025 00:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70B24280006; Wed, 26 Feb 2025 19:29:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BA91280003; Wed, 26 Feb 2025 19:29:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A9D6280006; Wed, 26 Feb 2025 19:29:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3CC30280003 for ; Wed, 26 Feb 2025 19:29:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9C6A121108 for ; Thu, 27 Feb 2025 00:29:18 +0000 (UTC) X-FDA: 83163840396.15.38A8B7B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 46D63100002 for ; Thu, 27 Feb 2025 00:29:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oW47K3SK; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740616157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d8D8LT9IoK79RnLiGW4KOTcnZ9kkbNtVoZ+I9QITU8M=; b=PE/JSj6KRwayAnM6VJSzfiAjZ6ri5c4iMPznwICUltKP3kcHWyqBO7DS2X4iSWYYY9sFgV eh+JeNSnVLqx65AcU33gP8RADcFTJgawbUbeiwtSD4viPZvO+jwuuXgcd87967AsaZZoCX lurMOzLkoEFkehNpFjIsanWP/zFt2RE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740616157; a=rsa-sha256; cv=none; b=8DAWxm8+ZLl266/HwzwA8IfoIK+wHCdtVB8An2nq/wNDRmrrv0IRGWJa0MMg/uH9tBx2uy trlHsHHaMZdLYhwE6V8RYZKxpoAvJwLBXlYLulUtMsfeOyNLXxj6O+vrHJrhHTHNqKrwue J1umF0L2qNpRYWzeO9Fji/5bp4AxBkQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oW47K3SK; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 692225C43FA; Thu, 27 Feb 2025 00:28:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C32C8C4CED6; Thu, 27 Feb 2025 00:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740616155; bh=LXJIbPMkT+7UcF2UJzjcQfuNFcE1BU59ZW1aikiYshU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oW47K3SK0W9wVtM8OCRMHp9d6TXboaEtLsTJjp6nDq0xMDTku8JxPy8NHkXQTZtRI tOSZDquLxmBsUduUEi26OHXqfcdHioVHi3dEzss2vSuZOWI1HDMqjBOGKK3zQTTUgJ ivFs6wdb9hmxCjF8XBMmdGKM+QYC9oGBuoylxjXaRZlyXuQATlmfxKSOiQD0zq4Brb oINQ5JTFKR8Ygl+tvyoVu1z64sUKwNLMXOTnIjWG+RxdNlewi4SmgGVM9KOpCrHkEN VJgM29g0rOFsQQtPucEVazGiIFGiZRsi6hWfNNDgi2DKyNiMao0ZrCUtPJuNXgoMRv wGY7g4fjjhn4g== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 7/9] mm/damon/core: set damos_filter default allowance behavior based on installed filters Date: Wed, 26 Feb 2025 16:29:13 -0800 Message-Id: <20250227002913.19359-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250220193509.36379-8-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 46D63100002 X-Rspamd-Server: rspam07 X-Stat-Signature: yrx3y9hfygxgpbz15pjcztqq5po5utdg X-HE-Tag: 1740616157-483864 X-HE-Meta: U2FsdGVkX1+OXoAEuMvLX+Qy0m2TucxWUDMTvyWBfnu0HZtzc4DaZs+cZ0lLhN19zYm0MNhZ9AWZwiz6VxUSjGe/6cwtstkP1Rm8/3L2/cY/70ZXM50OkBbzaErCPbrj6ZIFzAgMZNGOdGkStADJ9SYF+Gl+BEnYG6QqZtZfcjmyqjabLODoYfxFna3MbrvdqKJ8O6KsUF0kQlXdu/vidgevWFw/pRB7ceom386fVtvxWQ1QhTiGiXgjd/V3sBBtD5GLmbivwNUSofcoiL6Sq6mzzcmDQ9GhhDqH7CV0STL4W9LJ32Qwi3hoyY8IaC5fiG2i1bkc9HOc18KzOsElRUMR+u1S8opCDJreKRFas6xkmIZPknMN1/PnexQe4qQ+SEJCvP93j1G6np+tXnkdiO+z70ee0/Y2U60VvRwMfUO9i/qmjwmuC4zhgsEXH0XgMWbAGWnBkU7qgRQpVdSa0U2tD0vaxSxXD5+s2WIURuXsAe38UT8SMjVJMhfnw8qNuFvUz+eky0VOh90251uCuNaO4MxxNLdzTihS6TlUQmCSGfHsG4pbYPR7MEKDxHV9BLVcVD/PL9reFhNA/wYDhfi/jqdAJvZelW4oOPwZnmpCFwjcT5LjUjBLkTCMHWhIh/Hz+kKjt/sldk1aQsWzo8SYgtT9UCxotKb+7jftlKiVybEziDD7WmW7k5ePeFHKiumjA29ANLLiowhTBGydZgJBF8v9OsRJcrWQGJLhL1VUNDqa+nVHHachThwIHg49FYHxBLN3ofXNdEU7uFS33BqYs5s9aOZWmZkmNyQ6j+2Zr9vNjL+WO8xFUCbQGUDBbkhXzoPA3c4yHeFdbNW0OdY1z8AqWV4D1oZVRQSmrhU00lHWAsq10WTdjMwK7uG5bHrBKNF3R8wXnWVmPPXhXc8gso+hYf0E2vzQaRW6jZaUhZLAD+cTknyLhfXuinCHmWj4jovN1AZH+FJK0Pu 1s4vUDY8 E+lY3JNXTbe/ycxvjO2Oclr31nCbBQpZDCTgRccY3x/f+lT5L7mGeSaposgC+whgg15ZXO4pxw9ErSDFNhSY/aKQMIJxcvY0d2xb1hmhpHSjhoAR0ZqocZzmnIMyhGCkxxxU9IdGrgukOcn8LMzbcZP42a6HBT/c8eZOyUiGZgA3F3RRWnBqrQh47JQPd1TcIUPTHBrauAJogP4aUdAo5ueG+rUsrZ7z+vIYbxKIg6WDgkKE5f4XjbFdMhSeRuggfLZxmXhdzYuM0/cAGaGvMAvvN5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Feb 2025 11:35:07 -0800 SeongJae Park wrote: > Decide whether to allow or reject by default on core and opertions layer > handled filters evaluation stages, based on the last-installed filter's > behavior. It is the opposite of the last installed filter's behavior. > If there is any operations layer handled filters, core layer handled > filters stage keeps allowing as the default behavior, since the last > filter of core layer handled filters in the case is not really the last > filter of the entire filtering stage. The last sentence describing behavior is not really implemented with this commit. See below. > > Signed-off-by: SeongJae Park > --- > mm/damon/core.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 78126a5145fd..9744ab9ca5c5 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -864,6 +864,29 @@ static int damos_commit_ops_filters(struct damos *dst, struct damos *src) > return 0; > } > > +/** > + * damos_filters_default_reject() - decide whether to reject memory that didn't > + * match with any given filter. > + * @filters: Given DAMOS filters of a group. > + */ > +static bool damos_filters_default_reject(struct list_head *filters) > +{ > + struct damos_filter *last_filter; > + > + if (list_empty(filters)) > + return false; > + last_filter = list_last_entry(filters, struct damos_filter, list); > + return last_filter->allow; > +} > + > +static void damos_set_filters_default_reject(struct damos *s) > +{ > + s->core_filters_default_reject = > + damos_filters_default_reject(&s->filters); > + s->ops_filters_default_reject = > + damos_filters_default_reject(&s->ops_filters); > +} ->core_filters_default_reject should be 'false' if s->ops_filters is not empty, since the last one of ->ops_filters is not the real last filter. But this code is not handling the case. I will fix this in the next revision. Thanks, SJ [...]