From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FEDEC021B8 for ; Wed, 26 Feb 2025 18:21:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00DFB28000B; Wed, 26 Feb 2025 13:21:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFCF3280002; Wed, 26 Feb 2025 13:21:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC4A528000B; Wed, 26 Feb 2025 13:21:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF29A280002 for ; Wed, 26 Feb 2025 13:21:54 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 652931604C6 for ; Wed, 26 Feb 2025 18:21:54 +0000 (UTC) X-FDA: 83162914548.28.3EF4390 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id BF4EE40015 for ; Wed, 26 Feb 2025 18:21:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZcuAZ9mE; spf=pass (imf11.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740594112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j1F9I/iZ8TAs5hDxt1ttZ19kx2JlBHbTF4jlMhaCVOo=; b=WrizO/p/e1uuBiKWRTBfuuOPeq425vpo0liuvdyY8ZPzOYta9hivxISY1lhfhHq0bEnSDn aB9Nv1bXp1tWQY+JVmnoI/Rb8Oy0E8/5nGio6UE3EwvP/eoDZmX9bbAtueVVBvR2dL9J/u Vweco5yxKojCa2eKAEog9jerlTQqhiY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZcuAZ9mE; spf=pass (imf11.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740594112; a=rsa-sha256; cv=none; b=4L06MCgWSixFDmpVCp7pMXUsBtHsui8r9czmYzOa17QT+SkBXhCdhcx+6LRPTLpH8iEtTR n1gGUH48HtOgjf4KlFN+qrRL9G74bDzoE/pdzqrbsCWKB3mNA/hFmbxIJLzFyVMpS3aHTD UrmdgBkmTEvGiUISIDnGgRzyQFjkPTc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740594111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j1F9I/iZ8TAs5hDxt1ttZ19kx2JlBHbTF4jlMhaCVOo=; b=ZcuAZ9mEPgD3050xutGtxKxb8IX+9c3w6KiOa2mwOf+3V350Gip1RD1mfhFiklcj2jRJAG Nq2MFdqXH+Ebj3Hea1YzClE8lGFcZyXFkHi9yFU1A7ULdkoIHH8gxFlYgrzK6n53Vjxvmv lZ10clA8FCcGa+o+AzJbXGdmMhEjJng= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-xJSHAuiPNtaqTVVQa1RKpQ-1; Wed, 26 Feb 2025 13:21:44 -0500 X-MC-Unique: xJSHAuiPNtaqTVVQa1RKpQ-1 X-Mimecast-MFC-AGG-ID: xJSHAuiPNtaqTVVQa1RKpQ_1740594100 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4022B19039C5; Wed, 26 Feb 2025 18:21:38 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.247]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id CF318300018D; Wed, 26 Feb 2025 18:21:21 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 26 Feb 2025 19:21:08 +0100 (CET) Date: Wed, 26 Feb 2025 19:20:50 +0100 From: Oleg Nesterov To: Lorenzo Stoakes Cc: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping Message-ID: <20250226182050.GK8995@redhat.com> References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-7-jeffxu@google.com> <20250226162604.GA17833@redhat.com> <20250226180135.GI8995@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BF4EE40015 X-Stat-Signature: mu48s5pyuaxzg1xjh9pzx9oxjfkua7oz X-HE-Tag: 1740594111-223710 X-HE-Meta: U2FsdGVkX1/81n50rcFz6g1ivQn/FYByhrbFxrlw0ywONyTUhP9zAorHxNy6/IgDmDhGjUDo7ueuLdWzaXEi0KQy1qv8zQV5VdpTj5UwfmcNW3vsN+KSLh1TuW55aLciFUxBgpYCTtS6MVn4qGBbVrTxBXXDmviTbBvNbO4Zeq79UHuz/QBA8q9B9yA/0qs6IbTTIgcvN1IwO/jYKN39YXGd6Gpo+fd78gVXr2INXoGZlCO6j7O7M6lRuzjw4a53B+fqU00UO4QLGAUX7j/d+ls4sCG8WzoT9RspRoI8bcyiOKe3QJUlxeSwvAEYEPbFtssO6V9ieM3CvnAANtipifIsCJVq0DfI+XsByYoxOFBkhShyTumIXE8woDocbMcXq7T3TjpGM9lvcs5HbAEvCf/Oy63JMTNJnhJC2vdGPEUVOfEpnST+mE33zJpEAe2nylQ0b7NQAN3UF6VtatCn73x2FNgOmpSIts+YDSBTE760L/4icvcpq8sz+/CR5Wqv4cyROB2EedxSrxjMYFi/XBdo4LTCrPJqX59XN8cULHdA8Bz8gZdNlguj9YSutl9G6qnj/tfkr6MJt5eetwkjur7JkJbxWHe+beB4Fzsfr4EhqcyVrMT1R9zFKwewVRfsF2uU5hQCiHSSYmoR/2RQ8J4OEnCXPxjm9hJ/GEHBKwyGCN0RD2mXUDCuBbcT6pCSW4AfMO9iHUWNs9WAIF073BpVz6KpQc1vsO6w3wOvr6/mjirC7OAYJ2xdeFZF8FTE+C4owuMku2BQyikhOLZiEUM9P912RX+V9qiUCOxYDuqldbaIo8SWdIO7i80/EGnkgJNZebYkVIhhTT7PFebwusbTjWm4mAyW0EDVu2wxnoMFGzBG0Mt/6Q1KoODCoinHi9eB21Nf7/EKDrV2Jz8KC3jc26IyRkR/aL9KJIG484cfhCmvS3XuJboM92h8Srh2QMnUkfIC5lP6+Qmz3Sj NuuPxn2M lMJ7tp2A6VrkuLZLQhKk/k4cUtgpTR8t/a4XCkY6J2htSPcggU/IuampEK3z7m3JUA68rjofeirRURAIhua6fnO66+oUmJRIVr1Bxm+6NVCSS8Cu1NVWcecQk92Dl78wdBJo+CBDRiSWXWTlD2zagxQBwySTVBBlS/qgBadZkvZrP6doMISGC9RugJPvLYXMzrGdSWOmgjqgB2UndbEakhC7iBmpF9GWXHQMmV7mV1gpHG1IKWrCg6FaBsicYwzWq/bibBLk/0/marFpgiNVGRVbcz9tvcGYc+A5EyGPOafRBTMS0WNV9AKYfKVsKX5I+2kbXUtbi923Ut4ddpLE6uAfjpPIK6+hyLBejtpeHWl5ZUB+71HiZWUnbbtCBMPPJ73ypDk/4397DNQyYivRFyF4WEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.031124, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/26, Lorenzo Stoakes wrote: > > Like I said, Jeff opposes the change. I disagree with him, and agree with you, > because this is very silly. > > But I don't want to hold up this series with that discussion (this is for his > sake...) Neither me, so lets go with VM_SEALED_SYSMAP. My only objection is that vm_flags = VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO; vm_flags |= VM_SEALED_SYSMAP; looks unnecessarily confusing to me, vm_flags = VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED_SYSMAP; or just vma = _install_special_mapping(..., VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED_SYSMAP, ... looks more readable. But this is cosmetic/subjective, so I won't argue/insist. > Jeff - perhaps drop this and let's return to it in a follow up so this series > isn't held up? Up to you and Jeff. But this patch looks "natural" to me in this series. Oleg.