From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A570C021B2 for ; Wed, 26 Feb 2025 01:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE7826B0083; Tue, 25 Feb 2025 20:54:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D704B6B0085; Tue, 25 Feb 2025 20:54:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C38126B0089; Tue, 25 Feb 2025 20:54:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A36FF6B0083 for ; Tue, 25 Feb 2025 20:54:03 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 20C5C52216 for ; Wed, 26 Feb 2025 01:54:03 +0000 (UTC) X-FDA: 83160425166.30.5190009 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C0D01A0002 for ; Wed, 26 Feb 2025 01:54:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=doK4wBoG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3OHS-ZwoKCF89E7KDVR7KIDLLDIB.9LJIFKRU-JJHS79H.LOD@flex--changyuanl.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3OHS-ZwoKCF89E7KDVR7KIDLLDIB.9LJIFKRU-JJHS79H.LOD@flex--changyuanl.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740534841; a=rsa-sha256; cv=none; b=7leo0HaD3kGmP0Rvl71aMxYZzqFBoplXndjRcQbZryg2q58ZFcldJ1WIEJ7XFqAbkKDdcR jynkGe6OMiTjByA07Sn3i+UzJQSjf9tYtXBvZwulgJiWqo0oyc73VRTWqaTmVKfqmDZs1k 6IirOoUGf3Y4pr8Trj6zsTm/W6ej+Kc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=doK4wBoG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3OHS-ZwoKCF89E7KDVR7KIDLLDIB.9LJIFKRU-JJHS79H.LOD@flex--changyuanl.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3OHS-ZwoKCF89E7KDVR7KIDLLDIB.9LJIFKRU-JJHS79H.LOD@flex--changyuanl.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740534841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=WiqENLxGVDEXH4M9Gi1Aacvw55Fid9VrpKbIwKpz4tBIkrJbRwAXMlswU6zsAzCxxO7LYo F+w5w2kaLZmgYot94PONWhVp5G/dNEW80kBwEk/9knAqREYVOpXngkt3W+vmqBexn6RzyQ QvWt8K6/jarWZMT/DlAielq147pxD5c= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-220ee2e7746so127069295ad.2 for ; Tue, 25 Feb 2025 17:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740534840; x=1741139640; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=doK4wBoGbNqSKW68qV/QSorHnVtoMZBISlVbAn86kRM+uqU8GHE4Jj23uuWqmLLE3U ciVZdPt3hYgpXz0Di38hrkktfIVStZ4CrO7nkB9gRZTvdlNFFsi/osBKjDvpy9KPlS40 9QGSc3ia8buILXZrgjkfiRntLvhsHF0v5ztffJVacza5ZyHzErmpgruFXSAwd7Ij0m6+ fvQbFMNj4VXs9w8631wlpC9mIsw3Q8gM5NOeqX0lR8jBv0YG8EVnDbmUchCG02+NQY34 fwo1bMaGE49rbtnUBFfOn/1IkXMquPY5mmornNXAszCH724JYbywLQ06kE1CWwEkLLka HdAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740534840; x=1741139640; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=dRi+VdJkEdn31hKgCJuztOqqVzDbMgBCOnWW8xzKiIN6xynJd5pI2MSg9MJ0In+DBK Yx0AWJmD7wwxQCRVr/QRdScaTJkLPpVzjgrerFXzoVxNB1xaqBeVfChz6PheGUfDgulu FgV0+C3yLEAF3jRdPiI3Yra3vwSN75cXIxy3zBnCWydvsCuLrEqUW8GzgqGwcoanqUti UI924vUhj2sXP56lvPeJkt4CTs2KRrOPDu2NyrjqoAAG+UeUeHiN/fp70ck2q967a0GT q+/ilg91uQgIPzJaMtOrHyfLWzIK6uK8yRwNF4jdlMNQ3PD+QokmYLdF5v9jxhGQ6fDn 4xzg== X-Forwarded-Encrypted: i=1; AJvYcCXjgPzftkcFVEu3+yAKLp7gbt3SUH30UZky3LF0Zz+Mz5J5k0l9Qo4MwrvGgDdvH+cScSm/2bKNWw==@kvack.org X-Gm-Message-State: AOJu0Ywod9Ex1ubyYrVfYFG5XO2LuoaYUvxOJEwrON1ofODg6gqJKyIj SyNr4XThdRLhabNzYCeCgt++YEaaT4U0QNiAo7VHnt3AP2TaqhkKe73M34p4AaaeVYcscdg7huK CjshyfOiMngiuwxKXVA== X-Google-Smtp-Source: AGHT+IFkznZMkNBk5de2vOfANCIGfGmFUq4ZoIai/G7n3JkeCyYN8XDtQ2NLIWeTlmgvn0M2N7vBP6JVrlIIeeRX X-Received: from pfbna17.prod.google.com ([2002:a05:6a00:3e11:b0:732:502c:4a0f]) (user=changyuanl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2e1e:b0:725:df1a:285 with SMTP id d2e1a72fcca58-7348bdd003bmr2703166b3a.12.1740534840070; Tue, 25 Feb 2025 17:54:00 -0800 (PST) Date: Tue, 25 Feb 2025 17:53:39 -0800 In-Reply-To: <20250206132754.2596694-3-rppt@kernel.org> Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.711.g2feabab25a-goog Message-ID: <20250226015342.2136669-1-changyuanl@google.com> Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag From: Changyuan Lyu To: Mike Rapoport Cc: Changyuan Lyu , Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 5C0D01A0002 X-Rspamd-Server: rspam12 X-Stat-Signature: 77o4faye1mtubbbzpmqiu9jb1fetehyf X-HE-Tag: 1740534841-125303 X-HE-Meta: U2FsdGVkX1+qKcVT81ujVpJIrMTZ3Y/l0X81WhiC8tAPLgKl4F1iYbbkOJ3GYFs5gvsz3hGA84XEPLlv9AQ7ame45EQsPtfYUcGXhYxj0qMfZCr9WQ5EbVq+Vji1TbqGjyfFuthh6QDnrMUpWynLl7oJKfWLdMR7gtpEK76+EGJDSNXVAwRk42RzmSVuNP/aP7zGIBizajyufxLQqC7rU10o4XgYkjEoyN5MFjFiUVxNVO4Ix3UA3EBFO4apxNHi2l68Yr7PMlD/5pAN6s92TBAeeEletgpkQ6oE0UjLBUYy5KMg9wJCQdqYizdjD6PPinrhvCNgCYXQDyfuE0g/Ihf/T2wuldR0FLG8xviQCFsbnOmj162E+A2IHWodRIj6ddpAJ8EfksuWr7xlKLwMHQQ6gnJisVSpPrSvRiesP41Lt52kJPFa7bSLRvvznzB5rx6YqqEcKtubAvESozqTPmRt82WaLgjUOgqWEmFLnHZT4EXI35uIuC+uPf7TZTfUuulSDp7qMcsGr46IMqAfCI8ifcb4qbYJc1CTRqyAr2JjEbJjkbJysZvdY5yYKjHlH4mvv1hbRLDpJiW0OkOF3ro/LVtuI2XH9871SwUM8yXFIHGp6dypWoV95NLAsG9NgZ1x+KeEcRiBObku8DzyniBgB5Kb6oDVoYSUXFS3iCap+NQzHPMOUN2YVlejarAv39hNf+dYWw20uSslfgSxEMkkz2r3WPyGYhHkPGDGs2iPnXzes4Ajv90bOmVf0KxEkDdE6qZWRGDVP+QvF7Cg+9unFOW1/cU1pJEpjgVDi/OiXpSlxxzMnQAyURMcBMjXpXrJMgUcBI5tJJ3esNB8DlHLiWDN//dUOSyFaavw/KQTH6I3YsnV9Dr24HDPenI4U2xvzB35dh/xmc7uaUmLYh6RziOual9/1q0beAYCuQfdLmH6zmZm1gScSl0gM/E7GGmJEqYhy4lYaOLOiil 15y+DSxH KpYqSomFMW4OqZsfEWXpRz2M+SolT0vTEwVpsCzyHT7rJxQPbihSNTkVPSu7wCwMhMIh0f//kWG4GODneag/eHPm8jYI++INoBGyaebLS/WnUqmswRvlj/gSYr1HUNnuiw5uXWce4nTHkWqKNiKzvPjTX114vVGdM6AXMWZkRI2pw//a4/Ln1C+EAC2NRG55b4Ws6Vj/A3rmIZm2SRf78c/mmciUB7OaRMLMt6Fy4cMdRE4M10NumkSMlPTNhIbQVdZnpT4M45pHnQUjzFzUzdHmSzQn0VPdAu2CIyDMIXExXa/WKvfwK3lT2iT6gSq0G+GZ+kvaisAMBwzXeiCOhSliHoGJUgfLx6lvUVu/BpDhMQxF1FnCdh8ZMw0ZV/OUr0hebbsAg+a8uAMdZSn4QCdGZw7fuMa6ti2+47hfMqvHFPxPXDbsfwzqAC9zSfJkMetnyzIxa+6/QaWkmrj5bJHXvVE0MTUl0l+f+x9hllC4lrmdwDmYrPIHVK+sA8hvDdw98Rwt9mDWYmApHefw2TDT7jG8Rfk3B4gMTF3dJSP/8GsmbnVCsRNzb4lTveeumQXsvR3sGGTQJIxzn12H9Uc8g5joVUJXMZ4fEKbJ+bao0iQr18JdhcnTvCpOwSAZ7qJEj8mOrHPEoeZgsJ7peIdQxzcyBDSUURMuuyjv9Y+hU+6vF2gEOWJvIXbeZCMKxnnKjZuSGyExUxIcuDcaa/5HNnI5UV+WMBZfK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mike, On Thu, 6 Feb 2025 15:27:42 +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > to denote areas that were reserved for kernel use either directly with > memblock_reserve_kern() or via memblock allocations. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > include/linux/memblock.h | 16 +++++++++++++++- > mm/memblock.c | 32 ++++++++++++++++++++++++-------- > 2 files changed, 39 insertions(+), 9 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index e79eb6ac516f..65e274550f5d 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > ...... > @@ -116,7 +117,19 @@ int memblock_add_node(phys_addr_t base, phys_addr_t size, int nid, > int memblock_add(phys_addr_t base, phys_addr_t size); > int memblock_remove(phys_addr_t base, phys_addr_t size); > int memblock_phys_free(phys_addr_t base, phys_addr_t size); > -int memblock_reserve(phys_addr_t base, phys_addr_t size); > +int __memblock_reserve(phys_addr_t base, phys_addr_t size, int nid, > + enum memblock_flags flags); > + > +static __always_inline int memblock_reserve(phys_addr_t base, phys_addr_t size) > +{ > + return __memblock_reserve(base, size, NUMA_NO_NODE, 0); Without this patch `memblock_reserve` eventually calls `memblock_add_range` with `MAX_NUMNODES`, but with this patch, `memblock_reserve` calls `memblock_add_range` with `NUMA_NO_NODE`. Is it intended or an accidental typo? Thanks! > ...... > > -int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size) > +int __init_memblock __memblock_reserve(phys_addr_t base, phys_addr_t size, > + int nid, enum memblock_flags flags) > { > phys_addr_t end = base + size - 1; > > - memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > - &base, &end, (void *)_RET_IP_); > + memblock_dbg("%s: [%pa-%pa] nid=%d flags=%x %pS\n", __func__, > + &base, &end, nid, flags, (void *)_RET_IP_); > > - return memblock_add_range(&memblock.reserved, base, size, MAX_NUMNODES, 0); Originally `memblock_reserve` calls `memblock_add_range` with `MAX_NUMNODES`, See my comments above. Best, Changyuan