From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F9DC021B2 for ; Tue, 25 Feb 2025 15:14:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D48496B0085; Tue, 25 Feb 2025 10:14:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF7C16B0088; Tue, 25 Feb 2025 10:14:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC00A6B0089; Tue, 25 Feb 2025 10:14:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9D3EB6B0085 for ; Tue, 25 Feb 2025 10:14:23 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BE35B2A45 for ; Tue, 25 Feb 2025 15:14:23 +0000 (UTC) X-FDA: 83158813206.12.A91CEF9 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf12.hostedemail.com (Postfix) with ESMTP id D65894000E for ; Tue, 25 Feb 2025 15:14:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xTuCNOZA; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740496461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dOiv7bSPf7EjE51B+T0p4dYCqbf2wAsHmjw4hcxI774=; b=ATcoiFs4G8HPQCV6y+SlCuGyJ4kR8hJcge4VqHhAPwGnNRz5QQvqHHX0QHaW1ICFlqGlh9 ZUDdffznhiPiuaJ7XsrsLxvyIkUR0eYsiV5wV0ffXZzhSGCPJyOPkripQhB9J/y7pR3v95 rspTmF2Zo5tbylk9aG/MzmPYr2b5N98= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=xTuCNOZA; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740496461; a=rsa-sha256; cv=none; b=oxvoV1Y0dAmPVVvOaF2ZvQlLjXGvEYCPve2t58nDUGYxPTmZpKSTcJazILtzRXeamlS6xq OLKtqiybvyycmTzdvtY2gwoRKTUaG+ub7DOG/LT9MTpj6WdkAESIyLvV3pJV/KpXfibP8i RIc68K5emCO10nYOt0hsrDOMXCcYCKU= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4720fb0229fso53982851cf.0 for ; Tue, 25 Feb 2025 07:14:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1740496460; x=1741101260; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dOiv7bSPf7EjE51B+T0p4dYCqbf2wAsHmjw4hcxI774=; b=xTuCNOZAaFTi1zmQyNHKlfZ2N0HkIjkiH0D1pnJF1YENyXflRtr1seL2CHfHVsbt/D xlR9M1HvP1dl5/NcdHPwJ/uojs8nejZOO2++emclIx3dN6paRhrydyx47b2tKFMrJb2P BRVOBvH4g342zd6/IVmQ3fuRxRi1Ff2Uu4BEtnr76eMpW1aiLzr1ndamkE9YaRvTsdaD FQitJS2+QOzJFrw5ivOf26QkYDS/0JX0Ebx8UP0UFLAVmtyIIBlB6NoPjWNj2PM1H+1j Tj8zJhjWsb8bM2xKXWhLzM5dzCDbqQFzuzlTy/v9nsz9A+QRNdCmhC8FRr9c0HxIVq3A IxPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740496460; x=1741101260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dOiv7bSPf7EjE51B+T0p4dYCqbf2wAsHmjw4hcxI774=; b=NOQrelWYoFskDcDHa3Es7Sd4iOn3If3eMiqwyeUkcoNGiLZKqFKW3+kUmf4Kd2j5mq +UkdqVUIVWeETUS1+hZPAOQh8UpQfE0IzCFYpJjSoP2YJAAOYeUtt4+OrxxNLdmiQMAj mO7uKCm6yggrbRwZxkLvgHPC5VALSyHhJd5weV5F34n5myoO3ObdTI+AiskD3ptIrHzj UM5MNf1wblYWqrkTjW1oSow8B1SN3349sTXPmv5C+j13K0ydczDkXIHjanGoqXyDc44E wjjEVvmB5qTxIcZMNp/T6o+Sw8R0v1tgQKbs+ylpp6jaVTz93LvicknQlVcTlX7Z5QpX ZhxA== X-Forwarded-Encrypted: i=1; AJvYcCWRWiWUq6UvXqL7rpuuFGIGiAMcaAd6DaKuVjnke3OSzaG3RusiOnEyplWqyaudWfP4fcqBwP2Tgw==@kvack.org X-Gm-Message-State: AOJu0YxfbNM0zXiyUoYJaIHz+K5wqKgprZx8sl3sk5NOSqN/y2g/fzii VhpoSlFF1w4RptDN0Tz37esPTKvf+z6qTJihR/+SJGdjZep4RoDE659WjNFDaRs= X-Gm-Gg: ASbGncsZNP9oEE19TLEw1NFH06Q7bUWXRNKxPenHs+oqvSw94hIvd3E4x/lxp+wuRUw m4Qv2KtCbY5Fy6pwr9CLjsibwpPlgfFt7yoSaJUxrBGuJncmYRkUxv28y/gnGiDD+L9UOAfacY4 ADOLqGri1jgITVyywhSv0Ogya2D8xmLhVi/tdLgwu2Szt9iyACRoDJEUMLEp3M1lOsUZU2A505o xacTR5o8GTmTX9OUbuTvjSUGXEa+wthw8SwA+vsA1bDiRHAU5kf9+WGQk25BR4ikggyH6r8uldt hRpBnSMCrljjQlJkBUKVqpN5 X-Google-Smtp-Source: AGHT+IGP/2zpNEzKXQ2v3FQ1MydEpiwMwCLWksUbfMhw6AAi5TzZ2aWM4S09bKoL3BSv9/H1tb3tKQ== X-Received: by 2002:a05:622a:190c:b0:472:1814:3fc1 with SMTP id d75a77b69052e-4722485f414mr220324611cf.31.1740496459787; Tue, 25 Feb 2025 07:14:19 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-47377d5b9d4sm11038961cf.0.2025.02.25.07.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 07:14:19 -0800 (PST) Date: Tue, 25 Feb 2025 10:14:18 -0500 From: Johannes Weiner To: Brendan Jackman Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: page_alloc: group fallback functions together Message-ID: <20250225151418.GC1499716@cmpxchg.org> References: <20250225001023.1494422-1-hannes@cmpxchg.org> <20250225001023.1494422-4-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: D65894000E X-Stat-Signature: m9gouf74ftk7p5wsb1gbj3d8nerpsa9b X-Rspamd-Server: rspam03 X-HE-Tag: 1740496460-402196 X-HE-Meta: U2FsdGVkX1+S+9oaKI4OeLhBarl+HDgBuNiPeP1L4FajOQHBWkpQRj2iXEhCOWusvU29sfQSulmnJ/50XV10dTMpYuwIJ7eRwuAq7OAjUBm+qBdBy1PcL4w3+sspOrVbXqY5+x6ZEoqPW7Ud0UVbgQzGPb9xVIizoURrTfg3K1HXSdNa/qmXkoZhGT8eDWjsvnFwbI/mV9KpYFT/871QMnsh5NE2B8dL9EXojRV+7ANkU/MF7Fk6JKgzYYmmBNVXE9zPscbddXFnf8+X2HNkTfEpgh0+FONdS6r6YUgZkUO0OFBF9RqGJ12Dlcsh3+yXla4dcC/OalSkb1cRVQlrkvnAu2ql7lSq+v6wVxPtfMWinMy8/ny3ar+rePFSMwxazrWCdtFqFu8XphxIGgwioN+sYx0GLmcsFiF8xHdxU4l3U/dmqHG+VlJRDRNplmVdb1WpffZndUbVTCD/du2UCzjvpwNf+dotgc/h4X4d0Q7MqGEvQIw5NxiCaTwmTZrGRM3TmgxEXNU7b71DXq0vu16dtuQqWGiDS29jRC214QhEo8OIu78+uIHoY+GXaVCZCzVc+2HJqs6UKAm8/VkLyKwi1dB7p0lY8Hh516t3PGYJRgIP9YWCYn9S6I7LccZ7e4+4cDoPRaOoriN+oBWfb8xNq0tc1GiK1ceO6abnlBG2Lnm1Wxe/mAfXvccgXCtNrLopGeM3o6YJYWRM8cHKEogc53nm9fl8AJ9SWr1B5PEcOqyEhY7oPm0+Ar5LWsc257zgHHVfcbpWl5pXVB/i28NlrqsZfYB0fL7kM/Q08tZPzNqVG1r3VlUB2lRxzkDpilXm9yVOPhx/u9aQf+uAGXCzJkc+9RLWA3CY61Uyq0/0wTUXQgUHhlaj9lABl9Tr3C5qeWi7zKrKzcGStfNRIMIBruveubccUBJBDnUutBwvp8zLNeJzbJrA7NMPcPd7CAFDR4FU+eKKTfUAaOQ wG87nDX2 LuTB9BL6Es4QIIjyJs4CrmPakqs2hNVxldZXSOitnyetxNv9G0Dy3XYKKRcbYkL9PEhPvtEUjKuQAUInllridUS76w1fpDguw0OsqV3KLEXr2Nc7CZuuGaqpYx5WLmBqFkwgw3lIbH1UBDl8mlkZ1/mxkSqas6YnP+PBfdKs0wZSGPbcXBBiCbB41/uaMdNUiBXpwDdQ6GPWXtxlKbqLqlQ3i5/CV7oXie5cajtZpxD//XRIvZP3ZaZf0ZdsNVvPd2T9mD2Zo4HqwCrUEN57AqghXSDvPaV13WXZOPy2Ll/xitAo+yDG0GH+4w65fM/oloUPjJFW/PQ/fZiX5JNkRT4JEwbe/8+FKFknIR9fgY0iSnP8VEHYgx+oDfv2i+GXNxbZgMM6l6qf5JCc1kxxVLS3TyQPyOj8k9M5jbmFPxgKGkH1Rv6RqR0cYJM/AQPBOmPlcLisP8Cr0BtRktnYlqdki76X55VKqTTHOm+Jq26WAER3zUDBMmjTTvOB7tpuloYP9chvNKoxGhYE+EYGlp3lMzi8Bdb9B1tcFQqAQ4B2U4Sg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.026417, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 01:50:09PM +0000, Brendan Jackman wrote: > > On Mon, Feb 24, 2025 at 07:08:26PM -0500, Johannes Weiner wrote: > > The way the fallback rules are spread out makes them hard to > > follow. Move the functions next to each other at least. > > > > Signed-off-by: Johannes Weiner > > Moving code makes blame more tiresome so I wouldn't personally do > this, but if others find it helpful it's fine by me. I feel you, having had to get good at git blame, git show, swear, git blame foo^, repeat myself. Blame has definitely become quite important to understanding code. But I'd argue it's slightly less important than having understandable code ;) > Reviewed-by: Brendan Jackman > > ("Reviewed" means "git tells me there are no new lines nor totally > deleted lines"). Thanks Brendan