From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2B6C021B2 for ; Tue, 25 Feb 2025 22:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8CDA28000D; Tue, 25 Feb 2025 17:25:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3CE4280002; Tue, 25 Feb 2025 17:25:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B061F28000D; Tue, 25 Feb 2025 17:25:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9190F280002 for ; Tue, 25 Feb 2025 17:25:22 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4AA35140449 for ; Tue, 25 Feb 2025 22:25:22 +0000 (UTC) X-FDA: 83159899284.04.1503BF2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 79EE72000B for ; Tue, 25 Feb 2025 22:25:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=g0TQOcSj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740522320; a=rsa-sha256; cv=none; b=YQbwllWfAZlwYulPYz/7tQaJHXInO2EO8QtS1pXXFOIgeB1o0BOLfVmP55jZmydSvztfWc iP0PqB1f37nRept24bCVju9nNl6kiMhY3tSZhUMMt1m6RwA/ley6/G6I2NApuPJpn/x4cW EycKM5DZ4/5rGk1FeLnPVWW11eTJh/A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=g0TQOcSj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740522320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JL1h64KbNNNZTLomQr9QQ6kbpiZZXYdeW5CKJDnGbzI=; b=hGkfPHjKTiPgX+QdOGr6RV0gOW2k2qXTtjtLjmYnZtOkE98OxzClWkC456YyQUpk/2LxYn DpsYjunbv2NtmntwHW9BVT/0JuBNC1tiH659KI+B8jsPb7QwjO0aO18g+WmjLQvtevP6vY 7LjPe4WcwO6eXUrfyG7XW9k0SNm+HXs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8268B5C2775; Tue, 25 Feb 2025 22:24:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D55BDC4CEDD; Tue, 25 Feb 2025 22:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1740522319; bh=JRRIyL/a8aKLFOTghHkEIPXLTSsyoiuu3QpBGEuplCk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g0TQOcSjhXD9ZJQukKEuy4NVggJB8op/0g0BwzfrobcLbBJRt9WoeX8ynSRBSZxDq dNHrRuwlSWPcRQcQ9h8j6Iq+GMcfKCpQ3pu052kHh/RhgwqmYakMf5wj0clzfTrpAE +kbZl08NIWQxoNjVOQFr4qKefcIMTjaWmQhayZ2k= Date: Tue, 25 Feb 2025 14:25:18 -0800 From: Andrew Morton To: Nhat Pham Cc: hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zswap: do not crash the kernel on decompression failure Message-Id: <20250225142518.cec35a0ea77a0d86f3e860c3@linux-foundation.org> In-Reply-To: <20250225213200.729056-1-nphamcs@gmail.com> References: <20250225213200.729056-1-nphamcs@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 79EE72000B X-Rspamd-Server: rspam12 X-Stat-Signature: rdaudcroopu881c3pjg7je69zai614e4 X-HE-Tag: 1740522320-960950 X-HE-Meta: U2FsdGVkX1+H/Hz1a2+qHi4TuMeNul6iTesEPEsHzQGLtlPLHAxgvZpwhad4S/6dyhxUq1uZcu9+ibpFAzdg9NKVckva77nsoXAd1YrO5MvJMjRDPC+WH8XvVO6UDIGh1RVpWRj0hdjsdCp8cforS7orHQW5Wkbwbp+qzP15eIP5tfmKO/nRmM2LnMMbzd26UXWdr4jQT+WTHFX1kEaEGAXSXJXU/XF3MAgo4IDFutU0fxOAwW3iN2WTp9hVHKoBJyhVmP87h2nCtFwmAA28HvBgSbCpw/kFIzAwm8jkxJlL8Kc2i628Gdi7Tpiimr/diotHL/eiSYlye7SMrVFs2LDRwqlIqdLive5CzbSGXBT/WIJwVEFltisp/HgXrWNWzC2+gWgEPSA8Ab2rqSxtag6bHt2h8fDMTS5/7khlmmjVoreXLuV3uTRuh0Lr8H1rrFEN33/YBQc5CRw5HMLjguzgT6e6njbD6qjuyBD8vPY1JVa8w1OBXGpcT6uFoNsNsCwF9FEuiSJhXI9Y1pg7QMDY6NBSPldxajo0CWBYYlotM1Nf1VQlK0/NkbYFANh3SYH9ERb1XiC+fklDxL5jkVEQOAHY2b3X6SQlLogqU3i5FXJ2fMSb7WT+KDWyNWhiD0fqwFpG496SznDJMDgzhk1ErSWAaNbVXxPmnrcEnqerDg+iXYwvgFgx6Y4D+di1PJsMazSYcH6JDk3goEtaiah5AEBWe9uQIN6hkAyzJFhU5QeW4h815ZTRGTZleKGafGRh9f4FFQbkatiLbKZH2GcjIvz6qVACyOsnQW6iXoQ5V3GEaJ7xIGztRxWSqYGzuf5gjIbfdcvaXSnAmpIWUGtsJ2/1V1COtOUWe8FViytPsugo15xnGGHy76NGfT+713mYpVj2/QwUM+aH7CGdhLzt6Hgn9+OCMdDL23d2y6blEj2nfiCPp8EZCm3ctkkH8a08bGLsC/QnuZiySJs mWmMCbnY uyOtc2Xny3BnZUryUUevcfP17LQcnFI2/F9hpb+HP/529MHrIxypZLYEs2AJihIOZ82AsEHFQqi+EUOU85OZt+H5oQQscx/1xsTw42O+QccyT6hqK8cfM2gSVo/DMxff2o5jU9bZ8NGTiFHsGBj4TDtJwt8fdjEAYFCk2ZOv8SBPN3h2KjL+nmIGalOajNrmbzcyGiirQJR9NRbodzUD97Fwzq9FwKGrNWbJsxQmxlHpYtYfgYRlwWZXsXmzzeCz+kaYLHTsFdlwIO2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Feb 2025 13:32:00 -0800 Nhat Pham wrote: > @@ -984,12 +987,19 @@ static void zswap_decompress(struct zswap_entry *entry, struct folio *folio) > sg_init_table(&output, 1); > sg_set_folio(&output, folio, PAGE_SIZE, 0); > acomp_request_set_params(acomp_ctx->req, &input, &output, entry->length, PAGE_SIZE); > - BUG_ON(crypto_wait_req(crypto_acomp_decompress(acomp_ctx->req), &acomp_ctx->wait)); > - BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE); > + if (crypto_wait_req(crypto_acomp_decompress(acomp_ctx->req), &acomp_ctx->wait) || > + acomp_ctx->req->dlen != PAGE_SIZE) { > + ret = false; > + zswap_reject_decompress_fail++; > + pr_alert_ratelimited( > + "decompression failed on zswap entry with offset %08lx\n", > + entry->swpentry.val); > + } > mutex_unlock(&acomp_ctx->mutex); This mutex_unlock() isn't present in current kernels. I'd normally just fix the reject but a change in the locking environment needs some careful checking and retesting, please.