From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 889D4C021B2 for ; Tue, 25 Feb 2025 12:43:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0287F6B007B; Tue, 25 Feb 2025 07:43:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1AC56B0082; Tue, 25 Feb 2025 07:43:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E08C06B0085; Tue, 25 Feb 2025 07:43:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C48276B007B for ; Tue, 25 Feb 2025 07:43:38 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 304DA81427 for ; Tue, 25 Feb 2025 12:43:38 +0000 (UTC) X-FDA: 83158433316.12.EDD1E77 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by imf06.hostedemail.com (Postfix) with ESMTP id 397E4180009 for ; Tue, 25 Feb 2025 12:43:36 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=ahtVADj3; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf06.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740487416; a=rsa-sha256; cv=none; b=utOO4BGu6XFyo47LdOiLWE+CDCvrz3fJg84aRZkmUt6SYhHftaCe76DFm4JVjlOapy59wg TxlnGllKuh72mYBBQC0emsOQuj2luOj36G4BuNm9Pvo+EesNYPUB1W8213Fphn2jlvfGVf 3MtsQMI6I7x8TF4S6Tbqe7/ch8aD7Ec= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=ahtVADj3; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf06.hostedemail.com: domain of boris.brezillon@collabora.com designates 148.251.105.195 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740487416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4MIeG7uxI3B4a8vvfZbntHH6yNu1oVafWDrnwd5bIHk=; b=WeJRg9oglYtFczA5WT1lSa0w9MrFH8zZs/Ooopu+0xGUyEOdAj80G66ud2zjskhKIKbJK3 XMu4/EtMuS2bwuK9jgatRpaX3xdoCNWwIZ2Jhm+79fHCuf+qXFJ2gu4z3TWOmHucC0gB3K jgM9SK5BeulGzTPT2kSt9B/rAMLYKL4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1740487414; bh=ThZw8T6DuX3V5frsHq3jSN62Ru0Y+m5d8yUPxihXdE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ahtVADj3Eee4RvfCy9YX0ZRDzziZHexss9gc6QtR9GrJjhUjtv2cKhh+oKVFYHI68 nVn/jcuQkf48vWYnsE/lKjawfIwFDwu9ZaeZLvUKrTnpJwXt2y+lQwEC2guMISSjOI 5TC5m8B9Ntkh262//3SkgI0NK9umoEZ/g44iCiSMuwzrxLlwG+uXIYLOrEtImjCvVE eh0LK8loXyo1gL4mAhLTzCyXQh4GlwKw4Z4riNJm1cLg5pYzkEgG0cHsrSjvnRWHzH QI7aGcj+fIRlYXc8GI7T6kUrewUcFt1D7Zn+BHguyeX93oRTwmzKFWVLoE2zzKscpr bMJmV5l6oWU5Q== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id B9E1317E0B59; Tue, 25 Feb 2025 13:43:33 +0100 (CET) Date: Tue, 25 Feb 2025 13:43:25 +0100 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steven Price , Rob Herring , Hugh Dickins , kernel@collabora.com, linux-mm@kvack.org Subject: Re: [RFC PATCH 1/7] shmem: Introduce non-blocking allocation of shmem pages Message-ID: <20250225134325.72a071b6@collabora.com> In-Reply-To: <20250218232552.3450939-2-adrian.larumbe@collabora.com> References: <20250218232552.3450939-1-adrian.larumbe@collabora.com> <20250218232552.3450939-2-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 397E4180009 X-Rspamd-Server: rspam12 X-Stat-Signature: geer76huhkd9e3i4os7ruighdfe9h8ez X-HE-Tag: 1740487416-110059 X-HE-Meta: U2FsdGVkX19PTlcyQI7O1cc49CC8nCJaDF/4+Ck001rast8pu17p8xQb74CHMBzHfmIVz0MySjMEQOMDlYKOHqyXmE4wYyzKXa/gxZexzrTgqmYyAenSVmRWqGUmG22Od7MIEWZ+WKyuwjHlLoSiOxjNElQsoG7+RkssnnK/UXpiRpSBDYF2Ej5RUCHHvBibU9cA7ltNDaN/Q3GKzBlyaFLFQLz4xS5uQq2+0Dbme3+kMIo4Bm/DbF8jdPxc1J8y9N8vC8BuKxvRqh2Ui8yA8Zsu2LL08GZXWd3oPjduIHQ2OcCuIXSuMk0mfzuVW8+tXOTi04hFkeSDfjErUvm43CrkqJYVbFGbg6GQuocrlK8i6nBDZxFoTdHuzX8TEErXIYTvf3v0OZT6XKviue5FsLEmLhMZZ/20C5f7xAMYI2OZE2HMhkupqRRgqwrdKs90//ouYSOspvXhghnSojYQWAdtPqXUcSY8tjot+U0+b516iuK0UwuAqEgU/ijxoOrHsOM2CxPMKUhZ5sP7eEgg1s6pAuxY0VJp3DytXeqN7znLimv7R/jf6Tv8NyjE3yFJOGIu6zEcL+zus8HF2LYBanAN9Vx9MsoAKeBtTFZa8GoK20OILmEmyFZUKWmPkftPxXQPef9s9oWGmZfK5uBUXDr8kIIQOgF+4tWtfwbOUhbJLk/q2zOnHQ/TFY2cm58vJVASDZzkaP9sXdBVbGOZlrG9qDbwsfTh/JNCsEjjPsuUuxj4YDpxvHNZ06UUQEuisRGVxOEN+/J1a312Ku0/OtarrFFEWPQyMbeJCFAZ96Wpx01q2dlCkSIIixPFLtgSZo3gRhFVNH2B2Xs6CKlV7Uj3pRO3+h1G+f+lMoS2eruNlJduQjzgJDZcUu6EdKq6zFfxhL1ejWijG4WQLy+CsPP8tguNQIyMUAg94r/o3mRI8vkMhC/b5FZ4yaGPhsHzb/Avdd8hZISYog3buuE M//yVcn0 9JPEj/cFBtyPQRhxE3jN6XqhQwWYIz1hoX7hp+gcyD3cdfovFae8Nq/mspAx/mt+rEjr0Fnb2RgE61r9Ag8TRf+sVGYHtCzvz6xuCKSkgRVfCPrtouzObZznPSzKIZNCdhXxStjreaHBsM2cSBfvfBMI0rMKlqkHpHfT44Hk0BpzKJpNjjCZDMy7uSVpIKTZVNfjPJCWYeqfFWdHQIOc86tUddLgydBYEOnXFvRZ0hMI2s9vtMxr7tZgo7skpSclmZj9JrI/DvbqKFuHt03CkzOOKH1bUBdquTs7HiPbiduHApYbP2ZedkxvX0j65o5a6v+BsRSotNms4TsaFtOGRpxbntWQrBgn5Fxhq4G+pA3KJtqFXdzJ9/r9LSAs2PBTzB6+WhIDy8+WHEjfL5SbuJmkyDarvhqkTM59NuXiDhuyTSrc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 18 Feb 2025 23:25:31 +0000 Adri=C3=A1n Larumbe wrote: > With the future goal of preventing deadlocks with the shrinker when recla= iming > GEM-allocated memory, a variant of shmem_read_mapping_page_gfp() that doe= s not > sleep when enough memory isn't available, therefore potentially triggerin= g the > shrinker on same driver, is introduced. >=20 > Signed-off-by: Adri=C3=A1n Larumbe > --- > include/linux/shmem_fs.h | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index 0b273a7b9f01..5735728aeda2 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -167,6 +167,13 @@ static inline struct page *shmem_read_mapping_page( > mapping_gfp_mask(mapping)); > } > =20 > +static inline struct page *shmem_read_mapping_page_nonblocking( > + struct address_space *mapping, pgoff_t index) > +{ > + return shmem_read_mapping_page_gfp(mapping, index, > + mapping_gfp_mask(mapping) | GFP_NOWAIT); > +} Just my 2 cents, but I'm not entirely sure it's worth adding a helper for the non-blocking case given we can pretty easily call shmem_read_mapping_page_gfp() with the GFP_NOWAIT addition where needed. > + > static inline bool shmem_file(struct file *file) > { > if (!IS_ENABLED(CONFIG_SHMEM))