Re: [PATCH] samples/damon: a typo in the kconfig - sameple

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park]

Hi bus710,

On Mon, 24 Feb 2025 10:07:09 -0800 bus710 <bus710@gmail.com> wrote:

> Signed-off-by: bus710 <bus710@gmail.com>

Reviewed-by: SeongJae Park <sj@kernel.org>

Thank you for this fix!

> ---
> Hi SeongJae Park, 
> 
> I found a trivial typo in the Kconfig file of the damon sample module
> while I was trying to do some experiments with sample codes.
> The word "sameple" should be "sample", I believe. Please find the diff below.

I think the above sentence is better to be added to the "Explanation Body"[1]
part of this patch.  This shouldn't be a blocker of this patch though, since it
is very simple.  Please consider doing so if you have a chance to send another
patch in future, though.

> 
> Since the title should follow the format of the project, I sent a new
> email to the mailing list. Sorry for the inconvenience.
> 
> Thanks for the interesting project! DAMON will be very useful for many
> projects.
> 
> Thanks,
> 
> Ps: I found I didn't change the subject! Sorry this is my very first
> communication with the project.

No worry, everyone makes mistakes, like I made the typo! ;)  Thank you for
finding and fixing mine!

[1] https://docs.kernel.org/process/submitting-patches.html#explanation-body


Thanks,
SJ

> 
> 
>  samples/damon/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
> index 63f6dcd71daa..564c49ed69a2 100644
> --- a/samples/damon/Kconfig
> +++ b/samples/damon/Kconfig
> @@ -3,7 +3,7 @@
>  menu "DAMON Samples"
>  
>  config SAMPLE_DAMON_WSSE
> -	bool "DAMON sameple module for working set size estimation"
> +	bool "DAMON sample module for working set size estimation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for working set size estimation.
> @@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
>  	  If unsure, say N.
>  
>  config SAMPLE_DAMON_PRCL
> -	bool "DAMON sameple module for access-aware proactive reclamation"
> +	bool "DAMON sample module for access-aware proactive reclamation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for access-aware proactive
> -- 
> 2.47.2

[PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park]

From: bus710 <bus710@gmail.com>

There is a typo in the Kconfig file of the damon sample module.
Correct it: s/sample/sample/

Signed-off-by: bus710 <bus710@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
---

Chagens from v1
(https://patch.msgid.link/20250224180709.2167187-1-bus710@gmail.com)
- Wordsmith the message

 samples/damon/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
index 63f6dcd71daa..564c49ed69a2 100644
--- a/samples/damon/Kconfig
+++ b/samples/damon/Kconfig
@@ -3,7 +3,7 @@
 menu "DAMON Samples"
 
 config SAMPLE_DAMON_WSSE
-	bool "DAMON sameple module for working set size estimation"
+	bool "DAMON sample module for working set size estimation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
 	  If unsure, say N.
 
 config SAMPLE_DAMON_PRCL
-	bool "DAMON sameple module for access-aware proactive reclamation"
+	bool "DAMON sample module for access-aware proactive reclamation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for access-aware proactive

base-commit: 489e7430013060843b4f7f1ad3935ff58fbd5bfb
-- 
2.39.5

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park]

On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:

[...]
> Chagens from v1
> (https://patch.msgid.link/20250224180709.2167187-1-bus710@gmail.com)
> - Wordsmith the message

So this is v2, but I mistakenly forgot updating the subject.  Sorry for the
noise.


Thanks,
SJ

[...]

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[Andrew Morton]

On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:

> From: bus710 <bus710@gmail.com>

Full names are preferred, please.  Actually I think it's "required".

I'll apply it anyway due to the patch's minor nature, thanks.

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park]

On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:
> 
> > From: bus710 <bus710@gmail.com>
> 
> Full names are preferred, please.  Actually I think it's "required".

Thank you for letting me clearly know this.  I'll request full names to DAMON
patch authors from next time.

bus710, we could still update the patch before it is merged into the mainline.
If you could, please let us know your full name and if we can update the patch
with that.

> 
> I'll apply it anyway due to the patch's minor nature, thanks.

I agree this is a simple enough patch that the name doesn't really matter.
Thank you Andrew :)


Thanks,
SJ

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[bus710]

On Wed, Feb 26, 2025 at 2:56 PM SeongJae Park <sj@kernel.org> wrote:
>
> On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:
> >
> > > From: bus710 <bus710@gmail.com>
> >
> > Full names are preferred, please.  Actually I think it's "required".
>
> Thank you for letting me clearly know this.  I'll request full names to DAMON
> patch authors from next time.
>
> bus710, we could still update the patch before it is merged into the mainline.
> If you could, please let us know your full name and if we can update the patch
> with that.
>
> >
> > I'll apply it anyway due to the patch's minor nature, thanks.
>
> I agree this is a simple enough patch that the name doesn't really matter.
> Thank you Andrew :)
>
>
> Thanks,
> SJ

Oh, yes. I was a little worried if I added too much noise for such a
small work, but I shouldn't miss this opportunity to leave my name in
Linux history.
Let me prepare a new patch as soon as possible.

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[bus710]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On Wed, Feb 26, 2025 at 3:07 PM bus710 <bus710@gmail.com> wrote:
>
> On Wed, Feb 26, 2025 at 2:56 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:
> > >
> > > > From: bus710 <bus710@gmail.com>
> > >
> > > Full names are preferred, please.  Actually I think it's "required".
> >
> > Thank you for letting me clearly know this.  I'll request full names to DAMON
> > patch authors from next time.
> >
> > bus710, we could still update the patch before it is merged into the mainline.
> > If you could, please let us know your full name and if we can update the patch
> > with that.
> >
> > >
> > > I'll apply it anyway due to the patch's minor nature, thanks.
> >
> > I agree this is a simple enough patch that the name doesn't really matter.
> > Thank you Andrew :)
> >
> >
> > Thanks,
> > SJ
>
> Oh, yes. I was a little worried if I added too much noise for such a
> small work, but I shouldn't miss this opportunity to leave my name in
> Linux history.
> Let me prepare a new patch as soon as possible.

Hi all,

Please find the attached patch.
Based on the latest one, from @Andrew Morton I just replaced my ID
with my real name as well as updated the subject.

Thank you,
Seongjun Kim

[-- Attachment #2: 0002-samples-damon-a-typo-in-the-kconfig-sameple.patch --]
[-- Type: text/x-patch, Size: 1390 bytes --]

From: Seongjun Kim <bus710@gmail.com>
Subject: [PATCH v2] samples/damon: a typo in the kconfig - sameple
Date: Wed, 26 Feb 2025 10:42:04 -0800

There is a typo in the Kconfig file of the damon sample module.  Correct
it: s/sameple/sample/

Link: https://lkml.kernel.org/r/20250226184204.29370-1-sj@kernel.org
Signed-off-by: Seongjun Kim <bus710@gmail.com>
Signed-off-by: SeongJae Park <sj@kernel.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 samples/damon/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/samples/damon/Kconfig~samples-damon-a-typo-in-the-kconfig-sameple
+++ a/samples/damon/Kconfig
@@ -3,7 +3,7 @@
 menu "DAMON Samples"

 config SAMPLE_DAMON_WSSE
-       bool "DAMON sameple module for working set size estimation"
+       bool "DAMON sample module for working set size estimation"
        depends on DAMON && DAMON_VADDR
        help
          This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
          If unsure, say N.

 config SAMPLE_DAMON_PRCL
-       bool "DAMON sameple module for access-aware proactive reclamation"
+       bool "DAMON sample module for access-aware proactive reclamation"
        depends on DAMON && DAMON_VADDR
        help
          This builds DAMON sample module for access-aware proactive
_

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[bus710]

I was wondering how others live with the git send-email all the time,
so I searched for alternatives.
Then I found out that some people use terminal email clients like
Mutt, and learned that the inline patch is the right way, not
attached.
Let me do the inline patch if there are more chances in the future.

On Wed, Feb 26, 2025 at 11:03 PM bus710 <bus710@gmail.com> wrote:
>
> On Wed, Feb 26, 2025 at 3:07 PM bus710 <bus710@gmail.com> wrote:
> >
> > On Wed, Feb 26, 2025 at 2:56 PM SeongJae Park <sj@kernel.org> wrote:
> > >
> > > On Wed, 26 Feb 2025 13:37:03 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > > On Wed, 26 Feb 2025 10:42:04 -0800 SeongJae Park <sj@kernel.org> wrote:
> > > >
> > > > > From: bus710 <bus710@gmail.com>
> > > >
> > > > Full names are preferred, please.  Actually I think it's "required".
> > >
> > > Thank you for letting me clearly know this.  I'll request full names to DAMON
> > > patch authors from next time.
> > >
> > > bus710, we could still update the patch before it is merged into the mainline.
> > > If you could, please let us know your full name and if we can update the patch
> > > with that.
> > >
> > > >
> > > > I'll apply it anyway due to the patch's minor nature, thanks.
> > >
> > > I agree this is a simple enough patch that the name doesn't really matter.
> > > Thank you Andrew :)
> > >
> > >
> > > Thanks,
> > > SJ
> >
> > Oh, yes. I was a little worried if I added too much noise for such a
> > small work, but I shouldn't miss this opportunity to leave my name in
> > Linux history.
> > Let me prepare a new patch as soon as possible.
>
> Hi all,
>
> Please find the attached patch.
> Based on the latest one, from @Andrew Morton I just replaced my ID
> with my real name as well as updated the subject.
>
> Thank you,
> Seongjun Kim

Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park]

On Thu, 27 Feb 2025 07:35:00 -0800 bus710 <bus710@gmail.com> wrote:

> I was wondering how others live with the git send-email all the time,
> so I searched for alternatives.
> Then I found out that some people use terminal email clients like
> Mutt,

Yes, dealing with mails is not easy for beginners.  I therefore introduced you
hkml before:
https://lore.kernel.org/20250225000925.1654-1-sj@kernel.org

If Mutt setup doesn't go well, and you haven't tried hkml yet, you could give
hkml a try, too.

> and learned that the inline patch is the right way, not
> attached.
> Let me do the inline patch if there are more chances in the future.

Yes, that should be the right approach.


Thanks,
SJ

[...]