From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2163CC021BC for ; Mon, 24 Feb 2025 15:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3CFD6B0083; Mon, 24 Feb 2025 10:56:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EC676B0088; Mon, 24 Feb 2025 10:56:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DBB16B0089; Mon, 24 Feb 2025 10:56:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2E9D56B0083 for ; Mon, 24 Feb 2025 10:56:38 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77FDF1618C1 for ; Mon, 24 Feb 2025 15:56:37 +0000 (UTC) X-FDA: 83155290834.02.55C191E Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf20.hostedemail.com (Postfix) with ESMTP id 57D1F1C0024 for ; Mon, 24 Feb 2025 15:56:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740412595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58Le5ghcfckQ5XK2vaCHFZ42XSmtFL2ziGhoVc1NvJs=; b=0kq6gjIkYidNkWOkQC7XPOj3RFupLNNssHuTssTp3wRdIa2ymKjOvkC/nulbuTjGVjugPL JHsR44GHgOBncqwzjMmlyHiePUoohZJX0dbFFmYgHMkoXFeOXWfTItzms0Xj6JJEqCObq2 0a8Xe11FJXNbDRmx9FxDOoNZgR90yIw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740412595; a=rsa-sha256; cv=none; b=5CYbxOtmMlSWGef7I9bE5zZeVC3PM4G9/ewSczIuFFSv+Vk4XJ3dd50J2jKcid9eiylGOw hyBj2ql/SaRYlPEdj2dsaHBK0lg1Gu9mQrQF4In+Vl+FPIObdWbAE/8AqJsi4ucV0ENsxf HYmsAA6ImC4ZW8272hbd3gmPi3gW8jM= Received: by verein.lst.de (Postfix, from userid 2407) id 9C80668BFE; Mon, 24 Feb 2025 16:56:28 +0100 (CET) Date: Mon, 24 Feb 2025 16:56:28 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: "Raphael S. Carvalho" , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT Message-ID: <20250224155628.GA4617@lst.de> References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Stat-Signature: kkcsnunz1idizhtqh5mxd6agieiabhgo X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 57D1F1C0024 X-HE-Tag: 1740412595-528679 X-HE-Meta: U2FsdGVkX1+tTr5j00MXkHFA14FTzd4avw7Mg2Gs1gqNrywAsZO6RGt7+HJpxCEJXlVwc4iPy1SIp6XtEo1DIqX2oXrQLFgCAgEcR3fONJtJ+cFb8Ol0AynBHznNxZoDUc24ULIwNrUrlWlR3fD+dG4u360+xlx2pyCwsRYK7MY5v3SXy+vx+1KKAGoz1B8KPeHGB+iSJFsSgRLqFLrlXQHBylwZPyo9Frliiet4gErNJy+dUw12eUrhCXl3VlmSvhYzPx3oZ33uigntsavFreytBryEZZ01llhw02TOcJAl/57Ae11sWJewCtCOhY6rxZtypVKuSbDLNlapVro2JIxFglRGhq43+wzb7SenJx93vJIWkNa4xFiOSfAVjKMsESf9LOzt0v92YczuFF3rkFf/7moU+c7aE4xNyrgGNVuhPZNRpLsxnFXeFMH3UKo51YSoiRtCKt6i3N8MR3qXSPQC30w0iCZow3NWZeepowjgF7utKUBBvV5rYPcZ9T7WK2nju3fWVS4lX0kpy443mNCtIa3uQqfbfZfHUG75acPtt3GxATZT5A580HKBN00tPNUFip4RBrEhrNYkirRTzz5j3xwoRyxitRo8rEI9fSx+S8e7O/xoQGrSr6ax06Y3sYFCtICk/+rtgO9Rei6D4igyqma2SLguilyNxit461TQnyCOzhar2g11CSqRvy/XQuGPIujEKoxo1CET1LQ9aoIOlmibLW7k/IOdrl+4AUPt0d8GRzPXEmJthmuG30BuH7HKUh9tMkeD5gbbiuzQ3pP3WAu9hDI9ofw/4dmykXhkm7tkimCkxhW96rE3rvdPfos6LzbSXDzVswGFAIoMPihPcR3pxVJIUhWYhSZP9+EgfndbJh0zNnQYP9BFPhkXGQn1VF+1XKTwFcp67Zr09ry8VWg0BPUqfU+py+btyz7EwpJmJZ1icICkR0jKCSAt5034/4BrcP3j4Kw4U3m KOxpkjft XJUcj0Nnsh9EIRFOeaIYgUyhcSGi3vHoYEFwcEiQDp9nfqYNCCLLbUatg7JV0K4X9mAWqLH2SqaM59RAsZCiEo7CZpi3QZxN11ggknI4f4eT8TyfXkKBD+YakxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 03:51:58PM +0000, Matthew Wilcox wrote: > On Mon, Feb 24, 2025 at 12:50:48PM -0300, Raphael S. Carvalho wrote: > > Ok, so I will proceed with v4 now, removing the comment. > > No. Give Christoph 24 hours to respond. I strongly disagree about not having a comment, because while Matthew might remember the issue in his head others don't. But in the end he is the maintainer for the relevant code, so his opinion counts.