From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Raphael S. Carvalho" <raphaelsc@scylladb.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
djwong@kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT
Date: Mon, 24 Feb 2025 16:56:28 +0100 [thread overview]
Message-ID: <20250224155628.GA4617@lst.de> (raw)
In-Reply-To: <Z7yVnlkJx23JbBmG@casper.infradead.org>
On Mon, Feb 24, 2025 at 03:51:58PM +0000, Matthew Wilcox wrote:
> On Mon, Feb 24, 2025 at 12:50:48PM -0300, Raphael S. Carvalho wrote:
> > Ok, so I will proceed with v4 now, removing the comment.
>
> No. Give Christoph 24 hours to respond.
I strongly disagree about not having a comment, because while Matthew
might remember the issue in his head others don't. But in the end he
is the maintainer for the relevant code, so his opinion counts.
next prev parent reply other threads:[~2025-02-24 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 8:13 Raphael S. Carvalho
2025-02-24 14:17 ` Christoph Hellwig
2025-02-24 15:33 ` Matthew Wilcox
2025-02-24 15:45 ` Raphael S. Carvalho
2025-02-24 15:49 ` Matthew Wilcox
2025-02-24 15:50 ` Raphael S. Carvalho
2025-02-24 15:51 ` Matthew Wilcox
2025-02-24 15:52 ` Raphael S. Carvalho
2025-02-24 15:56 ` Christoph Hellwig [this message]
2025-02-24 16:02 ` Christoph Hellwig
2025-02-24 16:15 ` Raphael S. Carvalho
2025-02-25 16:04 ` Raphael S. Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224155628.GA4617@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=raphaelsc@scylladb.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox