From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE746C021A4 for ; Mon, 24 Feb 2025 13:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47F186B007B; Mon, 24 Feb 2025 08:24:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 407D66B0083; Mon, 24 Feb 2025 08:24:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A9216B0085; Mon, 24 Feb 2025 08:24:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D9BA6B007B for ; Mon, 24 Feb 2025 08:24:13 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 62DA3814AD for ; Mon, 24 Feb 2025 13:24:12 +0000 (UTC) X-FDA: 83154906744.01.649C8C4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id CD48140019 for ; Mon, 24 Feb 2025 13:24:08 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="iS/A260A"; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740403450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OwmwOu+Cjzvd/Dyh2oCLg1P9uzBvkTbz8Qibak6RkKs=; b=Gyf8wcfn0vDDiYfzd+6Hfh8RJDgW/uaRuwpoTmbtzO+IKdhiwM04/va2dahyYDQPtzXnoV 7aSiIthEDJZLfv4vtfnzHdlG4tF/ns81hlqY7PNSsd3l7wixfPq5+OjSP53b+7VrWbFjuD FgS0/hd6kXfNLh/+h2fH0EU11saL3Uk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="iS/A260A"; spf=none (imf17.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740403450; a=rsa-sha256; cv=none; b=2zFVHS90uCDh6T/z6Zqt4cS9bulcF1Xd6Z0hJ//J8KwTGzec96dStCQOSI9HAmadmAAZo4 lKS6H476qFe+QowfRLaU38Ud0KXR4QgldS+moxDMwoe/aIN4lrzBiOdJ4KIS+VwxGij6oN qmptqdP3j1eUccFoipXmHis9A2aZUKI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OwmwOu+Cjzvd/Dyh2oCLg1P9uzBvkTbz8Qibak6RkKs=; b=iS/A260A40VI6SQ9dsr0Pe2Ec0 +4I/Bpalp0CX65hp2mHNsbxfdLQ3ZQMp/MO3XTCmulOZ1LdYifv6XmmjBsEkUzc7/Ofye9OegILGU jhMbWZFAabjv9F1E7Tdsq+St//fzgpJbTghlaQ08rLhkZfj4YHNl3RsAgWE0X2VcL1qmU/ZGIqy9s q3djqUzHMEgyRNxqJ4zMlGJrlo+rBDv3+zWiBCnZolwsUOv1flDL0UYKwJjrhfaGLVZBSL82vN7Ui z/ItUQgAbHGrhpvvZGv/LP7zX+kb01JmoNnF7MGJbWqiG9NuEPEKF3SG3il1lVkgYfzh0ukPwqkvp tlhJKBVg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tmYR9-00000007Gtp-2twK; Mon, 24 Feb 2025 13:23:55 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id B2A18300164; Mon, 24 Feb 2025 14:23:54 +0100 (CET) Date: Mon, 24 Feb 2025 14:23:54 +0100 From: Peter Zijlstra To: Zijun Hu Cc: Zijun Hu , Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() Message-ID: <20250224132354.GC11590@noisy.programming.kicks-ass.net> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> <20250221200137.GH7373@noisy.programming.kicks-ass.net> <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD48140019 X-Stat-Signature: wnwzu47sogdk591dbayn3htprd95sy36 X-Rspam-User: X-HE-Tag: 1740403448-444612 X-HE-Meta: U2FsdGVkX1+aa8rA8BH5UE7CBZE1OisYpudJerXDx6788v0o41wuuoioVVysEvrw9LWAtGE1lP/AU4nSnsrduVK0t8jH/H56RKS2yzCiXFoJcS98kqBNxKIYah//u4VO5gqZxwDfmtYKRTNvEQkh8fCuTwnTUkMm9AnRY5kTEVmRYPy7QJCVCmucc72dRV4H3buVzZpbhhoDh/aQ0AiVcmZml0ge0GL2lTd5WDavEUJ1Z8I4okYKU2/zzKAezZRjBlutZqF/yCTU3HwnR7ObzEwxVRjpLgEZ7RYzDv/uDOIPQamYsqTVLSHdpONEEExkWARDXCx40gigBcTl4a6gzkKrh1AmOySoYsEzvKlmWQlwDREgWQGmiXT60QNAfIlyQdZD84ktGwngc61vSppTBXNgJVNsaGoaM28SXIXfgmxENsSaL3iP3xKWQbgnXjAGi0aG6VyIyFS09N7+0UI0qRhs0xZQtNHihbCGKaGHvYxFilRZLCF5TifdW6h11FbuJfOn2x9pD00OSOA+Iob+cCcPNCwFwN4cbSF2FfAWoYTYNMoH2wbzXfVNGp+vSywbEK4OZQ6Xt7zOR4KYpefn+8nrLUWK+Wy+DQhwgAgDn8ZnVofOVX05WqQPebxFJxM7IbriVIe06FZLRI5a9dUNkZid0JNJ1MJsbE6NomyIzme8kmUFgR2eTSMtpb+78DATA6FoUx8Zchz4FU0/Q3k3mUHmALZm69DEhOJBFOfxMj8ylAlT5dRHfBAwveIx1w3gTXrXbOwvl+I36dnID7LiMfPbQqGZ5R4S/z7L0LJzkPovYxtkfVt3nJ/k4oP7xPwMqXkIxafxjgzzwTh63SjWP/DaXNEIm82DMs++Oye4qhFdHzSUoITmYaeHuSKvFHK41c1KmuaT9N/M8xCMg1FQ2z2q69JuYyyPSrj9C4tZYawtUTrscdYoL7xZHA979bY6vFTRiIkBYV+ev3aCV1F yY/4Ma/M ptBLmcBW7J5lby0njIuZ8L6pvC7kz9BewVG2Odv1nkeEXTSa6r/e/MirdrpLBWLZYpRS//EVHl66KGRIW4IAnB+C/2XB670N+anGJ/OBWOz8+HsDkcHuBhhwgBg8Q8tD7zYebgQw/FtDTYSEElZRXWFc+spdbov2s24T4kxITRkdIXgWutMvJQ8jbeM0y7OTAunBBzh3WtprHRaOlSJta6iNA557fGIq2YK/1uMw2S2uB56A2CtsWPi5HFpCB8NO0UHJfNlCPRCL/0f2KlNJqfQFaUC+32piifmtsQnAeSPd4Li5DuL8m+GFqNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 07:00:28PM +0800, Zijun Hu wrote: > On 2025/2/22 04:01, Peter Zijlstra wrote: > >> */ > >> static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) > >> { > >> - return tlb_remove_page_size(tlb, page, PAGE_SIZE); > >> + tlb_remove_page_size(tlb, page, PAGE_SIZE); > >> } > > So I don't mind removing it, but note that that return enforces > > tlb_remove_page_size() has void return type. > > > > tlb_remove_page_size() is void function already. (^^) Yes, but if you were to change that, the above return would complain. > > It might not be your preferred coding style, but it is not completely > > pointless. > > based on below C spec such as C17 description. i guess language C does > not like this usage "return void function in void function"; This is GNU extension IIRC. Note kernel uses GNU11, not C11