From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C590C021A4 for ; Mon, 24 Feb 2025 12:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B0976B0085; Mon, 24 Feb 2025 07:46:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 961586B0088; Mon, 24 Feb 2025 07:46:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 828466B0089; Mon, 24 Feb 2025 07:46:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6585D6B0085 for ; Mon, 24 Feb 2025 07:46:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11B14C1327 for ; Mon, 24 Feb 2025 12:46:47 +0000 (UTC) X-FDA: 83154812454.07.823C0DD Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf16.hostedemail.com (Postfix) with ESMTP id 9B3CA180012 for ; Mon, 24 Feb 2025 12:46:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Tftfdh5x; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740401204; a=rsa-sha256; cv=none; b=dvRDT32BMgSngk2IQK/msKdEpx0cKDbB5pejNKJsXZNNuswO5LTMrnuaYuda9FDD+JF6Vr iH9pIGE6vttL1Js9IAb9GVLPxfjN32VC93Fzgj/YGTuh8NvJNzGB21ejacEWiFY+n0Zsyf 1tBmLYRymx/E+5nhzWh4LT45PppOoHc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Tftfdh5x; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740401204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4zJ7NGL8jaiq+rMES5kwpX3x3oY70MnfLBpgKugJOs=; b=epS3F6PKBqNdkf1w2ugJasYar+TqHBa8gmjatobLuLnQAEJZL60u/D8R71G6D8Ne6oF6x5 xhyCdEAo+7TrmUrJ7MKArPcwaxbCAULbxVl9lJmUAhCN7BHh50NVdmoE85Pi06hM4fa5+P mV/w3Q/4N4oBsd3nQoVMDbuIc0Y/QIc= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id D4C2140E015F; Mon, 24 Feb 2025 12:46:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zIGJtjT7ztu8; Mon, 24 Feb 2025 12:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740401195; bh=r4zJ7NGL8jaiq+rMES5kwpX3x3oY70MnfLBpgKugJOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tftfdh5xa8q24B8D7TqVCt5+HY4WFIG5+EFq2AcQmrkMf1YTEPpXCgxqYEneQBBV+ Yy9321QMWpjx0jcPxuUw5s5Xm5B3ndWMkTnAo1RH0+Wk9v99j7seJODYaRlja9s0f8 Op+C9liFejQ4RgHF6J88n/AZfWAkX24yOzE+DRtIztm6DspT1DJ2OhycUZ0JcR322v xhuetgS++S0I13RUmyhMplVZlxe10Iz0KwFONZ0q1Fg2MTJgqDf8XhuPykkeMlHlbF P1STo99C8DXzhWLseJCfIYBBnKmP5u/p46+94kqqiJWdpsViWwPAk/f6KfCrVGmsaE Ew8hAcBbmmI0eurIq7bViT00ynP/oaU2YrTFAWnCAnrobCkVmlRdkcG4NwyCichr/2 vbU0cofcY5PgR/M8cTfHAzZ+tunWlUuVT1eJab7FW2v7UbOdKqG7AJv/ZFcXNppfmq p/YvTjxLfxIlESNnTvpUkiYdbW+Wfg+odltsFDdblx6V5QvpbdfWc71iS5G5Xkj1lJ M5U7Cafn//jELR0G8V+CpVgC5+5binv/GhVsJ27eebFc8pAxvr5Q//DWB6pB1E/UZv k+1SBKEYHH+VvLi0MUMWo2eZ/EQYf5RqdLySJBmmWxopcWJFLJGZJncPft0GsAolr6 dyZgYz6Vq+Sy2/k8Rd20/M1I= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8F56140E01A3; Mon, 24 Feb 2025 12:46:18 +0000 (UTC) Date: Mon, 24 Feb 2025 13:46:12 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v13 05/14] x86/mm: use INVLPGB in flush_tlb_all Message-ID: <20250224124612.GGZ7xqFMYXmoRXqKdP@fat_crate.local> References: <20250223194943.3518952-1-riel@surriel.com> <20250223194943.3518952-6-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250223194943.3518952-6-riel@surriel.com> X-Rspam-User: X-Rspamd-Queue-Id: 9B3CA180012 X-Rspamd-Server: rspam12 X-Stat-Signature: 67ezte8wqx7s4eky94rky71sgxijwhfk X-HE-Tag: 1740401203-813628 X-HE-Meta: U2FsdGVkX196bEeQFe4/PPrh0xkkMdvOI21BNQL29F2/PXEGYU1zCEAIwaD8XXqQhs7QIiM86tQSEzPbsHUJASHdrgVF4OPWFV2gIMknTa2egglpICqsiXGJXjM896QS3/EwXQwJ6q2lTMldW6pGnWKSrFdiivZJTt3geFGU+j+/Yo8EqvBWBLh//KudKr3Sk7C74If/xfjwa0PrOBLM02KFFSmHzJCdYNOMEnA2yPv+nD+1YhtGBfhYJOBDcYpfPu4TBtDcaedPzdf6D1rfTPfsE1Ol4a+3gaFP9H/KYY3Ei88fQoBs146+c2/b2l/F+gjSkztmHBQWugO2m0RtNymQDpBwvv1F49wVwrBvqKML8RMp9Fd1FXQEG+D+gByWThMCxVf1TBzmipGQmVhq61AtL6idFRpr1rVmCjVqMlq5Ae8X8Py95ojBz5i7YhqH3HSoah0tEfRdq8dOJ9aVvh04d7SmHXhZL2wLMcs05JROe3eo6WS9UTEW0gHud4V98dmB3zaDdgQ1SznAXnHtUlFBewamoz+7AcOKAUU2P1DDd1L2OF2etndYsIuR1clorBLAKcG57p6hEBeDQPVCPA2kGkWZ0CbwayCErl/dWHXmbo67JCp3/WFweDMJ03faSrJxKg1RwbWNg8+FNCQOP6SHdF7ABNfy06vXMRF9RVsuBDFUHP2+l8AjTaf6eQ5FyJ/wW+sRBIpH8SUJgseilZnkv7DYRVPnXEbd76jyOdicP3qAJusTspP9h850YjqzZ6Deke/q0eqK82SdTRQThMFEo9al/jKn7AFaUprZslaXJQkKjBJkT9M9vYEsNZINrbK7P9s5hnoCPe6zv78+KZ5vG/m4BHKqgLt7DJ0vG4sG+3R78GnkGoO4jE/4ymz1mUcMOPjYrMS730N1Pe9fd7wWDiKffBra+q1ew48kpVMSrc5cECdnQEBrnyxkdpdc0Z+7S8WrQ6byprjvoOl Ws9gN8lQ EUkrQqyGk2zFUpgOrnF2VGxpyJZKb2EP6m6xDCEzHPLNYkO9dtvU7ZbXoUgzCt5+B/UO1SCK/ls4HyxQ7vMOjINbT6kSz1HMhMp1r8qcvP6ukHyLfkdZFi03KJYn7HEWU/DsvtAqUJIVxNJrhZZOyD/lnLRyUxP7wirF3gxIFX3XmkZtPnEPz1hLXtvzWN7zO9Okq4Sl3g4xkTE47blr1efoZK3/zRLuQdS/CwgFK8BwZZjz34CsCWFoWxwPWGiUPQ4vSvP1ff7lqMHaZjz6e9EllB4JGvHzM7Cr6J95te4Nd5r4Qp5aH3BZ04nvXQPYkhBvU1xR2/+SUsvGyOYLop132h0OgQ+fCEWQ3lAhBf8tjziiOFV2NmT3j65m3mVVgrOt/Q8Vdlp6bvbHLCrvXNha0g5GfnRxO07tLF6JyEzPXPhzXawtoP3oW6eC2bEAT9olH5SPXZotUu5TANCQUnGZHVkzk+pQhPTqXFYw7zmWlk/7Xw0MWY3JKnORkrvcQDvR+vQeHrD3zVcA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 23, 2025 at 02:48:55PM -0500, Rik van Riel wrote: > The flush_tlb_all() function is not used a whole lot, but we might > as well use broadcast TLB flushing there, too. > > Signed-off-by: Rik van Riel > Tested-by: Manali Shukla > Tested-by: Brendan Jackman > Tested-by: Michael Kelley > --- > arch/x86/mm/tlb.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 59396a3c6e9c..2d7ed0fda61f 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1065,6 +1065,16 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, > } > > > +static bool broadcast_flush_tlb_all(void) broadcast? All those INVLPGB functions have a "invlpgb_" prefix... In any case, get rid of that function: diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 2d7ed0fda61f..feaca53b7685 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1065,16 +1065,6 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, } -static bool broadcast_flush_tlb_all(void) -{ - if (!cpu_feature_enabled(X86_FEATURE_INVLPGB)) - return false; - - guard(preempt)(); - invlpgb_flush_all(); - return true; -} - static void do_flush_tlb_all(void *info) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH_RECEIVED); @@ -1085,9 +1075,11 @@ void flush_tlb_all(void) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); - /* First try (faster) hardware-assisted TLB invalidation. */ - if (broadcast_flush_tlb_all()) + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { + guard(preempt)(); + invlpgb_flush_all(); return; + } /* Fall back to the IPI-based invalidation. */ on_each_cpu(do_flush_tlb_all, NULL, 1); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette