From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D24C021A4 for ; Mon, 24 Feb 2025 12:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97E8E6B007B; Mon, 24 Feb 2025 07:32:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92E876B0083; Mon, 24 Feb 2025 07:32:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F6096B0085; Mon, 24 Feb 2025 07:32:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6155E6B007B for ; Mon, 24 Feb 2025 07:32:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 096B1505EF for ; Mon, 24 Feb 2025 12:32:15 +0000 (UTC) X-FDA: 83154775830.04.21D3A5C Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf25.hostedemail.com (Postfix) with ESMTP id E97A4A001D for ; Mon, 24 Feb 2025 12:32:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="TM/q4xlc"; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740400333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TcyDkc7c9gBCOEI6pzKjHHoYgUk+1szSgx0RLJQP/Fg=; b=66DvQ2GSktAZb7ig8WmiFpskou91UbmIQV7K5wwp0ELHB6h2U7YWPa2SoRl9+bhI1i//Zk iaFpKKv0n+zjDQHFhFfCDoeSwMxG41+d3FUnsB5bpih6ILsuU8tR90Y+ppfoD2PThbZxW6 4PKgpjXnGTomhetcqoonOpmm7Qur2z4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="TM/q4xlc"; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740400333; a=rsa-sha256; cv=none; b=LwE4u4zcvy6uyeUUWt67hDBwcA0soBsgn1Qxvxkt4pIcl7KvzzToKnaoblFhwW+ad39HJf pldRJ3kJsGu27+KXavebqHU4hcSD6WRICYw8O+Z28HVWB52w4n77kGNjLnN03bm1RXdrxM Ao5gfxmOGo53PRUhG6EZNtTs043+MP4= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AFE4D40E01A3; Mon, 24 Feb 2025 12:32:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OSeDC-B-B6hg; Mon, 24 Feb 2025 12:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740400324; bh=TcyDkc7c9gBCOEI6pzKjHHoYgUk+1szSgx0RLJQP/Fg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TM/q4xlc0EfzK0QLoUM4hiK4V+KfXJ3roILDlo4AJNPTNjLTOkdfZ9nHvTzd7+oSe Wswe8DXNbIS9Op9V/Dna6FL2RDvbz/7u2FaY1Sg5Zma76vWDLZ4kG/lCxgkyOWkZLa i+SgtNKbHSwgaIjZEdtpeBjw7TfEyYza6aCb+EsEsrcSyo3Fk84QmiQQ+fM+cjyIsq ExpUyJ3MCGWHAoLG9DrsolJeet47nhtKMNwpNI/BAD/y1CCy7nyDwBkubK18jKL3oi yMBS4NSbQTf3PsS+7MJiyDuxocvlg8QA0GdGNtT95sR5Fm48bLTIa3cwKuvE2Y3Bc7 AwuKUct8TkX9uixa32NZlZI0TherwrVIXeqrzOi/7G6j/B+H9VrXyUC3GeIk9yq1R9 Y7EYjkjYKKaixz/MEJ3A62MpDg7VPFXQBy2RmIl1ESHHWS8ZC7/26W/O0hOuGOZFtv zZbWcFSmo2YXmJEzj8pp67JZfjSgb4b9v/+5o+rxO/5lmY1rl+ky+6u3HUwA62qCl4 S2/v7Gnioh9v0MC9ufAjPCLZLH9whYw1DvBe1lqf8i6jSjQRIEiJXmHrHLHo9p4JzK XGKfor+r+pxdwAwKo3l4DtcY72HY0N9KIjQEvH5fBWnWkAqaREu27gJdk7hOPLapvO DXM/mTwGEmUtLrYjB3idGtqU= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 635FF40E015F; Mon, 24 Feb 2025 12:31:47 +0000 (UTC) Date: Mon, 24 Feb 2025 13:31:42 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org Subject: Re: [PATCH v13 04/14] x86/mm: use INVLPGB for kernel TLB flushes Message-ID: <20250224123142.GFZ7xmruuyrc2Wy0r7@fat_crate.local> References: <20250223194943.3518952-1-riel@surriel.com> <20250223194943.3518952-5-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250223194943.3518952-5-riel@surriel.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E97A4A001D X-Stat-Signature: u8q6gxp6fs7rdr8d51c8b1w1hyip49w5 X-HE-Tag: 1740400332-304014 X-HE-Meta: U2FsdGVkX19PX+2ptBbS+LgTdiILrw1I8R+LeSbzPwh3wzsFu5NirquFxdrzMeNFNIJJwPrO++4L00t2J/Ki5bOVXxavOAoW5Lt97DXP8D+to3iozJZxYFfYakbTm4INlXqVJ1hv/6+CRRC49OOKWq5QJMSSMvKhPZGgUHgHVm21TuX66xKqfdiaYLa1L4F80iZPEXwSddTTanKBe9HVUdy6+KYr9xvbWfKqmMY7nAHeZtrQFzGZO27Tj2L9LO5lbeZqgzF2w+Vx4ucw44QARKAVUEAoBvNwN61iRTwlb9U1j27LH4jTdpKOmZdR1VgKzXEIRldmbGQRvfVaox0jgU7rU6HcJ4arRv7dNf7p7YI61A+RU/TG1xld4ZP//XPQ530yBc8VLv0nl70gwS5vecXRZ2YZeioC8Wtik0tNtjv7sXb5zWoeG0lJERJ/CPCqOz9B0s8R9dRMg9+IwQy4RfNEFGkoGUuJK2gg0P6SiwXSb0r0pqQkpoPv7qBW5SwlQTFiuUlMrowVmYmRKMLdIlhcUioeEBVF8DubwS5ebWBQ9zKRKrXZMIy9k8XeADwnQKDJQByF+r+BPDhH6zsZN0SRGo7lPXqzFfGfbSJyEnGhVJLW1tc9CkpvHBcfrmdbT6kyEphg2X8Pyy7gjeT5ByYidTRb7944XG95uQdvsYmAfs5mZlxSwjKm/rrP9EeJOcVzJnbaUsZERaM/YoV5qaZezRM1AJV/vWly9kxJRsgvwND6Vveb3vUAT35AhJwu+PmYfkwfDUhlDwAVe/GZhpyMGTDbxpPv6ZE29feOVsAWw+RRW1ynO1x2qsiyP8o/8Z5KZtOqgEPHnYiAKAp3XqCHG6uo0Kh/0qIh4BO5iXWCM3ByXNVBPO9dXO4MaDU6bO7oM34gTnP4ndJKLmvsvK47HeMcshIMkFfqqvARbtYZWjndbOCeKe3kiFdIxaA4OG2wv/WlnI0VZ8GqhGN eq373loO aAtazfKbNR3AmTk+D8aH0lFx0lt4fbgPZOROTAU8u16AQ/i/y0TJo9gILdU4zMhdB8ydU/mflaIriSLc4j8vb5SdcGlu7+se1EYtVg1fjFMEeVXwYiUxWAMYO8lKX+Puqxhnpkh+MEKvzFtk+vw8kgZuORP5N3bL2GOOw18fcVGHzBMLd/ht0MfB2I1Ibenl+rQmMM6jBOsZsjxyFTOIFJLpKgrsjJA0NgFUbBjTIeBwrGEPlYILrTIufgdacnrMIMWIg2tYv4BSc8b2S7EFgxWrn0tfybN7iktASE4cqUhD+2QWLjvCfVhIR6KKHZIhU9Qk6IgYKDI+oxivue7FFVsQEln63na/BAlOdXOtjYh3di65CZc6hFWXGd03CnDibQkSjJD6gG3yqDnpeyZQ3RrWLWWZnclaAg3GwOv7kyEaQIUcbHPh2YqSW1eocKvRD377hwV710/drGTTE2afo1qxKzbtHlmzuUWp9nXAes196aaa00YnLr8CkHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 23, 2025 at 02:48:54PM -0500, Rik van Riel wrote: > Use broadcast TLB invalidation for kernel addresses when available. > > Remove the need to send IPIs for kernel TLB flushes. > > Signed-off-by: Rik van Riel > Reviewed-by: Nadav Amit > Tested-by: Manali Shukla > Tested-by: Brendan Jackman > Tested-by: Michael Kelley What's the point of keeping those Tested-by tags if you still keep changing the patchset? > --- > arch/x86/mm/tlb.c | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index dbcb5c968ff9..59396a3c6e9c 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1077,6 +1077,20 @@ void flush_tlb_all(void) > on_each_cpu(do_flush_tlb_all, NULL, 1); > } > > +static bool invlpgb_kernel_range_flush(struct flush_tlb_info *info) > +{ > + unsigned long addr; > + unsigned long nr; Oh, c'mon: unsigned long addr, nr; > + > + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { > + nr = (info->end - addr) >> PAGE_SHIFT; > + nr = clamp_val(nr, 1, invlpgb_count_max); > + invlpgb_flush_addr_nosync(addr, nr); > + } > + __tlbsync(); > + return true; Unused retval - that function looks like it wants to be void. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette