From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C52C021A4 for ; Mon, 24 Feb 2025 12:14:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EEF96B0083; Mon, 24 Feb 2025 07:14:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09EAE6B008A; Mon, 24 Feb 2025 07:14:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA8766B008C; Mon, 24 Feb 2025 07:14:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D46406B0083 for ; Mon, 24 Feb 2025 07:14:55 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A2F31ADA7D for ; Mon, 24 Feb 2025 12:14:54 +0000 (UTC) X-FDA: 83154732108.13.504CC63 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf26.hostedemail.com (Postfix) with ESMTP id A35A7140005 for ; Mon, 24 Feb 2025 12:14:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=f5qtBwvS; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740399292; a=rsa-sha256; cv=none; b=mlif3MnZn2hsCSA6ozs8sgzFKvxjTun0Yhe9HSRqPTMRTozbonHvfs6UIqSst0LnIiBuTy 6iUNmj7h/S8C0MkZt4X6WlTP/5DEDgKAecJdp1QzI6uGkT5dN2O1PHQXwfx8nUD1fP/MWP sS60De7gsOpBtoZ6lRv8zJblRN41Hwk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=f5qtBwvS; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740399292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lhImJPjIcI0AMJM7iOO1E6DHn/v6OyLBkgq4ZZyrkPU=; b=mqDCYMnrH3PRPzhFYNJfNwvSS+CWifChlRNPItHVMdc7z3VWuqMJHgEeQWE6n5orLx6zJt dsKULwv3iIPRsI0J05NchPu/a53jYxMF63Ub/lV3g7scS2Awl0zu19MnJeJXYov9pkK45t YLEOuFh3puiChSW1y1zBlbaGS6MwPwY= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E786040E01AE; Mon, 24 Feb 2025 12:14:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K6HgFcyKJ6Zt; Mon, 24 Feb 2025 12:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740399286; bh=lhImJPjIcI0AMJM7iOO1E6DHn/v6OyLBkgq4ZZyrkPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5qtBwvSoiNLuR8DI8xbFYUVsZPYy1K69o15yw+zk1YwsQ3PxPN/4eI3w5PBjev4f NPxdZx2aWk6AzZ4XSZc95LefTiwwlst/g1caGg3B0bqYao8QxImsmXyeIzXwyzZxun IZzJvT3PcK9LIbgeyhw84Nc88Ds83C97WrX7Kr45jMirgGcZ23La85iGJAf3VL0EzO kQxlaDk3OPJSKEx6zXbeWeqS+Q8oiB7+X5DrDKI6McSlFW4coizLXfnl9t2DtnUDJX Oe1iHMvbA1U1Rj2/l8LDq1dGNxrxd+GpPQnQmIB/v+KnHKeTlhIcpzSZY7HSik6Hrt YRMRHR4tln45EYRkF2Vkk+DblvvVVblz+zXpf6LETYKsau+ockj9n31B+Fto52Pg7w 40XejAFZs5gF1tG8o2DtmNZBkMLuYx0xaR3juWsaawX3osGPWStMvV1Z7kJ/ZpdrfX Uz99rXlMviPx3MdokKKbQmiRKQPAtt2GbJjeAyou9B1c31Fr4vsmU+3sr1AduVnDBg vEBuOmdUHdpIyH0Hq/Ex1Pm3tLMMDbVF8paRHm2nT7Azo422Eyj2sn7O1tm2errCeI 8N9o5ZhnrKAVOjpFpeipBDeX5KT+1NXwx/AasGNe226DkOvNybb8DXm2/PXNM1Ucwu +gbBtG7PKO7GGzBQhR36fl/M= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A79C840E0184; Mon, 24 Feb 2025 12:14:27 +0000 (UTC) Date: Mon, 24 Feb 2025 13:14:21 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org, Dave Hansen Subject: Re: [PATCH v13 03/14] x86/mm: add INVLPGB support code Message-ID: <20250224121421.GEZ7xinWhjstV_xPU_@fat_crate.local> References: <20250223194943.3518952-1-riel@surriel.com> <20250223194943.3518952-4-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250223194943.3518952-4-riel@surriel.com> X-Rspam-User: X-Rspamd-Queue-Id: A35A7140005 X-Rspamd-Server: rspam12 X-Stat-Signature: s1zg7hiqyq8hdiyma9dfgyed5s7yj98w X-HE-Tag: 1740399292-495740 X-HE-Meta: U2FsdGVkX18QWVx5+5aU+V9yHhBF5wbExyCEsqSUZjVuCgsCZXnAHOn/EQzfq0ztaHdSh7+UZyio3n+OpP225XJEkSDk7L+HsYBCgOtwuXLDHes7wDcyBCT4rAt6lyPPla4tmFe9mBOleP5Fpvoeov67qFygiretuGdWNx+ZcgKnXKlh1XsD6PTtg3Q1K71IPaC0XjfXj9aNYFFYcLkYWZls/on1RZx8pjI6+VzjMllJEmTBNkCnISlTrMy55HFZ323o/TZnY6LwRpvC5K6APxfOtBNoyWFCJn3PJ3jj0vntKPuujj8dTR5vhdJRGMMmv5ikd2BD/euLWjuVLFvz+wR8dQiOzv5QCuuT5LF1LJtnWDj3RgrPoMi4lKuDPlhAtkjZhiJbdbqXQTV7zdwIvM2q39N4o1hEhzjOSng4d5UbE/7hkR4L7chiZqP+LMSfxGsKz0mFu/gea62lAQNn4B7kS227EcZ/jbJu45j2UINrt4n4l1xSxOx47fd5uWpmSUl63cteGoKgbvRplk2vLGcwXcl4s1VwICaCXMoF4ay1lg51NW2xc/hdedDvyYkltkmK5m5rGKXsGGpfm3LdhJ/Q8t6A/7NhLwGI0GmnfC8SqRcXhtIBSgD25cWhcTOod+p9pUiXHG9CSK6i88OzLMOMB9IM26SdgWFBAjSMoAeXcBxqzWAi1pKBWaOevc9ikAfWq3HvKMVu0/IGiIikB+/rwDuxqJDk2u+conDKu0X6rX2+Dycawl08grYp4cniMKw/uh/eSX5KYIs+YQ9aYiluStmk/b9N5Xg3WWdwQgoor7HwO1BfxKs+YZaxU5tuNiyVcRGUXPFTiOiFXpFTFujCV5dJCTdcLCsBob3QuTfac0DFdq1SCA8I0Nc1pKeeCdSqePmI1Ya7QSN41wbIwgHCDD6QGyZwu6xQepSaX06v1+i+h7O6XvYMFSSz833Eg45A7imEpOeF18R1jz4 RiHbrBxj HZdnXB+lqnOQZSP5PpEIZG5TFpqz6V0YvSK/GvEgPAwk6dv0oNcq4YtQhwy+oSDUmLTDLZ9gElVVVj++r/gBmn9eiPOZNfgoLMzBGxXcOdZwA1Mg1u7EwA382N2zQJlBHFgVgixh393Dqk9AJ9tDi4JZC6TZdyEfA0JRiAFm/+HKcwchMvqXnlmPA/r6cBiSfGyDBx4InoQCIYh8kMFbkvX65Ns4XwCX+BJXqXX7k0GzlMTX6KOz3/fBcpPH62ubtee3dA/V/MHFDOzckKIuRafQuqw+1wldFL0V1S/nGGm+yW+iBpOB9PNt44u2uWCLIr+xQqIgRXuurLHBRccysEJjZ3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 23, 2025 at 02:48:53PM -0500, Rik van Riel wrote: > Add invlpgb.h with the helper functions and definitions needed to use "invlpgb.h" is stale now. > diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h > index c492bdc97b05..95997caf0935 100644 > --- a/arch/x86/include/asm/disabled-features.h > +++ b/arch/x86/include/asm/disabled-features.h > @@ -129,6 +129,13 @@ > #define DISABLE_SEV_SNP (1 << (X86_FEATURE_SEV_SNP & 31)) > #endif > > +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH > +#define DISABLE_INVLPGB 0 > +#else > +/* Keep 32 bit kernels smaller by compiling out the INVLPGB code. */ No need for that comment. > +#define DISABLE_INVLPGB (1 << (X86_FEATURE_INVLPGB & 31)) > +#endif > + > /* > * Make sure to add features to the correct mask > */ ... > +/* Wait for INVLPGB originated by this CPU to complete. */ > +static inline void __tlbsync(void) > +{ > + cant_migrate(); I could use a comment above that one... > + /* TLBSYNC: supported in binutils >= 0.36. */ > + asm volatile(".byte 0x0f, 0x01, 0xff" ::: "memory"); > +} > + -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette