From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06341C021BC for ; Mon, 24 Feb 2025 19:02:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 726F028000A; Mon, 24 Feb 2025 14:02:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B4B9280002; Mon, 24 Feb 2025 14:02:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5291928000A; Mon, 24 Feb 2025 14:02:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2DE6E280002 for ; Mon, 24 Feb 2025 14:02:58 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0202141A9F for ; Mon, 24 Feb 2025 19:02:57 +0000 (UTC) X-FDA: 83155760394.29.8021651 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 36050C0010 for ; Mon, 24 Feb 2025 19:02:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f914usR1; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740423776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SdP9a4Al2QUM295kdBFzAImQoLNTjknW63qt8vY2cx4=; b=RcXqAVqcPcUkYGmI+AX3Q5hlUTCOWNVuaYg7q+U0iSkSnlGvzzHGuCDaLfxSbOsKhhe3bT V1hsXC6xIOX8IQ8yQ5kLGOeInJTaorIxPFjQ1jc153Z8OlyhoJsZTiKzZGv7L/gDelHDM5 LJZ6hcwU/ut7eRItNVivTRv5rFUm6Xw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f914usR1; spf=pass (imf22.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740423776; a=rsa-sha256; cv=none; b=pUfSY5XafIBBtACFncYZI3z3vtTQignwm0lx7/j0czXZFVrk07O292ffmmxnofJKHrgtUj HexJYmAYPlgBb9KuS6AxU1WmGexynCYwVmplSHkl4kPwNd9CKiUUCaxGsxEMRdhGAFa9wj +9rUZKxvwcmJiz6mCTh7anUPIC1ZHDA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 537BD5C54C3; Mon, 24 Feb 2025 19:02:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA1DBC4CED6; Mon, 24 Feb 2025 19:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740423775; bh=A6IpvWzpqr1JITL6jOxep5JLmWREXE9w1Dp2+ShNZBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f914usR1jbCJ/6Oc0mcZQQ06cjOMAsT/Ym7JbP0pCRxiD6MArnIgC132mw6KNPNBQ vf3Hwlx893t8DI6zOvc44iB+8Te/XdxFwcNzy3IKT0BJTdRM7/KpxqJeblAnasxb1G ItAS2jlgVOFtg6CMVRksApiKX0YeF7GWpYKmKVoKFIjMrcXIC4Ogz77nXrVFUmk+5K R+cmopUvhcp9awN7eslQ98kA2e/4kdrKXJxdXbPttcpi5yWD7jJgie2AEbY/tJ6BFk h25ZAEw6SC3meApbEzlAaOqhB4cM2AnYiLnLlRrvICcngDAe3hnNiTimdaFRbhGnVU ooMbQuapR/3Ag== Date: Mon, 24 Feb 2025 11:02:51 -0800 From: Kees Cook To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed Message-ID: <202502241102.AB138D32C5@keescook> References: <20250224174513.3600914-1-jeffxu@google.com> <20250224174513.3600914-3-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224174513.3600914-3-jeffxu@google.com> X-Rspam-User: X-Stat-Signature: jo5hgefes5orig4bkbsczxc7zzwru1q1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 36050C0010 X-HE-Tag: 1740423775-646152 X-HE-Meta: U2FsdGVkX1+eW2KvJT9pmorvNKDgAh3qJcel37xkzu2vpXK7Xe6qbTs7ZJVaxB4dQ7/65Q931v1Vqz1rw4Th8x6IGPYi/6jOIxVH81xjYdCmMj/bQ+4JWJXSjxI1x3QE/ExVOSkMpKVmA8Qx9ljuwYgbWeBmnJo6pxl6Se6LH34P7haz95PT+9I8lhC22dONQaB820abbtQSpZ5wv1A6+6RFhvvsOF8wkTP2ngChygrzRYi0C0A0qzhq9p2UQyh73uJ0LhzSlBmC4WM9AyFBtjJ9zJ7n684mMsakzyari1ThMhE2GfjFAdCnWWWFrlUMoj7uvE7lGLnYb0lMeH5pS5qXNSghpAM9s2ir036ghFTFOZiu93GcfD/7WV82tYoH8XT+268JKVzv5jKkSfZwU+AzyxGWkelnsNkmyPBt5vjIloCwCJ9oS7ZN0jDsBddVX7dPHDoFVrH3/v2biAPNiBi+WhwHmjAcaTU8+ztLZzgxryelLJnzG9zGwjIzOMxALX8ZgWq0KOkuoud5kXEoFjHHpOmT3pmeW/m/DP9p9z0VPJrk9m5IiTS7VhFwc26yJIwGqiTzNXEFzh/fn5Dv+2X8XuYxVdkD9wAt6Op6wpPZWNHmVWAkM7mcX4RGHFflkYktZyb6basHfOwjh7jm2MdAyBcI7kdOT+g8RAOYeTB+OY8DN172T2jY3nYiVMW84tIM8jth/GtMhyGAiBlHgJ1CYcPoLboRwFMoa06fqi6B13tEe/cY0Gd3AEn4TLIQQtyBYDZ4WhxP8jQcNBCeeTTsvEaH6GnWSJDD4gbGMgbjstZxCmZHg29OTwv/o+fJ51w41MrqPPtSmHTwEODpQQKXjDnNMM7e18faFkTD0+AN6jMNXPCaWN6MEjixuMIutMekALyahgyQHxF3CI+y98giOXIenYHyS99KszHafCtHMpKEwIOs9pp31dAaOwIpZKadVySH9wLzvKwUALT aheHG0h2 v2iFCktl0T0yEmhf7BTDP5lxwa0258UZ2hjHan0YEv7/OhHmVKtYMLGUc1Qxr0eObsrqEvad8J+eJ0VKt/xszBc6GuBBRTAtMIT9+Yp0Dmh1bY2hRhBLHxIZpzVKyQFtsZ6FnwLGLY+ElQl3SVpIeqWpxplsuyCbhRFpswXMTyg9jVSgHvvg1lEWxv4/e1/VuwmlryHO+DgFNTmVSH2wk543/U1bwn/LLlFf1cJKPhdBCTglACfwYPpdRj8QdKj8gLMYEZJhWAvfPtxydzhK7JSvwFlMns1j/lCib8MConsnY2b2AyP4Teo4tuYHHAf1zITlHDNYYARV3KM4rMtcjrFMnRMtWqosImjKrPAcIzXelyTVGvyVW99K3eFPbZodJIugMokF0eVRKevu9RJN/yeJzYYICGRTh15mE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 05:45:08PM +0000, jeffxu@chromium.org wrote: > From: Jeff Xu > > Add code to detect if the vdso is memory sealed, skip the test > if it is. > > Signed-off-by: Jeff Xu Thanks, after my full 360 on reading this code, I'm back to where I was originally: it looks good to me. :) Reviewed-by: Kees Cook -- Kees Cook