From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CC4C021A4 for ; Mon, 24 Feb 2025 18:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C19DF28000A; Mon, 24 Feb 2025 13:40:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9E6280002; Mon, 24 Feb 2025 13:40:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A914A28000A; Mon, 24 Feb 2025 13:40:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8873E280002 for ; Mon, 24 Feb 2025 13:40:26 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05A71A106B for ; Mon, 24 Feb 2025 18:40:26 +0000 (UTC) X-FDA: 83155703652.11.59844D5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf30.hostedemail.com (Postfix) with ESMTP id 7189C80010 for ; Mon, 24 Feb 2025 18:40:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PfQxnxG2; spf=pass (imf30.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740422424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypMH9S7tXMYGjmbKxwoD7JNQrCjW8gvuWmbChSSFcSY=; b=iiYWCY+fd3TAAFp7K5EFwcHoZFfMs7Iq/iVHs1wStmM+B3l7xPZp5cWkoJrxFbOxwVg80h NKQENQlxr2GibL7+kvu9V5YLBK2egYeLML0QlEdRveF4606IW7LGCw8wPoeKdPo2ouG/ln NcUsSvQU6GtKkqV1NLwC21cM0Rt91jQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PfQxnxG2; spf=pass (imf30.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740422424; a=rsa-sha256; cv=none; b=X5lZkipHVK6bDpJF9D/cIQoD60kcGgPEV6FW7hX1CIzY5QTSpTqnynctAjNbFSnLjWOqC3 NI/C9HmSnCEoECPeJnJYF2DI7AxjR5djCfVOD+2J6l+ZKoBDOIPdAHZpDC2/UWBQpQYiSX dTxvIFF3pwfZJ7INKl/N8cYWOG4vxoM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A3EBC611EA; Mon, 24 Feb 2025 18:40:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4966EC4CED6; Mon, 24 Feb 2025 18:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740422423; bh=W/4TB0pejHdesPEYcGw7u9G1KUlaFKUiog0H0ebCgZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PfQxnxG24sBcRNpkmE9jJOV0VHHLnAJuqY1IqaHBobd2C89p4o7xcDVJR2vzU7sPz gO7KSCyBga9aWmwMTwDz1jpLA5ktMAjhWvYsMvQHMAxREiXCp1/q7Y3mVNvT135xu6 P3NhsooPfOd2tyx1Cml545qQoxRP7s3VWaGMIot8P9FLoVQgIKadBHD2BCskVwGLYX WZyioBs5RC8lZ6R4j4ZmGDhGV7vpEHkXeDBObtGltAvPinAn9Y5stzuTffG2BsS9zj HTbCm9z1TEeSh+z9A/0L0ktC1FLFbaTRa1/G1jsI6eQcp7Y9nXYWZnJkI5/OM1M3pV VVLYZ4TYLAVvA== Date: Mon, 24 Feb 2025 10:40:19 -0800 From: Kees Cook To: Arnd Bergmann Cc: Andrew Morton , Brian Mak , Arnd Bergmann , David Hildenbrand , Peter Xu , Jason Gunthorpe , John Hubbard , Steve Sistare , Vivek Kasireddy , Yang Shi , Christophe Leroy , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: unhide get_dump_page() function Message-ID: <202502241038.A4A1ED25A1@keescook> References: <20250224151225.3637934-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224151225.3637934-1-arnd@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7189C80010 X-Stat-Signature: dn3ds898rzzffzykux7s7ke3fe8xxs9c X-HE-Tag: 1740422424-201007 X-HE-Meta: U2FsdGVkX19KIEoDoFvxtxLJfWf3/8yqwpHpgynKN3t6VjAWEbliV7nP/HkZjRIHeSLmW3942qYPOFxBF+WBSRk3R+qpnLbN09tIiOxKy/gefwOn8MWEdQmlkTaBRXZpM07KWH79fmuSuSZgz+otCBsBegf7VFjrHlnYO4F/4lyTEXdwOAEGBrEgRLONePzkz8NzwOBxHfgUaSY88Qhr5QA59pgvfOE6We6KK+GGiQscNtnrJii3tEbVT1/L9ZzcAO7IpTHouiqpMbQYSvmbRNHvnlx3faMQfOOsvlTLQDmO0d6Wpm7V1augSzdrav6YtPYoCP0qKxcf+hSPQARhfx9u5dgxxECmaVsnZ+0bylFyEEzzcasMLCxIUdt0W2/TUY8m+hn06prZyKfoA/r11zokN1dRCv3xmJ7q3HOfP+AlmWLYJ/sOxXfRddTJ5E8BfMtdvfbwOsmZPZKSDKFN/5AQfJmkQGfXe4XHoDQRyFwb2qsaIkdcICPhA37mV4tpitN78Z5nyOiXWzHuv0vQqs26kpDOVzIQCAiY6Lv7XKeZcslRjj+kitdNWRfy6fiD6Ls4294YWLw+Y3bEIv0zm7ztR/NYE2KHjALwfH0IjG8vgLL9/uCzIUyVSYCc6Rh84aWDszndA7Ewjohz8FMTJ6AhZkU90aVoJ6SrXXzSl7ELyBPqRQQo24x9XQ5yLZ4zkcptdl65rOOstmsOKGOl53kPO1DcVw9srReOVXK/sZmjw8J8CdqAbPoUJzYp8qMjxpLtTVZ35G/UKP65/Ezk2fWBVrWbAOuWoGs5x+V6nZwuqtRqlUybBUhf9ZAY4WfQh7+qbDxSPjLBZtL80VjOccNdYLq15TC2FLySaUqDck6Dc14e5fEJ0SCM7SB+MGmYnUZ7DK+Vv42Zvgu61TN6BMWs5CEW2SfgdO4/MV9NPET6AvVAWVexyUsqtX0To57DVHgmR1JebX78HyWCPPS gRW5qlCS +DYCXkIU3yldZ9opzwV28PkcY6vnSxihsHNLKig/Q2GSDlazpUrfIHIeugR2GoLMwFi7HSD0GPmwNbt7l7eoftSyUDazdiTKIpq2ARuIsXfRlrXQXUu3CvIhOnZOm8vvkpHPxyj83BSAjzP0YPIZWASmguiJ88IwTe4UadaInxSu2BIqgb35yWw+Q0Adx5oqLd63YMmYzJMOUQ+iVZp8u41DSii8SuaPhjlVbyNK5HT6Mg7F21HBLw5Ak4Hz4eDAmPsWZ3eODRl1sV6wSASVg7uScaxbY8sDKAoKqG+C5Rgk2wwU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 04:12:21PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The definition of get_dump_page() is guarded by CONFIG_ELF_CORE, but > the caller has now moved into a function that is built based on > CONFIG_COREDUMP, which leads to a possible link failure: > > ld.lld-21: error: undefined symbol: get_dump_page > >>> referenced by coredump.c > >>> fs/coredump.o:(dump_vma_snapshot) in archive vmlinux.a > > Change the #ifdef block around the definition to match the caller. > In practice there is very little difference, as setting COREDUMP > but not ELF_CORE is not useful. > > Fixes: ff41385709f0 ("coredump: Only sort VMAs when truncating or core_sort_vma sysctl is set") > Signed-off-by: Arnd Bergmann Thanks for this! I think I'm going to split up ff41385709f0 -- between this #ifdef and the recent prototype changes, it's going to be not a great backport, so I'll pick this up too. I expect I'll have a simple sysctl fix for -rc5 and then the rest in -next. -Kees > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index d846c0ce41d6..15d6d7b5df1d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2266,7 +2266,7 @@ EXPORT_SYMBOL(fault_in_readable); > * > * Called without mmap_lock (takes and releases the mmap_lock by itself). > */ > -#ifdef CONFIG_ELF_CORE > +#ifdef CONFIG_COREDUMP > struct page *get_dump_page(unsigned long addr, int *locked) > { > struct page *page; > @@ -2276,7 +2276,7 @@ struct page *get_dump_page(unsigned long addr, int *locked) > FOLL_FORCE | FOLL_DUMP | FOLL_GET); > return (ret == 1) ? page : NULL; > } > -#endif /* CONFIG_ELF_CORE */ > +#endif /* CONFIG_COREDUMP */ > > #ifdef CONFIG_MIGRATION > > -- > 2.39.5 > -- Kees Cook