From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DCDC021B3 for ; Mon, 24 Feb 2025 09:10:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C856B0083; Mon, 24 Feb 2025 04:10:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC156B0088; Mon, 24 Feb 2025 04:10:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BB136B0089; Mon, 24 Feb 2025 04:10:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1EDF06B0083 for ; Mon, 24 Feb 2025 04:10:41 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B483B80F58 for ; Mon, 24 Feb 2025 09:10:40 +0000 (UTC) X-FDA: 83154267840.30.C534DC9 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 08766180009 for ; Mon, 24 Feb 2025 09:10:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=2OWZEL+c; dkim=pass header.d=linutronix.de header.s=2020e header.b="7CZDdR/l"; spf=pass (imf06.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740388239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hPqGnpTERnLv/18IQIdDLi4CqLYf720duchwyRqxOZU=; b=LGcqCsRoUwdkueZ6KWwdZA2Of8fepsJ6elgetzoJAdpzFirC1Sjf2M4itUGLJ9ozIo8Fjv K5kwdkKMT+AwO6GPFSXMX03WmBVe864rOjSRMZZJ+mrHF3S6Fp8CPMnkGriQ2KqIca/kvR /TY37FKLcZpqg7S/vM05imgJNeDC9r0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=2OWZEL+c; dkim=pass header.d=linutronix.de header.s=2020e header.b="7CZDdR/l"; spf=pass (imf06.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740388239; a=rsa-sha256; cv=none; b=8VulnjxrlieZRZebRbP84vLxexGPqcyyc6FMROwjC9k+3Rvqr3hMWUh5MpUwJqai4ooSqs n9vtCb7+WTwUVlyYkEIp6dlaX7T20FZ8UIKmgC/rqkNLg0Wq397j+M73aivi/lKn9MXmq8 Nb86o4JffzsfxN1WH4ayWQoUiUeak4E= Date: Mon, 24 Feb 2025 10:10:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1740388237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hPqGnpTERnLv/18IQIdDLi4CqLYf720duchwyRqxOZU=; b=2OWZEL+c1cj8I0babIp6FhPn+sOh120YWsro0KostGW4iFTBGb2eCyrN/nGOjU1ouAsCMj dNZCWINWTuqQyHH/rRgJC1+/YZsmQLrJld75izW57QoN7pSI1EqqvwN+ktm1QjJoN2+b5/ gc25jJA18EooRjgHEtKzNiI2cRm6Rg+MLKjHRzsOFByD/Oen+mhwyuBQbE2VxRcbxhVZ+C 1QKpb7ajlQJP5948Atu+2ufiO9v8k5oUWuLrpzgToYa+PvryYN4CfKlCUM3u/OVxC6gBh5 i/Pp1d7BZYOGSGCa2xPF5dzbYQVV46hrm4al8OCffE0X8jCbjNR3MCR9aNCVWQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1740388237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hPqGnpTERnLv/18IQIdDLi4CqLYf720duchwyRqxOZU=; b=7CZDdR/lQVFuSZ13nzzqpxmYidYAwyMH2Pq/c34Thj4WqVMfHrgu6Nlyx4ftKbbwqww5z2 akR4ri2QJ5i2zRDA== From: Sebastian Andrzej Siewior To: Sergey Senozhatsky Cc: Andrew Morton , Yosry Ahmed , Hillf Danton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 14/17] zram: permit reclaim in zstd custom allocator Message-ID: <20250224091036.Y9fHrKr-@linutronix.de> References: <20250221222958.2225035-1-senozhatsky@chromium.org> <20250221222958.2225035-15-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250221222958.2225035-15-senozhatsky@chromium.org> X-Rspam-User: X-Stat-Signature: ngaraxs88odtre9jyu999rbpnas9sh96 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 08766180009 X-HE-Tag: 1740388238-985424 X-HE-Meta: U2FsdGVkX1+dlE7LdML+uLreJkllJQQbzMaRo4os1MQgz4uYLuoeDgUN32opHIUhKDbWvFJVIar3B2f8fnuBqMspFK9JAUr8xxSZAQy8olz78KBpCMEOYiYXlr+Qix02CtCeUjoJqFjvWVPOZZOhKiysTu+t9i+FAdlVC2ftPNPq8gDEPc1F7ZAtpapqe7oElQQqEDstsszx/s8rFsMzrpIXea+Rk9ypmUiSYF72uk/DsJEGPhQjqI4Po5aU0MjQtBSU59vA4P9KbFGDD/eS8deGhjr2sNdwg6X29Hhsw7jgqko+WdR4lC6eLepRRiNIiycKwywk73PntcDWwncemLfEj2vI86B1DG1x6w0lUEiJQaYmlfP1qWiCNuLdBQWcZNKY70KDvJXa9ZKxcWap37jsnnNrIQI1DuN8oTsXlPYhnKk5hGXZ75dDI6jcILPGPxA+mfbBUVXaD5YN+tlG7zOuuLIP3tnTv4a9Oy8CFdKkJ/2tWbQ0VNClysVinY62WH6Urz5D2FPK0D04uWHl/D0eD/69gXk+EokAHSqVZnsoD+aam4IiPZZCfDKrL7IO2oQv5CP1MLkc5VlRgZpDkWXh9+kjOL/EyhwPKgprraNjOc+TKz54/kIBwjKz/BbLzLe4AI/fhhWVlbOuMEj2DeFk0gnEKdXuZgSn2VObthsYi429gQzv8lFNFQbAhv6Revm7Rsl0kVwBCiTlsF3uSIQEt28WX2qPiPeL44LCLqiUo3UuP7z3x43VscxHMzxXfADDmAX9jfNE7VC699FF408fakHQKfXyefleUJ+8Q58cdpNd+L6zoT6J6ycpNtR9v/+Otv9ueNGy9MwJv2S/bAPyRqQmxHjB5GvinUHz9s+tfesfBVXnr5sXSpM970o8pXaLH0+CCUAanNeMccJvm1/Ml4sIfwGHazy2n/Lg6SkH4n08OgFu/cLRGZXzs/3/klxlidja/d5hEEtNB7r pte3v6Em 4I42tj5f5HvrfsHz6jwL8aan4LoaEai6k7Fdfdst7B67rB6pOy4d0WS4Xu1gwU+ATp2eTgcDv1NP2mhQHp6jjUHEyZdpH3W7kx0XwBK29TZ1vXudiEnFe8mHHMBvIx0AkC0+3Et5tkQBi2lH0s4JAVn4zAbFE2/1r185ccYVljfedGPXKSgSTB8A4FN+C9jCKpxAv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-02-22 07:25:45 [+0900], Sergey Senozhatsky wrote: > static void *zstd_custom_alloc(void *opaque, size_t size) > { > - if (!preemptible()) > + /* Technically this should not happen */ > + if (WARN_ON_ONCE(!preemptible())) > return kvzalloc(size, GFP_ATOMIC); This check works only on preemptible kernels. If you run this on !PREEMPTIBLE kernels, preemptible() reports always 0 so that WARNING will always trigger there. > - return kvzalloc(size, __GFP_KSWAPD_RECLAIM | __GFP_NOWARN); > + return kvzalloc(size, GFP_NOIO | __GFP_NOWARN); > } > > static void zstd_custom_free(void *opaque, void *address) > -- > 2.48.1.601.g30ceb7b040-goog > Sebastian