From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EB4C021B6 for ; Mon, 24 Feb 2025 07:14:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95A5B6B0089; Mon, 24 Feb 2025 02:14:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E4346B008A; Mon, 24 Feb 2025 02:14:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783736B008C; Mon, 24 Feb 2025 02:14:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 51F906B0089 for ; Mon, 24 Feb 2025 02:14:00 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DE868C0CB0 for ; Mon, 24 Feb 2025 07:13:59 +0000 (UTC) X-FDA: 83153973798.23.5A4A6DB Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf24.hostedemail.com (Postfix) with ESMTP id CB6A0180007 for ; Mon, 24 Feb 2025 07:13:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fl5YA8vB; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740381237; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AhJ1T/fwWWXZEiEbcn+HPev6I/zpx52m+r3y5yvwxno=; b=qFK4CiiOHZ2ypuGyVZ8HyxocwvtG0i7EyirpJolKzxSeCg8PrlI5ykN6s+EBAVLceSKBX5 zzwZzTbDJCCFcbEgcAEg2lT4UBTH7ttKDQQHHxZ7lIYcGVk+nCCEfqsEYrZQUufcJS5nAx +RAgvdJeZgJVqQXUnwHTnMdG4/smLP0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740381237; a=rsa-sha256; cv=none; b=64hpTCAUNISfqS2Kpt337NaJATeZn0JjSBzpm9PXk64HA7Rbt7//IKRgCiJGC2VT+1hDAt kS4QviAIMAG0ybt5sxZ+HOkQYNW9ZT2Rew9ESy1D1+9yNhFfOVdLwRmByzjS/EbF2nNQ0b /KQ6LjTK7Lb12DHa1oEZO+BoSEr6hJ0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fl5YA8vB; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-abb81285d33so779239266b.0 for ; Sun, 23 Feb 2025 23:13:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740381236; x=1740986036; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AhJ1T/fwWWXZEiEbcn+HPev6I/zpx52m+r3y5yvwxno=; b=fl5YA8vBAX+U08g5mk8jRs3PNVCD8CNSQ6CYpKvEhkGWf8agseAISTELiFGzV3LByu n3eKG8S+pMiB00SQZ/ttc59jM/r/ZjcUZbHpTOEbpj9MmcfgZ/PFW1xg78Kr7MNc6Ybm FDZeIJOt7eGumZPw9BSS5552Bn0cohIMjjIjy1wWq7RtSbnRGJRzwUVrGeIgzP+z3a8J okEibKiDTf5zs0aZ2RRUrPiH8sIvV0t441SKXysdwoETubjST6O3+dGvnwHOlAS2bCaN HPQnLyeFQaYnmii1I8SXCQpLub/b+ZXhSeVE8UZOGP1MmNGyjewg3dVJqN8XGZxO118c LiFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740381236; x=1740986036; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AhJ1T/fwWWXZEiEbcn+HPev6I/zpx52m+r3y5yvwxno=; b=hRyM/V01D2+5L7yV+GwhdCwKM0zzMgJ4JnPqan8edeHHbpy8A8VpKVUPXH/2IgYJ0l KZsi/KEO9ACLjPVIFQgGZXXvz9iDJc9B3DECTaagEGSDCn7bCdyx9eTIAERF4Nst7Osz xT+V7vTOWb78k/CaToqX9ieJE2pZZiZDmRcxHMd/OqtqEcKSDvzisUiaHFAHNOnYRcrc O5uBLGhvUiyUyQVxpOwXRD4/Uan8L2Da1iJO0/QO9QHuGn+Q0aQZuua35nswhjPSqUKI FZwxciHRIqErtsxOxjC02SfnhEtEY+n4IwIl2GFFa1WSN+Jp1Yge4ko+N7AS+B8f9jah u6Sw== X-Forwarded-Encrypted: i=1; AJvYcCWu8vhnh7QRe0MrKCrdBdIaaI6i8mVh/oeAaPeRlrEoAqsfRslKqbyDaNQMcBvC3jHC/DovzlJ6oQ==@kvack.org X-Gm-Message-State: AOJu0Yx0vBWyqks68w7H6W3V7t6d/XznlNLwoeAIcf1wfHOT6k7XBZSu XyogzT1xv/AVUBgRyZfIBORoVqwOb8r4NppPYnz01WoCoV9M9AgC X-Gm-Gg: ASbGncsH2xVKYHMFV++K/B4E6fmLPGY3hIirkY3O9QHU0ZM31+QMzOiDAYyBpm/phwW xtbQLp1WotrvoIHhXMFcPltQfn90ta6FLYN6TcC/Fo4IlMsUEkfsiCzf+yUHIY78ntoELIwYAcy WBYTLemziDRtOujWFkIxUndfqRroSGd/LtL1jrDa62Snbe0TFRxeeMGerG4mkkapZwYklz+XBaO +ZSZHx5KUyOiAjE4Y93ORGwl0ZzC1WSwhJ9cOuPlIPyfN8hXe66hyJ4eAYAVSU6mCfKqifECZp4 29JnzbkWUFHl3wkDwjrBvxuv9Q== X-Google-Smtp-Source: AGHT+IFTl/OJwiOMCrQwp/6jVuRvgGddWSjPDFK5GMI5evFJFlBu1ePwDd5puvr/8TxFgsTqVzZxSQ== X-Received: by 2002:a17:907:7ea0:b0:ab7:d361:11b4 with SMTP id a640c23a62f3a-abc099b7f3fmr1362031766b.7.1740381235930; Sun, 23 Feb 2025 23:13:55 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abbda707e3dsm1034964866b.106.2025.02.23.23.13.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Feb 2025 23:13:55 -0800 (PST) Date: Mon, 24 Feb 2025 07:13:55 +0000 From: Wei Yang To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 12/14] x86: Add KHO support Message-ID: <20250224071355.xsl2dbupda4dhfzl@master> Reply-To: Wei Yang References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-13-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206132754.2596694-13-rppt@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: CB6A0180007 X-Rspamd-Server: rspam07 X-Stat-Signature: q3u8ccpjaznjz4b8r6obw8t4psxi551i X-HE-Tag: 1740381237-143592 X-HE-Meta: U2FsdGVkX18GUTB7Zcd/oJSPdawjBatUy8rOjPajMkIvhLxPXaqyYFty4HzXupaTfLLf66QOckJ4xHE+vwbywd503gGhONDYa55PIttynKceznCzHQSPlAIacrUcwE4o8lX5Fq/qFGvohp8bbyNVhQWqvuFNqh5MKja2UQ0oKE81u1mUaIhie4ByOTmH0jREEuxXAdbAwcVrinzd1bF9SnT+V4ziKa62GWZjmjc0H1NxwcRHUs5j/oM3JcYyy3CzHCjxvvBQXTzow8pl/62xLg5+0UBgl4hKWZTTzGC9Luprsd8BQXMhN/JQT0iKJn1RBygFolTonxUJ3OM97taVtgPuAvYvPy4npJjbsvlJ9rywt1xQ5F3vRZuZ5t/AAjtC4hMyxJWe04Kun/tn9DmLvwt4yW8kbthRGB/oGn63wf52QAsP0WNxpEpEtqiNHYXVJ9TfRmvjgqVHdVddq50N6qPXnPJT2GcFe2NJBaZR6NUOs/I5Gx72wzIb6Ju7B9Fbp6vJHYx0ZwmA1fu3p9tH/ChCl5y70a2+0ZnDugi4I7o6cip3GNmMhLI+aRwSkVVuk2Bzqm+x5rrQxG75bqEtpIpTVPGHs9kl+6fu4LdvInCTTbjeB4OdhzhK1dVHY12wOXqS89i6Gzyrc80d6dD77ymmAwJfgvmk4BBw12rD9PG6sYU+S/fD3FnJiL1B1fDGSQr0/kQEtVb1Vo/mj5o+0JwL5mGsp6wAANdywgynWjRvXN4k9IgetIJYkK9Cs2KSvq8gBkybh0RGYEutk37IANGOsY2DsWv5+BqPbDB0+uLzEPKFKz9rfadiUOHWx0RvZD91TS6sFpLkJHpeWCgWo1ZTe6JvuG/H+DmijxTa8EZpzd7MzphRTiduCdSj7QAcRMw3d9MC/nZ/Ddf4xlylOv1kFK6S0vrAjzP97Ov2c68UfTMUXPVg5+8LQP+OclXQq3uK87gbydoEVDJWZpD 6s3fOJbr DZib/Su+723u4uF4JnIv63FvKCGstIY7Dsk8zc9eU5wd+EwzOPF0GNEnRqqhP7tbp9M0l7dsS3lcmZ+f7IhoQwjbT8kPW0LTieUUA77rTCkrrQwBGQl5Foji3clIvGdHCdsEviYo3wY5KThLqUte68qdyi0Pw7Gld3BbTQ6gWD1scKpU1m1hmRxKCjhDJTBFy3IKkoGd6aHyTr8gusRyCeloYPxcpyUFcJZF3mDrVnIlD43sSzg358D4sgkrfFTcq6nD2bT7tFTm81/FMT1zGR2L1euTRC7Sntb414WSyghaff97hUIaFQOD0SZQcL0ehmkveq1jiQKDWU/SncODwH8av0nGziHhFo88lRdZ9xCQH8YT0voVoA8Qhn4ylXLz67XcL7fdMGL+V/8wfYg5R9p+cnwUPoq6k2mbRzhBmDFvGRAgYK/GxBwj1ps1RTXn+6sgwNcK3TZH7R+8lDOvrf717OdgfC0tmuiNzsKJEXDMag0W8R7h3f+zhOMTqpPQWVWxWLt6AdBSbzLc1qKT0vYngZqLo0j9csgcmxgVbbSW5d/aFHq7ZwXgJUlDWv3oAXsm8D/Mb3qyNkVm1vTDkO3tLIjFlclV7bvZj3dBCg80QJRhlztch31S3v5Un7pObbCRprjxZpB18mwz+2VqBUEDLSbbVr4Ym39BEuGZN7ZSejx+p0nieBxAsTbPEuCF5wBqs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 06, 2025 at 03:27:52PM +0200, Mike Rapoport wrote: >From: Alexander Graf [...] >diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c >index 82b96ed9890a..0b81cd70b02a 100644 >--- a/arch/x86/kernel/e820.c >+++ b/arch/x86/kernel/e820.c >@@ -1329,6 +1329,24 @@ void __init e820__memblock_setup(void) > memblock_add(entry->addr, entry->size); > } > >+ /* >+ * At this point with KHO we only allocate from scratch memory. >+ * At the same time, we configure memblock to only allow >+ * allocations from memory below ISA_END_ADDRESS which is not >+ * a natural scratch region, because Linux ignores memory below >+ * ISA_END_ADDRESS at runtime. Beside very few (if any) early >+ * allocations, we must allocate real-mode trapoline below >+ * ISA_END_ADDRESS. >+ * >+ * To make sure that we can actually perform allocations during >+ * this phase, let's mark memory below ISA_END_ADDRESS as scratch >+ * so we can allocate from there in a scratch-only world. >+ * >+ * After real mode trampoline is allocated, we clear scratch >+ * marking from the memory below ISA_END_ADDRESS >+ */ >+ memblock_mark_kho_scratch(0, ISA_END_ADDRESS); >+ At the beginning of e820__memblock_setup() we call memblock_allow_resize(), which means during adding memory region it could double the array. And the memory used here is from some region just added. But with KHO, I am afraid it would fail? > /* Throw away partial pages: */ > memblock_trim_memory(PAGE_SIZE); > -- Wei Yang Help you, Help me