From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72961C021B2 for ; Mon, 24 Feb 2025 02:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07BAD280002; Sun, 23 Feb 2025 21:46:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02B67280001; Sun, 23 Feb 2025 21:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0E10280002; Sun, 23 Feb 2025 21:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C2FD5280001 for ; Sun, 23 Feb 2025 21:46:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4374DA121A for ; Mon, 24 Feb 2025 02:46:46 +0000 (UTC) X-FDA: 83153300412.03.8B05DA3 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 4EBB940006 for ; Mon, 24 Feb 2025 02:46:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=iLyWyQBr; spf=pass (imf11.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740365203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RseA9vRLicI2hZtcPLQnaq9yqG3Xe6FVC7uCnuf+cbQ=; b=IYUgJ40/bw0FIG6+tYYJqQoLhA7407bkm5GhVtzoBpBUAwVOc8SWAgpLdxvuRutHap46Vc jNgH5JQsIMmy5POHgC4ESij5ZoavwLPmRmauvZSbZYcIpjlqoCrY9etpoYc//NH+4sj75t vqwnAN0KdkLP6oeS9/jwu50diDYWclY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=iLyWyQBr; spf=pass (imf11.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740365203; a=rsa-sha256; cv=none; b=4MEzMB7n04UEligU3mYQMBrLLLAvbYqM9pwsdoHA5f4FH5c6TOhAw4mDTsXy3rcKs4DTjb ddkZccWi9VuGR+hJJYFiVfb2nebWihJToBpEAGNVcb/Oxrhd/Aek4vPl5Srz1bKTzzjhiD W3ccq/19AeKWtd3j1Zn/vopMNbRBuIw= Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20250224024640epoutp04b0e8b7011d15c3f6b0744f8125de256b~nBO3GHOyu2814628146epoutp04t for ; Mon, 24 Feb 2025 02:46:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20250224024640epoutp04b0e8b7011d15c3f6b0744f8125de256b~nBO3GHOyu2814628146epoutp04t DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1740365200; bh=RseA9vRLicI2hZtcPLQnaq9yqG3Xe6FVC7uCnuf+cbQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iLyWyQBrmIjejZf2EFbu0oEG7yw9atAXj1tCtcjiH7rDP1I9zBWcfoxmigEFTd5Up 5HVRG6b698BMWYiA3XIrplc+rUeiv1y5u6Zb/+qBWeF7emhUYlK1ndl7KnhssKj0Xs N/KgH3qdNtXRS+rUOyVETlTHxIbrVXZAAKT0QFJ8= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20250224024639epcas2p3fc88412e50c73bcf1d4a4ce63256e2b5~nBO2zX1ZW0307003070epcas2p3E; Mon, 24 Feb 2025 02:46:39 +0000 (GMT) Received: from epsmges2p1.samsung.com (unknown [182.195.36.69]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Z1Q9W4D0Xz4x9Pw; Mon, 24 Feb 2025 02:46:39 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id A4.52.23368.F8DDBB76; Mon, 24 Feb 2025 11:46:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20250224024639epcas2p13f0d1fb193b771a4e7507175278ca036~nBO2I1eSx1571215712epcas2p1D; Mon, 24 Feb 2025 02:46:39 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250224024639epsmtrp20ffa7b505cdbb78437f10b881bc7950b~nBO2IHVcq2394423944epsmtrp2A; Mon, 24 Feb 2025 02:46:39 +0000 (GMT) X-AuditID: b6c32a45-dc9f070000005b48-c2-67bbdd8ff7ee Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 8C.31.18729.F8DDBB76; Mon, 24 Feb 2025 11:46:39 +0900 (KST) Received: from tiffany (unknown [10.229.95.142]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250224024638epsmtip12c42eedce9e75d3493a8d6cdcb9e3ef1~nBO15k2Tx1038710387epsmtip1J; Mon, 24 Feb 2025 02:46:38 +0000 (GMT) Date: Mon, 24 Feb 2025 11:45:12 +0900 From: Hyesoo Yu To: Harry Yoo Cc: janghyuck.kim@samsung.com, vbabka@suse.cz, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] mm: slub: call WARN() when the slab detect an error Message-ID: <20250224024512.GB2153960@tiffany> MIME-Version: 1.0 In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEJsWRmVeSWpSXmKPExsWy7bCmuW7/3d3pBs33FCwm9hhYzFm/hs3i +rc3jBb3lz1jsVjZ3cxmsXlOscXlXXPYLO6t+c9q0fb5H5BYspHJYuIaUYvZjX2MDjweO2fd ZfdYsKnUY9OqTjaPTZ8msXt0vb3C5HFixm8WjydXpjN5LGyYyuzx8ektFo++LasYPc4sOMLu 8XmTXABPVLZNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+Arltm DtD5SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpdSClJwC8wK94sTc4tK8dL281BIrQwMD I1OgwoTsjD+tp1gLpohVXOuzb2C8K9jFyMkhIWAicXjqatYuRi4OIYEdjBK/Z05kg3A+MUo8 OfeJHcL5xiixZkITK0zL9jsfwGwhgb2MEjO/S0IUPWWU+Pb+MztIgkVAVWL39onMIDabgLrE iS3LGEFsEQEVibfHDoGtYBb4yiTx6+oFNpCEsECgxP+O1WBTeQX0JO5t+sUMYQtKnJz5hAXE 5gQa2n12KlizhMABDommXZNZIE5ykTix8ReULSzx6vgWdghbSuLzu71sEHaxxLbFh5kgmhsY JTZ33GeGSBhLzHrWDnQeB9BJmRJvX1SAmBICyhJHboGNZBbgk+g4/JcdIswr0dEmBNGoLLF/ 2TyorZISj9a2QwPIQ+LxwtVMkEC5wyix4mkr8wRGuVlI3pmFsGwW2AYdiQW7P7FBhKUllv/j gDA1Jdbv0l/AyLqKUSy1oDg3PbXYqMAQHr/J+bmbGMGJWct1B+Pktx/0DjEycTAeYpTgYFYS 4dUt2ZEuxJuSWFmVWpQfX1Sak1p8iNEUGDcTmaVEk/OBuSGvJN7QxNLAxMzM0NzI1MBcSZy3 ekdLupBAemJJanZqakFqEUwfEwenVAPThuRJYU9WP2ewOHjgl1DiiZ8KRs0J/f+Syq78Xzbx WYi5zZz9Z/Mj1ts9eq9cE3ZGIj4xRcjQ62PkjZvRul8TsyTm1Rk82fbuU1/Tk2XhIgvbfwbx FbpWiwvMs+IOZjorZSoV5SNxfHevqr/2Zm+JS8d+yZ7vVrkrevPs/khehessy1Iv1q8RW9PZ c+yetcU6qWpJ462K9uHsyzezKr+SuVKpKFDk0H+A+falrFc/tBZbnd33uGji5Fnvcu7+Oyiz KCdUapPQqiubN50PDOM4fJhpoVtGvKv2/0mBXhKGBz+/Om05x1T3n16cxd4PEj2+a78LLd0b XurEknDB9OmMDDO+E2VSU/+ZbO95eU1biaU4I9FQi7moOBEAtNHdr1UEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42LZdlhJTrf/7u50g2097BYTewws5qxfw2Zx /dsbRov7y56xWKzsbmaz2Dyn2OLyrjlsFvfW/Ge1aPv8D0gs2chkMXGNqMXsxj5GBx6PnbPu snss2FTqsWlVJ5vHpk+T2D263l5h8jgx4zeLx5Mr05k8FjZMZfb4+PQWi0ffllWMHmcWHGH3 +LxJLoAnissmJTUnsyy1SN8ugSvjzfpV7AUXhSte3b/I2MC4mb+LkZNDQsBEYvudD6xdjFwc QgK7GSUmn1zLCJGQlJj1+SQThC0scb/lCFTRY0aJ5qmLmEESLAKqEru3TwSz2QTUJU5sWQbW LCKgIvH22CE2EJtZ4CeTxNSGTBBbWCBQ4n/HalYQm1dAT+Lepl/MEEPvMUrc71/HBpEQlDg5 8wkLRLOWxI1/L4Gu4ACypSWW/+MACXMC7e0+O5VtAqPALCQds5B0zELoWMDIvIpRMrWgODc9 t9iwwDAvtVyvODG3uDQvXS85P3cTIzi6tDR3MG5f9UHvECMTB+MhRgkOZiURXt2SHelCvCmJ lVWpRfnxRaU5qcWHGKU5WJTEecVf9KYICaQnlqRmp6YWpBbBZJk4OKUamKrsjmxSVptsfER/ 2plHmVYH+gpu+Py/rMP265uuWNWGJVsTSp5esDp1Zn4yV4I7w0nZpfITrsT4SATseD7f8tkG rsNrwv8emDt59fTHGW/WciyxXSpS/k/v6vLLgj/kGbVU18azfRKNnfWzJvfKn89X3R+m+V29 L+AQ//Ttx1Xx+ldzzz7/bXq/lq8ucrnLvfJ+QYb9LewzFd46f3DcErQ95dbGKqW4TWHRsanG PClPkx/9PHh7zrMil1sKb0ueTj1zvmIrn71Ktl3NlSW/VRWOLb1ldXeRH8cbFabUPzKB3JJV Lc5ru6asmdr6k2P9l0LmkuAQ4YriAzsPan6OWHrN3Ff98IqOGR+UHl3ZxTVZiaU4I9FQi7mo OBEABn00KB0DAAA= X-CMS-MailID: 20250224024639epcas2p13f0d1fb193b771a4e7507175278ca036 X-Msg-Generator: CA Content-Type: multipart/mixed; boundary="----2jehmUjxW0Gkbg46_GefLyBaSre4jpBnLPH4I-DC_hWbz.jz=_12e179_" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250220034155epcas2p156b90cfb655a03cce4bfac9683f0bfe1 References: <20250220033953.1606820-1-hyesoo.yu@samsung.com> <20250220033953.1606820-3-hyesoo.yu@samsung.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4EBB940006 X-Stat-Signature: wcz996a4ajax7fyrnyz9xyq9hf7enwxn X-Rspam-User: X-HE-Tag: 1740365202-647739 X-HE-Meta: U2FsdGVkX18FkXAtz9Hl/vNN7vFeQ6HSY20U01V//auNVuAdECPY2rWyUjoZBbThwc+O8MIOzkojaWetoECQg3j+MEUdbjGSdpwgo6xxSZW5Y4Ed1Jvx9dEtsovG5RZnR9hh1whreodtdtgkIBH12AJhfbaevUNxCuwThMa4iSxC/+QK8b6W/R4ov+ebGhK/sJf66qaRSvuPnA/9ZlSMRjlgfvw0/r83JOziFWy35CEQZZL372vBm5qlzy+rIFq3E9La9R1NX76jL4ExFywA1TT8PpErDVTnpeXU/gc9lIGOeLNsfB5k5jZwxRB55gVZIop4xRwP0N/9cSKz1AIDCTbJJAd+KHzn4GQtoJ4Vz7nD4KyXJydj7HKdSo6dWsySFlPUn+v1ZFMgrCp3YNvKpzZgjAX2xFiXJMRBTkM9Lj294UyHi7TD7v+mNXQTX5KdunaTmR35CDDi9Pyl9KD8x+sw2cJzx9h1g9KJSwWmLCaQgv8m/pIEJckhRyCUGCDDfa5tLf+yUnkq1ydl7cjyYhL/3KDI/VwYbOhFW6c4X/6IvRBUTzik1oQ9tnCbt8P0XKGRcwf/Tz75073iOU/KEgS76ALYQH2NjvlKxKAvvEXkwTU8Wk+IAv4NSCRn5sK6etoCphraanKSjwN6D0DXcAUVXf2P+0DjD704hKhZgQ/Thqr5X/snMm8N/pMKq99YYWcjo8XuHelJsEaun2D5hyceMVJM+lFsrJcr/jFD93zNlk9T1ZyV0ELKCsLbe+8aDldsqlnKvjj4Vw7elcdqzkdjXZQiXnMUCsqARhLPucfGp7FxrutwIkC7RN3nbKuOYXGhVgECx04oHYQ1uw6uXu7IZd05PG7FVw/3X/FPw3/lmmDs5qSmaGfSeOYJxSeLep2+2mFWQrkNtnbiEraudm/hwo+FvDMsF3yYpwUhSdpHcr7kZvIoJm9rYZI+TXq0gG6P5CDV7MCdEsr9nWJ 7tSgmO5N Oj60BqBkriLZ1ZMLbPI79pQ7/P9XZ1A2vI8q6+DAhVcB/tD3rCWez5DDnvsecPwiHYEQAUWQMuIJZ1gPtfPBxu0ntZM2++N0TOGGUuDxzgZorzJfV0UEO0ffbeSH8m0pYy22Abh/5FoH9YVLVkzyrgF8sV2vdjlN4Bmnz/Df2de5YU7x1od4PhjzRfB8tPTl8VaRNNQ9zjvjgPPM1voBtobPBusYjUVdQQpwjtSc+dqctPc01AqkliSN4i2wFQUqaa4cUjq0oebKQliY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ------2jehmUjxW0Gkbg46_GefLyBaSre4jpBnLPH4I-DC_hWbz.jz=_12e179_ Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Feb 21, 2025 at 05:30:59PM +0900, Harry Yoo wrote: > On Thu, Feb 20, 2025 at 12:39:44PM +0900, Hyesoo Yu wrote: > > If a slab object is corrupted or an error occurs in its internal > > value, continuing after restoration may cause other side effects. > > At this point, it is difficult to debug because the problem occurred > > in the past. It is useful to use WARN() to catch errors at the point > > of issue because WARN() could trigger panic for system debugging when > > panic_on_warn is enabled. WARN() is added where to detect the error > > on slab_err and object_err. > > > > There are cases where slab_err is called before meaningful logs are > > printed. If the WARN() in slab_err cause a panic, these logs will not > > be printed. WARN() should called after these logs are printed. Thus > > slab_err() is splited to __slab_err that calls the WARN() and it is > > called after printing logs. > > > > Changes in v3: > > - move the WARN from slab_fix to slab_err, object_err to use WARN on > > all error reporting paths. > > > > Changes in v2: > > - Replace direct calling with BUG_ON with the use of WARN in slab_fix. > > > > Signed-off-by: Hyesoo Yu > > Change-Id: I90b2ea9ffc58e3826f7ae9f1a774bb48c2d43bf4 > > --- > > mm/slub.c | 31 +++++++++++++++++++------------ > > 1 file changed, 19 insertions(+), 12 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index de62fed12236..7f0583a71cda 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -5473,8 +5481,7 @@ static void free_partial(struct kmem_cache *s, struct kmem_cache_node *n) > > remove_partial(n, slab); > > list_add(&slab->slab_list, &discard); > > } else { > > - list_slab_objects(s, slab, > > - "Objects remaining in %s on __kmem_cache_shutdown()"); > > + list_slab_objects(s, slab); > > Could you remove WARN() in kmem_cache_destroy()? > > When a cache is destroyed with remaining objects, two WARNINGs being are > printed, one from list_slab_objects() and another from kmem_cache_destroy(). > The latter becomes redundant with this patch. > > The WARN() is added there because it's good to catch such an error. > At that time, slab_err() and object_err() did not call WARN(). > Thank you for reviewing the part I missed. I will remove the WARN in kmem_cache_destory(). Thanks, Regards. > > } > > } > > spin_unlock_irq(&n->list_lock); > > -- > > 2.28.0 > > > > -- > Cheers, > Harry > ------2jehmUjxW0Gkbg46_GefLyBaSre4jpBnLPH4I-DC_hWbz.jz=_12e179_ Content-Type: text/plain; charset="utf-8" ------2jehmUjxW0Gkbg46_GefLyBaSre4jpBnLPH4I-DC_hWbz.jz=_12e179_--