From: Brendan Jackman <jackmanb@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Brendan Jackman <jackmanb@google.com>,
Yosry Ahmed <yosry.ahmed@linux.dev>
Subject: [PATCH v2 0/2] mm/page_alloc: Some clarifications for migratetype fallback
Date: Mon, 24 Feb 2025 12:37:27 +0000 [thread overview]
Message-ID: <20250224-clarify-steal-v2-0-be24da656764@google.com> (raw)
A couple of patches to try and make the code easier to follow.
As discussed on the v1 thread [0] there are additional cleanups that can
be done here, but Johannes is already working on those. These ones are
just fiddling with the code to make it more readable, with no
behavioural change.
Note there's also a proposal from Vlastimil[1] to rework the interface
which is renamed here to should_claim_block(), I have not adopted that
suggestion yet but I could still be persuaded to do so.
[0] https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com
[1] https://lore.kernel.org/all/764394d9-592c-4d68-8910-67362dd8810a@suse.cz/#t
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
Changes in v2:
- Tweaked some naming
- Added clarifications of should_claim_block()
- Link to v1: https://lore.kernel.org/r/20250214-clarify-steal-v1-1-79dc5adf1b79@google.com
---
Brendan Jackman (2):
mm/page_alloc: Clarify terminology in migratetype fallback code
mm/page_alloc: Clarify should_claim_block() commentary
mm/compaction.c | 4 +--
mm/internal.h | 2 +-
mm/page_alloc.c | 88 ++++++++++++++++++++++++++++++---------------------------
3 files changed, 50 insertions(+), 44 deletions(-)
---
base-commit: 8df57ad4ed6209600ccd54db2357f75eb46408b6
change-id: 20250214-clarify-steal-f244880441c1
Best regards,
--
Brendan Jackman <jackmanb@google.com>
next reply other threads:[~2025-02-24 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 12:37 Brendan Jackman [this message]
2025-02-24 12:37 ` [PATCH v2 1/2] mm/page_alloc: Clarify terminology in migratetype fallback code Brendan Jackman
2025-02-24 18:42 ` Brendan Jackman
2025-02-25 11:05 ` Vlastimil Babka
2025-02-24 12:37 ` [PATCH v2 2/2] mm/page_alloc: Clarify should_claim_block() commentary Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224-clarify-steal-v2-0-be24da656764@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox