From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E1FC021B2 for ; Sun, 23 Feb 2025 01:44:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6513C6B007B; Sat, 22 Feb 2025 20:44:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 600B86B0082; Sat, 22 Feb 2025 20:44:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EFF96B0083; Sat, 22 Feb 2025 20:44:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2FE026B007B for ; Sat, 22 Feb 2025 20:44:32 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AFE881CC0D1 for ; Sun, 23 Feb 2025 01:44:31 +0000 (UTC) X-FDA: 83149514742.09.B9E9597 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 1140340002 for ; Sun, 23 Feb 2025 01:44:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XhUHO1zw; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740275070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ApJ1JaldxV6voGL1nuGoBPEXPk2EZQa92HcJ++oYOxc=; b=3zYq12CSFFyQdXmmNyhymg4bG0ocASTzA8NoGB6mB+MLxmqXvdVPpl1yeNiJL1zEwBoGOc M4z9cef2R1kLvf5bk2T9WmT8NaLzA3uaHrxHFZYAIqgZSywtuC64OjPKAuD1fxgtI9OZTq jkquI7mzWORugM+iWGEW3JYnvXKitJY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XhUHO1zw; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740275070; a=rsa-sha256; cv=none; b=D/d3oDIjp5ECP2+7msSmfJOuDfg+3yuuhJCVwpX/dvMK7CkQMf6UkV8tAuKX/tW1s5YcWY +JCCvcbBA/X5FnWNql0sPmKIMuvcx9ODMVEmwzBmix9Q+l07fxC45o7d6kn7h8fRa2XkGL Y+NDBJ2jd6yhWkL35feXTLpSc2aJH00= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F24E15C630A; Sun, 23 Feb 2025 01:43:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49605C4CED1; Sun, 23 Feb 2025 01:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1740275068; bh=zV/2J4qzn0ngZ2wEk4LuylyeLRI9omOQ83Y2xtt1JiE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XhUHO1zwWBMQxspln033yuiyHjIFQH8hwibGgaoOOjJV38X5Nj+DuAZvT8lFkvYL1 rwHFCIGkY0fiVt15cyz1WqSVi/gXLqhB9JgIk8/VNjzaIMdmxWgsS15ZVU9jWcyvDD CdDZvIofTkxYJ5fJOAY1m2eOBkxM0QDd9QfvUK2A= Date: Sat, 22 Feb 2025 17:44:27 -0800 From: Andrew Morton To: Kemeng Shi Cc: kasong@tencent.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] Some random fixes and cleanups to mm/swapfile.c Message-Id: <20250222174427.2f7d1df81853fa01fa92eacf@linux-foundation.org> In-Reply-To: <20250222160850.505274-1-shikemeng@huaweicloud.com> References: <20250222160850.505274-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: o6yd5jojbz3o8rp9ne5ox4p7bwxmfx8s X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1140340002 X-HE-Tag: 1740275069-860086 X-HE-Meta: U2FsdGVkX194xc3hZkr/X+szh/HbsvWaYVhd4NmL61yHdtkDBQQVCWSplhMIl4nTyvjVBvXzNHnZTSQK902de+OXDNSWGvCyqrn8jmgxxuZbtS6gZMaS2XJFPiBIcEnytzQTHJMzZZVwmdSmsTMzVQQrVFwAlE+eeo4isohPpRZygU0KUVBwqMlFy2ex+89ExKor4s+SN19g8Zned12LKVJSmO8MeHDg44FrNLDMWOQOmDXgbgyHH8HacQMdiH1OqmAJs/kw1ivF0HxjmTIlXVfsiqBKeMo3ySfDVgy/1rUGDTcO+zfYiqrQCr74s33zAoWlI8ZyvG32nwSr9nQWCaAgrxw5CIGv1WAhqnNCQBZyUwLj24qwQ64FrsJfwA6pQku1g+mOD2FK9cj9ZmyH/lJYc7Qg/t/u++PPZf8Y3snbmY96mhEFA38PMuObrnMv3RkjSmb86G1p/WKxr6EV22vBSbaHpOeCXrEvCfldGoNeBU4T8JHpyABSwXWM/ApFlVp7O0TIMkk9yjwK7Xna5AnWt5fftqFFJbVlGtoaDGOIEn6OdcRHxs7PVSRQn/SOBaDU7WGqTI4Nfg/hsvJ9kO7qlteN4Ll1IENHy5JUIVkBfvAewRBsSjEnR10rYAVkOjYfkv4ypvZ2BsAZcH8FPu86iHdMvQ4U4xdY3svizpicUMd8Yys/FLiEtvwNsnAJWzrZIghBF9d1rNrqEKSjW7rbc4KUlm+bE5pp62TmidYOXiIqVO20EEa4+hDixxMXjRS6YPxjhSXMoqRoezFjD0/uBYbX45DUgjhim9zQwLxpGJukhRmrBF4NYdfwpDKwqQMMY3IO+l3LJX4MmHy02xZGQdnyUiU6jfOMNlL6nfYtQQPKMEK1TB+0WSnzxcVCX3vLKp1GtDfOx686NiBL+OvotYTSZUmzAw67vJ5iFoni927v61+05JJ+jub8uhdm3jSxEKMhn0adf9RII4q fAGiLvUe eBKSAH2hOGyKZulP/IOMPSWEviJNuqKoWgci5MT0bXbtAFTr2onAJcyX/5DVSuVoBmRy39lD6cOZIVyRAdNuU69DxTzeZOaGpkSolM3umS8F4aaC9e421W+whb0/9M8dzkm7rVbukyg0UJgjFei/RouP3NPCkLx0N5Qv3nMGe+P5nsHZ6p5XrK7ua6aERio7eG6/ehW7MUQ5BHqYc+vkGRcmKxTjigEhsGG35UV5F8da0v3GMgqa8bGS5A2hCPPov9ljX4TmcJmMBuGgCt3vWw2x34w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 23 Feb 2025 00:08:44 +0800 Kemeng Shi wrote: > This series includes several random fixes and cleanups to the mm/swapfile.c > code. The issues were discovered during code review and can only manifest > under extremely rare and race-condition scenarios. Further details about > each fix can be found in the respective patches. Thanks for your > attention! Thanks. I queued the first three patches in mm-hotfixes-stable, as they address post-6.13 issues which should be addressed during this -rc cycle. I queued the other three patches for 6.15-rcX. I corrected the Fixes: hash in [2/6]. I made some changelog alterations, along the lines that Kairui mentioned. Please check the results and send along any alterations which you feel are desirable.