From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBA5C021B2 for ; Sat, 22 Feb 2025 16:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8086B007B; Sat, 22 Feb 2025 11:19:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 870BC6B0082; Sat, 22 Feb 2025 11:19:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7116D6B0083; Sat, 22 Feb 2025 11:19:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 53CD76B007B for ; Sat, 22 Feb 2025 11:19:41 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ED91F81815 for ; Sat, 22 Feb 2025 16:19:40 +0000 (UTC) X-FDA: 83148091320.20.D5B9E56 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf17.hostedemail.com (Postfix) with ESMTP id 80D8640012 for ; Sat, 22 Feb 2025 16:19:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=je+VGqDg; spf=pass (imf17.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740241179; a=rsa-sha256; cv=none; b=fIqJPw58B7QKDDmWgddwEaUvJmOfAYDiCLG42k8XBcHQ3WQPB4HNOkBGzUd/3KUo0SHW4E E+KhdsYFSGqpfSnUly2mig4H1fQUQXxfQtBOb/oDP0/qrpF22yqS3EtXJMDhKGuoYQhA1f akPp3sr9rFeDUYQoiGnmqjyLR7/xSVs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=je+VGqDg; spf=pass (imf17.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740241179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FNbNrHvrz0ro0BejSj3k8yFchTM6hYTC7mNMvo2ANJA=; b=a4Nbqxa31eI/BuatwgB1VFfZ2PhgDnlgcIlez9WRh00Cpe/BkvcPSaAHE6aEUJox/HVEcC baFxFdus7ouFolunYq+zRs1B5c5VtfNtsQoad9F2BqloIR6K7zoD6VZY+z9MaTjHBJSpjP p22cAU4QDhiXWaHWbYHL+IUtNXOarJ4= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A911940E01AD; Sat, 22 Feb 2025 16:19:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sLJ7bO-Z9SZM; Sat, 22 Feb 2025 16:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740241170; bh=3c6QLrQOPMg4gJUMnvvUhkC8BZW8S7qXs09rUpcW/W8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=je+VGqDgPUeJKKE+49xZd7iT3AI8eVDYVvU2BjhZ6xZ55sF1YWtjo55DS9fA2H5Ms WBHxh3A3Z0pz1QWtFCBG/M5dAvaZBk3LYHJMGEj60xS5WeqFVbdpTJpM2gW/BcFVxC ZzUcnDZBF+i/tyDEhzL8DFcdVRnkUGxXDhKvF2UF7sIiOeS2ouXgUO7iN9j4/Bbo3Y VD5UVFMFyZKS+y6e3bQgeo7xDiu1ywROr4twPPzYFoKeou4A0WmZLXRexGxmdTE7jW I4ttWCqHmzYXqYC1bytwSz3aq8irro63NDXkqVRnpYGFJyd86OH3B6RsTZO/MERYHZ JlI/Frm7G/2kCJbAQwtrKk9paIhk+GaBYwmfKebhZMiD/I2KI9hMjMXh4C+MsqSVsZ fZbPVNx8pYwMnfoBqBzXs2f6sOubVujKF6NqSXHs4j3l72kmfh5E3pFz9vW1C9mPed In10JgkKh3o6GlzjCqlFWX1KQx+Q6dl5g30y0m9/qk7vyIrtVT/uF8hCb8tQMTuYQG 87AL208rIUtPvwLgy+7aYc2zrE44EBeBYkaCp2GEXQ6/hp7e/pGeqqITt4Vd3owuhO o61TrvKn2JqUoVk4uJpBz3OlTOIB+Dz6dp2utYeyjllQkvnVgWdS3e9daD4drtSEmZ Zn0uA3GJfoPed3DLEvGy0KEU= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 60C6940E016E; Sat, 22 Feb 2025 16:19:13 +0000 (UTC) Date: Sat, 22 Feb 2025 17:19:08 +0100 From: Borislav Petkov To: Rik van Riel Cc: Oleksandr Natalenko , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com Subject: Re: [PATCH v12 00/16] AMD broadcast TLB invalidation Message-ID: <20250222161908.GDZ7n4_I-t2BSg52X4@fat_crate.local> References: <20250221005345.2156760-1-riel@surriel.com> <5861243.DvuYhMxLoT@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable X-Stat-Signature: u3nj8buuyat9s6ubpin13sh8ncs691ns X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 80D8640012 X-Rspam-User: X-HE-Tag: 1740241178-122626 X-HE-Meta: U2FsdGVkX1+maK84BHUXmum5rEvB607lA1Jvdnb6KqiMUoouaeljsm0M5Yjo3+MOh/9CagrV7DTTfh3yT1pobsu2MXBQg9ztKNklX87FpNWdyyXZH9GZyJM9KlmNK3YGH5AyUrg5e0Sbtz5VXceNyX9cTtddC+ll2AhwBfCo6gApyl0Vfa+EBXJsoGCHqDsrpOHm2cTm2Y2b8N2ZpzDuLHTQ5uBGIN5Pi2H1CK4yml2vPYk5XxYG3ptsEvOQB5htTflxKHH9mE3xThIt68QcYe+bnw89mgIcQL+2BYPrR0g31dkKZ727+IXMKQEK5iVIwqOogJXhwUouIEPvsvu5t5CcU7WU+zF8LDqxLhlwghInyUqm8HDAD2Bqg4RylymXBxlVmBAOxftPBYq3XNWc+P3iSSwg9I+4FPsJKqr/2zOVQ9lK/8Z0pWyiJCWHEpTrKtbT7SxGNTHatPLqBbrA5aWIYQSNuMaIoY+Z6iReTpUyxLHEkulKrbuyqT4yWs/DNL64l2dGQsPz1WgagB71u59byUZv1VwmWToSMq1IZPu1oQC/ZIzjBOfqFAyfYYdlbRZ34dWnPoSzzryvoaoFv7jn5Nh+vnoi5VBcjuNYRxcOu0ADwRAR/FTRh2q7s8O/wnZP4WMyoi+AcPRZ0cEmIBAEVofrJInzXtYZRZAFaVQ+z0pf/7ByZXbhDAdWxRAT8XCD/XidsJJ0s8ow6ws7sFwkmfz5Y8e/qxxBLY6aMMaDWcpoA200Fxm62uE0l3zl7viZi0pNApTmQ6+MPkd2oGbog92mrzz5HrrxW+vPAnTncVbjIhMFxAYLAffqm8b5lVsiiniEkUYWO1VJMcFfls2pma1tQtpjGM0VO7Z+AqQqs25Lbb38OCFVr7d6VsWH4U1GX0mDLlcdnT+ZiiK9W3grYmTxxpfr2xUUIPLHWAtLzxrOtog2PjkirqUpS2IC/BN/tR+HYhlJ76u/fBs QkAI+q6X CE+i12iqPGMYUoY/DYaY7+3/m+7ZeZdBBsCp4hl0umCIgWy1vAhHD6+/6QofLA2Qat+uOHWAaXj1Xal0/VVL5YzCD0H+qhW9okK2cr1GiC92Cxcn5fSQYqowgnRJ4gD0qmbvYJ5082QT4Agxl6/aU2F62pOfYYpTs45bjRjE7Av69wQjjpCwBH8K9IDK/CZnYbAAPyZB4TE9OIl2PV1UGQSUFNyWcZ4bLgwvnyy+ctn9NnnvzWQp9M1L2m0SUi2i25XCCgtaK+fcTt/ftZOa9ede2FlIhqc9js04qjB/KPfpKtK1yWGBZcbc0lxsAiqrT7naOt9oGSXnWTTiQyBHPRIgaxqu5HyZC0PspD5hC9aMpLwYfcAJhdheLjHFOvzuqyrWOL39jypVnHkpOQWYau4pxJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 22, 2025 at 11:05:41AM -0500, Rik van Riel wrote: > It's crashing when writing the value to the > invlpgb_count_max variable. >=20 > This would be because: > 1) invlpgb_count_max is marked __ro_after_init, making > it read-only after the system has finished booting, but > 2) get_cpu_cap gets run at resume and CPU hotplug time! Yet another side effect of us reading CPUID gazillion times. /facepalm. > Borislav, do you prefer I move the initialization of=C2=A0 > invlpgb_count_max back to where it was before, or get > rid of the __ro_after_init thing? You probably could move it back to where it was - cpu_detect_tlb_amd - an= d leave it __ro_after_init because cpu_detect_tlb() is run on the BSP only = so I'm guessing resume doesn't bootstrap that thing... Thx. --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette