From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F88C021B2 for ; Sat, 22 Feb 2025 15:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF306B0098; Sat, 22 Feb 2025 10:15:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 482576B0099; Sat, 22 Feb 2025 10:15:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33F776B009A; Sat, 22 Feb 2025 10:15:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 158906B0098 for ; Sat, 22 Feb 2025 10:15:35 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 78E2881705 for ; Sat, 22 Feb 2025 15:15:34 +0000 (UTC) X-FDA: 83147929788.14.F740873 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf24.hostedemail.com (Postfix) with ESMTP id C7C73180006 for ; Sat, 22 Feb 2025 15:15:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gTkn4MJG; spf=pass (imf24.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740237332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cTJMIaTjlPZCgro0ZmkHUDYw83lEG7eLOA5hCvlJiyc=; b=cGVVEBvV8WnYkYddDwQT4ji+O5zVyjwD253WlJhS34Rr6+P3DvS9q7XPElRt57CZb9gSxF 7rlauCvQJCZbDiOg2W61Xs2SiqMTvhESOSqqPTLPEvXaXVkNIrOFq9nzl0gcDU88p095rO NDaVLKWyhqFpgqqwtehYNGZpHw9hBqc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gTkn4MJG; spf=pass (imf24.hostedemail.com: domain of kees@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740237332; a=rsa-sha256; cv=none; b=QAEjrAkirlR++j4qaitipME89VAqMUQAJMlPlxtzpFoClsoDXd2zT3ngSc4r0jsbLlHZjk SKwep6Dn8+ljvr9iDFEEjPOAKdt4RUiYewd05BDRC+74dldqeUrlP1V80Qw6p5gySJt5GT ZSxCcBrXIgByKJsP+FOoVD7SOHcM7uA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 88A7361143; Sat, 22 Feb 2025 15:15:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0FF0C4CED1; Sat, 22 Feb 2025 15:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740237331; bh=sJrdFo5kUWwYj0rpinJ3eGq+yCAES26qMAIh9ssBxzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTkn4MJGpYwOtt6j6SRHE/mTp03KEyEK/OjJSG1ziLWqoPWuuej9YtU+Jo+q83r0B 5JVumBS6v8Ekwe//m4GrKTf8Jw0riW2vD+pcPi7XSaZpZrv8Ec0hSF2O6wWguDy3wJ RB/5ozFELdkJCUwlduTbpftDKtzlFZ7S5SteC5mCpkto0ONTEwRXkBRr/U1xKNri8z uwhL8QNNv4YAcvuvg1ZMikPPmFV2JFSCyscoU504ARiBA7k78UFse5y63g6xk6HYX8 nK0gdUgMr3IuQt+BquKciEROuycR4LVcONBcWBiIJlcqSk2zI3zXCdptO1yYBvGzdj IlKEk6YPSAo3g== Date: Sat, 22 Feb 2025 07:15:28 -0800 From: Kees Cook To: Brian Mak Cc: Linus Torvalds , Jan Kara , Michael Stapelberg , Christian Brauner , "Eric W. Biederman" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Oleg Nesterov , Alexander Viro Subject: Re: [PATCH v3] binfmt_elf: Dump smaller VMAs first in ELF cores Message-ID: <202502220712.D7B251910A@keescook> References: <036CD6AE-C560-4FC7-9B02-ADD08E380DC9@juniper.net> <20250218085407.61126-1-michael@stapelberg.de> <39FC2866-DFF3-43C9-9D40-E8FF30A218BD@juniper.net> <202502191134.CC80931AC9@keescook> <202502191731.16FBB1EB@keescook> <5870D095-D47F-447F-A079-B32D9C415124@juniper.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5870D095-D47F-447F-A079-B32D9C415124@juniper.net> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C7C73180006 X-Stat-Signature: htaqjeu4tjihnibuxafa1mkmihn3zy1q X-HE-Tag: 1740237332-470419 X-HE-Meta: U2FsdGVkX18YGEwgGqF0AINmBqiPSqhKvpnQfYnrg11l0jOrTrJysmye7Ut0RZ6Dw8GCknhcdZ8rZg/pYBv/AicoRXfk3y+sCp0c8vFj4FhO5gooNUmUBZ5OTwqwNFzhvvnpqv559go4fDBI1ds4vQcQXBxg5bCyESQBJGNafRbaa7ASMotYwY+zpj34NxqKekulYoHjohG/c5y5f53tszmSlUmM/ttWRnIhK5YmGdKdq96zvKRlDenIZhXSiFB7gYK68B31PBoI4k5kqDWkhzRjXqaimYspeOjwHX9cM/iLH9Lh86Tp5q1kKsoRsbBQymDCt62S4JJ6YZCiX3RICRwTHYRLgt5U5574EwntCbLlXLTbUsib6uW/F3W3b1x4iX1Xb73wG6xe+vDOmDx84811kg4WjC2tHp8K1rlDpEtY4H6ytsvbpgGjN5d4Z/NIjrOajhCWjwD2BlRs5JAYiD/2PsRsNhf1u9roXhgLMxFWO9inG7qTYhFzZAryJ2++XzUGqERMABj+vIYbLBDM58KRjIyMGe7q0VsQ20/9dM66ZqpSP/aHHp6VlbN01S2TLokuF1umLaoWH02Zsaymf5O91QTTI435Z4AyjuXXZKmHQrAMiUqfO+0bu/ntG0u7Lwal6fWr4j1WQsdMmexNNz5pq/xXsnny1AatAv4u9U2vFpxoOW49829ngJxLf7g3Z8u2hxHYu58CK0HGWNVJ5+BVt33snsNtzXfcxvZb25BY7p9+4268p7hcKr9wxwIO4uw5eS8cyHzZosUWGPlpryuZWj//RNXP011zq/xMQJPvaEudju9wjIHsFqjVRrjhLFzKmga6jqXzBt1j1gqQCUeWm9mM0CjerHYm1A9l4NLGSoLVBi0PVpRByxOWLJ58QoR09EYRY3aZLGeCnACxRYzk/zqnd9GjIlKDuD0IQd9eiwY8ZKzZHfUHg73ehI0zDqSkCEML16T0WiLhPGp QhEPGrBV 4zDKMsg49Nb240/4CVQFx7sbJFyEU7DWLfcM5tyKfJdPAz0HK2NW81KUI67Ic/DyGUYgmYIHcgsbKMf6JlcGC2RDVHS1xMXV6SPSi0k3Puyx0FLnzFjcIP0o4PNpzn1aXxYmVq8n7e0Em7sZkAARTVQ2f9fUpcbBmX/UaOuKWAFmFH6aYmgChTvg3idibz0NG/7WrT2HJBqnLpY5Lbw6v/VJIY8wJZzv/vktnWNwK/5yU/dU+gPUSuJ3MQ4Aa1NMn2GPXxEHGkcYopbH2fbVX+cyELR+tG9jpfDM1KYuQPT75j5Qd0dAaQVyfVZbKyaXNi2Vaj7TdQtjjrr5pUUzqCDqkxP6yEJNF6lOHMCTIgyNWB8M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 10:59:06PM +0000, Brian Mak wrote: > One thing we can do though is to iterate through the pages for all VMAs > and see if get_dump_page() returns NULL. Then, we use that information > to calculate a more accurate predicted core dump size. > > Patch is below. Thoughts? I've pushed this to -next for a few days of testing, and if it's all good, I'll send it to Linus next week for -rc5 (and -stable). https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-linus/execve&id=ff41385709f01519a97379ce7671ee4e91e301e1 -Kees -- Kees Cook