From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4407C021AA for ; Fri, 21 Feb 2025 13:12:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C87828000B; Fri, 21 Feb 2025 08:12:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35088280009; Fri, 21 Feb 2025 08:12:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17CBC28000B; Fri, 21 Feb 2025 08:12:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E9599280009 for ; Fri, 21 Feb 2025 08:12:22 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B0469160FF5 for ; Fri, 21 Feb 2025 13:12:22 +0000 (UTC) X-FDA: 83143990524.09.65B26E6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id BDA1620003 for ; Fri, 21 Feb 2025 13:12:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tyXONUDb; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740143541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OR8DwdxL5JIpqvSc4DzY3clLfCwA0cwOCo9j302e9Ck=; b=qq0Et1NHHG5AI3Orh65MiScawM0TlIdOCIXQKYLFVBkQiUHOINXhZidk+ym1zyni/9pWTV +wX7rtUp1ZAihZzXIHqn2L+iXSnmjc2nuOn40HDeRL46kHBvwEpBNb8N/h/HG2DPsqpIiS 3q7mbT+Q1gZt/pyR8/3PX8pa9emJBNE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tyXONUDb; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740143541; a=rsa-sha256; cv=none; b=0jcCWZsdgWZWZYuQuExnpsgZ7ucdCSxcWcv9QARL/m7LAriYm9pnhNTATNyc0DxyQpkYp3 15e3wdyIvKzq2bv/daeacJTmUi1g4CnnvBFh1CtSoJfimIHcYQ4K78zPlkffeI6FujOElK L3a3fznrmP5Fs7ALgAJST0Dnqg42r3M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D46C95C5698; Fri, 21 Feb 2025 13:11:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FF81C4CED6; Fri, 21 Feb 2025 13:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740143539; bh=OaIEfRGrNHujGIM2xLDrlaaE7zfxvSiYKjihwGmoU78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tyXONUDbGQ78MxsudewWlzaPrGsFnl2q/eB10uxmLxkUWIEIPE62xYNKYKKcUGAhr RPQvR4591QqFmp/SBvlWCc55VgxYql2SEwFsM+Ss8aba8JFiNjATNYZ43c6E0SVGDQ WgAk6f+2vY/eqZV/Iie1hLQLtLIh5+agINDhu+wU= Date: Fri, 21 Feb 2025 14:12:16 +0100 From: Greg Kroah-Hartman To: Zijun Hu Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs Message-ID: <2025022145-ungodly-hanky-499e@gregkh> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> X-Rspam-User: X-Rspamd-Queue-Id: BDA1620003 X-Stat-Signature: a7kjzingwwbix8p1uei8t8wtbn6tyqon X-Rspamd-Server: rspam03 X-HE-Tag: 1740143540-743258 X-HE-Meta: U2FsdGVkX1+RYcOSNoBCnEmoF8o/j9PLzsXhd4kpzYOOIc/sQ1+X3EG9czisDAssgqQSXzWGbwDeKdWxS+NPz+S+47mNS3Et6wpjqeLZT19oxg233aN5LW2wJBJMQLPX8vVkCrXjj5GWgKO6cskX0zcUNo/l2JtlYQmEQ7gQ7pcbR3tZ2XBrcLAXi2iwp/Y2cx5SfS/bT7Bhycxvi96TXWMGymqhus1458VfdFU7fmyN5EQ42twPuMtyanO/neJhCP/a+6ACFY5J2AR7Gy6wcRlyjq5RiTeQv1vuTEdzSdRG5JFDJrIwM2Dc62qzXOoDmD4AkikXBRHiINGgO274ds/TEVO7g5y8bIguFkCr+glIy0EbqYIxLKodeSzcRh11RYd88EPAP5f4br0HGGLORDwfG5Q+Gi7k1djmbzSbqfg1mNYii4Kz89LZjZyB/3tJn1iPXcG1ASbt7kZENp2VDD2JK49kdK2+Sm1PkalKDemKLLKXTyNd9owVfsK4nPKrZxPbGW/zGxzLQNHd4JA83T1yVfOJt8SD7aHtzSn+oqLBJ57iw2Mx2nS7k82Yb53LtCnTtoMgNZJkiMoBlUk7HW1eumik/OTOkewTVRHuxyCr6x2e6ZfbgFLl4Dzt3Ftr8JVKJks4Nt8kbh6lJsHHs9Y1hdAuW038YM2+vGWey1CIW4gzyCHhr4dHg7B0Fo1qIDpOdPXMT+4SrHM+C/deBJ7DT35bzsgYjo4A7wQ2o2Wz0Sw1G1s3+8WjLEFTd1peeMF2BTmcMrL1cWwLN7CWYrHUKUz2rGMP1+LmAYCQ1Me7qAp/kHbp9S/EYPmCTW4+e8SVLd3RVC7wDjMIoaeS91//vxs7gE8kWEskVoIeRGY+Jln6cS+IzbC34Au9UX6T+u6uAeGAwdNTXgcR4GKk1EB4V9c9IaXC7PliKoely/qgF1ODfYTvjlB7mWkOoaAwx6wKDWcQKN6VH2tL7Hd uzHGq07s ALQXFqIx2r0r/z/y4ya1xMpBRI4HXOjueWPru5rOl7DwSSON59wOWF1noNXqovkyl2vCX9ZETqFim9eZOvj+89WFV1VmG/SO5H6WJHDwBvYvsNQSffp+tTUP2i8cwN9IDgb63Ulewt/+P6qNozb8epNoZijBNOCEauKZ/ccIzC1aX9ZQKmoYWl0e/EgAusNm0v08rPgVu48Cse586tbB5jyEvjdgPGqn9FO9rlIwr9XIfNnU6GhzJ/P9BdbZMX+NXPf9DBVK3JChDEhjRDLZRM9tPXR0WCaditSmaBwC2ls3ZticyQYvdrIdnXH+0nAZdGlTdEPisVkOyPwq52qNq+yNI03dWsr8VfZ9ZJmK8XvMpXkd/pWyvFfviiPhM8qwLhWzY5EvAGmzvbPBJi9OdP2uKzp7XQyn1VnEQY9H6IZC/hM6JvzS2EMi0OrkMGVNesvXWYKXY7C9POis= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 05:02:05AM -0800, Zijun Hu wrote: > This patch series is to remove weird and needless 'return' for > void APIs under include/ with the following pattern: > > api_header.h: > > void api_func_a(...); > > static inline void api_func_b(...) > { > return api_func_a(...); > } > > Remove the needless 'return' in api_func_b(). > > Signed-off-by: Zijun Hu > --- > Zijun Hu (18): > mm/mmu_gather: Remove needless return in void API tlb_remove_page() > cpu: Remove needless return in void API suspend_enable_secondary_cpus() > crypto: api - Remove needless return in void API crypto_free_tfm() > crypto: scomp - Remove needless return in void API crypto_scomp_free_ctx() > sysfs: Remove needless return in void API sysfs_enable_ns() > skbuff: Remove needless return in void API consume_skb() > wifi: mac80211: Remove needless return in void API _ieee80211_hw_set() > net: sched: Remove needless return in void API qdisc_watchdog_schedule_ns() > ipv4/igmp: Remove needless return in void API ip_mc_dec_group() > IB/rdmavt: Remove needless return in void API rvt_mod_retry_timer() > ratelimit: Remove needless return in void API ratelimit_default_init() > siox: Remove needless return in void API siox_driver_unregister() > gpiolib: Remove needless return in two void APIs > PM: wakeup: Remove needless return in three void APIs > mfd: db8500-prcmu: Remove needless return in three void APIs > rhashtable: Remove needless return in three void APIs > dma-mapping: Remove needless return in five void APIs > mtd: nand: Do not return void function in void function These span loads of different subsystems, please just submit them all to the different subsystems directly, not as one big patch series which none of us could take individually. thanks, greg k-h