From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA13C021B3 for ; Fri, 21 Feb 2025 20:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E75B6B008A; Fri, 21 Feb 2025 15:02:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 497996B008C; Fri, 21 Feb 2025 15:02:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35F0D6B0092; Fri, 21 Feb 2025 15:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 17C296B008A for ; Fri, 21 Feb 2025 15:02:11 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BCD521A0316 for ; Fri, 21 Feb 2025 20:02:10 +0000 (UTC) X-FDA: 83145023220.05.1679F8B Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf16.hostedemail.com (Postfix) with ESMTP id 9AD87180034 for ; Fri, 21 Feb 2025 20:02:07 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=UteSg52R; spf=none (imf16.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740168129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7gGBaRe4JgYzbdGSQQDl/iu7LJKLfKjaa+/NCZsQ+Ao=; b=LZ4hEIXCyFVc0P6dcca0ZzOb2anVE+9mpE88Uct0Ud6gjXLEvsLH8KLY5lxmL+eY4mqzCB +YmqRNMrCu3fdp+BfJMTUXQ5Ugmxe3/spbjCvAYehApqPU5nY9erHlVcMc01y03bIVzvHO ijNDyKN0ViGpnG6V3NTlk2fLmyUjBQ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740168129; a=rsa-sha256; cv=none; b=vICY+EFrsdexQgA67sQIcHIL2suPkoXO1HJuFW2v64syXRRcFzl6IrZMQoMRBWEWP1fslB QVXXu8Gvr1xKR4jBWTY7hBUiIPJYveD1H5OIAdDPi7PMC3UseUiTmpKbfKK0XttCXPvVJ+ K0uSvwCqt9tHqrLSRvpj8kLr4D3Ug80= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=UteSg52R; spf=none (imf16.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7gGBaRe4JgYzbdGSQQDl/iu7LJKLfKjaa+/NCZsQ+Ao=; b=UteSg52R0cyjvV7m5TTbonCM1h nNaAO3jaW9OJTFD62ZSqIMkpbxkqDB1DnXGCDq1E9j76theeavHA/RRU5cr9Ld3y9wfjpXqbzl6ny StfdLe4oNTNBs7AUNYsLHfvw/kaINS1IKRZ1sucXhgJkMsTs/iy5t0nieQstbQpmCN/ql5vASIsCB garNWnx82z7wKP48scb0FcUXdE8h/CiJr7AzuSeezFGNc+OEyw6P8aofPitbVwLiEyPVPm69UbSh3 xtKeubLPCtDZQLsl/R9x4n93qUl1H2Gyc9cbQjUEI73Ffxu18HzmEy3NN4RJTxgXH80wZWZPvSf6f vY9JATuw==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tlZDO-00000002in9-0hY9; Fri, 21 Feb 2025 20:01:38 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 48E7130066A; Fri, 21 Feb 2025 21:01:37 +0100 (CET) Date: Fri, 21 Feb 2025 21:01:37 +0100 From: Peter Zijlstra To: Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() Message-ID: <20250221200137.GH7373@noisy.programming.kicks-ass.net> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> X-Rspam-User: X-Rspamd-Queue-Id: 9AD87180034 X-Rspamd-Server: rspam07 X-Stat-Signature: 31ey7mfm54erzy1fisbghbqy98s5q81d X-HE-Tag: 1740168127-794691 X-HE-Meta: U2FsdGVkX1+M19HQfMQRFGitXpcMNslltbHSdPzwpMq26aFJwijQc5v3bpdl7s8vyr37DNFRQnJXN8W6e+Dkxg2ZUqrUrbIfqXvhjrBynYA26XAMz/PF6+dK0SNktZzZ47UMtOkzEERyzli2Rk+pC4pckyCYCb3wViQQjejj41ry7ZN/skFbKOAWtDg7lFS7GCZ+u+tBo8Nztp4uvCmQb4qj1eYuaRZAlITuZuL9i4i3W3GGrk2C4iyyi0ZdXt/2+dL/rKw5eAjVKiAGrJ4M6wwhTl0Z+Cqb5mOQmIBXtS15bDy88PTfKcRmJ3BnXxmkSN/jN2dMACQQ9bDC4kd5WV06TpR0yDPepQUHSuPoXM/mHT4rHBogVPbuUL7uz4FnUq6/u/Lvu/R9uNCyJONBAQUi7WxZg2nJbhoIz6eRJN/lm7273i9pfGHPv+znjyArmdqWRij8em3Twicnw+Qr7Wick8A0mzqV0bI2kZoNG7e/mmXsCWQOvgjGGWmeysMlk9fgVBe33AO0rwNVpa7Z914DfDsQivhWC49CSqgV6I9kwMouKoNbTlTXkkjVfUEa1b139Bs7uw7q4OZ4AlxYR+sIcuD0jPozjLhV8hLTjy22oJGdeNGqKQ5ZKh8rR5yI2lXfcYhpZP/Va+WKeFyqLrK7rHpRc7KtUQjpJPXhtuEoGjwBPjhfD0ta90NDH8TcxlTSDJx9/lNxcis/PWDfjK3oLlPNWbNgQJ/bK5Y7fKjQXYa4YHs7zxuA7kjnb1mKxvIdF7qTj7EpKgstcTVoi3OrT47MB3ATVxy+yWm8gOnTvMq0GubDktY+XG+ZVYTu646vixDXDY+igoVCX+ZK1zeX21VySCSkSh9CSTwmSY4xZjf3gYm/XNUAI1wu8aAk/VswIHOVX0hNyvTi6z4wzQs2xT1pWTsaOjjCFhFSQWowyZ2WFMfsUXepxi7ePAXs3VJ8X2rNSBJZgh6QWAS IPAqQWE0 xK9do33yClmGobijxwkqAL4e1kcqXtCB5wdNd7dievyamYbQOPpbVrYIrbscuS0lBsHhfqMGYemjW4QEtlgUn15Be0w3OCrBFavKMe6gPxkXK3qcljr/xNCE7CyYOr6uYAaQ6wx8fyjbF47+8kuhYVpyZ6Q/8mmOOxqCJZP/HzfdU8dhe5m1stWC9OMTDmcrnU65tobltUSo2jIyvZsMsv/R1+zpxqw3l6k0AP90Rtgio7gXxCd0DeWAG1eORjbRNRlKyZOy2znvfGxkA6Bg618Iq7vncLoDbyL9Sph0AtrI13DPntLvRoJWuXCa7QJ21MXh2cvbb8lUDH49r+mC6HfDIw2+keriyLck7CJjIt09pZcgOnu3DHzHdDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 21, 2025 at 05:02:06AM -0800, Zijun Hu wrote: > Remove needless 'return' in void API tlb_remove_page() since both the > API and tlb_remove_page_size() are void functions. > > Signed-off-by: Zijun Hu > --- > include/asm-generic/tlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index e402aef79c93..812110813b84 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -501,7 +501,7 @@ static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb, > */ > static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) > { > - return tlb_remove_page_size(tlb, page, PAGE_SIZE); > + tlb_remove_page_size(tlb, page, PAGE_SIZE); > } So I don't mind removing it, but note that that return enforces tlb_remove_page_size() has void return type. It might not be your preferred coding style, but it is not completely pointless.