From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716BCC021B3 for ; Fri, 21 Feb 2025 15:35:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0694428000A; Fri, 21 Feb 2025 10:35:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F36E8280001; Fri, 21 Feb 2025 10:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAF0028000A; Fri, 21 Feb 2025 10:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B7FE6280001 for ; Fri, 21 Feb 2025 10:35:15 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73A5E16175D for ; Fri, 21 Feb 2025 15:35:15 +0000 (UTC) X-FDA: 83144350590.16.53B3AFE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id A84361C0002 for ; Fri, 21 Feb 2025 15:35:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OJgfNl3S; spf=pass (imf21.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740152113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rjn/XsdELQyVcH/LFgFRj5wTVV97SpqSwpexgK7vwaw=; b=Db/VLFtCj8n+7y0+UG2EXbUpjpCmEeZ/CTvZ1WvIk7GuyXP8zBg4Zr9E+Z11izE1ftD0cV 0RsOKXdsQRy345dM5wVCC1OduIHKmtJh1jV0+ooKbO7AMGOQXZAltmMuV1ZTthX7FPloDl BluAC5z/fzDFlKEYC37Y6KB/p5vfIdY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OJgfNl3S; spf=pass (imf21.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740152113; a=rsa-sha256; cv=none; b=k7AvfN2T6KAzI/N1yZzXSEFRoVhzonP2a60ASVYTFg7EzMxWhKc1GQySmKdujdRkU59juO CbhO26h8UEeWDvVU9EfEF5ZtQf04UjD0GHJDmNqYiTlvcOV0Ns1edmmBGBjgkiaDB39+lt wwFw+w+pDCzSq82+prdiIcD3atb+j0c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 723CC5C6618; Fri, 21 Feb 2025 15:34:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F23FBC4CEE2; Fri, 21 Feb 2025 15:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740152112; bh=HFbveIpxBrHCezKac0bPWSUzZSYqbqkw6nidRl1Irxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJgfNl3Sv/k0lydbFfAJYgv48UkwUsory7TtVR7CJC2KaUy1qnINNOVZQNyroUwIo 4gCbF80U7wG3xjOoA3a1x0W/aaCPasW6C15q+rv2vkLFXGQH0Jzc7R80BrLAkfil4g bAlfxN3obgLbfIXOYbxTU31OZYYfTXK23XDduDlCRAlEDywHoSsO80l97q2axSx/5v Gk9K9uj/rYb/+c2amOJzh9MoOnkEWIyXezml8hqnqxtzH6JYiyraS0sY9KukmdnohL vq6LFXxcDtuPVqarCPx8m2IKzBaHcDfxVxJ1eloXdL/smXMkl4LII1kc0fSgYGSASY 5WeNkluJ8/1xA== Date: Fri, 21 Feb 2025 15:35:02 +0000 From: Will Deacon To: Catalin Marinas Cc: Ryan Roberts , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Andreas Larsson , Arnd Bergmann , Muchun Song , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Dev Jain , Kevin Brodsky , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Fixes for hugetlb and vmalloc on arm64 Message-ID: <20250221153501.GD20567@willie-the-truck> References: <20250217140419.1702389-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A84361C0002 X-Stat-Signature: jypf3jmy7fyjafkgpm1x184ok7rpsq8n X-HE-Tag: 1740152113-387883 X-HE-Meta: U2FsdGVkX18rmCSjlZIIIAIPHdY6JatM4yHujbYqOtzBME28HxWAGpxIxa6s5XHi/Oru1w5cUewblykDdeHd/ZmBsfEESljVuhPcPYOEs2++V4tosp5FkSmPJDfKX3pwVjJ9L2fv5deIITVM8lzbLU5rIzSmx85UQQO7TqOlDXDPpCxPKJruhIl9q+f8XGBRrtZ9dxRSQwIKAV4kNY443AD44y6FllgXTUKxTeYjfmuL9n4hYXMxkDbWejJoMRkXxkxNgejvdn8se1R5ZW0WEl7Vxna1Qpt1QMh9Vlvj/UzcG+29Edb83rNLWpKyfHhzL4XiXGj52rnegy2y4TukdU3tWHkBNcR0fdhkKuxwKkbZDPjIekYHLPGa0P2X8CGphZUoTVnroWRARaJUm6wiKYL/suOSNyRx+/bb/Y9fWe18qlLxq/WPJqsQADGQqF21RFV0vM5fLcF3qD9Cwmvr54gqEMq4GPMDWBS2WQ0z4NZcsit4bTsIrUh7leEvQmOS8ZYz6pv6s8XWTQOmCbDOv5KpSYN1uzFcyLckc1IEqnNjTcCNZ3XJ2pylsx2+zE0C8OLuEQNxKqT3EZ/LeNfMs+pgf33U7u0//hhMpz6eTRfxNQdyLu7G+JLMX/0YjXwFmLROg6avRdWVKe/h1M8fVNLw4nttTe/xe1DEXQhlhcMTAE9WUxz/JXTFGjTlWnRVm5KPmMOq2gRogeATsvZRZhIJb+fpTqfUyb8vdbiJyVzVw89BGou6jL8Jbf0X0eN8RGoZlvQz/ivTjLsSCxc0J2y3keTc3CO9H0Kl4ttmxcYFUegRNpUljurXk6Fnzp0ops7rgjJVpq8FcpWFiLIcqOHthhmptVK1c+/UBLfO1pQeqLxDucIVkJygEiEwT5KkFIPqQqFH0O4g8dpvnGCVeBXfgphWLFuE+SE0TQbfO1eMLrFeyx/ktLVohss9FgpJvsn00LmlmZB/UEo2bjK UDBMngsM KXv0Sbsbwb4jLS7kBDgc8JitFk9aYf3KOgNg319C2LSLWmtaMBEkl6qv3E7QbCYvGQEnCziv3htN70tmyHjyi3OWUNXERci7PENu5GXdlmDKBUnG9quzJuq/eI/RNYiHAuR9pW3elF6rG2KZtRgTPwzseG6xH4FzAjzRbj0n0PQ3FkNrzAR6vKeGcy45FTLsyeHH4YnZ6BtZe4AA0FWZGHKzqNDQnuaOGKrYi6q2gtYA84zvW2Pp7398HKHttDL6iaTT9Bc95S3w7UpzognBSIS0S5oRavMvw3xQWQpZp/cTv5wk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 07:10:32PM +0000, Catalin Marinas wrote: > Will, Ryan, > > On Mon, Feb 17, 2025 at 02:04:13PM +0000, Ryan Roberts wrote: > > This series contains some fixes for hugetlb on arm64, and is split out from v1 > > of a wider series at [1]. While the last patch is technically targetting core-mm > > and is not directly related to arm64, I'd like to to go via the arm64 tree so > > that the wider performance improvement series (v2 to be posted shortly) that > > depends on this series doesn't have to be robust to the fix not being present. > > > > I've included maintainers/reviewers for all the arches that are (trivially) > > touched due to the API changes, hoping for some ACKs. > > These fixes look fine to me and I think we should get them in for 6.14. > I think Andrew was ok with them going in via the arm64 tree: > > https://lore.kernel.org/linux-arm-kernel/20250205235219.3c3a4b968087d1386d708b04@linux-foundation.org/ I think the diffstat looks worse than it really is, as the arch changes are reasonably mechanical. I'd like to let it sit in next for a few days though, so I'll pick this up once we've resolved my comment on patch #2. Ryan -- did you find all of these issues by inspection, or are you aware of anybody hitting them in practice? Will