From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B987EC021B3 for ; Fri, 21 Feb 2025 15:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 482BE6B007B; Fri, 21 Feb 2025 10:29:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 432E66B0082; Fri, 21 Feb 2025 10:29:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D3576B0083; Fri, 21 Feb 2025 10:29:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0E0A56B007B for ; Fri, 21 Feb 2025 10:29:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B22CCC15E6 for ; Fri, 21 Feb 2025 15:29:34 +0000 (UTC) X-FDA: 83144336268.23.31C6E0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 8D6B1160019 for ; Fri, 21 Feb 2025 15:29:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y8HgpHKR; spf=pass (imf08.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740151772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ic1/uViOEImLUfOGxnGRSWveOc6wET399Ae2ZdSNHEc=; b=fRRPm0hts0IPlVftq3I+fZYudoDykGq8JybTKWLYRbnlgof7sfVuSc0kre3psRiZxG/iy6 aELt8zRKANjQIfuWX95kc5FyDpah3I+3KBKC+PlHxJ9ZXX1gaX+I4XeT5pGyIsDsJxY51V rZwgnk9AxH43PSX/OZtOymIGNpa8SXk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y8HgpHKR; spf=pass (imf08.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740151772; a=rsa-sha256; cv=none; b=ttkNJN+0ZFmJtzNpbJE1wX/ouAZmwXbuSovYabeo60cqCTle9Vootnc1QFgg+dVnHP4Up2 FDOwOv6hbRFr64pC754CWAU+sgGQhsIhCv41atPUy8CuQlif2bNbgKTgB15b2zVsmIfU4F deTYBY8U0aGfEcRi4j89cfLHsI+6iO4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740151771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ic1/uViOEImLUfOGxnGRSWveOc6wET399Ae2ZdSNHEc=; b=Y8HgpHKRmCWc+a8mgo+FjSVJGsYOshQWKTsIQWuP8DE8MzASpFuWzv80virxRiMWEw5jQn DW6HPP9TLFKx6phNLFKX2sLWZBZyHcaexh5rkWjg2/7eMHM03agL82tDKZV1R8lxiWlFpd Dh4/tsgoarH4pgyjcE27MqiCw2UVix0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-W3hhLAD0P8O_s-BkpsjBfQ-1; Fri, 21 Feb 2025 10:29:25 -0500 X-MC-Unique: W3hhLAD0P8O_s-BkpsjBfQ-1 X-Mimecast-MFC-AGG-ID: W3hhLAD0P8O_s-BkpsjBfQ_1740151763 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2F6619373D8; Fri, 21 Feb 2025 15:29:20 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.97]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 3BE231800943; Fri, 21 Feb 2025 15:29:11 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 21 Feb 2025 16:28:51 +0100 (CET) Date: Fri, 21 Feb 2025 16:28:41 +0100 From: Oleg Nesterov To: Tong Tiangen Cc: David Hildenbrand , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Peter Xu , Ian Rogers , Adrian Hunter , "Liang, Kan" , Masami Hiramatsu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org, wangkefeng.wang@huawei.com, Guohanjun Subject: Re: [PATCH -next v2] uprobes: fix two zero old_folio bugs in __replace_page() Message-ID: <20250221152841.GA24705@redhat.com> References: <20250221015056.1269344-1-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250221015056.1269344-1-tongtiangen@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8D6B1160019 X-Stat-Signature: jfiuox6z6k8eut3fsgojrdnht3xhh6mp X-HE-Tag: 1740151772-759611 X-HE-Meta: U2FsdGVkX1+kC0gMv94TVUxoziSEh+oMe9ix+uTIArA/fZOHcWOKJzdxMbllngAE7lY/OTDUtOBwBFf6gKlxyUZ7AGL15zTD4z15lPwDJGP/7a+//QUVRxUhiEOpX0mlvJtRVCqG2SpiI0Bwkx9PgJyufYVN2p63mUIZsQAUQsZFDEccjqEgoR0o+bGGP/qFPc3O0z3zjCgsFooZbZVRIpDalvDzSeul7XIcjqBluuCkYC8hS1mAQLG8YDLpL0DEM3FS8d6advBcvNL2zmmy0lRTCsgi23Yweo6h/jisVknhlx+MZhqghLsjTP/4LGopeAJvVJ1iH6pGxuOfFQmzoET5JJYCcG5SC9bAOlXS2gf7/bM3yEvK19MwjPwWtCO5GpPdUNbyRSD1XsxlhynWRBpRLP76clznbrJeQhFfeShTSPuJ61OpS84CWn2qXjX46ECrZe5DwmTbnp8DkApqR/jExd/dBooS3jG5siCsqcmqJ/nhn2pZfL4+z7V7U36LNMh7viRxCwhIhlcKz9Ir7r1Mvn7eJayWp3Sj4uexkAu5Fnhiyv5FA7F9yr69gawAlXNIis/6vBIRFxMSgul9eDUESYrzOeY2E/PfYhTFmNvzHZCtDf2VLGOx6oJbcAbjcdz+vtK14z884CtT4ESleDnWm0CdhuAmHeioIZILNUQoNBvtmK6fDOX4xy0qzrVJEfgO+68FeReCvnLeEz6Y2hs/2Y9bgx3/jbBtBgyDN6CjuNiEsglqJyQL9yWWSoOUst1jwTQ0PMjJR055JJPfUVl0JyNSnqM0n7IH9SIB2dTmFMDiKhm3QVV3VnjXwZrTCvOuKRRD8UcT1nSTymhUGfFkYgi0nRVh1Mwn2oKyvbiTNiqDLoM4yBv6TVN3+9YatRXG0VKdC+9BBQsMrSvEk0eJvlglN93WyYSy3jSzQwiXS48GL/XXtq8c3jPP9EZxMIEg+7ASHNmNN/EGkq8 C2hQBLg6 wvdUkJsxXikv3hpwaZOCp6W6VLe7Q4CmlyQZwEs9228SgvO3sf7d5MuVa6gy/3zJ5E8zQLpMtS5o94hedT9R21ng/le26OdWPsQenp44fgCQTx/pvDmNUC66nHmQsO1hxUJFzStsIAPHGcsQ/Ws6dzACzbElI5B3XggNsy7LHfLQRfyW17hLoDQn11g8/FKqxwoZ77Eivq61BIQiujxE43jm1L4TtTkM4Im7Hcu6B1z4hoZXadttLG/+YuFwFwLguqLU0cn0Wke+fJPDQ88akThC2viYBTl6C3qixZ7GD8JR8n/KTmnrCNXbTq/kcWsp2mhFoTykTaxyP9kxy9dsyH636yAd2gyzLsz6BXytEVbXe+7g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000635, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/21, Tong Tiangen wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -506,6 +506,11 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, > if (ret <= 0) > goto put_old; > > + if (is_zero_page(old_page)) { > + ret = -EINVAL; > + goto put_old; > + } I agree with David, the subject looks a bit misleading. And. I won't insist, this is cosmetic, but if you send V2 please consider moving the "verify_opcode()" check down, after the is_zero_page/PageCompound checks. Oleg.