From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BC6C021B5 for ; Fri, 21 Feb 2025 19:00:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DD4E28000C; Fri, 21 Feb 2025 14:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88DB328000A; Fri, 21 Feb 2025 14:00:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7552828000C; Fri, 21 Feb 2025 14:00:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5926028000A for ; Fri, 21 Feb 2025 14:00:50 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0CED162035 for ; Fri, 21 Feb 2025 19:00:49 +0000 (UTC) X-FDA: 83144868618.05.9AE6EB4 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf24.hostedemail.com (Postfix) with ESMTP id AE6CA180034 for ; Fri, 21 Feb 2025 19:00:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=CRoOkLGU; spf=pass (imf24.hostedemail.com: domain of stephen@networkplumber.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=stephen@networkplumber.org; dmarc=pass (policy=quarantine) header.from=networkplumber.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740164448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=77hh0wQ+sFBBrkK6MEd/a6yvUwrcItGhllYO30mC8s0=; b=R91N+erEMqkL223NQqxmSSZ6LW2vwZAdX15m5wAjopr3e91IdFjVfcFaO+OG5w4kJ7hPjD allOWVum053zFlifEKlu7V3dlEWsZovtJ+f0kYy6QgG/QybyuIWTiNvtZChO2ou4rULEex 6aaEgLeNxWnPjS73LqeA3MBIwKIP9Vk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=CRoOkLGU; spf=pass (imf24.hostedemail.com: domain of stephen@networkplumber.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=stephen@networkplumber.org; dmarc=pass (policy=quarantine) header.from=networkplumber.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740164448; a=rsa-sha256; cv=none; b=6AIcwnidjXnCSuIdQa5tQ+2eZ8fXNC/MHjd2JfvurQnD28jMGzV1Vjcq9E1Z6HXls0TxQE NtHF5cUAJwTPsswUT6UNbDNsig7W3f8mHgbYUCtKdzi4q23kzmiq04yV3ZHwIYHO+WtnIk WxqPVikYJdjN1icvjGSwoukgEQVmdt8= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-220d601886fso38575035ad.1 for ; Fri, 21 Feb 2025 11:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1740164445; x=1740769245; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=77hh0wQ+sFBBrkK6MEd/a6yvUwrcItGhllYO30mC8s0=; b=CRoOkLGUDK980cPUh5GCxzvV+6HObeAy7JEDaRDZDHuoV3sTdt+VHO9BBf6cK5vf29 XJsv0Hj6cZiJGOJjKdCag9z74xk1sj2XyeQGTKKdk+YmPT5D29Pf1yu+kK5vaues4oYI 2US0aPV1TXjG/4cB5AQsv9df8ctwVmZjG+Da9CKqES2EAvtQltVyxLpa2uRg2+iDdZa9 rWKj2B0PILMLWQaudVNaxgNmDSDx/ZgFPxCRUFinLCu2LM2I+urRdJzC8Hj3pSdM9ipn ozfUVY5Z96eIuWOz4ZZdLm1+CnIlEICk+tlli/DWoZ4A6dv5VGrkN7I0QG7dZtNlHx0F DLSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740164445; x=1740769245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=77hh0wQ+sFBBrkK6MEd/a6yvUwrcItGhllYO30mC8s0=; b=f+YoBOiDKY0rI8iDqzN0TQrRIDKwXOtCBGHwL0Rfz/SgGrfpYLiydXYefsOuT8xRR0 Y3OsrWVumYL/8Aa9GjoFw0pExymi1mpe8Hh5KJGQZLe2Hzee0hCnlLCySX9RHyv8UWO8 CP/s/7jw+gcmhH7FV2N0pHNQ30Yz4vIWQzVA9Ci25xUGpZcr1Fd9vHb7YSl4LVMo/1o8 9OaqNzHQ1Sg4XTRen/7FX5zC9e/yvfIovjq0s2O0PVNsOhWpKM2awUmBZcpMlJCS8lsC EP8lwO18I7fXxn4Dvv4ygw04d3VsXYrfqb2YI+FTK/2qYYMJ8tow4MmNSFllY8yveGgp 69dw== X-Forwarded-Encrypted: i=1; AJvYcCXFpqt5EnzvE2In7SLWM7vXucurOIH5MfSnzZiyX85sszCBclvX2uGHMTQITaNSvK9z2TpT74Mqfw==@kvack.org X-Gm-Message-State: AOJu0YxOqni8lpBzUQtk+Op9Eei0VHo8ckXok8ZBOo4QqJ+K2Wb+5maU anlo+33ZFXbDnIkku1dRnyfX4lV6inkVbsnVDv+QalSZhgAsNxXRkOPP6jA912M= X-Gm-Gg: ASbGnctpHS63U1G6GytpZgsg136MwCX91V3hEQgqjvB+1/B4EATP235/buxi/OZ79rv oyp9HJmZ3aHdQQxFiWoccIRgC+IbJlbjYbWzUo47JFd6HPx9WvcShttFJjOC4NhXAWcRuP1rpg3 KlCEQnSe/FQLoYB7+gTr8v1T/NhHNDo/jq476SnFPBn9J+P8IInJho0SSiqlRq9yQsScVl6JHPo XltmbLH9GBPoCPkrJ4H+iy9S2iTREWJf/7EdlWekg7bTsPYT8zllCLhd1EF/kGTWg4gshO/+wNi 5JrvQr6vuM6WmP4aWkokBssaXkYxx20oJdDnqkMgUR4kK05Szqli+sworjyGTrY27IS/AByMWdq 2gwc= X-Google-Smtp-Source: AGHT+IGGJurj1ywGFGfMqLad+W4V0w/HWPMlDvnZ5WiNoOtzbXCiXiC9jiI+n/maSmmLogJdgVe5uw== X-Received: by 2002:a17:903:2346:b0:21f:6fb9:9299 with SMTP id d9443c01a7336-2219ff5e7c8mr68299995ad.27.1740164445571; Fri, 21 Feb 2025 11:00:45 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d5364676sm141352715ad.82.2025.02.21.11.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 11:00:45 -0800 (PST) Date: Fri, 21 Feb 2025 11:00:42 -0800 From: Stephen Hemminger To: Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , "Danilo Krummrich" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Simon Horman , Johannes Berg , "Jamal Hadi Salim" , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , "Bartosz Golaszewski" , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , "Miquel Raynal" , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , , , , , , , , , , , Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs Message-ID: <20250221110042.2ec3c276@hermes.local> In-Reply-To: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AE6CA180034 X-Stat-Signature: 7jnate9qpoam4gdkigpodh78w3d1eytp X-HE-Tag: 1740164447-855243 X-HE-Meta: U2FsdGVkX1/QW4siUhRRH0mCGYuXtRfXtf1VAPefe93ygiWGy5cTOYHtQ7r9y2/SQEO9ka1k9J6aKF+95GtY3VXHERaKaHRpoEdPaPeDEnLZs4N1ObOj2h42iXbM+g2DmnDw5u2wg1vXmBRT3jAQfFk0OtN+7VJ8A82zhrobPKZ4Y8LD8ZyPeI6M0rvAURCipEXfM5wAaWvTvzoRB53+KNTqr4y9JbsFm6q5NM5YHqh7BNL0I6nq4s0+NfyuPqGtwfdCHoeZIeyyz+g8sNFYT1fyyf5m8YUm9LQxbsQZ7XRuEBp5jjfKJ3aaLiJQj/cLByLKCfAn5tu0CfMO5NrbppLg5T0KrkDcbP8mLyDQxLCOqJUDKJPQ5NyC0JE6l3+VHlHR+kcV1LJ+b5to/Um9tSVz3zebyR9rUyQbs4rgwtLToZ8o9h1KaZ3nf4Y/15LHXftTEzg84Vl8aESOlzz/ktCSGvPBXdqPYSqrcIoDPVgEvUglmKkKE7lNUa8/LCsY19YhbmKkin+x3od/a+bRDiW6/90Rebxil/CeuGqQxrxRDqJdnmdVWPnIuEhEjwQcwX2MekvihUV3+8gv1YO7eUJoaLVl1UzA5L+t7nCjP9JUt181qwki2fy0vNin1mx6u+FrueB53MXqHqwi0S85bsnSFmbC9L/EgsJtjVnGnfoeSWmzRbVZGI5vvStkKRaKsbxTCts2fetd5ikzwPMAmRmustC2EPlNhMf4gS/7sutPBGhq6/91QAI7RN4bFcAAQ8WTOviP7o7mwqYTqiijrOe1eorxj70zrd92RHq6CX7ySHl0hk0znk1RvtG4ft+YdyF2DfuC5NbK0dwWmPFPokt5DDZ948QMIZxcO7qMN+tyaNQ7VIyCURsxxDeG9pHmc/B85v7TtHBD7uPTqeuQQKxoIkD9mmgCMGIICTXqBPA299GgCsUGzcaAFqN+ESnAom8j0e4Dm2qN+jQOTAl D0lWVY43 yWSizznXFxWFn6WENM7zvnxZLsJaviX2FKMbBxYZoPqofFpqIlFWPj2/pH1/gzRFYgZPt6Ew2LPetPRmOQwx4s9LvYSguJz6FfCq1TZhwbLW7BQZeidN89RdgLS/PvsPRvqBfkUcD7erfQYxVbRqbivN7e3UTltK5QwcZGyK3QVOt21VujO80n0CAHs5iHQ70NpoS7mlN0gqHSH+irs23Ol1sTnRCB7miGgc5M8CXPgiK3VWB7vUtvkTQVf1/JmZgqNK5fvE87Iz9wwYIhijGif9lHXp1P21Pmi3bMWKK9KeleuUwJEK7Qn5IomMl9TJDcV37iEWu9aqn8QIPJEJvlHw0XnmsJuV5tHT4Dv6u2I9qBX3F4CybiJ7sYQBZETvCt/bCsR5o4ESL6c4tfK5tq9m/ep3k91xrM2c8NVBKwdBhB7LwctcRirajGHion1RgPel1ahZdeS5FwqgcvEV7UQB6NssgJRG9GKAvA5DfaHPRzp7OstFbqBIFEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Feb 2025 05:02:05 -0800 Zijun Hu wrote: > This patch series is to remove weird and needless 'return' for > void APIs under include/ with the following pattern: > > api_header.h: > > void api_func_a(...); > > static inline void api_func_b(...) > { > return api_func_a(...); > } > > Remove the needless 'return' in api_func_b(). > > Signed-off-by: Zijun Hu > --- > Zijun Hu (18): > mm/mmu_gather: Remove needless return in void API tlb_remove_page() > cpu: Remove needless return in void API suspend_enable_secondary_cpus() > crypto: api - Remove needless return in void API crypto_free_tfm() > crypto: scomp - Remove needless return in void API crypto_scomp_free_ctx() > sysfs: Remove needless return in void API sysfs_enable_ns() > skbuff: Remove needless return in void API consume_skb() > wifi: mac80211: Remove needless return in void API _ieee80211_hw_set() > net: sched: Remove needless return in void API qdisc_watchdog_schedule_ns() > ipv4/igmp: Remove needless return in void API ip_mc_dec_group() > IB/rdmavt: Remove needless return in void API rvt_mod_retry_timer() > ratelimit: Remove needless return in void API ratelimit_default_init() > siox: Remove needless return in void API siox_driver_unregister() > gpiolib: Remove needless return in two void APIs > PM: wakeup: Remove needless return in three void APIs > mfd: db8500-prcmu: Remove needless return in three void APIs > rhashtable: Remove needless return in three void APIs > dma-mapping: Remove needless return in five void APIs > mtd: nand: Do not return void function in void function > > include/asm-generic/tlb.h | 2 +- > include/crypto/internal/scompress.h | 2 +- > include/linux/cpu.h | 2 +- > include/linux/crypto.h | 2 +- > include/linux/dma-mapping.h | 12 ++++++------ > include/linux/gpio.h | 4 ++-- > include/linux/igmp.h | 2 +- > include/linux/mfd/dbx500-prcmu.h | 6 +++--- > include/linux/mtd/nand.h | 18 ++++++++++++------ > include/linux/pm_wakeup.h | 6 +++--- > include/linux/ratelimit.h | 4 ++-- > include/linux/rhashtable.h | 6 +++--- > include/linux/siox.h | 2 +- > include/linux/skbuff.h | 2 +- > include/linux/sysfs.h | 2 +- > include/net/mac80211.h | 2 +- > include/net/pkt_sched.h | 2 +- > include/rdma/rdmavt_qp.h | 2 +- > 18 files changed, 42 insertions(+), 36 deletions(-) > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250221-rmv_return-f1dc82d492f0 > > Best regards, Is this something that could be done with a coccinelle script?