From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EABC021B3 for ; Fri, 21 Feb 2025 01:58:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 034A1280014; Thu, 20 Feb 2025 20:58:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F26EC28000B; Thu, 20 Feb 2025 20:58:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1518280014; Thu, 20 Feb 2025 20:58:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C727D28000B for ; Thu, 20 Feb 2025 20:58:36 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46985A073C for ; Fri, 21 Feb 2025 01:58:36 +0000 (UTC) X-FDA: 83142292632.11.5F95DF9 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id D0A39100006 for ; Fri, 21 Feb 2025 01:58:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=fWmbGxN+; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740103114; a=rsa-sha256; cv=none; b=NX00aqCkPaFLmY50GaIC5YVYrtMMvXydUoM/suVQtd+O+zA0xnHPPYabFO8iep/6AJYR90 tZTSQ6DfoMJyLzEzEqn+Vv2nKWPh0r7en80swR5x9RhIOGc31d1BmlayZTOqEeh0d8L+rt G8ljmyUsOfMMqWdHLrjdyhnWnoSl7kE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=fWmbGxN+; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740103114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9pl8mc1+LryrdBQUYpnpwMJchQlk3HW4nhPbnRy/OnE=; b=6uTRxvxeWB3U3S9GcBmb1nXsLxzXVpJXCFRnXXH3+WQBkJj693PRnRzBcoBd1KsKEtPZ4m 6HPiQf2EPO4N5BWjnacuKw6MirF9s4rgX2rIrqcxDsySwLge/ht+2rR+YtBvXZYrC+laE8 39ew29a8Z6Q9G9D/4yY43D2Xcw1zNCE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 025BF40E01A0; Fri, 21 Feb 2025 01:58:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KlF8eqA3UIG5; Fri, 21 Feb 2025 01:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740103105; bh=9pl8mc1+LryrdBQUYpnpwMJchQlk3HW4nhPbnRy/OnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fWmbGxN+1yA8Ht7WT08Or9Rv113NVICpFGmCyrTzNE2u2AoYcTsLA6ivYjXD+6bkx RJriWPB+DlKI/Dd1ivBp57HMScPqs+f6bfCzGpXeX4uW3/zEv+9TiQ8DHX96Yg9qAi fH70I3VmTM0hT2J+FgsgThJJKf891P+12ioxculXYZEVp9sYMRfIBy0aR/JRr2rYob DgzX56dU9tFnmYDc8+4szqlqoMgQohRourYM2W3pW/qM1I8Puj0B1BhmEK11Br5dy/ 8YF5Y98m8NS4ncbJ2hbhRdB/V9aNf+lRhCU7Y7pKfqzbrJ6kERc3oyJK93qfVzhUSW BQt217wZRlgaIVcuvgtOsNluiLv4Etn2/5WU8NAkaKkVCuW0bSORizETQscSXLYAjU qHom5jDorBsjfgbITli88oCx1w0Jnl2d7aOWLFqktSHMXUIpGci+YIoOFuRUGR4JmX Ol0XDhH4sYSqN50oXDL/mkoLPn1B986rts6F8zpQvQ0MH7wfR4Z656oQy7RAQDN88Z xrfVzUkgP+b/5a9h90yZgL86Wj9eg1fDiEpm3bsgTUa0bURmYw3wqAI09o0Y5wvK6l MX+ho7hIDHiuir9D/U0mYA6wU17XRdACM+3DzwBSzq2HHbK9qrTXEDGj0EZ5OQFJWc wUjnXXLNXhPKmZfQfR6SW7s8= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4CEDB40E0176; Fri, 21 Feb 2025 01:58:08 +0000 (UTC) Date: Fri, 21 Feb 2025 02:58:01 +0100 From: Borislav Petkov To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Dave Hansen Subject: Re: [PATCH v12 04/16] x86/mm: get INVLPGB count max from CPUID Message-ID: <20250221015801.GHZ7fdqaGFEvsG6qW1@fat_crate.local> References: <20250221005345.2156760-1-riel@surriel.com> <20250221005345.2156760-5-riel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250221005345.2156760-5-riel@surriel.com> X-Rspam-User: X-Rspamd-Queue-Id: D0A39100006 X-Rspamd-Server: rspam12 X-Stat-Signature: czuirfzht3wogcdi5yuf9s81qytbgpgf X-HE-Tag: 1740103113-754130 X-HE-Meta: U2FsdGVkX194UfqOZX/Ko8jPri8Ng4rGEi1dACYwYcxJVtS5UGzl0/3ZobqZQVNKUtcLF8nnszjFKhqK/Y3zwibsg2rXoPU+gIqCgEUHG3Ile467y+2KJcmgBcaFMi7cXwlYf28ZoPDToOvkxrOnSVekYVQTaZh4XQXpZBQ2ZPGHSOl/LmqfAbEwBS1O6e0NANYHG96Digmcv52JwEegcxUUflXtQLPohdm9l8IeiIHPj2ZYpLKxA4KJUhRNefJ/HGcUbqjBLL8PVQ3bDd6vJAvYp7UgZz4pBs93XWGTA6VrDRDz9u3QZfYjTu23/hoxwMaPMALoFInYAmo4w0RAiuBJNwzbNKid97m5MrSlNV7vdawgKXK7uoUy9E7MxZ4Cm+7VD+wp+QL4DwMiSA8ksLoZKptrG7OSlH9O9HX5XVcZKaO4AH9IuQwA8BDzu2jSFfTydp3tIdqRSOEGnwMxyF5yr7YeQFzc/gi80Qgt/zuYZOWBRdE1SuoVZw1sPtDNyP5+dzfbhyOFfXXV1M3hm3mFl6B9JiUJCB0fE28dP7edySFt52nGmeOwUToYHO7BqaYixOiH8R61nCjqh3EaTek56SYv9hyjwzCJtAsqDjEcadI9XPy+JrJPwGeYGHviTjFCBoVMX8X9N/LsYdqvFy73cuQe43VAP3VQ8FdvfP1kuG3MqAmGZtEOthfq6OCaWz6H7jaMSEejBWeSi3zWl7nUIOu8ix10uCzqwWFZiT/RgTL7D9v+S15sHPWaXHPCP6uSOTfVXk94dAgkSiJcsngWdixBtJ79mlNIiOoakCyZ1YX9AJPqRsKuu9Ajj8X4KhChMZdObBiLvqzO8O9K47XNsWUJoy/uFEcSV4tGIUVQJzoDvHAG+nc7svSVEc+dYRYEJ8xhsUJL3HKE5l8ETRskC0zMDp7ZEB0Wv3UJmsRSZfv+IoSshmBpN4MfR7uhxS3AOJS+oPcWaEXG37j YF7h28Nd ZRbTVe+bamSNzVBzNchDGsmwZ1wxfUGv7bh9UpBl75UibosOIU9LzkE+XzqpBwzqPHLOxfAwhQ64ySXbnqkFEDqm/aoS17jze4CaJBSRYRm9lrftlLtn5Gsyvbqrt8hpyC9AY9OXphn9MNC+CE8qStZAu8oAdimOPf9D7fYqZKjPp6WazRxm8oCN5tABXslRy6R5JQrPICacbzP3GjZEuBHV66KfLOFJ17+/S6kSGItuoriUSZZ6gSnxHabkzUWo9OS1iGh9cf/0aKxbaKjHwaUv3+04RATlh+VjX/R0EO/JR4UXlj6rOwVlv7/kEWoFKhZCEho1dieOw6rx7jawt166wBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 07:53:03PM -0500, Rik van Riel wrote: > diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu > index 2a7279d80460..bb6943c21b7f 100644 > --- a/arch/x86/Kconfig.cpu > +++ b/arch/x86/Kconfig.cpu > @@ -401,6 +401,10 @@ menuconfig PROCESSOR_SELECT > This lets you choose what x86 vendor support code your kernel > will include. > > +config X86_BROADCAST_TLB_FLUSH > + def_bool y > + depends on CPU_SUP_AMD && 64BIT > + > config CPU_SUP_INTEL > default y > bool "Support Intel processors" if PROCESSOR_SELECT > @@ -431,6 +435,7 @@ config CPU_SUP_CYRIX_32 > config CPU_SUP_AMD > default y > bool "Support AMD processors" if PROCESSOR_SELECT > + select X86_BROADCAST_TLB_FLUSH > help > This enables detection, tunings and quirks for AMD processors You missed my comment again. How about you read review feedback more carefully please? CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD which selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD... You need to make up your mind in which way the dependency should be. Certainly not circular. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette