From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Brendan Jackman <jackmanb@google.com>
Subject: [PATCH v2 9/9] selftests/mm: Skip gup_longerm tests on weird filesystems
Date: Fri, 21 Feb 2025 18:25:48 +0000 [thread overview]
Message-ID: <20250221-mm-selftests-v2-9-28c4d66383c5@google.com> (raw)
In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com>
Some filesystems don't support funtract()ing unlinked files. They return
ENOENT. In that case, skip the test.
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
index 879e9e4e8cce8127656fabe098abf7db5f6c5e23..d2c33dd9da9cd43cc6666e5d9ffd3ff9e62dbb27 100644
--- a/tools/testing/selftests/mm/gup_longterm.c
+++ b/tools/testing/selftests/mm/gup_longterm.c
@@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared)
int ret;
if (ftruncate(fd, size)) {
- ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno));
+ if (errno == ENOENT) {
+ /*
+ * This can happen if the file has been unlinked and the
+ * filesystem doesn't support truncating unlinked files.
+ */
+ ksft_test_result_skip("ftruncate() failed with ENOENT");
+ } else {
+ ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno));
+ }
return;
}
--
2.48.1.601.g30ceb7b040-goog
prev parent reply other threads:[~2025-02-21 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 18:25 [PATCH v2 0/9] selftests/mm: Some cleanups from trying to run them Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 1/9] selftests/mm: Report errno when things fail in gup_longterm Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 2/9] selftests/mm: Fix assumption that sudo is present Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 3/9] selftests/mm: Skip uffd-stress if userfaultfd not available Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 4/9] selftests/mm: Skip uffd-wp-mremap " Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 5/9] selftests/mm/uffd: Rename nr_cpus -> nr_threads Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 6/9] selftests/mm: Print some details when uffd-stress gets bad params Brendan Jackman
2025-02-28 12:47 ` Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 7/9] selftests/mm: Don't fail uffd-stress if too many CPUs Brendan Jackman
2025-02-21 18:25 ` [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems Brendan Jackman
2025-02-24 10:25 ` Brendan Jackman
2025-02-27 12:58 ` Brendan Jackman
2025-02-21 18:25 ` Brendan Jackman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221-mm-selftests-v2-9-28c4d66383c5@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox