From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A71C021B2 for ; Fri, 21 Feb 2025 01:20:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5731D6B00A2; Thu, 20 Feb 2025 20:20:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 522916B00A3; Thu, 20 Feb 2025 20:20:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41115280014; Thu, 20 Feb 2025 20:20:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 24A8E6B00A2 for ; Thu, 20 Feb 2025 20:20:34 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BC3011603D6 for ; Fri, 21 Feb 2025 01:20:33 +0000 (UTC) X-FDA: 83142196746.19.9FD71EB Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf14.hostedemail.com (Postfix) with ESMTP id CC0E310000A for ; Fri, 21 Feb 2025 01:20:31 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Bhbj8cX8; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740100831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6B3FtZTHArPIPj2ZwcldwX5r+ou1LmGVfI2lo00SHP0=; b=18K0x+cNoQtfXDTbRAM+KzV6LtyMDuceP8ECvwt6nhNkzO1szYMImTYXEXDPXm6oBRtzXg mi7vaZGwlpUtJBJfm2DThGVPHRuHwhkW8ZwdRjLqC8dRb6/P+5n1NePsFfmnku8gdhV9Lx 9xQ21DG3et8FoY5svEG9rjf9L/6yOEg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Bhbj8cX8; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740100832; a=rsa-sha256; cv=none; b=SJ2YURT7ZjUNn4rL5vL34MC0l0EaKU3CJt7HVVHbKD1nzOkrC1UIK3ML3AyFl3qRU9X963 wZYQCR3PxjZR+lhXlG8ycQdhhkyVfPl0xoyvHFX8RqPxRZXDGpaSrV+sqx7FjxQt3Xub2c wbHnXgGjb+MR5B5OBmiH6kfdzK6dbHE= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22185cddbffso40191425ad.1 for ; Thu, 20 Feb 2025 17:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740100830; x=1740705630; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6B3FtZTHArPIPj2ZwcldwX5r+ou1LmGVfI2lo00SHP0=; b=Bhbj8cX8oEzVaXqRxAMETq/lJRluRwTKucZBJTvXL3D+llxPJrWUcl+QRHpA8qws8o fzDCmadhcR+03y/P7ii0fVeFAt2WbQYk2rPUOWeVFhRk1Ug5LUOOu5OKN4eN7bXNiZ4x QJ74NHNms/iGrYiXK34LTF1vgqStAP4VQYmG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740100830; x=1740705630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6B3FtZTHArPIPj2ZwcldwX5r+ou1LmGVfI2lo00SHP0=; b=eAjyai8zFBPiJom3539GOdQjafqm+okXKOVwkyBKry9TUy9ZRPo4Lav1V1zyf9EFA9 KZmdeQKuV9d9sslWk1heJfWCh/rS/THT5/Du9d8qW9qIiKcENiWTwF3jHO9H0w+J3TYW pnARnCZPai6HsyV6H4CDyIHLv+CIPwGJ+yHKduvWjRwQ6gqycJ8Qb/nr1J9e5RObkVKI bY6irVBQB30YlzSWdTLkDzifKJ7uSNbXGCrqARTGagRidB+01tND11Skk6+Iv7dy0j/X gYiJkxDfZBdMuXWI0V3gku5UACMI1BpICaUBBNTSbyL1ILA5ceQ/z7fEbWVzFomzYYor rWCg== X-Forwarded-Encrypted: i=1; AJvYcCUs9YJegCSypch8MO5gvvAVRZs6eU3pF133UWNp+Thp9MwJaaQInyvIhPldB145qMbPTEzn3qa+Yw==@kvack.org X-Gm-Message-State: AOJu0YwlBdS94PjR4s5gumdpofCPD3kWrr0DDvdyNPZ+CQPjfmStkOpO +R3kHEB4u+yyl6G3uZTRwA0Vg6V2gSN7hjsTPHjeNjSo22ueaHRN7aakWQ5pAPzhgsp4vnzzqo0 = X-Gm-Gg: ASbGncugNljpi6a0Z9onlTQRleZZHL0bG1kPWlxiQVcH7ktglIabOyvbIg7n3w7URSc eA4CJxhM5eB3GyQjhdGUQx7HRsv7aXE0wDAJ4fw/ZryZwrYcJebs2RdEd5MjRpAzC5DrlIewN+c 4uoaRu6StExggibhnCdiEEVQV60yLJCjp04aio9Ug0t5uCsYRSe+ihxZccalNtSWfMZtCZYy9h7 83gKWGhFpz3uUF9hM0wJWgLZGeJ818RRKpN8UMCgstEEukrGeR25qBoq2ipGmvFxU1M756HWy+1 GV/ntux9G5n7JFdcwg== X-Google-Smtp-Source: AGHT+IHeIFp2n2yLTc12/J5sp5fgmZ4wVfS6kxoyp//xIO+R58ESY9aI1SDsY9hr74s+VIp0ZzU1KA== X-Received: by 2002:a17:903:2312:b0:221:1eac:bf7a with SMTP id d9443c01a7336-2218c765b1amr90285235ad.24.1740100830599; Thu, 20 Feb 2025 17:20:30 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:f8d0:f3a4:ac2e:69d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73270de9b7asm9982285b3a.90.2025.02.20.17.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 17:20:30 -0800 (PST) Date: Fri, 21 Feb 2025 10:20:24 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Hillf Danton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 11/17] zsmalloc: make zspage lock preemptible Message-ID: <20250221-095831-265429292-neomutt-senozhatsky@chromium.org> References: <20250214045208.1388854-1-senozhatsky@chromium.org> <20250214045208.1388854-12-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: CC0E310000A X-Stat-Signature: 6trmo5gxwge1ziy11xoz9ff7b6jem168 X-Rspamd-Server: rspam03 X-HE-Tag: 1740100831-426153 X-HE-Meta: U2FsdGVkX198iAEH9ArCrcFKbr2uvh7VCaKB3XkbH7ZKL+R6rCu40FeaMa2sj92sCqPR9VwFASgIEviTmyN72kYnK/44UOgK+NAgtRZZNz3R2dCdtTc3no2jmPN5GFqL5iSDcdn/8iSyuG4iP9AkcVzkT0+fsoFzRtBSEmZ7iTbLLsh5H8AqrtlIam1g2tAWFCeFQ8oqh7YWERqZXp4uGx2A6cHjBxSU/cMfDeBzlkJrAgzreSTZLpIOI+XfiIIsCS7bFWvbnzvXyaaONZL5GBPTS5/kKHzGITwm1rFmvaRTaXtJcWVNiQwDepB7xEtOuFNx+ESaKvHlQJj1m71PbFBnMc3M7KliDeYb41Up19HYX/w6PNaUeqgLXLFdDxTQbqVNAG7N3Mx3GuGVeRRZlU/Oob18nbJGEzWqI4WoBv7y1Gexvhcjlx3mwhJJ+rJs2S1YdQDjjceYmZsoGJchEfUeqkk1RpcFY0/ZoqS+cLWkkqihvq15H7f3iXxK7wXGfF0QVkjxIzWVki8l83tmeAHlacaFor5QDoKyTDGVlPowVjCTF/erpM3PVyOlxFjsfAm6nhMxTm+v3GNMXXnPWNG4y0Wh2kZCYUnrwgHNiVe/8Ft26NicJq8vq1i1NWyI84pYTie5vodAmGx1rpRMTkwcFUr0isd0ctYuRMK5zqwzWqetoaOCmSELy/kS3N4V4zHm/MOrQW4OU1BnMdPqadtTZeAQcUDFIgXKiZ7y9QWCPDQvS37FaTOODxukf1akshFVhQKcXfVxYdQegg614q6Ruhh1tSU7OWgMmHRCtH6btNMa5OwabeFtWH8i0062nhxBUDvHIcsZJwbyXDSMp9oODF7fAXjB//ou0r2e9GZjKlw/cQ8TziJ2dcNoiBO9YaUEsEF2UnvqI63f0X45vrNLxMxEAfo80svTE/rYu81YiVXXkgcrcJk4OKHATYJVJ98ZKFqQSd7cVNGt3DN otHgwgUY AADuBfeOnfSTGsBN42tl7QB7q+yf6gIgL7GA5iz3GtgUxaeG1G3KPkAPu3dqPaW54GolS2Q9Twf3GtUQx9M0MOx3FLEAU/x4td9GfAgOzwIPFEB+UDTw9J6hn/GLyfULPd4TbfsvuZ0HpDW/hixVtlCxWRZcNPRR2RIIgg+g3qgtsaYFQuarTdu3wKypKQ3cas5g7Sc0i9c9ctcnjj6NTcwvJNAZc9YZBg6ahreDguQTYVOmQuol8CAWxSSMvou2YL52RrbNNcRjLwIKtYVOlBAxCDHIiIOd94XsQo+W7uzeyHZdwhuR5SONEH9a5q4yc3xK1mGc6uMzXw2+DLttcarXPOL97MHkbnB7k/eqBC3nfIrI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008126, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/20 19:18), Yosry Ahmed wrote: [..] > > +static void zspage_lock_init(struct zspage *zspage) > > +{ > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > + lockdep_init_map(&zspage->zsl.dep_map, "zspage->lock", > > + &zspage->pool->lock_class, 0); > > +#endif > > + > > + spin_lock_init(&zspage->zsl.lock); > > + zspage->zsl.cnt = ZS_PAGE_UNLOCKED; > > +} > > + > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > Instead of the #ifdef and repeating all the functions, can't we do > something like: > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > #define zspage_lock_map(zsl) (&zsl->dep_map) > #else > #define zspage_lock_map(zsl) /* empty or NULL */ > #endif > > Then we can just have one version of the functions and use > zspage_lock_map() instead of zsl->dep_map, right? Yeah, maybe. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B1FC021B3 for ; Fri, 21 Feb 2025 21:01:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41121280002; Fri, 21 Feb 2025 16:01:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BF2A280001; Fri, 21 Feb 2025 16:01:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2870D280002; Fri, 21 Feb 2025 16:01:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0BD71280001 for ; Fri, 21 Feb 2025 16:01:32 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 92F7012059C for ; Fri, 21 Feb 2025 21:01:31 +0000 (UTC) X-FDA: 83145172782.23.F928D9E Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf08.hostedemail.com (Postfix) with ESMTP id 5DC17160020 for ; Fri, 21 Feb 2025 21:01:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=itqPsKS2; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740171689; a=rsa-sha256; cv=none; b=WAPi/YhGkxm1Z8F6Vc/TOkTsndWdJyK7TdOuHJNSToakuuDd2XZuNKxxVGol7UTGBMlMhw lt0cIxFkx9+2TdMJoDUvyXLbf6jwR6On2rohMI4SSJSZfxG9lTgA07s/ze4ue3Txvo7XX9 j7ix3RszIBpnhgQQWQiYUG0Yja978sA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=itqPsKS2; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740171689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KB7zOw8AFw5HwaiJLyXfCqtg75nhb187Vb/57RmyT1g=; b=QGm/DtTbF1k29GjnkrqVTVyMAx4Y3jZUb9PtJqAQkJOjnbK+mrNkPXGo+a6EfvP5Z8LEkG MM7AbYVircy0UapCcx7z5OKtWVCBsgaErsXRBMPAA8s9OGN9P+ke6z2VEOVGRgZgCjkIKJ sxUU3bY+KPqB7nWRlq+/vXpotl2sS0Y= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fc1f410186so6491528a91.0 for ; Fri, 21 Feb 2025 13:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740171688; x=1740776488; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KB7zOw8AFw5HwaiJLyXfCqtg75nhb187Vb/57RmyT1g=; b=itqPsKS2Gf9Z9NtaIVsOHKDXxEXu9L0QNS2ZncIxCM3EylnQZt5jpTvTr9ldbmOl5k Kyo964Fl/X1CnOlzT0OXSdmTbQbUIu+vI6xzMH7awYf1TUfbMDoZIzvvZYniiqxBpDBl a08kMqCfBphhVMHIuJazS8RkrZ29ot80BCzKg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740171688; x=1740776488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KB7zOw8AFw5HwaiJLyXfCqtg75nhb187Vb/57RmyT1g=; b=NmyNZY1nkEd+RHcbzfiPVRlbRTQewg0kzFpC+lh8FnempUQYBV3MYR8rlXHqt7T3Be opIdV/p+BJUP5i7UiaY82PA82Nn86NIwlar/QgL0F86+4F0kN/qdlBje1sssjG6NqmNj M5tSsQaDEHaCu297kW7Su3k/WirPcKdy+Dh6ry/uy0e9p0um40xIEAtiy6OJUViF4hP8 e1pM+QvKBUgGL545ef9R1NO6/V1WtOxTmg11T4wiSmcCQWfsJZUaok71k5zBwYKtwy46 ZtNOBBrx3qVe7q1U85qBx+IJSCzsw6+8Av86PAcPCxHdvrNaOb8HlKnFIdCzqyw2w/Jb bhkA== X-Forwarded-Encrypted: i=1; AJvYcCU9I1sZWNZY99fhDzsIC7AFTnp8sb+nxkWOkchZyYRDCozyykpFCfPcO3tQfFbd9PKuKd9jrlYHVA==@kvack.org X-Gm-Message-State: AOJu0YxjA8GMl75KfXBfm0XXQkgMIGD5fjHJlCPtJ8NqWHoiORdPGXkC GPpVdsWIqEwlFUenkoCFzVZntLgWquAF80wjB0CE8o4SYPW+P/dWSExA1dWdzw== X-Gm-Gg: ASbGncvemPYZyNOyUQq3HWtxTrMiWAZEqx27RLSPF8USBjKmEt25ZE+1PU9MXDwFVHr bFipW1027DoR5rKuwae46JKb/kKzdxxQSIpK+Niya/SzZsy7xEIOBN8+RQXbrqlMves4isv4z0n tu5ze5mH+5l+cWfkxBnXJC3dlkT8zysuyv4kR5V2L7qqTo2lsiUSYpzFC8ie8sQ4zbCRcBhP58N 6w7Egj4PHOWI4yXewmYLhpi/NAK8KGc/0DDDw3CMG4IE9G57TFr+hcKIv9kYgOn8kF/Wz1d8hkx mkzSvj4KSsAzKpHoiGBxc2TJ7kDt X-Google-Smtp-Source: AGHT+IEs01Hx2KIewi9vZQYw0yu8X2kEXs1yphv1va/bFuzNYCs+BRNeDhKdyaUblwTlOF6avYXpxA== X-Received: by 2002:a17:90b:3883:b0:2fa:42f3:e3e4 with SMTP id 98e67ed59e1d1-2fccc0f838amr13550504a91.3.1740171687113; Fri, 21 Feb 2025 13:01:27 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:f987:e1e:3dbb:2191]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb05f2basm1833275a91.21.2025.02.21.13.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 13:01:26 -0800 (PST) Date: Sat, 22 Feb 2025 06:01:20 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Hillf Danton , Kairui Song , Sebastian Andrzej Siewior , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 11/17] zsmalloc: make zspage lock preemptible Message-ID: <20250221-095831-265429292-neomutt-senozhatsky@chromium.org> References: <20250221093832.1949691-1-senozhatsky@chromium.org> <20250221093832.1949691-12-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5DC17160020 X-Stat-Signature: 5bt7nhuyfd55rbnbb5rqqnw17dy3wron X-Rspam-User: X-HE-Tag: 1740171689-902159 X-HE-Meta: U2FsdGVkX18aAS5qspr1x7B+1xR3LRGIOVUaSTYzQp/SCcZK6noao3UCxijUUJqG0mKPgRH/OX1AyqvEvju+NKB5MHcXUm1g4Fe3dUi6tJPMJLbhV/QCiMpAEkM+jzALcHGUfzPkcRuIO46oy2SvU2llV9uxVu0xemzjOgL6qrjiAo0tC4szF0ndvYwyv+gAgPg42Y3nl4Oat2l6D+HPUCsP7u8vaZpLRjgI+LFsVilkpbo9VBbQYztWWBxQOjGPs5kzrCRK5VABZ03WDHymGin5O6/DR+HaZP9oTK+PT7wR2Vw0SvX4UMrFka/voy4wqpmGH1HfTyr6sOnxLWhUUv3uE8ZCJCd/oZOfa9W6VTEULvmvawapEUfrvvVh5f6Qznn87zS/nJnSJ5TIZrEjcoT+zyNmlA0+slNdIPyecOxV+l5DGtLgd0GV/J+kg0JUI7SnS6hK8jW1nEP5WM0PNirw8TQtToetTuvvqUkPdWUM9htiC44ghScCO9RMYrfbZZ6lTtv0rw+6c/xE61BB/vsKfnV7iKJvBHk2WFMfi2M+z0rrg7wDK3hM284mRRKk1CUuIiOOTLa2lJe/gnCq1C95PqCySyqjJeQRvqr7usoUDzhiqqarpq5phd/hWvW/ReTzxhJBBmTXVTZ217CWcXxVJC5jRjWzv4qw6h1+aN2hzUuM5rG3UT+x7PoHAQsOrShfz9lVuNmwkcMVVukQpKNkyd4DRpcpM7iVOsT9nDOGhiAAKP/wsi56IS7z5Z77QXdPV71regUvhInkrKIn61J8vd1NPDdo/O1K4WfPhf9Y9incm6X1aXf2ACg4nR7Pm+DRXEXXcQ8tSoHiZPxDlli+xFs7x/MgJ04lck+wdz8XTuU1WZhYpIE5Dv99HjAWNxfuTGOXRSZzbV3Z2rAfxvfica5R7HX7m2ouCDzIk51Z2H8Ri2K8Vza6UMUPRyeupYVjxSi9l+d/YSPFYYL Hj9jtCiD lxzkOaluRz0Uk9GUvuNYvZ/k3x1v9YCirtjG+rDrsTKMyO961LjOBLxi55c/8cF3LaEy9ZgmqqmSY9qB3MN6AKNtB7GuQrDltCgkGSqbG+g9yvc9qp/fkRVhx11Q93Gz03uhLXdBH8Rp3Mpe/dvGGvmMdIqeOFFXBLuq3sfQsqpLpCpr8zToI+aNDVhLj7pyzNptoodmHNvXECn0ZFdlWytwKFMets0Fhar2cdTFRz+6JyFhWT6yQFQNumuOPjuxoqm1QsjbLEu0TdkMTyoW8FIJBBg2wvMe7VZ405R19yjDluSSMI3S6jgrPz+crJyZMCz4mgA/dLAm+SN/QWat6tJz/CjH8Qa3vwluSq6BKBzb1uCA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.023363, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Message-ID: <20250221210120.TVOGW7dsBqVjilblIFqr3r9pH8hc5sNynRiVvnihYSQ@z> On (25/02/21 19:48), Yosry Ahmed wrote: [..] > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > +#define zsl_dep_map(zsl) (&(zsl)->dep_map) > > +#else > > +#define zsl_dep_map(zsl) NULL > > +#endif > > + > > +static void zspage_lock_init(struct zspage *zspage) > > +{ > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > + lockdep_init_map(&zspage->zsl.dep_map, "zspage->lock", > > + &zspage->pool->lock_class, 0); > > Can't we remove this #ifdef as well by adding a similar macro? (e.g. > zsl_lock_class()) I thought about it but then was not sure if having a macro that we use in two place is worth it, but I guess we can. Let me send a v8.