linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, kernel-team@meta.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 4/9] mm/damon/core: put ops-handled filters to damos->ops_filters
Date: Thu, 20 Feb 2025 11:35:04 -0800	[thread overview]
Message-ID: <20250220193509.36379-5-sj@kernel.org> (raw)
In-Reply-To: <20250220193509.36379-1-sj@kernel.org>

damos->ops_filters has introduced to be used for operations layer
handled filters.  But DAMON kernel API callers can put any type of DAMOS
filters to any of damos->filters and damos->ops_filters.  DAMON ABI
users have no way other than still using only damos->filters.  Update
damos_add_filter(), which should be used by API callers to install DAMOS
filters, to add core layers and operation layer handled filters to
->filters and ->ops_filters, respectively.  The change is applied to
both API callers and ABI users since ABI users use the API internally.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index ffdd84ff6fa5..78126a5145fd 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -281,9 +281,24 @@ struct damos_filter *damos_new_filter(enum damos_filter_type type,
 	return filter;
 }
 
+static bool damos_filter_for_ops(enum damos_filter_type type)
+{
+	switch (type) {
+	case DAMOS_FILTER_TYPE_ADDR:
+	case DAMOS_FILTER_TYPE_TARGET:
+		return false;
+	default:
+		break;
+	}
+	return true;
+}
+
 void damos_add_filter(struct damos *s, struct damos_filter *f)
 {
-	list_add_tail(&f->list, &s->filters);
+	if (damos_filter_for_ops(f->type))
+		list_add_tail(&f->list, &s->ops_filters);
+	else
+		list_add_tail(&f->list, &s->filters);
 }
 
 static void damos_del_filter(struct damos_filter *f)
-- 
2.39.5


  parent reply	other threads:[~2025-02-20 19:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 19:35 [RFC PATCH 0/9] mm/damon: make allow filters after reject filters useful and intuitive SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 1/9] mm/damon/core: introduce damos->ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 2/9] mm/damon/paddr: support ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 3/9] mm/damon/core: support committing ops_filters SeongJae Park
2025-02-20 19:35 ` SeongJae Park [this message]
2025-02-20 19:35 ` [RFC PATCH 5/9] mm/damon/paddr: support only ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 6/9] mm/damon: add default allow/reject behavior fields to struct damos SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 7/9] mm/damon/core: set damos_filter default allowance behavior based on installed filters SeongJae Park
2025-02-27  0:29   ` SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 8/9] mm/damon/paddr: respect ops_filters_default_reject SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 9/9] Docs/mm/damon/design: update for changed filter-default behavior SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220193509.36379-5-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox