From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 1/9] mm/damon/core: introduce damos->ops_filters
Date: Thu, 20 Feb 2025 11:35:01 -0800 [thread overview]
Message-ID: <20250220193509.36379-2-sj@kernel.org> (raw)
In-Reply-To: <20250220193509.36379-1-sj@kernel.org>
DAMOS filters can be categorized into two groups depending on which
layer they are handled, namely core layer and ops layer. Also their
evaluation sequence is decided by the categorization. Currently, all
filters are maintained in single list in mix. It makes the filters
evaluation loop inefficient since it should do the categorization in the
loop for every iteration. Introduce another list that will be used for
having all operations layer-handled DAMOS filters.
Note that this change simply adds the list and does not change any DAMON
code to use it in real. It will be done by following changes.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/linux/damon.h | 8 ++++++++
mm/damon/core.c | 1 +
2 files changed, 9 insertions(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 795ca09b1107..add82fdc1117 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -448,6 +448,7 @@ struct damos_access_pattern {
* @wmarks: Watermarks for automated (in)activation of this scheme.
* @target_nid: Destination node if @action is "migrate_{hot,cold}".
* @filters: Additional set of &struct damos_filter for &action.
+ * @ops_filters: ops layer handling &struct damos_filter objects list.
* @last_applied: Last @action applied ops-managing entity.
* @stat: Statistics of this scheme.
* @list: List head for siblings.
@@ -503,6 +504,7 @@ struct damos {
int target_nid;
};
struct list_head filters;
+ struct list_head ops_filters;
void *last_applied;
struct damos_stat stat;
struct list_head list;
@@ -810,6 +812,12 @@ static inline unsigned long damon_sz_region(struct damon_region *r)
#define damos_for_each_filter_safe(f, next, scheme) \
list_for_each_entry_safe(f, next, &(scheme)->filters, list)
+#define damos_for_each_ops_filter(f, scheme) \
+ list_for_each_entry(f, &(scheme)->ops_filters, list)
+
+#define damos_for_each_ops_filter_safe(f, next, scheme) \
+ list_for_each_entry_safe(f, next, &(scheme)->ops_filters, list)
+
#ifdef CONFIG_DAMON
struct damon_region *damon_new_region(unsigned long start, unsigned long end);
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 38f545fea585..bcb7e42098dc 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -374,6 +374,7 @@ struct damos *damon_new_scheme(struct damos_access_pattern *pattern,
*/
scheme->next_apply_sis = 0;
INIT_LIST_HEAD(&scheme->filters);
+ INIT_LIST_HEAD(&scheme->ops_filters);
scheme->stat = (struct damos_stat){};
INIT_LIST_HEAD(&scheme->list);
--
2.39.5
next prev parent reply other threads:[~2025-02-20 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 19:35 [RFC PATCH 0/9] mm/damon: make allow filters after reject filters useful and intuitive SeongJae Park
2025-02-20 19:35 ` SeongJae Park [this message]
2025-02-20 19:35 ` [RFC PATCH 2/9] mm/damon/paddr: support ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 3/9] mm/damon/core: support committing ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 4/9] mm/damon/core: put ops-handled filters to damos->ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 5/9] mm/damon/paddr: support only ops_filters SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 6/9] mm/damon: add default allow/reject behavior fields to struct damos SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 7/9] mm/damon/core: set damos_filter default allowance behavior based on installed filters SeongJae Park
2025-02-27 0:29 ` SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 8/9] mm/damon/paddr: respect ops_filters_default_reject SeongJae Park
2025-02-20 19:35 ` [RFC PATCH 9/9] Docs/mm/damon/design: update for changed filter-default behavior SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220193509.36379-2-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox