From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D9EC021B1 for ; Thu, 20 Feb 2025 09:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9334E2802BF; Thu, 20 Feb 2025 04:48:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 909FD2802BD; Thu, 20 Feb 2025 04:48:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ACAC2802BF; Thu, 20 Feb 2025 04:48:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 610E32802BD for ; Thu, 20 Feb 2025 04:48:06 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1B81EB609B for ; Thu, 20 Feb 2025 09:48:06 +0000 (UTC) X-FDA: 83139846972.11.114392A Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2123.outbound.protection.outlook.com [40.107.255.123]) by imf19.hostedemail.com (Postfix) with ESMTP id 125EC1A0002 for ; Thu, 20 Feb 2025 09:48:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=amlogic.com header.s=selector1 header.b=Ek2f7Eut; spf=pass (imf19.hostedemail.com: domain of Shengken.Lin@amlogic.com designates 40.107.255.123 as permitted sender) smtp.mailfrom=Shengken.Lin@amlogic.com; dmarc=pass (policy=none) header.from=amlogic.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740044883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=7V6uiUxDgRVNyG8uh8bAQAW1eKIpvVhqpolsN8J6ZNw=; b=JuGlCjQ4rY6nZkDJqR+bT/ilJcovd8TeYoATxWRNd2hOunYzLgKfotCWv7aDhM3bSWpLpe IXNyBMmLt6/u75iy/rn1aJeZ6USqWRrzdDGC75TCsU/XrOM3lf2i+75e9qPsW0DLwr5rXG 5vKPvGjgB0r7XLI2f2nRqe4l4Gd8+uo= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=amlogic.com header.s=selector1 header.b=Ek2f7Eut; spf=pass (imf19.hostedemail.com: domain of Shengken.Lin@amlogic.com designates 40.107.255.123 as permitted sender) smtp.mailfrom=Shengken.Lin@amlogic.com; dmarc=pass (policy=none) header.from=amlogic.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740044883; a=rsa-sha256; cv=pass; b=3lwfJSZ84YchRiup9KuwXfTOa4EiT4J74yRReFbrLWPANiQ8N8XA1JWup0ffg3fLoG67+e cxySbAZTcSxirPeLcjt1oHmgTrQ9/E43Hmn9L7v1jiLZZSd/dDJIePmOT+MCYEZT/bVhfu 0yzPisbBrb8Z1CRv1yqjYVgBmdob7Ng= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IwnGwNNZgS9ytmS9GDHD0rdsvi7IhXbqiiXzcGqj6jB5Fg7UzwcfzYurRbJN5BHlUy+z+SxzYOgVHWsC6IvS9hpk8Q4JQfPVczrx5AbLAmnfmhFtyzyNDJ915cUrWh75Gfw2a954vfzDFa5ZQ6XxeQLet+SBD+uFgSNKXk7JmKz0/z65hXjkn2OjkxGUvRbd0xpHg+aO9vg7KcU+y7E7QcsUDxk/J3lm75SLhzUHyHVv7J+wRTpOxUffxEi35Htoq4AITw7JcC/LkTxl1ueFg5enHQEBtktyJUb0pVn8dK/bp2hwHiD+EbJ76f/QBx6rmVEkFJwcA+WC/8nqRiOoVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7V6uiUxDgRVNyG8uh8bAQAW1eKIpvVhqpolsN8J6ZNw=; b=yHRhKMPTzE/iO2SuETxn3GJkmFEKsUPwZG8Wi7ofA9RoaLBQBM4KfOSwAzzY/KnM5hvsTbzs/cyZnRonJuGsaSPWFioBC6fwI+AkaVJjkl+PbPRSfUwVmBN0yhuM8CaDanZW8RO1QHK2rZ2XELEQcz12EMNKob3z8W1+UQxaSb+CkuiBRSAc+SSethOLJetBLR+8sXMyRaWEkEbdJyYgBh9p3xMiQfJDWRKpNRLI4HLJpkLl9MixhNHaDoRn0MOIu/U4OkNuXOoMFQEbkEJ9P5L9oYNL4d5tm6ll4ohc75qSBmO3NYsE3W+auIhBubHOfcPZjGvo1FZ2yllH8hkL1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amlogic.com; dmarc=pass action=none header.from=amlogic.com; dkim=pass header.d=amlogic.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amlogic.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7V6uiUxDgRVNyG8uh8bAQAW1eKIpvVhqpolsN8J6ZNw=; b=Ek2f7Eut4ZeILho/Pd0vtVZLYwP7FadUNui7RFFAcErQymsDZPDzwgE8do0oxwHLQcplwK8rVyw2t9T3N7mSgxLfURLYxycOK3/hhPiAT/UM5rBTsSaEFT8klwlq8jOuvW0UqXsHVXIwiT6gS3BtIqAe5KxRAGIZbcH+5n9y+pZ0kdPAf5iXTZeOfjbmVZYaFQK8m0xUaEvaYes0yUboCI4kkj+TLeY7dhf7CFK9qy3tkw5BUIatC0eMWT0WooKja38WoJsz/kvJnvuXk/qgKZMlkWUcD8DFTZNw+9uMAt7JVE372KSj6ITat6H0b/bk/yad9LChav8G6X+oUV/yEA== Received: from SEZPR03MB7775.apcprd03.prod.outlook.com (2603:1096:101:126::6) by SI2PR03MB6464.apcprd03.prod.outlook.com (2603:1096:4:1a4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.18; Thu, 20 Feb 2025 09:47:58 +0000 Received: from SEZPR03MB7775.apcprd03.prod.outlook.com ([fe80::fa3c:5644:cb17:f822]) by SEZPR03MB7775.apcprd03.prod.outlook.com ([fe80::fa3c:5644:cb17:f822%3]) with mapi id 15.20.8445.017; Thu, 20 Feb 2025 09:47:57 +0000 Date: Thu, 20 Feb 2025 17:47:56 +0800 From: "Shengken.Lin@amlogic.com" To: "Matthew Wilcox" Cc: akpm , linux-mm , linux-kernel Subject: Re: Re: [PATCH] mm: Remove redundant PageMemcgKmem(page) call References: <20250212020627.3461237-1-shengken.lin@amlogic.com>, X-GUID: D1FD30EB-B202-4FA1-8B60-A589DF5CE1FD X-Has-Attach: no X-Mailer: Foxmail 7.2.25.213[cn] Message-ID: <202502201747552959016@amlogic.com> Content-Type: multipart/alternative; boundary="----=_001_NextPart075086560420_=----" X-ClientProxiedBy: SG2P153CA0023.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::10) To SEZPR03MB7775.apcprd03.prod.outlook.com (2603:1096:101:126::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR03MB7775:EE_|SI2PR03MB6464:EE_ X-MS-Office365-Filtering-Correlation-Id: cb4bc94a-f0a9-4e6c-52a6-08dd5193a7e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|8096899003; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?r7t3cAlPhRVn8HKv1B581YB1O5cyU6bt/5oaHyB+a43ZDCXdyjlvpLuSym?= =?iso-8859-1?Q?G5HvJ/JozYYlf9XOJ8F8+yvnkfHwYz/bgq9oTPrpdXsFw/4UvtG502w+bf?= =?iso-8859-1?Q?p98XveBXvVhrhOk2nTzsXScmJRihunBGQa0vAbp3lne3bQFwXEyqHMLM6t?= =?iso-8859-1?Q?JpfydQud2GQwSCVylPCusb0hzVlKUz6AQiws0bTrktLhLcHb5Zw9tqvWXN?= =?iso-8859-1?Q?FItj1asmb8rEhPgMXuP1/u3BZwywFVZGYp8mg09mP3sPCtc1+0vHpvr+xr?= =?iso-8859-1?Q?WYx7ostvFP4LlBdKydbNJSTZC7MCYJ5e+xv86JnaS2vtxleaGM+kbWTaU7?= =?iso-8859-1?Q?BNoPSMn974VqSnd6xX/H++t7jY8aVCMUVoZo4XZmw+7tAVSAQ3Afe+q8c/?= =?iso-8859-1?Q?Y46LeNLcR0r/QqLgLRrcOASethDB5P779AKJvcLwuJ9ktDrF1uMjsy08K7?= =?iso-8859-1?Q?my0L9fOLnGP0ZyLySsIP+1QyR/6EaSLu5Tx+/Ahzn+ADjamQ14jO50Pr+c?= =?iso-8859-1?Q?7+PtJwQoFrtvgIuCKfrs5DtnFcnz3bGL6ZfSDxlhyea2eiRmszY6oxhWHK?= =?iso-8859-1?Q?3mUhKzUdqdam8591BVM7szDPwF2/MwfgnLk7A5d2A/NJg1MovYPsnW8Aqh?= =?iso-8859-1?Q?s+LtnGdqjNT1M2hsk7tDFvnIHYGoFRIScYIucLMQ1vBr5UWn/OdlPGEr8y?= =?iso-8859-1?Q?Yzn/AS0pPAoojUwPoSA0Co/jGxCiXCpvx1NY2kZnzGj6PyTXdxQBmpwqGB?= =?iso-8859-1?Q?drbRy+JjvB/68GUkGHMrV6YjW9J/AGZu7ZZsvSycmho7WL7hZIZ7F6d/ZL?= =?iso-8859-1?Q?iY2wbaPyDyLG5I3na3KXNtlX+ulnl05KVVusN13TMk3FPWLGzcykUzneGv?= =?iso-8859-1?Q?xhCk0i0spEPshw7AohKmQ31krnPDenb2Gzy8fOyHuwvrfTsoOLu+AuSacb?= =?iso-8859-1?Q?lxD7LMAs/q8oPNH2mZRiJGl8hvETEEtjl0XiUye+v1y8vEpHPKZTlHFEu0?= =?iso-8859-1?Q?7B4RuTLvJZxIFDPxbbPCpCJhO/BVwyzFS/zPiCJENSg3vCFqPDjQJbpY0V?= =?iso-8859-1?Q?quj/Ni5xslr8BU8/4CQXBo7eQAu4kcsM0Am9gUFCJTd505kwrlfgzJxRpB?= =?iso-8859-1?Q?aM6I74czkHMHOQs3hVAIdKXeMVdgyZMcoYbvkiFo6jjqPbcZKCcQ36uGte?= =?iso-8859-1?Q?uW37heUwciKHDV3ZaoSJWyBnufTDC63fORQgc4soNx2klj4rtieP8Es4aq?= =?iso-8859-1?Q?HOZ22gdOQ9pYQQ9AIgLgGOETgsnNgpP4eblESM6+TXVhNe6M/h9qQOjxvl?= =?iso-8859-1?Q?Y0RvOtbwYHEseVq1f5iO+3SHVi822V7Prpxklf48hsRjDOlQlh3sTodkK4?= =?iso-8859-1?Q?AwKjBZ3+efeyfuFRQui64nr5lE1ZMjBa9avpmvmh63XHLtBNpniyU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR03MB7775.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(8096899003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?rywwlH2SC6epgkwR+OAlBuGxAt1rJm2yhAvLVNSPq8GAit7JD4Yw4AtXJh?= =?iso-8859-1?Q?uIHlhnrF0XnoECLmR1AHRfrtX/x7mCZkfWHwkcuZfYsBkiBZ6IGOQ/h08I?= =?iso-8859-1?Q?sV8Quvu0O+KKUfofDNonxfSIkfbCkpSbTEyS0I4CWxb0jOhBbGqTXmflaC?= =?iso-8859-1?Q?1xD91nXNVJTRSBrrGOkQ1T2xLkfVbKWDPNlrBWBCTncJmv4ms5HIz81C6A?= =?iso-8859-1?Q?bEJvw4DYQckSL49C0jtGEMd2+/jAM40wdhORRBbodLTT4prPcDElblqgBj?= =?iso-8859-1?Q?SdvxvaT3VpBY1dPNJ7M4BkBZZGoHWCh+hKVbiXuUpnjrNdd4aIvB9aE1yB?= =?iso-8859-1?Q?91dMG+B8IVV0XyruJTyjfCdPvMds8aSfNR5PM+Fn9d7sVT2f7e+5jSYAdB?= =?iso-8859-1?Q?Kh+FKuUTkKe5cQr3ImgScF5jw0CrcVNNwD2p4wi8NK0RmoPRMedlrmyIyu?= =?iso-8859-1?Q?lIweWXn0Z5zUXHzeBgMIMUwxt66VyokpJtcOqpMw6hhRP2km7kezogZMvV?= =?iso-8859-1?Q?UtBNzb6G01/XjdODTjfi6XDdn1eQBgqhkL4eMdqZtUFyaYGutXORzFnJ0H?= =?iso-8859-1?Q?ApI5ntBcaioNEbp7dOWWJneJyrmwgY46IEbgeQza/j/DxsxI2bXKbze+Lz?= =?iso-8859-1?Q?iH05WdTI7Coi4m0LbB52aSO7LRkrcNsLF2qsFEVYZiBuSf50XKrE0QvNMX?= =?iso-8859-1?Q?0glB872BIFJFy132p64lK3J9RAP9O5eOV+p4xQ2nBT8UJveAdMjYzeenrS?= =?iso-8859-1?Q?sroRjVXcOr+NdxRgU37ua9r+mgWBlk79H5jOzodemJ0F62vhoJ5VsAzvDg?= =?iso-8859-1?Q?pscKYUoZZn/9YOjaMuP13qjjdFl968u8wJ7fghZcFTBW9guLnjkaLATE3j?= =?iso-8859-1?Q?+S1nZAuDM5F5An1MYnwNny6I34kkZ1QptN4XSL9wF8oQRfXuwufshS1nKX?= =?iso-8859-1?Q?XJ4SEsz12nB7P4W+1RSPfr1Squ6JAmf4Q1wX3Qkvlo5/R08X+zm0L65rFR?= =?iso-8859-1?Q?PgpYWcRHSGTjlpoDV/TsQqrrsOj0+x39jwJCXfPCUZaM6BFCCYqhscoeG/?= =?iso-8859-1?Q?ks14rwkfylOeTKy5AVJuBsTr7SM8lDkkN3qZzc7nSkJXa+srSlFCBkDIoR?= =?iso-8859-1?Q?jE5642QYNbg6r4NOQFx2oy9nqZxiiPY0bCif4AjGrUnGlpGibJ+DNpzvAp?= =?iso-8859-1?Q?D5+Wus5hzAQzRrTF+opvMT3JQ4+2L0GPmVF9hBp9Y5P7mwd6BmGhUNnEkh?= =?iso-8859-1?Q?uUuOsgvrtSMgAPpaZjxCMRVsdS40HRV5ZgvswCm9ECPrPTP5wo0LzEwl4f?= =?iso-8859-1?Q?4EG0MosJBB0/fqkr5zzdIbJHKd6F4vn/9mN88B2Iu0Jo0U1Tp/hIzTS8ln?= =?iso-8859-1?Q?hjtZhsb2ToukY50O8u5OnsijmNv1dRGby0S16zkbebBbtt3EI/BQOBffxG?= =?iso-8859-1?Q?REgvcQ5v58TuBIEyCY6myHOyNGI2lHDHjRUaTVLEF3zVZjm3QEFQ5CXI54?= =?iso-8859-1?Q?7Uy0c8vRaK3kuWpGuctOTYDXcKJbvWLBnhY9ElOWTJqnMe5TWdzOHK0FK+?= =?iso-8859-1?Q?pXoK5mr9tTBzn+QrVeBLDje5YLCLmGbTLlMFCfLBlSoTlHZe0RTtvpjiL5?= =?iso-8859-1?Q?2+9QnarI4AkIFFxZzSsZc7tq+qKfYtyZSXAknS9x8AsJIY2h7pw1lylw?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: amlogic.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb4bc94a-f0a9-4e6c-52a6-08dd5193a7e7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7775.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 09:47:57.7673 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gLjCwxG36Pi0YqLNNF34/LziVx0QNL4+Sy9609uBuKXQRjVvhUilm/4PEMZNhrOg4jqIkByeYfw9mbqakhJZ548FOoANWYMxIWEX7OwE8WY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB6464 X-Rspam-User: X-Rspamd-Queue-Id: 125EC1A0002 X-Stat-Signature: 5xer5yqfch14bi9pe7u8riapzcgwzhhy X-Rspamd-Server: rspam03 X-HE-Tag: 1740044882-915208 X-HE-Meta: U2FsdGVkX19E7XIzBeLKfFQHV1s2kWCPKWhGl0NV03p9L76he+A8BfFoMUXuxnV+1s2Mk1nkwNPR/g57skNVTo9i2S1i+72yiBmlOY/nlNK9V8XNFL2OzUPpifkDajznEY+kDcuokDGOsqE/e0H75LL8MrzBisaID7pptDUCSbtlfMUAn3o+NMhVXyv2pLpigK5oRnauggmy2ZcBxzwRuzX8aLFIjL9WL+WKG3biqBXKejhQir/iG2owHAbbPZlFh4VbHxIxgWv3vTjS0pwctvXJZPwN9uyfNcmcQbkAOEdDB8bSRM2mSTQTJs9YV3YoSw6MENG6Q8LiGlnSWRy8ro5bXtc3kTGQ2s9q2tcGUtHHAZflLHTH7a6CHvIfxuK/e+MnJihUok0fA88M5jQ6uuZOCUbPZ9GmyzQqGFf/dWiT78w2ee+N8OswLHeVtSLVmduHOt5uWEWa4hS93Nkf9Thu0HqzgPV6kNYpbT8AjpdMGxFggHZvHORNpzDIeYSQgW7rQzFeoTUXLHipftxohG4Qa43OPZwAbCFRWQHSPzaz1xgqxlnlAE4I5esyCPniF9WEr+SZIJ2gO7MK/ysu42Un8k6yBMhE9SdQYjwrx5AMkh47F/8rOORXiVei2zUfu2JEchA3qa6h8ouGkmrvMZlEvEGd5bso4dsGxqKWFhJw1/hz8mXD9XUom2B3f5AMcf8gapeetYBfScTvaTvFnQ2gxrJlYgQEMNDZebKYaJ3d6xTMxaW4g72qyyO3A4mnLwzfkW5JfhVydKSDj9vXX1g+rCA59DZhzYgXFM0miPUPpJq/APaJqgYNIPoP695A5qz33xubiM2F9JBHgBWPyCMIQTw2nn4kuJAtEw4c5ZDFxZZ+HzAPpMu9eqFJ2Y0auaRx2nFX4uJtRvKyU/ir3NuQQyMWp8weR97j7E5hN+RDw796cktXNL+3jIcC0AU/xod8UbTr8+Vc5YCpOJE 10CeDiEZ K8zSkFZh51A0656x6Gtuce02sOyP7GP33RhcC58wcvJGImVK6muTnBVX2t9EF9XuB9CvyGkGcH0+fhGCXJkOos7FX5187SEhZh8S3UTgobJLFUNaaF0W2gvCj1t2gyqIpIReZkZBKhATeNGfE2sNiHgENurnk5DWa8e4yiwYzYDswQq/IVL5VJAppMm9YXPzquAxhD7LyS68l7MjzPSqndHUtlWea8cfJXoTV21ZUz6uEzSoHkfmY01gXHkzrabzILBd6bSwk2pQYmXi0iKpDGAKs/8QKGDOTz/ZCKXQWQeX5EuK+E/tL3AQF6Ahvo73FtBPgUSfV0doP4SerfB31ftbT2YxvGyoJiGk/klt6IHOlwJhq5mkH/MezbDyjrXuL2pmRD5elhbdJdBEGyC+040ibLTiulvhODLQlv9qW3RmsQEi46tuR/AN0fVnbkOaG7GCW5rpWX37pRsWymgERqztGIc3Mam6tLxrM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000168, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ------=_001_NextPart075086560420_=---- Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: base64 T24gV2VkLCAxMiBGZWIgMjAyNSAwNDoyOFBNICswMDAwLCBNYXR0aGV3IFdpbGNveCB3cm90ZToK Pk9uIFdlZCwgRmViIDEyLCAyMDI1IGF0IDEwOjA2OjI3QU0gKzA4MDAsIFNoZW5na2VuIExpbiB3 cm90ZToKPj4gVGhlIGZ1bmN0aW9uIG9mIFBhZ2VNZW1jZ0ttZW0ocGFnZSkgaXMgdGhlIHNhbWUg YXMgdGhhdCBvZgo+PiBmb2xpb19tZW1jZ19rbWVtKGZvbGlvKS4KPj4gCj4+IFNpbmNlIF9fbWVt Y2dfa21lbV91bmNoYXJnZV9wYWdlIGFscmVhZHkgdXNlcyBmb2xpb19tZW1jZ19rbWVtIHRvIGNo ZWNrCj4+IGlmIGEgZm9saW8gaGFzIGJlZW4gdW5jaGFyZ2VkLCBjYWxsaW5nIFBhZ2VNZW1jZ0tt ZW0ocGFnZSkgYmVmb3JlCj4+IF9fbWVtY2dfa21lbV91bmNoYXJnZV9wYWdlIGlzIHJlZHVuZGFu dC4KPgo+QnV0IGl0IHNhdmVzIGEgZnVuY3Rpb24gY2FsbC4gIE5BSy4KSGkgTWF0dGhldyBXaWxj b3gsCklmIGl0IGNhbiBzYXZlIGEgZnVuY3Rpb24gY2FsbCwgdGhlbiBhZGRpbmcgUGFnZU1lbWNn S21lbShwYWdlKQppbiBpbmNsdWRlL2xpbnV4L21lbWNvbnRyb2wuaCB3b3VsZCBtYWtlIHRoZSBj b2RlIG1vcmUgY29uc2lzdGVudC4KSWYgdGhpcyBpcyBjb25zaWRlcmVkIG1vcmUgcmVhc29uYWJs ZSwgSSBjYW4gc3VibWl0IGEgbmV3IHBhdGNoLgotLS0gYS9pbmNsdWRlL2xpbnV4L21lbWNvbnRy b2wuaAorKysgYi9pbmNsdWRlL2xpbnV4L21lbWNvbnRyb2wuaApAQCAtMTcwNyw3ICsxNzA3LDcg QEAgc3RhdGljIGlubGluZSBpbnQgbWVtY2dfa21lbV9jaGFyZ2VfcGFnZShzdHJ1Y3QgcGFnZSAq cGFnZSwgZ2ZwX3QgZ2ZwLAogCiBzdGF0aWMgaW5saW5lIHZvaWQgbWVtY2dfa21lbV91bmNoYXJn ZV9wYWdlKHN0cnVjdCBwYWdlICpwYWdlLCBpbnQgb3JkZXIpCiB7Ci0gICAgICAgaWYgKG1lbWNn X2ttZW1fb25saW5lKCkpCisgICAgICAgaWYgKG1lbWNnX2ttZW1fb25saW5lKCkgJiYgUGFnZU1l bWNnS21lbShwYWdlKSkKICAgICAgICAgICAgICAgIF9fbWVtY2dfa21lbV91bmNoYXJnZV9wYWdl KHBhZ2UsIG9yZGVyKTsKIH0KLS0KQmVzdCByZWdhcmRzLApTaGVuZ2tlbiBMaW4= ------=_001_NextPart075086560420_=---- Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable = 
On Wed, 12 Feb 2025 04:28PM +0000, Matthew Wilcox wrote:=0A=
>On Wed, Feb 12, 2025 at 10:06:27AM +0800, Shengken Lin wrote:=0A=
>> The function of PageMemcgKmem(page) is the same as that of=0A=
>> folio_memcg_kmem(folio).=0A=
>> =0A=
>> Since __memcg_kmem_uncharge_page already uses folio_memcg_kmem to =
check=0A=
>> if a folio has been uncharged, calling PageMemcgKmem(page) before=
=0A=
>> __memcg_kmem_uncharge_page is redundant.=0A=
>=0A=
>But it saves a function call.  NAK.=0A=
Hi Matthew Wilcox,=0A=
If it can save a function call, then adding PageMemcgKmem(page)=0A=
in include/linux/memcontrol.h would make the code more consistent.=0A=
If this is considered more reasonable, I can submit a new patch.=0A=
--- a/include/linux/memcontrol.h=0A=
+++ b/include/linux/memcontrol.h=0A=
@@ -1707,7 +1707,7 @@ static inline int memcg_kmem_charge_page(struct page =
*page, gfp_t gfp,=0A=
 =0A=
 static inline void memcg_kmem_uncharge_page(struct page *page, int order)=
=0A=
 {=0A=
-       if (memcg_kmem_online())=0A=
+       if (memcg_kmem_online() && PageMemcgKmem(page))=0A=
                __memcg_kmem_uncharge_page(page, order);=0A=
 }=0A=
--=0A=
Best regards,=0A=
Shengken Lin
= ------=_001_NextPart075086560420_=------