From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C6DC021B1 for ; Thu, 20 Feb 2025 12:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB9354401D6; Thu, 20 Feb 2025 07:26:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C67C34401D4; Thu, 20 Feb 2025 07:26:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2F664401D6; Thu, 20 Feb 2025 07:26:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 95F2F4401D4 for ; Thu, 20 Feb 2025 07:26:23 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0601F1614D7 for ; Thu, 20 Feb 2025 12:26:14 +0000 (UTC) X-FDA: 83140245510.21.0727202 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id CCEBF1C000F for ; Thu, 20 Feb 2025 12:26:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HgZ+kY9L; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740054373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YvVj3Y+E/X9aMBDeF+0zodv5Y6r1iWhyl676Hl/yr5o=; b=02zH6CN26AKSispmI1Zc5wDzjHkUpdbHBOr2O9g019e0kij64gGaFwrT/UzBUqJ4PE4AnH SGg8EivHhNPMAuexYqvswEddSQcDA8I+myvL5h2vbBifW/6+gkZyz4hlXU3wqJxMAyN7P2 XfNCywNP76umicWHBXiA3nKWgTTwjyE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HgZ+kY9L; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740054373; a=rsa-sha256; cv=none; b=kO5zz2HjX0twi1a8ReQCLoyEAJCGecr3KmXdl3pzS96o9RtxFYsutdmYB6mJRY9sSXeIgb 321QgTP1wQX1ex/5rbWkOWgHxP+7H6ekrYGyLk2KumqqM6pU1LJe4kYea0HfUPB6DJ2ASu h/1WeeftGPAtamEtysztqFS7gWxq9NY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740054372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YvVj3Y+E/X9aMBDeF+0zodv5Y6r1iWhyl676Hl/yr5o=; b=HgZ+kY9LVHzVBXRjeLbCdP+z+IotU+rjRa7YG/qA9G4upP9h6cFdlYDY/lxuP6T5SBfJlV pFmkPnNe/MAY/wQ3jWiyNushwY3ot65fvM12N2zLLsXa8dvtu20gzFV4LAqg3CTTmQyya2 0KMIaArNSLFfpbQlXchY9IWDPQyr0es= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-Lpk1sia7P76NWT0yuqVEtQ-1; Thu, 20 Feb 2025 07:26:09 -0500 X-MC-Unique: Lpk1sia7P76NWT0yuqVEtQ-1 X-Mimecast-MFC-AGG-ID: Lpk1sia7P76NWT0yuqVEtQ_1740054366 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 78AE419373C4; Thu, 20 Feb 2025 12:26:05 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.147]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 9AE43180035F; Thu, 20 Feb 2025 12:25:56 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 20 Feb 2025 13:25:36 +0100 (CET) Date: Thu, 20 Feb 2025 13:25:26 +0100 From: Oleg Nesterov To: Tong Tiangen Cc: David Hildenbrand , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, wangkefeng.wang@huawei.com, linux-mm Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() Message-ID: <20250220122525.GA30669@redhat.com> References: <20250217123826.88503-1-tongtiangen@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> <20250219152237.GB5948@redhat.com> <34e18c47-e536-48e4-80ca-7c7bbc75ecce@redhat.com> <2fe4c4d1-c480-c250-1ba2-1a82caf5d7fa@huawei.com> <196fc7d8-30a8-439a-89bd-57353fd98df8@redhat.com> <85725388-180b-267c-e121-3af1f1b75f94@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <85725388-180b-267c-e121-3af1f1b75f94@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CCEBF1C000F X-Stat-Signature: qtiohgbw9if41dzbim7o5m7hknqorikz X-Rspam-User: X-HE-Tag: 1740054372-820741 X-HE-Meta: U2FsdGVkX19lqshwKDOI4/qsAHJJTsNeet7w6h6EAAzYQGQXKpCY6bifXadJc3n1GDtYq2fP9DVTus28tsZEGVLPhwb7oEfZ2sLPC3AlXmFMW0OPuxj4t/Di29PuaQlTWyfbn7g6khmlkkQK9ANqwPed79Bc8gH4YZ4Vxp+DTFTMg7o3xoLIo/WCgnIqsTUaS11OWjjdfGR7fjBIJomQt73etjvZNgO+Ky574WmVuDAqmLWAr+dbTJJo6svO2xHXsD7vFg2Xlq2rhQ3qg4+dvM8z/BwP55KIXh+uNcmYi8qm26D45Ua/LBLVqnFC1WQ85oj5LBHyl2iefruVjXVQbIx+0kr1S40ah6m0798BvC4LTypMz6mQNW51ru6FaXMwnUd0s3FEYBgzBvk55vF7c5O7MSiLhUTyoZCJrwnjIT+UEagVHbXasFVQAH3wbBpaRnWZUA85H6IeaQ0N2A9zLhWfikimqd10twSa68Q1PqY/7qs/4G2nLIl92EyJdOClPTJjCGeTX6lIpPVfM3zQNjbhN4FjYyPmNcX6sH9pQVMTO9nGiFFTW5PTGFNxvNBnDfwLjKH0ljWILAZDXCI5HtIsmqRObYeqCEDb8zl3GC3DY4QuxPrWkPE83O1OJcCePNaEgH6aN0SNofOJcctY7wBuLgl6KF6Iwb8XRXTv455KzitxAeqtUaup2Ac5lf2+Anx6tQDoWFNrFVR4keMO18ZPljTSjXaZLdBdB8uOrlwhrNDG9JaSTHMJR3x6gPdNora9lF0toRYY6nNyVqDA/FfcyywG0vlsn5LTlw/fPPokM1zM94hw4x7a9jN7g53gAc1tEBSjuxhFzLDSF9uj1ivECTtWlPkmWu9VbG1+syE0k49gZfpRadnBVkEA3MmyQyiaSd0NXOu5JH+EA+Wb+SgJD2QTm5YlhhLfbKhh/9grazyQ6ONsxs8Ymd4CfItLcZeODjNG4WiOg3ihgm0 s4xKfyLV kQRkY7SWRAxKmHsVhDDl1J0Bnc7ll9VZFZAZZ+a3/gOMVkg/EsjGSfk6qsDnANhT/i6glHI6EGUT2vdK9XXeF6Lk7SltmEaulpYjJs6Un3CcAtLZTlbnnm78cEHMgYx0JKZ+4kdD3e5vUjbjkWgIhawMnnlEjV6cjwtk7DHuo81Ncc7CiF6Nq4RQNBnFC5OKyZVNHxT/42FG5pUChz17YXrTuRaDaYkDe7nw5mvMOlffdqxMa7TIpEXhdKQVtBArVfLTnENlg9Ns9Fp52lgSFbi73LS4onWFVWJOmnP07fd57Zl5PP1gHm49jj6xSQHbLgYXmwolG4Eu7Dgzpq7gS7FCCUEdYdlF+Xs+sPVtP4VC4/9Lb1iRr0NAJRdPFE13R+egT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000256, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/20, Tong Tiangen wrote: > > 在 2025/2/20 16:38, David Hildenbrand 写道: > >On 20.02.25 03:31, Tong Tiangen wrote: > >> > >>@@ -506,6 +506,12 @@ int uprobe_write_opcode(struct arch_uprobe > >>*auprobe, struct mm_struct *mm, > >>          if (ret <= 0) > >>                  goto put_old; > >> > >>+       if (WARN(is_zero_page(old_page), > > > >This can likely be triggered by user space, so do not use WARN. > > OK,thanks. > > Hi Oleg, is that all right? Thanks, LGTM. Oleg.