From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27170C021B2 for ; Thu, 20 Feb 2025 10:24:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4B52802C3; Thu, 20 Feb 2025 05:24:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A83FE2802C1; Thu, 20 Feb 2025 05:24:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C022802C3; Thu, 20 Feb 2025 05:24:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 751902802C1 for ; Thu, 20 Feb 2025 05:24:22 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A963A120575 for ; Thu, 20 Feb 2025 10:24:21 +0000 (UTC) X-FDA: 83139938322.29.CE581E4 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf27.hostedemail.com (Postfix) with ESMTP id 4780040003 for ; Thu, 20 Feb 2025 10:24:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=a5+I1Lno; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740047060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G7hgjesSmpA0ko/eTOgvJmvU9Qe0b+EIBkdXyjk/XSo=; b=8WxRTBMfMBhrnTrQ9T6f1XVVZ0rh6cBI4id7hi1e5VrwBsYwkOnJj8erMvuBj/rFjJRlmT iuLzqNTbzN/N0P4I04hozPPPZMvjfve5mc+d0OJJfORCqrSKryxT7cpYAjH2Zq6JUOirB9 uog91QdCV02gZFRbEOGKf+JTbfBLIcA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=a5+I1Lno; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740047060; a=rsa-sha256; cv=none; b=D5mFeOgtIb6baACyLlUG8lR6L48Bgm6iuxT2KX8EmCqiU1gQ45Ft5QnnNocu3c1B60HIPM zsvH4iHuKqn7tN37RKcd1AMqyGpKV45sZ5Cu+5HAQbzyzf9uvBoqAeCgwsyA+M5kqj2A2C b97v1L7W5MyPF3k+IDDGrC2DiMVHQW4= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 78FC640E0177; Thu, 20 Feb 2025 10:24:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y6CF0GisjbJy; Thu, 20 Feb 2025 10:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1740047051; bh=G7hgjesSmpA0ko/eTOgvJmvU9Qe0b+EIBkdXyjk/XSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a5+I1Lno8dQW6mPso2rBSCErDnruVQpFMduikIWDT3ExtLMEG28z92Pia9zixNyIB JGKlTzGAuphWYDhZNaSa0Jwm7hTNhY/pwmUCvVRRxcJVO3hqEmtZdLU5SdCywq6FYO OMLM6vIl0ogEp9I2wbk1w6HgHhXjL9y1JPLOVrWvlNonVdWR2Ye2ceGbTDe2O4lUi3 BADExEKmokHO1ll+EKOV5ltRK/wF4lg0c5bKXqU+fFOfUkqMHWo4jlZynGQQyEnR8u jof3vQjSxbwu0NcPlrAuJIJo0Vqrbmv18+Mkx2F78jZ3UDlOhdwwI83IjjGjn0TrFs OZMhilT0Lh/udTtOrfO6hahU5Mff+f4EfBVl3r4UYALmSJrbd0oSkljRe3aIuhZ0wz j6LhpNPQyYlgA57mmaGgpNMDabtjLqGBp/m9AY6dBU/XWTLV/gtGb1/260wGPCvVDo sh9htXGmYnnHYhju8pgpNMmBm+yu9poItopA5TDKbv3nBU8e2mHnmKRF9gvKZF3HH1 j89onICHQaUFLf7THUTm7vAba0+Var8ces4qGdqLaRoFE2jyZ4pvUxxYAR8QWYWeOI lObdoTr2JblxajHwvt2e3BPCaEgo45yjOWzHlzNGanlO621cVnZ9JCcDoD2ViX80Fu RtxTJzCmXaMKFFyeI9Sg6z98= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4430340E01A0; Thu, 20 Feb 2025 10:23:54 +0000 (UTC) Date: Thu, 20 Feb 2025 11:23:52 +0100 From: Borislav Petkov To: Rik van Riel Cc: Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code Message-ID: <20250220102352.GBZ7cCuGd_hy-OaHlK@fat_crate.local> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> <20250219120441.GNZ7XI2aWWUmXh2H2m@fat_crate.local> <2930024a88be186faa6a0338fc003e8ffefb710b.camel@surriel.com> <20250219191519.GDZ7YtxzBiMxz3wwlr@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4780040003 X-Stat-Signature: m5a9waiisfqk1zgi3fjcqdta1jb5wcr4 X-HE-Tag: 1740047059-808905 X-HE-Meta: U2FsdGVkX1+kr2dRvPlC5P/ulqGppj5zhultLhSMQrWigtVktnejuQDj02NOmHv/OCgtizMXGo/OGidwflyGmQoveFKlSHcKdaVbpV1yy9tEikrvc1n9k5So8dAwSBfQ2V5tJHGl037DDjn6Ld4djcyXt7tWu9qu2TqVXn+DxBg/fI1OF0H1ID8oE8GYpCihhQcqdBJfioqOfPybqGuzjGtqy1J+7o5vnCk9Oe6K8KYESHgmFoR0pRWeIGAAMH4VqVRv+IJkJF+4l2S5DelXlgoaIGlEbxQp+cLSc8wRiR2hfIAnhx/utMDYGcfnJ6U1+ATiauKOQMJYKXp13asEQtzL6MvBsok9CrOuRVDXe1+02TLrqrpQf/8ftmA7jiCDzTSPwhLY92spLUGiVF8Mo0XgSnr1ahf7EGQZjM2YFPE1AdB6uuv/lwVIwhYjhY9ZnCspz/99Ai2gLVnzl6CubXTZS+jOFh//z4prZreoBpnwlbuan9iCZzybiXEvsgcgdRQmk4YY3ha8md++AflxJYIjEEs4ZtWEYWRgVypoRyrUKW0xk0m7ZEwWIaLaeEnU34/so/63PD8M4P3ukDjEBPTY7U/0M2wLknRCbgZjmpyFgwhRhUZ2Qnmyh0BmgRDu9D9AikBxqtzA0rcvumL9VIFpHpJlK4VL6ThZA+H260785A/5ewJRquJGxOqfw7JrIV6HLW+X2hc+wMg4xErSiUqs1E0786bQU/sgNoXGCndq9ZrddsPLL5i17ahQ8pGBlA3WPc6P4Y9SDRyXMQKCGVwYnoAxFo3mLXmMQtJHr/A58Nf7kZiwWyIBVaxDwOOOzCmBgwd+hZMjKjpimpEBr1FQaRV3ni2p4zdarOd/lV9itFGKVmcUTktoOgL+HuTAMirELX0hrm17PKpydIRcL8I7gj9/7H612TO6wxU/UUsqAwc8diFYI9uX0ZoE4TwPyLCr6PKisH52RDGG8xN SZeoN93p zd52XmhFpVqKFB+732BOqGlDvLhTCiB6NVb1A4IA/iXKcFV0eOWi3orFMfIZTEADBKoELd0KaIT1pjQD4pX311sRbRpTTqsHKaNfu/+/9y2YOH1B6P8NgJ1q9acE3/Ml6uyayAIr4cnZUODfy+nRDqm8AeVrF0JQ/s7p43J8QUk6//tQ3OcrVhRGFe9p1fnTlp7J7ZSknVGEo5T459b52J77MyoYRzzPQARZ5XVNr88R0r4tRlipsg6QETIkWvT+g/6ciUoQSQ3QB+HAAP3yMucGJg64yXiTWavYPCmKtoz/+nxbqIlKcOsu+VMGT6ucZAT8TR9p7V6JY/lCy69uTFIfUYA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 09:49:01PM -0500, Rik van Riel wrote: > I'll re-do the series without ifdefs, except for > the one masking out X86_FEATURE_INVLPGB (on 32 > bit systems). > > Then the compiler should be able to get rid of > the other code, when the feature is hard-disabled. Thanks. In talking to Dave last night, I think we are fine with having the majority of ifdeffery in headers and keep it away from .c files. Any new Kconfig symbol adds more configurations we must build and test but... oh well. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette