From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04938C021B2 for ; Thu, 20 Feb 2025 08:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E8DA6B00A9; Thu, 20 Feb 2025 03:36:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 697A42802AA; Thu, 20 Feb 2025 03:36:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EC426B00AD; Thu, 20 Feb 2025 03:36:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C9B72802AA for ; Thu, 20 Feb 2025 03:36:07 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C5A33C0E3A for ; Thu, 20 Feb 2025 08:36:06 +0000 (UTC) X-FDA: 83139665532.22.233E8B4 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf02.hostedemail.com (Postfix) with ESMTP id 84D5580005 for ; Thu, 20 Feb 2025 08:36:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Zo0U66KB; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740040564; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SEaHAsDM2MLSNpt7MvRkD4rjd16wxN3bWpPMinYr6Xg=; b=cHM7AJuZ67FcY46R0x72ce4o0CgyUHVh+O3iG6G8wpBSSv5MvKV/8IcncwnV3PasRJ4sxe tbJ2V3+LQVyrWr2a1qjcmyoTP+189rTxYwaCbPtj7pk3V4PZnsghFARAhwwfqUx4Zhaw8N yb9aAbphJLuT+BBWmm/UajKHfDpGOEk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Zo0U66KB; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740040564; a=rsa-sha256; cv=none; b=EZUZov8/kW2fweg2FZ0mopC7ed4sAIpVzzvbeosLo0bzYjLwr9W3Hhcf2xWh1lzmf5kLRL I7zYnNmWAgaG2cZ3tGZDShgKTckWbPLR1q/rFi/NkG+ExQ0r9HnhQKa+7cEa661IDx3LkF aPQF91Q57hhB7QyuQb0zdhmFPr18hTg= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-abb8d63b447so93460366b.0 for ; Thu, 20 Feb 2025 00:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740040563; x=1740645363; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SEaHAsDM2MLSNpt7MvRkD4rjd16wxN3bWpPMinYr6Xg=; b=Zo0U66KBKuhacYFrszqC9IAQ9hI0v40S8NY5PBWvElWlQ8KHLF0YXXAttmGH5r/I5T +6vmRuZOndcsOCy+gXdgxCtsPU0om8T65ayrAtCs9XDcCDPrJe32aygtZCfNwfk5csCS 6o5BivW5nXMtgzMYiGDoVr+cXtCKB790g+3qFPVi0hb1YJo9FMlVNhbJtj8OgpI+FjQq xX7/PBCDwKMMFsC4oCwJb6NjgagtplomguNh5zoVTqmJtjmRY4QpXsUGji80BLamhfAo F6ii+76oCV7pqAB5/dgrq9lYXHQUDXjlsmZEZs0hZBsqSjW1uBHc4ysX3QQz5CLs/0Yr 5+oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740040563; x=1740645363; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SEaHAsDM2MLSNpt7MvRkD4rjd16wxN3bWpPMinYr6Xg=; b=nrVKHS6zA6/ADvpl/mMS6h2G5EJohd41XHhfnyOHF5nvlaSiODLbBTKe2C9whM5VUz MFiCv0fV5EoAQjZKopCc5YLlNsML0rp2v4Lxg2hIVlHgDVOKDa7fGtDTpcx5OLWYrnDH O8lLLHarwSYF3WjQIZW41T53F9V9o1NiEbauUC8l1E0Tx4LrZQgFv0eVaMhDzGN6Zzi/ My6bvyStLFwIYp4Yzeg0GmNUpMbyaapALLayodP10SMQak5c1Hn6joNGRt5RN+KFJP3H NfKS7ON4slAq9q0IqaVRZmhMC5h1dYkzQAtnAX1v4eUpSJidtZ5BDcpmm6SWIdpin537 AnNQ== X-Forwarded-Encrypted: i=1; AJvYcCX903TWM3i4cVEWPGb24lwLQQh/zm9//5j3x+uGUZgRS9fhj2rixSrUY3VMHB60JE5PQCCfCeFbOA==@kvack.org X-Gm-Message-State: AOJu0YyKSAsK8CAjMydOEh0meYpJ0pK2SZS7q1C8k3S4U1lQSzkQRBwq IuU5tjtGArR1pdZE8h0UUEzpFxsMEYXboOP9TKYVU4s37CdHXDmq X-Gm-Gg: ASbGncu2rWCyyUBnMKRf5Y3XbYeaXBjg6UGu7j1NWkpmPCc6h03m7on/Mq8vxtFIQBd WTZC+47fDKSz+X3RAXr4HoCEMNBl5VhDOJqPcDSbw7jsbM6rlJJCIoQwPxvDN8TIoLfMXLhbfE9 5Sh9yEJpv85rHyB1CO5eKOGT3FN7QHwJLN0mI+rZ/97D6OovKBWiet0fVtkpSHfaFbp3N5vn4VL UmvtytzFtuPfkcNMWTlBJ8GIUJXozNmkL1c1PshwDp3AW60uS0eoRvsVQoaXUoFRhJCOVDqpCwn twfCP6tR8943i+4= X-Google-Smtp-Source: AGHT+IE9Q2O6cgNo6w+VEkK3+GcOBd0W7VIAg8ovqvSo1Dx6kdse3rC3i3ABuRQoN+lqO1U9Ke9Kyg== X-Received: by 2002:a17:907:60d6:b0:ab7:f0fa:1340 with SMTP id a640c23a62f3a-abbcd0b2d3dmr769569466b.50.1740040562436; Thu, 20 Feb 2025 00:36:02 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abb86c9320csm915498766b.55.2025.02.20.00.36.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Feb 2025 00:36:01 -0800 (PST) Date: Thu, 20 Feb 2025 08:36:01 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 01/14] mm/mm_init: rename init_reserved_page to init_deferred_page Message-ID: <20250220083601.4p6ehmfhyvs5q5io@master> Reply-To: Wei Yang References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-2-rppt@kernel.org> <20250218145904.x57chhz3whvckzu3@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 84D5580005 X-Stat-Signature: o7f7irirkfetizu8qdqhdx6q8ui1d7if X-HE-Tag: 1740040564-378176 X-HE-Meta: U2FsdGVkX187MQoQHto44qCBbeAz/YAzUJM4Ot8UhskhzVnF287aRtBKNucN/h/0KQvScWmSUe/zdhDK43VLGOauG5wQAt7IUONtwy9NWiupkeAzPFbL2xBwvueLA0sa9Dapl/X1vsiqE3d2WgJFpksNAU6CFk/VGJ79kZncxH9QGi9C2s7kmaduX4l1i0YprnLV/5SDmznVqmg5vbtJtlmqGAlTH73BpDdOAXJdeZnRZ04Lkevgrt2x+24oMEZtoBnXCgp1Knh1Tyc0EuPoiavM6rEJkMpc2/4vSn3kMMr4a/VOUwi3G+unqijxEFZ9ue5U6fjT4hhOsQSZdSm+D2kOZdk33/Z66PP5HTjb5WVmlfnII7uehJijNfe8911AESStaQvbxhFkc4iS98vGfKIl9vPZhI3FTcLWGeZcoIVczxSWhRs0rzPTNu6H/0TFtdk6U+gktOkpAoCm+TWiWbYhD1mx0evA8jlNiraiEoJ7sUMp3E9Vehh5M23blPRZBHZ6yUOu7zbMJafgHvj+jZobtLHiStcTGPAshGyv34H454M39bt16I+1WBszVNVynzPl898/fPhF3YMKrmDq2NV+nDUeyx3sZAJbp2o0vLym7nkjaEKgsKlIDM5omrAqWT0ZXuNr5cs4xnQvXadajdEECwqmazs3CPIhVgoc+DNIcNYqgbtOcS0J2WiMfWdkvdhpUwSoXNC9odPd0Wd5ZdLTSWHARYAS65nbGHFA6axfsLXzT+ind3ofciIb4TEr6zUHHu0qnbVARrTa47imyCMYoOiRzPmcKAtZuRPD1/gShVq0D0RpK2osz4lYYzh3lRDRtKzAxBQ/PxvAjPohsa5vaCx9lrdIgcYLpQ9toQPCLsOdvlxCai3mWjTzalmu/wsfttNuE7FsjJFl+327maaITvz3tr5o94pI1limoi/ezjYYjG/3BkvH5t7y4PvqqKRDM5/yVVZatZso3bG tc4qTXu6 0SkyvvKl5LlXskzBqeHjEC9sNjTzv8TWdGVT2PRfTzQcTN2QROGSVd0LigcIRyL6EaQ8lp9LvfaYTNOI+EewqBpqgvoCoWIKsA87YJZvkbKXcfKAiTTLpyzNfk09sjBeuDfscZFDT4u+yBR4o42RQ5c6vtay/fD46xGe/FK+qW2Tr697Db+qd0o0XLKNFejmDGYaQQgTOTEqzArtE+9EdHISyGgRUUYYjJAkV99R5AOXJHkX+jWiEk7sp0Nq1pHkN59c/OcfL+Kwr6NB5UhwCWJfWX232C/PCK8kJK6CHRWk5s3ucxhUhHVaBgXjd7mQfg98sUZwHHq8LjJb00YveGSi3zPZE+dswCyyP6yvMh/dlbn5tpI1wijekrdHtN0XxCajuuLQ0Fndw5lJmRqqTK024eYWuVsLob3udxYkVNYq9n3pW2asf+qSN+EPxYx6uGX62VC2XFqIoSWX+oQMiWYfCkvOeW3tyNYY+guCn0Dsq3JIJgAJUSduQRW6UWDXlYrJKRXFynlR5QPKtRjH5x8Vg617CAFexHaeucp5UXqO3kgHVnAZOBf2dQlw6SZicujHW+jVtXNewlPPZr9LKH6twEjOPg86t2rgl2OD1PCUrcOCUknCNNFy6c9JILS5SA7mTJ+KXGIVrqZO4si/IyNrA4MMR15r523s1DyYFCX4lUgfgnFX67hRdW37UqbsF7spaHVr1/aoQnzw9m/9LHktR1dxwz2UPTdc5Fok5MsvBpHv31FUZUwOdfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 09:13:22AM +0200, Mike Rapoport wrote: >Hi, > >On Tue, Feb 18, 2025 at 02:59:04PM +0000, Wei Yang wrote: >> On Thu, Feb 06, 2025 at 03:27:41PM +0200, Mike Rapoport wrote: >> >From: "Mike Rapoport (Microsoft)" >> > >> >When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, init_reserved_page() >> >function performs initialization of a struct page that would have been >> >deferred normally. >> > >> >Rename it to init_deferred_page() to better reflect what the function does. >> >> Would it be confused with deferred_init_pages()? > >Why? It initializes a single page, deferred_init_pages() initializes many. > See below. >> And it still calls __init_reserved_page_zone(), even we __SetPageReserved() >> after it. Current logic looks not clear. > >There's no __init_reserved_page_zone(). Currently init_reserved_page() >detects the zone of the page and calls __init_single_page(), so essentially >it initializes one struct page. > >And we __SetPageReserved() in reserve_bootmem_region() after call to >init_reseved_page() because pages there are indeed reserved. > Hmm... I am not sure we are looking at the same code. I take a look at current mm-unstable, this patch set is not included. So I am looking at previous version with this last commit: 8bf30f9d23eb 2025-02-06 Documentation: KHO: add memblock bindings Here is what I see for init_deferred_page()'s definition: init_deferred_page() __init_deferred_page() __init_reserved_page_zone() <--- I do see this function, it is removed? __init_single_page() What I want to say is __init_deferred_page() calls __init_reserved_page_zone(). This sounds imply a deferred page is always reserved page. But we know it is not. deferred_init_pages() initialize the pages are not reserved one. Or we want to have this context in __init_deferred_page()? >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me