From: Hyesoo Yu <hyesoo.yu@samsung.com>
Cc: janghyuck.kim@samsung.com, vbabka@suse.cz,
Hyesoo Yu <hyesoo.yu@samsung.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] mm: slub: Enhanced debugging in slub error
Date: Thu, 20 Feb 2025 12:39:42 +0900 [thread overview]
Message-ID: <20250220033953.1606820-1-hyesoo.yu@samsung.com> (raw)
In-Reply-To: <CGME20250220034151epcas2p3e23d8496e872b49da28ced7a87edd4ad@epcas2p3.samsung.com>
Dear Maintainer,
The purpose is to improve the debugging capabilities of the slub allocator
when a error occurs. The following improvements have been made:
- Added WARN() calls at specific locations (slab_err, object_err) to detect
errors effectively and to generate a crash dump if panic_on_warn is enabled.
- Additionally, the printing location in check_object has been adjusted to
display the broken data before the restoration process. This improvement
allows for a better understanding of how the data was corrupted.
This series combines two patches that were discussed seperately in the links below.
https://lore.kernel.org/linux-mm/20250120082908.4162780-1-hyesoo.yu@samsung.com/
https://lore.kernel.org/linux-mm/20250120083023.4162932-1-hyesoo.yu@samsung.com/
Thanks you.
version 2 changes
- Used WARN() to trigger a panic instead of direct calling of BUG_ON()
- Print the broken data only once before the restore.
version 3 changes
- Move WARN() from slab_fix to slab_err and object to call WARN on
all error reporting paths.
- Change the parameter t ype of check_bytes_and_report.
Hyesoo Yu (2):
mm: slub: Print the broken data before restoring slub.
mm: slub: call WARN() when the slab detect an error
mm/slub.c | 60 ++++++++++++++++++++++++++++++-------------------------
1 file changed, 33 insertions(+), 27 deletions(-)
--
2.28.0
next parent reply other threads:[~2025-02-20 3:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250220034151epcas2p3e23d8496e872b49da28ced7a87edd4ad@epcas2p3.samsung.com>
2025-02-20 3:39 ` Hyesoo Yu [this message]
[not found] ` <CGME20250220034153epcas2p286194dda687b47a3dec8fb89b868f96f@epcas2p2.samsung.com>
2025-02-20 3:39 ` [PATCH v3 1/2] mm: slub: Print the broken data before restoring slub Hyesoo Yu
2025-02-20 11:01 ` Harry Yoo
2025-02-20 21:49 ` Hyesoo Yu
2025-02-21 8:16 ` Harry Yoo
2025-02-24 2:43 ` Hyesoo Yu
2025-02-24 14:08 ` Vlastimil Babka
2025-02-25 1:09 ` Hyesoo Yu
2025-02-24 17:24 ` Christoph Lameter (Ampere)
2025-02-25 1:11 ` Hyesoo Yu
[not found] ` <CGME20250220034155epcas2p156b90cfb655a03cce4bfac9683f0bfe1@epcas2p1.samsung.com>
2025-02-20 3:39 ` [PATCH v3 2/2] mm: slub: call WARN() when the slab detect an error Hyesoo Yu
2025-02-21 8:30 ` Harry Yoo
2025-02-24 2:45 ` Hyesoo Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220033953.1606820-1-hyesoo.yu@samsung.com \
--to=hyesoo.yu@samsung.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=janghyuck.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox