From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4691C021AA for ; Thu, 20 Feb 2025 01:12:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D15628027F; Wed, 19 Feb 2025 20:12:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3811828027D; Wed, 19 Feb 2025 20:12:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FB5B28027F; Wed, 19 Feb 2025 20:12:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F372A28027D for ; Wed, 19 Feb 2025 20:12:56 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77D2B806A2 for ; Thu, 20 Feb 2025 01:12:56 +0000 (UTC) X-FDA: 83138548752.05.7F2C616 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 6BCBA100006 for ; Thu, 20 Feb 2025 01:12:53 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=23d8mdim; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740013973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OjyUhgaXJe5srU1oJ64DWC9ymxxyDTuqu9jkMdpx0Ow=; b=PYxasx1Hq9MJ/59PH5nd5lOmYeQgfAV3FCM44vHd8vu8RazaEZM3ChXUuFOx9fLwNhAKdM tp+AL1WhpQNfaq2IhbV+Sw+6JD8pB5xT6wKj86giSL6v0wBbZ0jyb6tl1+BmBDQiBsyi8D KcZTloZwaMzTGZad0NAxtaUN1Oe/fJ0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740013973; a=rsa-sha256; cv=pass; b=dxywKQkIwzNTezNYMikAhYp6rCe5diB7tHF9h+2FERf9/1v/uvM3AkJHvPkShCdRPcs2DX XIQlb8gPpI5BmUvlp2RSLWaUdYRn46irV6jc21flD0JF0aYpx7XCjNqGczz2q6Vra56yfE U4KEBH2vglDUtBPTU5IE5Br5eNt9nWE= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=23d8mdim; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf05.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.50 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y69Y9ceTDZIw1vlgoXAQuyF3g413syTn3+5pn8lHDiq9zd0DxJH2kSHgUJIx53lW2+AJYm1Ri8ZcEyazLZ1Zwt++dEmV4jb2qbKNe2RjwNuhhh13RHxTa0CrNJtVmSMQ9aiO/7UgdpIhEFMZwG51bypXUe2ejcrqkvp/GgIE+so3kvHO0nySm+TbxtSPpZBOWtwco9oFaqa2okKiwOPWQ4nhozk3VBstTi3AzI1Q9b1vmM2BKoLK/UxV0oVmzTwSl28s5+FpQKbasU4W+gYhIYFLXS/vZ31GS2KUi4H1Zxng+Q1AHfmfVy02oE5liJJYoNYut1OL5V7915nkzfhHYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OjyUhgaXJe5srU1oJ64DWC9ymxxyDTuqu9jkMdpx0Ow=; b=jsZ2Q6smOo0tp/Es+TkNJkGLLzmWEv5hKcILjD9TajJcOsOpGhohXb/V8ej2sdWj3QFphys9RYaNt7+PCN8dTVht2S06jbJCmSzMFddjOqNVXnWAOJynezjY57e1/DNY34gIVZjQProrLHHB9vXFqUzEZpM1B2r3iLgzg4lZVR1gbOOhDg+t6mXuogSjFluzB184zewjQvL/8juNiQ7hr/aSx8k80o5XO+sIvSFyCn6Rm5ifS0JoC5sGq+Nma7KXB10nY92Z0p+fqSe+yHyzh7e05Us0nIG2Qb2DKFleV4p9LWR4ygO9jASNcP3Tj/OHuEfck0hJ4zE3YqQHJF9NGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OjyUhgaXJe5srU1oJ64DWC9ymxxyDTuqu9jkMdpx0Ow=; b=23d8mdimANkRui61a6tygWGQkUtLuANrbPFC03LXTTqgNB6vKlDkUIGnC1u5FqoRnhrme+1aISimvWowDeiadHGXC4RYVRzsbw+KeqfmEZ3U25wT9yfPMuhL08eEsZRUNYYKAr4ylqz9g4d2XHHVUHGsc0RJgPdQi0Y7qRkGisg= Received: from BN0PR04CA0061.namprd04.prod.outlook.com (2603:10b6:408:ea::6) by MW6PR12MB7070.namprd12.prod.outlook.com (2603:10b6:303:238::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Thu, 20 Feb 2025 01:12:49 +0000 Received: from BL6PEPF0001AB4A.namprd04.prod.outlook.com (2603:10b6:408:ea:cafe::9c) by BN0PR04CA0061.outlook.office365.com (2603:10b6:408:ea::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.20 via Frontend Transport; Thu, 20 Feb 2025 01:12:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF0001AB4A.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8466.11 via Frontend Transport; Thu, 20 Feb 2025 01:12:49 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Feb 2025 19:12:48 -0600 Date: Wed, 19 Feb 2025 19:12:11 -0600 From: Michael Roth To: Tom Lendacky CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/5] KVM: gmem: Don't rely on __kvm_gmem_get_pfn() for preparedness Message-ID: <20250220011211.tjgo66egqxwqjzdk@amd.com> References: <20241212063635.712877-1-michael.roth@amd.com> <20241212063635.712877-2-michael.roth@amd.com> <80a5a52d-68d9-b4d3-e243-7720a097a3a1@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <80a5a52d-68d9-b4d3-e243-7720a097a3a1@amd.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4A:EE_|MW6PR12MB7070:EE_ X-MS-Office365-Filtering-Correlation-Id: c974f94f-ff7c-4f17-4963-08dd514bb111 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7Gm1xekcbqWbHTMrowefczBN5TLd1kGkXLlmrN8lnL7yDuIfQ4SkkHor+zJt?= =?us-ascii?Q?8xc/CIJhtBESjjQUUdpB3Kq8tIhrY4nn/4zUDktt1rK9fLIluXZUq18uYwEy?= =?us-ascii?Q?KE91t2U58j+sdNUv0pZX2PDEvhsfmj/bCW9Qgj+YqHOMfEsBKTNJQYViShSq?= =?us-ascii?Q?TtKYQnWCWonOLV/5FTN8R49hVNSurE61I9DdfvrH/73FgqvqORhFl2/yZjNJ?= =?us-ascii?Q?4X3gsrWEF0j5eStKixJFu+/9rWGi9D4/RMXkdqC1RA4qlzHG89iZOp0knJNr?= =?us-ascii?Q?mJR8+ivB2hv/FHVZZwAFH96ApBlOiplxsu9RLeqIx9sPvWdE3Uw0bAzwYKgW?= =?us-ascii?Q?DWtcTEizTpdjgpmHXG4v4l/SAhABbfvgfm8EmkOuCBStb/9BSG693enjGgtD?= =?us-ascii?Q?NUVccc+G3zeTlZo7V00krpeZTpVSgy3AetANXfDdPqidAY8za6/DFsuDNlNT?= =?us-ascii?Q?tZA3VeZNar436eLC8MqnOup0w6DtTebXe0MtHVQ73HenIlKwY/hD+6pqwys4?= =?us-ascii?Q?Sl/7QKhED1fljIL5UJdFXdHl10a05HQXTQlKQMZ8qwuqg92VA06IIwu5vmqm?= =?us-ascii?Q?yJdvcUHgrDFPZ4z1jHdZ22pzthMQt1PsdBtLzK/n+hWa7pk9pI1EbcXNMfHO?= =?us-ascii?Q?6pEVLDSD1tMjfKpJBc/3ct0Gh2fwcPFtCcR6arHtslCYlfZbzhQwlPZjblm0?= =?us-ascii?Q?6GsY+O7pN4QySPggmFTY7XdUqnC+ZEtjIVd2QgN4NqroV2WV22IrFrwzLRfh?= =?us-ascii?Q?z2z7BwY+awaUO2eEQvCbBwCNSWWoIohtplq4KHEXmJ+sYbvn0xMuAdv4jNaG?= =?us-ascii?Q?KTKvgsVkJWGW96ByR+/L1c99BLt8Ov4bLlIo88/o3H6BLK3GKJRz2KuS2q+E?= =?us-ascii?Q?X+kTv+KM1Se2wMAB4VLszR9P67fa7tCKWrKDn7wNrA0AEYZiwumpsDWgQ6uF?= =?us-ascii?Q?zDWyL5yV8gGA0/iAFbSrBbuqnp6a5vTlhpQb27eszUpcbBmNecO9caRiBt7Y?= =?us-ascii?Q?pYKSaAC5OKGUXL9T+B05JoefPVnj4z1LzM3SyRjSmPO6gCWTfVYVr6pRdy0/?= =?us-ascii?Q?iW0P6/o48ut34eVPBO0rlmbr7D21PX/hfoZygtOHJLYzPbwi998Osv+rK+2E?= =?us-ascii?Q?QhYpfgNo8m0kqgIhABsM8ZWYPhOTZdV/G5/45mqo0UEUr+nq3cU5kbG0IlN9?= =?us-ascii?Q?My830a6AbZuIHTred3P+T8gGpcFJ2ytA5ni7tt2KE2r2QF3bsT3GUPfXMs5S?= =?us-ascii?Q?W7wLSeoygtD2ClrXJwnZJTixNnl4HNloumW82iv6LAxnzD2PreJak5ICvru9?= =?us-ascii?Q?tnMCKFYnPF/vOZCD0fjm/dCVOgN81nCtbrBXkt60TKdcykkeL1Fn1ia0vI5w?= =?us-ascii?Q?wyN3Wqia7iomP5PmbKNQ0kVWBW4Yq9HxY4wkOGWgoIKVGbeX4JD8MUQE1yxx?= =?us-ascii?Q?A6vFi/X8TbiKO3TaMtl1kjBeC6lpYyH9qjd9dA2Olm97qmZCEdPOOszQSYUo?= =?us-ascii?Q?RKnWdEOGNXIEZ9w=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 01:12:49.1106 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c974f94f-ff7c-4f17-4963-08dd514bb111 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7070 X-Rspam-User: X-Rspamd-Queue-Id: 6BCBA100006 X-Rspamd-Server: rspam07 X-Stat-Signature: k8qjta35e3fpbpaa7f3bm9tnfgbfffmx X-HE-Tag: 1740013973-875054 X-HE-Meta: U2FsdGVkX19XqBqXW7gkNBEdY7GltBzsbgqDcC2zXaFpBQ0CHqk7ujCR6H2f3eXd2t43IypIZ+jCe9G/Ka1gBUJ+oRo06+cH+jcg6SEFHLxWU7tR/0d0DAKeYDaTQPi+koKZdXtQnlkZGThAYFfJ39o93iBcw1tvtieJQbB7CxmSSsIL0Cb6zlLzcbnt7x7b640XEW7g+VcMOD81bYdUS5c1BGuNpbkEmwF19SPXeOh7uOIxTz2dQDmBCGJ70b2jT4PFpaee20kPDAnlih/uHlwgGEWfgeOXrK4xeSPZ1NpCWS6JG6CzlUF0XsCGdgXSQHaAeWqjsmnKlKlmIx6KBePTTstExMOrypyK9DyYmdwmYtuxRekgGivLsgLPrJl29b2onqZsNc5zm+jSjZVD2EvTL9KEAgebEaWlcjmt4vpzy6pMKpnMyLAK2yCIMGBbcyg96LZdo+usn6c1VvAmtoe+CNAzhlh/hDc1tOS+c7spJVleEy1/O0DiKFHjddq8E39MjaiCHaaT3fLstEQ42twrwefiKYvhkGOlHoqC6i9k/KH/c88759KvcocFSNUhotqtAD6xxrAshWgyN7eCKSCRaJ0QrP7Bm71r6zroSFrrl4m1dxoPD3gOj68oCHlOfyxPHswc3ag5JkKEQj0W1gPTlVYEaYqf+HOYNzCHm0iJCm4XYubYbYwGfwrulgW7dSezRQPP5bmt6V2Fg3TDHx9a3wXY/7PQPNnn0ef4YIQW1VD7414pyjXwib2k7ukWvfUwZj6C+895c2zE/4TC3pV++L6v/ZSV38XDFuK89pUABk9CboLHiS/8y9NcCBhqr1FL1j7L1Bi5p2JYSo57yDeofcCEA4j7Md6GjnSXAhnfrNHLk9cBeZhD8w5b+NynRCE/NSbLeGPDka5Z/lJl4yIlOj/W0Tz7Zu0kho/bupfyiN6dZFL8CWRJxodhWhsH9SE1vk3bxJT58AircQY iW/4yUkN YVEwQ+fuy1GOTb1s3xdM/CPoy/3AQ7lJEVRDI11m8WywwkXEPJl71XdxxQfGsEI3p1ywcffhnQObGQXGdjs6Dc4yaCgdkCKgScHQYsdMtEk93cZs0DgNDZEFuGWDnwwrEeBsmMGgXrWDIyp+U1L4+NNElP32VEUBghIq0DMPrhR5/j92iPUxSFzbXnsuMLS7wmxgrH8XVVV0UJfy9TiB97T6pmHk9oKQ140g2CKgPI7tBWEgRMJtp7dj5vj686cX7JmJ6SL8qaQhoqpUHFpnUgcLiBmzMAgwArHE5OxjqF2albzFMfOIsI8wgs4oqmQVUrE+EYWZYxd+vwviM+PKEAizhUdn5BYtDdhFV6y/+81Lf6xGXlRYfbF5j24CqarpLS1gK7sqPKiQD5F0FuwjBZJZ3ouIgIRwJSDYYkH/ukiXxQVA8TkP1xWLPX/UoDt/olBwciTEtYtiojQr0mGLarPW66NUiKCvnBRwUj8SQ2McTagy0yaz1BKSab4iHU8Pm8X2N/96mzDfbDmmafuAyLSLE61SAlAq6B2EeedSs0IFTWoujGPGTl5Gg/fTrsVcsagxnQigNUZbuGiHnwDf/CGbj7YiuBHhtBbkl+2WEt6zDwYDYZ4Ye1SnFnNBAKqdU7/+v5r2+ZMvc0bA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 22, 2025 at 08:39:37AM -0600, Tom Lendacky wrote: > On 12/12/24 00:36, Michael Roth wrote: > > Currently __kvm_gmem_get_pfn() sets 'is_prepared' so callers can skip > > calling kvm_gmem_prepare_folio(). However, subsequent patches will > > introduce some locking constraints around setting/checking preparedness > > that will require filemap_invalidate_lock*() to be held while checking > > for preparedness. This locking could theoretically be done inside > > __kvm_gmem_get_pfn(), or by requiring that filemap_invalidate_lock*() is > > held while calling __kvm_gmem_get_pfn(), but that places unnecessary > > constraints around when __kvm_gmem_get_pfn() can be called, whereas > > callers could just as easily call kvm_gmem_is_prepared() directly. > > > > So, in preparation for these locking changes, drop the 'is_prepared' > > argument, and leave it up to callers to handle checking preparedness > > where needed and with the proper locking constraints. > > > > Signed-off-by: Michael Roth > > --- > > virt/kvm/guest_memfd.c | 13 +++++-------- > > 1 file changed, 5 insertions(+), 8 deletions(-) > > > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > > index b69af3580bef..aa0038ddf4a4 100644 > > --- a/virt/kvm/guest_memfd.c > > +++ b/virt/kvm/guest_memfd.c > > @@ -773,7 +773,7 @@ void kvm_gmem_unbind(struct kvm_memory_slot *slot) > > static struct folio *__kvm_gmem_get_pfn(struct file *file, > > struct kvm_memory_slot *slot, > > pgoff_t index, kvm_pfn_t *pfn, > > - bool *is_prepared, int *max_order) > > + int *max_order) > > { > > struct kvm_gmem *gmem = file->private_data; > > struct folio *folio; > > @@ -803,7 +803,6 @@ static struct folio *__kvm_gmem_get_pfn(struct file *file, > > if (max_order) > > *max_order = 0; > > > > - *is_prepared = kvm_gmem_is_prepared(file, index, folio); > > return folio; > > } > > > > @@ -814,19 +813,18 @@ int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, > > pgoff_t index = kvm_gmem_get_index(slot, gfn); > > struct file *file = kvm_gmem_get_file(slot); > > struct folio *folio; > > - bool is_prepared = false; > > int r = 0; > > > > if (!file) > > return -EFAULT; > > > > - folio = __kvm_gmem_get_pfn(file, slot, index, pfn, &is_prepared, max_order); > > + folio = __kvm_gmem_get_pfn(file, slot, index, pfn, max_order); > > if (IS_ERR(folio)) { > > r = PTR_ERR(folio); > > goto out; > > } > > > > - if (!is_prepared) > > + if (kvm_gmem_is_prepared(file, index, folio)) > > Shouldn't this be !kvm_gmem_is_prepared() ? Yes indeed. It looks like I fixed this up later, but accidentally squashed it into PATCH #2 rather than here. Will fix for the next spin. Thanks, Mike > > Thanks, > Tom > > > r = kvm_gmem_prepare_folio(kvm, file, slot, gfn, folio); > > > > folio_unlock(folio); > > @@ -872,7 +870,6 @@ long kvm_gmem_populate(struct kvm *kvm, gfn_t start_gfn, void __user *src, long > > struct folio *folio; > > gfn_t gfn = start_gfn + i; > > pgoff_t index = kvm_gmem_get_index(slot, gfn); > > - bool is_prepared = false; > > kvm_pfn_t pfn; > > > > if (signal_pending(current)) { > > @@ -880,13 +877,13 @@ long kvm_gmem_populate(struct kvm *kvm, gfn_t start_gfn, void __user *src, long > > break; > > } > > > > - folio = __kvm_gmem_get_pfn(file, slot, index, &pfn, &is_prepared, &max_order); > > + folio = __kvm_gmem_get_pfn(file, slot, index, &pfn, &max_order); > > if (IS_ERR(folio)) { > > ret = PTR_ERR(folio); > > break; > > } > > > > - if (is_prepared) { > > + if (kvm_gmem_is_prepared(file, index, folio)) { > > folio_unlock(folio); > > folio_put(folio); > > ret = -EEXIST; >