From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01628C021AA for ; Wed, 19 Feb 2025 18:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A99D28020C; Wed, 19 Feb 2025 13:11:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65976280205; Wed, 19 Feb 2025 13:11:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FA4D28020C; Wed, 19 Feb 2025 13:11:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2FFFB280205 for ; Wed, 19 Feb 2025 13:11:15 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E83D01C9159 for ; Wed, 19 Feb 2025 18:11:14 +0000 (UTC) X-FDA: 83137486068.20.E05488E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 86EB540024 for ; Wed, 19 Feb 2025 18:09:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LTG+FjzA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739988570; a=rsa-sha256; cv=none; b=rH+k59ka5ZiTVOiLfyWYtJxc4CoX+UjNMNeRmIjETeg7mDohP6gr1+vnjUwrne2blDTFDo F2muIVqm7hm2H4L3R3yOUTAAyJQz2tZSaQ7IWkX0Cb0/FBPN1y6YI4sMZRD8raXbeDgMxZ ifsbljOcKw99WZ6TzHS3GcWCEuNhbuM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LTG+FjzA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739988570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVHylPD4O4+wwmiKndaJXgH7JCxmC4gQ8QE6z/yk3Ns=; b=u7XZMzrDdkrtolHBi/iDyEvdkM4PaDeRUsqyel1tkm0SAL3qY8vqAO9lUQj9amXUGr/hhF 6p2by8UNr5yZJPBhgS/x9dcVsVvr8/fVkuA0THD8OZBG+QtNZl2w5K+C+DWOEi/5zmclBD bxyoxhrUrXWA16/fzHY6cUcH3kgEBnY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 540825C5A54; Wed, 19 Feb 2025 18:08:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABE1AC4CED1; Wed, 19 Feb 2025 18:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739988569; bh=89pN2lzpnqx4pWKh5CtnkftsUiCXfM/YS4po5Dm9sWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTG+FjzABQ7n7DrisxPtoZmA2zEvi4uzF9hzOHHpMb5sB6eWt5cCLd8cAhHAzbPe6 EYcNhRG2vo3DAhoUmQtN7iN8JrDv9YWu1AM8OPan6/tSHDfSZ2iIqHyxJDXow5aU8K a9XJsPDHtMBPOu16IiImWiw7pN+dh4YezumkgO+w= Date: Wed, 19 Feb 2025 19:09:26 +0100 From: Greg Kroah-Hartman To: Catalin Marinas Cc: Naresh Kamboju , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, hargar@microsoft.com, broonie@kernel.org, Linux Crypto Mailing List , linux-fsdevel@vger.kernel.org, linux-mm , Anders Roxell , Dan Carpenter , Arnd Bergmann , Herbert Xu , willy@infradead.org, Pankaj Raghav , Yang Shi , David Hildenbrand Subject: Re: [PATCH 6.6 000/389] 6.6.76-rc2 review Message-ID: <2025021959-koala-flypaper-1ad5@gregkh> References: <20250206155234.095034647@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 86EB540024 X-Rspamd-Server: rspam12 X-Stat-Signature: py6dnuyda8cd8p1pxgofbpf6fe9zdote X-HE-Tag: 1739988570-190282 X-HE-Meta: U2FsdGVkX1+Jd3hWldwn3vnt+qW4L6JXc96cEmHNxuwpoSEoUdPcuaHsi3z1Shw0mm/qi1lRv9Z+agBj6VZHYAWLD2yjEgA9MFHFURJe+30PkAsAHhsIC/VJaVbK4gKlJA9U60ijCsRfoluVBctQUoaFcyjRiiGkaDKxnxKkowxK8JBN4RiFF70YycYWu3rCScGEg82FXZyesaDfmtVUPCPUXsh/i59k+tNul7t2ygKE93X0zFT0sqBE1oAwt6wwnbZAd+oXiKKKFxm7pVNX0nQsAtK5X5oG72tLblL3aGQ2+8SzcNkrA4rL0xhw8ml2dyPtNkkk8E8q1UVPWg3pEH+agraNMPhl/FUiXBlVauFR5p6VbR6ea3ZHX9bxBzzmMN3Kp0alhasG1cLBWnBrUVkekfXClUE7zeBU3zXiQMybPB2O4VGPgfX/bjQrKcHYtczxDNzdL7H932Jacto7fMovh7l/cPaqboNl8L8cgZJitiuNpxGxcRDQkgo/kvT/jOVnpzdZUSF/GtqvGAmS/hms2ZeTcksVx2IWd1b+u4qMlhjGXfm5NzyWf31rTvtacHzbsM1zSqSHFZACArhPUsxAwtW6EndqH4zBI0mJdrzDa+ZPnAlveDF6qditB3JIbBQLFfHDbOE6M6Lye5jZ2SkTurrtIhMfBGuSXTNB0nsnf3EG03d+BsU6r5wZMLoL17szwVCkKzbWC97lAyTcfq7CnDTdexlJFIF0U8kfiU4UAjkcZmTWi6WiTbrC8RBLW3z6X97WeRFhKdu53PoOVTnJl360AAC/q4/3vbgoh25TdZ2gZQpuRGOdIiiBMce5tKXVi4XkBDZ6qUl0Ekk75wJCNs7Ce1W6GKWD02z2v5FbtygUqJD41gUv/JIaJ3/8iiBqQzNn+N0XKMOb4tb+hGnVybO2nmTeW+qjdDrvnNE0quKsGJLj1RQ1ntElqPl4jwL+MpFRAUIZl0cI864 KofZ3I3J XZ0/zAeMLSpl17mm/P61oXhLMZzWULyKEAEg9dRt7PskQY4e9Vhlyrko86EG5imlkR3wVKphPm1X9ys548eYvOLzSaYLHeWcSJSgGGmDxtQhTMXZXXmWrlfEXyCzFeBdUZ/QbqB+13aomay4ndFS/lMIYDJTveDfDa+c0r4cgXsPc9cGCHigK5vuAtd/1HJwcFIO/960oxNgFLpNwRiiw3l/kS/aKL9FEwSBNFau9QqkFz6682cdg7muTrDvOkEb7JtgobKa5VUejC8AIBBRO1RpfMWUMWbDmBPofx2zGopQwEMt9SsK96cdJq2BwRiR6j4KOOGDh5bLwGNmkVJLeZpJ+YYMrQdRr4TVGAFDE64oY73nOwUVyDITNQrE7bK1IGeaP16v+tKn2QB63XI0LQIMz6zTDGEG8JF8Vh2NLK1rtfGJkwvD+X2Z4fUfAw1e38UEmqGInDEnanuo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 05:18:24PM +0000, Catalin Marinas wrote: > On Wed, Feb 19, 2025 at 02:00:27PM +0000, Catalin Marinas wrote: > > > On Sat, 8 Feb 2025 at 16:54, Naresh Kamboju wrote: > > > > Regression on qemu-arm64 and FVP noticed this kernel warning running > > > > selftests: arm64: check_hugetlb_options test case on 6.6.76-rc1 and > > > > 6.6.76-rc2. > > > > > > > > Test regression: WARNING-arch-arm64-mm-copypage-copy_highpage > > > > > > > > ------------[ cut here ]------------ > > > > [ 96.920028] WARNING: CPU: 1 PID: 3611 at > > > > arch/arm64/mm/copypage.c:29 copy_highpage > > > > (arch/arm64/include/asm/mte.h:87) > > > > [ 96.922100] Modules linked in: crct10dif_ce sm3_ce sm3 sha3_ce > > > > sha512_ce sha512_arm64 fuse drm backlight ip_tables x_tables > > > > [ 96.925603] CPU: 1 PID: 3611 Comm: check_hugetlb_o Not tainted 6.6.76-rc2 #1 > > > > [ 96.926956] Hardware name: linux,dummy-virt (DT) > > > > [ 96.927695] pstate: 43402009 (nZcv daif +PAN -UAO +TCO +DIT -SSBS BTYPE=--) > > > > [ 96.928687] pc : copy_highpage (arch/arm64/include/asm/mte.h:87) > > > > [ 96.929037] lr : copy_highpage > > > > (arch/arm64/include/asm/alternative-macros.h:232 > > > > arch/arm64/include/asm/cpufeature.h:443 > > > > arch/arm64/include/asm/cpufeature.h:504 > > > > arch/arm64/include/asm/cpufeature.h:814 arch/arm64/mm/copypage.c:27) > > > > [ 96.929399] sp : ffff800088aa3ab0 > > > > [ 96.930232] x29: ffff800088aa3ab0 x28: 00000000000001ff x27: 0000000000000000 > > > > [ 96.930784] x26: 0000000000000000 x25: 0000ffff9b800000 x24: 0000ffff9b9ff000 > > > > [ 96.931402] x23: fffffc0003257fc0 x22: ffff0000c95ff000 x21: ffff0000c93ff000 > > > > [ 96.932054] x20: fffffc0003257fc0 x19: fffffc000324ffc0 x18: 0000ffff9b800000 > > > > [ 96.933357] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > > > > [ 96.934091] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > > > > [ 96.935095] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 > > > > [ 96.935982] x8 : 0bfffc0001800000 x7 : 0000000000000000 x6 : 0000000000000000 > > > > [ 96.936536] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 > > > > [ 96.937089] x2 : 0000000000000000 x1 : ffff0000c9600000 x0 : ffff0000c9400080 > > > > [ 96.939431] Call trace: > > > > [ 96.939920] copy_highpage (arch/arm64/include/asm/mte.h:87) > > > > [ 96.940443] copy_user_highpage (arch/arm64/mm/copypage.c:40) > > > > [ 96.940963] copy_user_large_folio (mm/memory.c:5977 mm/memory.c:6109) > > > > [ 96.941535] hugetlb_wp (mm/hugetlb.c:5701) > > > > [ 96.941948] hugetlb_fault (mm/hugetlb.c:6237) > > > > [ 96.942344] handle_mm_fault (mm/memory.c:5330) > > > > [ 96.942794] do_page_fault (arch/arm64/mm/fault.c:513 > > > > arch/arm64/mm/fault.c:626) > > > > [ 96.943341] do_mem_abort (arch/arm64/mm/fault.c:846) > > > > [ 96.943797] el0_da (arch/arm64/kernel/entry-common.c:133 > > > > arch/arm64/kernel/entry-common.c:144 > > > > arch/arm64/kernel/entry-common.c:547) > > > > [ 96.944229] el0t_64_sync_handler (arch/arm64/kernel/entry-common.c:0) > > > > [ 96.944765] el0t_64_sync (arch/arm64/kernel/entry.S:599) > > > > [ 96.945383] ---[ end trace 0000000000000000 ]--- > > > > Prior to commit 25c17c4b55de ("hugetlb: arm64: add mte support"), there > > was no hugetlb support with MTE, so the above code path should not > > happen - it seems to get a PROT_MTE hugetlb page which should have been > > prevented by arch_validate_flags(). Or something else corrupts the page > > flags and we end up with some random PG_mte_tagged set. > > The problem is in the arm64 arch_calc_vm_flag_bits() as it returns > VM_MTE_ALLOWED for any MAP_ANONYMOUS ignoring MAP_HUGETLB (it's been > doing this since day 1 of MTE). The implementation does handle the > hugetlb file mmap() correctly but not the MAP_ANONYMOUS case. > > The fix would be something like below: > > -----------------8<-------------------------- > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > index 5966ee4a6154..8ff5d88c9f12 100644 > --- a/arch/arm64/include/asm/mman.h > +++ b/arch/arm64/include/asm/mman.h > @@ -28,7 +28,8 @@ static inline unsigned long arch_calc_vm_flag_bits(unsigned long flags) > * backed by tags-capable memory. The vm_flags may be overridden by a > * filesystem supporting MTE (RAM-based). > */ > - if (system_supports_mte() && (flags & MAP_ANONYMOUS)) > + if (system_supports_mte() && > + ((flags & MAP_ANONYMOUS) && !(flags & MAP_HUGETLB))) > return VM_MTE_ALLOWED; > > return 0; > -------------------8<----------------------- > > This fix won't make sense for mainline since it supports MAP_HUGETLB > already. > > Greg, are you ok with a stable-only fix as above or you'd rather see the > full 25c17c4b55de ("hugetlb: arm64: add mte support") backported? A stable-only fix for this is fine, thanks! Can you send it with a changelog and I'll queue it up. Does it also need to go to older kernels as well? thanks, greg k-h