From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAC0C021AA for ; Wed, 19 Feb 2025 19:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA106280263; Wed, 19 Feb 2025 14:15:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E523728025B; Wed, 19 Feb 2025 14:15:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD49B280263; Wed, 19 Feb 2025 14:15:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 974A228025B for ; Wed, 19 Feb 2025 14:15:50 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF391454B7 for ; Wed, 19 Feb 2025 19:15:49 +0000 (UTC) X-FDA: 83137648818.30.C98E554 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf04.hostedemail.com (Postfix) with ESMTP id DE43C4000C for ; Wed, 19 Feb 2025 19:15:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aS1KptYa; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739992548; a=rsa-sha256; cv=none; b=0ZXWu/itnEVS51uOMwKDG0XVULhmqxf5uoNqfbo0h35u+cY/JN6wAK3AH9zNCCuBP20T8i U/6j9+roEqtu3u2YuR3SYHj24nYiNP9RJaR6p5EkNsRa559+AOD6+GtYGB2QMVOebcR2TX kfmSvyFMaKl1YDU4mC09YC+1tOYb5H4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aS1KptYa; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739992548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Sm9f8CosVKerH6dIT1y6KUA7xfRLyxObBsshfAZM1M=; b=H3Rff5DpHdkwc8J62NfuxodoU4hPRnyBifxH3MZhepr1FZd1zniWw+IkgDy7xX2vhfIKyg y4V5bhxS9eUHrVlXPTHw6zj7QazZxuZvENtQR82rCY2R76kLLBJBBVN1UfZaLZOBiNfcGQ UWG6vUO96Hdda3WEg2mI4z3/V3SEbQc= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 19FCB40E015D; Wed, 19 Feb 2025 19:15:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FByxDcaAGTRa; Wed, 19 Feb 2025 19:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1739992541; bh=/Sm9f8CosVKerH6dIT1y6KUA7xfRLyxObBsshfAZM1M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aS1KptYa6T4FSZsPmIBAg2jfpj+xpns2ARKi+2GWSwMiv2sqJxBhCQb853+G8SMOm BPEUY1y7eeHmFDhB63IQhEtxMfBluBqdPd9bgL+wOgqs3NJXrF7CvIFYi+5QsO73fu +pR5bI2PsdkRS7w9vF1P+s0/ow0P3SrVlP8L6h8US2TY2pAZC5ZlTq7EU75/uRhV2D mDzYJwdV+dGq4NYOlMImLojcf2jeAQ+OGvxdgBo3yCVlsKHIgs2apkJ7QSMKL71NWC gCgTymr9HTn+vXmXB5+odAP0WGhWT1l9vVJDSKVlgWfdgvXYm+xfvGgipteZO9iPZL BCGf40y0Iw6Lbt0Rs2H5qWYM9ut2fHDldThihY3JoZ8a3yvcMV69iMrqhdXL7q/yqt Eoi4dhp2eIyflN6cg5hNeCaWPK4o9t8gLytG9PBHoJD+xGuxcfcPkC1JsymRooHfvR J8XQ5eE4M6Yx9SozAmC/oRXru4LuFDGcEH3oEQgSBZslscPoclAbwfjlsMA20tBzWN Dj9FgqQlsK4VntZq3GBGjcd+RQJFHMRDq5kB+NimaR51vJbc4bjicGL7Mz+bweThTL yjdFtMa6N9FQGh0Bc4v0/n0nNWKeLUrxPFYoyUTnzg7yEJOUXvTOhe+EezN2wv/n9U eRZ1OtkFpPNdV/34Cpdjcf1Y= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0385240E0191; Wed, 19 Feb 2025 19:15:23 +0000 (UTC) Date: Wed, 19 Feb 2025 20:15:19 +0100 From: Borislav Petkov To: Dave Hansen Cc: Rik van Riel , x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code Message-ID: <20250219191519.GDZ7YtxzBiMxz3wwlr@fat_crate.local> References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> <20250219120441.GNZ7XI2aWWUmXh2H2m@fat_crate.local> <2930024a88be186faa6a0338fc003e8ffefb710b.camel@surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DE43C4000C X-Stat-Signature: zxf3st5gp97tdrua9o85u5h7gjs5qf98 X-Rspam-User: X-HE-Tag: 1739992547-868479 X-HE-Meta: U2FsdGVkX19gm7RwUj9RRKasAxHTaCw3QcEYUQvtlut0fM8m2MR7GSk4c2SIXrSxseAbzeI2aT0za6gwo2cuQ2HAYPJIork1vfoSJlZdU6a9MMsrSkegsfDSnbww0IihCEBishI7IwfI5kEOCQxH6bRoZKjUl5L8sLdtCFfAx6esCQC8HpxQrMXarZCsJ8vwlDUtENafG4nKfntKJP8ZtOW6MoSsC76EpWW08DX7YJniqN4rswDSvKOLjVjpl3Kxf2PBPhsCIEsXPB0/AQiCd7wxfzg+06yYv5fGtZJucjBzVJ1riZEKyYCwXmuEKiHp1q4KcCJZu+AgAKlZq28LV2y2Sr02uZFeXCMwHysgTltacPwVoCJ1xCzgEFX2s24ydY+yYXNj/kunN0OlEhdtxdxsKbg2IhWrn7B+qoeMEHMjaxaLReP+xum0bRcIew9G1cpNUvh1KM7aUO3YcyFBL+/KihrvdTPV763ft5lV0gj21QPHCJUAXQrGa3CU2XjM1XXNi2pjTD04Fr0kdKdYSUJ3xclHz8BAwLtc1/p8Pf3jpf3dLmuesrw0C2UKfBZFa+WjP8j+gt8VpFFMXl4I8FNsg6vo3dVmDueRgieTSCvzk+WTDyVGFfElmZKAuqge7r3h4T9brirVCuZDEbDlPj57QVp76LXS5OKJqI/kasAUVtpqgMcudqUcRRygXnKvsso3EoB1KuYUL5ieU2sU/r1YIJaCY5S60iKR2vc26WksgQwAqe+5rWnoUezlIgYY7IA+xePizEy7uNbwaC9t2z5lgTQRbuJZpcVZREUsfjBIB7jx8/eRua3Ys5HEpzEbKd23vbFuKyZ4iUpSQKv2gONqSYNPMpjWYn/o7UrqMychGOVuRG70bn7wWS1ApS5EnWfS+Y6g8Zf5xyYFlQmpIofZFJZc2WRs4P4VYw1aAWnouQMWoFavbsaXhS7Y8vtHuPxbVNlhLn3+48UlN8E V4zq1fFx eS7YKw1qu5l37mpXTqxjoAunsP7lFb8Oj/5AkfjL+xB/0ZRfOrDEc3TFLeTP41i80wrGZuIz/C6pXCn1vFZwHgT9T6CeERqm+HaVRJRtVzqb8ClXJDe1ZK9dTDZ+VJgFq5VMfNq3fZGHRjz3sZUjH+wP1CnF1UdRsfCgc/m/+ey2ERWba3r7g31xogLTqmIkPoBfSpwswnGxioOV3lNh7vEHsZCAHuIW21pbAYfOKInbR1BM2x9sbJGGg7czlD1QjU+gTuG/dTXRiLO7/91CDAzUzWt5ncxuJwgxq8CTmzeMFBy7Wd/e1incqTWkOTRIdwEhp64ZHDuK8M67KQ2aPFHcbbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 19, 2025 at 11:01:17AM -0800, Dave Hansen wrote: > But, either way, #ifdefs are a sign of weakness. Less so in a header and > more so in a .c file. ... and, as we just discussed and agreed on chat, we don't need the Kconfig option either. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette