From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8D9C021B0 for ; Wed, 19 Feb 2025 23:57:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E73A4401A8; Wed, 19 Feb 2025 18:57:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3970B280276; Wed, 19 Feb 2025 18:57:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 286534401A8; Wed, 19 Feb 2025 18:57:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0BD32280276 for ; Wed, 19 Feb 2025 18:57:51 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B03A712048A for ; Wed, 19 Feb 2025 23:57:50 +0000 (UTC) X-FDA: 83138359500.24.ABF9146 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 16EAF120008 for ; Wed, 19 Feb 2025 23:57:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of "SRS0=Eo3P=VK=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Eo3P=VK=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740009469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QfzHf8oRC/ysqPf8ZQzy3N415TYJ1WpUzVreb5ow+fA=; b=BMHP4DSgLiRKYs1kN+J6uVjB3r5RzssDxPcN1QX7PpYLNEKcnhxOtGuLpkgVFOjYz2ku7P DJ1gMSRBigndjX2fts/CARUnsg8CNbFc22mU/jwhj9H35Z8gGItuIbcjKo7enzjhBOExS7 oPE4TdUzAbfYekrSLZfvHUmbceJXrRc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of "SRS0=Eo3P=VK=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Eo3P=VK=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740009469; a=rsa-sha256; cv=none; b=B0ba2zDpnw4UvkjZwb19P503eFAeNmjmcs1E8MTRgRocyyJzMc3RjzRFmY5fDdUMcWBrtw +BCEdcdQ84ICzhCK8lcHJksCqwDPer6D3gcBK8lpNQmUOFGjb0/XHyU6ZKvH9D8LjMflDy gr/jno8QLyxa3a/Id365WlPCR2gjLgE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F3DDB5C5CD6; Wed, 19 Feb 2025 23:57:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FB9AC4CED1; Wed, 19 Feb 2025 23:57:46 +0000 (UTC) Date: Wed, 19 Feb 2025 18:58:10 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Andrew Morton , Boqun Feng , Joel Granados , Anna Schumaker , Lance Yang , Kent Overstreet , Yongliang Gao , Tomasz Figa , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: [PATCH 1/2] hung_task: Show the blocker task if the task is hung on mutex Message-ID: <20250219185810.57561c69@gandalf.local.home> In-Reply-To: <20250220080908.fc1494f0f7c611b48fbe0f8b@kernel.org> References: <173997003868.2137198.9462617208992136056.stgit@mhiramat.tok.corp.google.com> <173997004932.2137198.7959507113210521328.stgit@mhiramat.tok.corp.google.com> <20250219112308.5d905680@gandalf.local.home> <0fa9dd8e-2d83-487e-bfb1-1f5d20cd9fe6@redhat.com> <20250219152435.35077ac3@gandalf.local.home> <20250220080908.fc1494f0f7c611b48fbe0f8b@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: r4qa76tgh4tinhpr5c8fn9woxeykxxen X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 16EAF120008 X-HE-Tag: 1740009468-390485 X-HE-Meta: U2FsdGVkX1/nsfNNgDcUgK7vWn2+OpdxfFcJiSjxTxu5X375Ysauk0MNBrmOwzMjSB+XU7FEEJyoi/rv+pReUDA1WxmQsuULdblDctXpb+KEso55QpPmonkHWqcxhCZwY/hU1cveS+QDLgqbboi13ONFzB/zq4bFGyzRDSV0m1MLHQv0jBB4i5Sum9hKm+rVeFmexoUz5rt3icCrlOoUoMfDSvHENHhXKmADt0aXZS1nL57K4HbTQ13CfXlHy3tuB/uIqd/9vGoFPVxrq5mX8mPaRTYq4XQ9BDUsLdYqQLpgBIT5mr4QP5v2acgH/wqu/HGZqZmoBzj5Z90rI+xu7oxESiyR7lnYoIUwAX+vy5g5vtms8uxytTKN4Z2k1Tocg83eAERkUiaUjD9FwRNjpwBd3UScXrnfYYfQSTMbIAOTs4jMPr08dBcLIWkzKV/x4EMeZu7QrEoWg+HngHq7kE+AhGzGm2wmUBj+LSpQtqcfcF6diGYpj3y83VtBXLXzu30+BHF5vO77oAWGSZ9UzPNysEf6TSBzEPLpJw2VDh0cEqT38r6X5FlsGpBwA/TiBRpc2+GVGqK7Cn6IrT720He1eirgb1slGjz4ueVd+NcQAn1nBDeJltXacuNEmkaGQYaygBFQg9Hm74L+ZIGQ3flP04mX+rE5RsA/93jZIBidSwxf9lbJKtJRgZ09IWb0VqZefkqaPKnPlyJScZSkl/4MHxr0tDyH6oJBTJZLHVmA9cfxZux0aa92aVkmmbSRZBd0k7uIwyno/N5dU/LzKTXYRE+b7CD/L9ZhLUPev6xoqmMUj1pxoTBMUtg65zN2giZMn7FXZoESyw/KjnmGcWtaiREt6PRWj8fSKP93JRZmNSxiNMtZR1FjVifo5r7pGNWl/7yVqO0zn0eECpzGaYBsqFJk67gzhhgEOT2P5GwlVEvdQ1Q+QlwqAZYzzeK+FR5bhYI4YF2RcyyjalM R4L81TZY MN2q1HNKEKxm/uIzTWXShEak0iiKns4U9LzfMIzV1yaUM6L5sRpluAsqhD+ywPoGT9g3mfb5E5SnUWqokYRnVrXg/vS+9W9Ved2xpUhedK/g5c4Ie8O3rJ3RhDOr3K/L6VrjCVj7cSpGyI2ufhlJjNM7C+LCNfKR/kqn2S2hw34X5t2t4Udz5glw4w+Y04X/S3S88FZD+OvSo2AcDoFJbR1Cy24kEnevHnQmP8dKyiEmcG1TDl7Q5aifPcRYuJ7LCLIYPFbztFV/rYdjg+n3FTfxPGHoqFzulcMvAgyqvnHetc0AMcRHo1i1G/s8rXdZH1qZk+bEGK2NFgkB7ajmMZwYFchoq1qvVZO0qDahWV3OqtrWq4GRdFScwPTfYjc2KWLyCDdDMmTlThrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Feb 2025 08:09:08 +0900 Masami Hiramatsu (Google) wrote: > So something like this? > > unsigned int block_flags; > union { > struct mutex *mutex; > struct rwsem +rwsem; > struct rtmutex *rtmutex; > } blocked_on; > > enum { > BLOCKED_ON_MUTEX; > BLOCKED_ON_RWSEM; > BLOCKED_ON_RTMUTEX; > BLOCKED_ON_IO; > } block_reason; > > For the safety, we may anyway lock the task anyway, but that is the > same as stacktrace. Why not make it into a single entity? struct blocked_on { unsigned int flags; union { struct mutex *mutex; struct rwsem *rwsem; struct rtmutex *rtmutex; } blocked_on; }; -- Steve