From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC30FC021B0 for ; Wed, 19 Feb 2025 08:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CD4C280212; Wed, 19 Feb 2025 03:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67D4A28020C; Wed, 19 Feb 2025 03:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51DD9280212; Wed, 19 Feb 2025 03:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 312B428020C for ; Wed, 19 Feb 2025 03:51:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A48C31413B8 for ; Wed, 19 Feb 2025 08:51:03 +0000 (UTC) X-FDA: 83136074406.14.34460BB Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf26.hostedemail.com (Postfix) with ESMTP id C84DD140007 for ; Wed, 19 Feb 2025 08:51:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n6XEjCrk; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739955061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JREwPg3Bf59aD+771OzwbLzmFE0j2imEw4DCcT5DxqY=; b=TD+1iFDIjdt5sfe2X9iUYg05QtVe3t/AMZInTp5LMAhUPBdjzICzQmUQGfjauWpFgKm87V ve0obMUm01AvuEUtg+59d8ZcS35DDKS498VPXyxGBKUlLqiKxQWYpxNIaIvlqH5kVWO9Wg 3f7DEFzTdmkTIAhgYo2gvzN9V2G1T8I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n6XEjCrk; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739955061; a=rsa-sha256; cv=none; b=WovwfMtcKVIpy1BtfDL0w2UrDT/TAmhvt4kAvFCfaV/cvs8LvRCh2vY0V/icbZu7N8ZdHX pJF3/aJ/Odd/dGljITrVE0lTNVCcuZ6RxpEh88sSMjl1SzphpZDsjkSez7xRL25bcmPwKc DsIQ3/iDPndAD+T98fw94j/x6wgv+uY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739955061; x=1771491061; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hbSqsiykuNDWOokYPnx5zxrp0p4HqkViEANBANJlSFs=; b=n6XEjCrkdo8N7tQDVjmQzznYo2zCrmJaPBRRvlCh0jJqjO06OmNMoo2Q VrTxdxVseqg0C2Z/7jgt9L98rQ+Oj2fEGPj01iY/pLFLLzkX5Ez2bq2N3 uikFF7pU844n2p+ERXe9yvECstAYpnrZ+c01ODPPJJ59y09M0+ERRxW9f a+pz2lec+MFJZs5z5w9zW2oh2O+7EoRO1I3r7LP0XcMEmkdG1qitSQVrD P2kLPmyFzx2L5VaMZnR1Lg+LKuCk3u8FVBuaku0qdf2ZQftgDrJmzb9UE 9fiJahBQ6fajaNY9HEO/C9AddBvInlHbmSR7EpBElBEzzqghlzZ/Io2au A==; X-CSE-ConnectionGUID: v7duluMTSjmiw2+MrD/r/Q== X-CSE-MsgGUID: 9tA2UJpoToeL7A5fgN/hQQ== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="51323282" X-IronPort-AV: E=Sophos;i="6.13,298,1732608000"; d="scan'208";a="51323282" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2025 00:50:29 -0800 X-CSE-ConnectionGUID: zwUy2+s6Qiiluj1yN7OmHA== X-CSE-MsgGUID: xDmN3XvTSOKjgikhTWzITw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,298,1732608000"; d="scan'208";a="119631744" Received: from lkp-server02.sh.intel.com (HELO 76cde6cc1f07) ([10.239.97.151]) by orviesa004.jf.intel.com with ESMTP; 19 Feb 2025 00:50:26 -0800 Received: from kbuild by 76cde6cc1f07 with local (Exim 4.96) (envelope-from ) id 1tkfmh-0001d1-0i; Wed, 19 Feb 2025 08:50:23 +0000 Date: Wed, 19 Feb 2025 16:48:11 +0800 From: kernel test robot To: JP Kobryn , shakeel.butt@linux.dev, tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 08/11] cgroup: rstat cpu lock indirection Message-ID: <202502191619.0t8nOsuQ-lkp@intel.com> References: <20250218031448.46951-9-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-9-inwardvessel@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C84DD140007 X-Stat-Signature: wcmfkmuswzoeyfnb76auhr5ci4zrsxq8 X-HE-Tag: 1739955060-391026 X-HE-Meta: U2FsdGVkX1/NaqBFpGwlzisbAhqBZwOfOHSWgMhMKugRkR+EV4BmNxQhtCMeYxacDVERKmQlr/bMFZObvB6z2eGdq2rqQrK4YGRifCYqsMZnAzhaJoP995vvFPlbb5s2VZCiPsFs8DDOrXgi71JcHOkrSM3CxWbh3RFLj/ZpLuODnAlydfnGh7gjFJmgYP8rIjFj0iZARgQL1ibUi1vGoXJIc3VmMPqlzCVY8IgVeqKYIxV8HeHQD0O8K1TAmLU/WZ45XJKgrJmX3ggZyr2S2FKH38HdwwENWc4lhn+BYdl+t+Lmp6J8q/zf/XiMOFUHCao0/f3Q7sYZRkDi0Q2dV1pcFkXxGdvExOsKrwzJ7zT0qbo/T/35I9m4tl48KOLB1dFcOvrpylSFvq2ByIiI0N/wPts0IwtK8kPZDlVyqO22X86o23DZZYKqifYo9ldjX8fb1Embc2YyyjH97z186BxcZdEbnhCUbkUIDtl1IGu1EqfXTDZdy5Jr6IBZu+xquHQBECOZTz7fBf+k/0GOFwtLZNsy/8BkOcUtPfxFo3qQ77jCsv6mXRXfYsjtVO3LY7mjwPDJIyy/wB2l3dAm0h0B7icIbL5MnvQunypYR7tipanSLbARmBLXeoW4BlvyfIq/wozieAJ2U/2WB1khWPg+w4R7k9VqEb6iuc954I3SPTiPPFTznj+X4YfpRteTpWxJPqa6H0LoEBNJOBKvcHzTdgXkCCDmLL0HnvSQTvrtivh01L6Vc3fkCYw6AuZPYABSRgP6juqwqj5y1XIYhQqWU/0vW/rmSz8yOEw0GP9b7pJy9ersckk6xUMgWciJDk5h7yFL6q1uL6+O7/ZetAUam1s9U2mRhdeVikz/L56KSw4gIQBJnodkZWzP5tZAiEQLehy8GXJbPa0QtXd08syHTHKIpr8UxVz8kIa5GYiR+VJmgLdncmVQARMkhRJX8KCAG5rKep79xfdACZw tOAUps52 SlCzgvzh5l1zUFFJVgcPDdEkFLIyXSBQHdEy8BDQiu13pQCznXI8Qlr3GRJZQoKkAKJLBgXzo4jzvWHUd0FSAUxKo3/70HYNb5pGS3CzqwG1f4DHvnaKooYmkbCidEcmkTUzenJmf+SLlU2SjmGZgLClRDTECRwntoWAUyDabrgeYjrVTYzrHiH/41h7t7dNGez8Fh8XN8gzI1jGtLLcPDs/GzTCp87oFCyeTglGGoUUB1hR6qwxE9MfFCn65vGOY/hvXQLf4y07rZPKDDYUXviKKGm9SW351Hk80QdbRHT6okuVrRv7TabfL0bX69HIzlMAyzM5EStxX15Kq5Hpn144uciCYPzsyZ92nj5CeXzQIti6FMT1MJm2I3GV0pxCZUZVd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi JP, kernel test robot noticed the following build warnings: [auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on bpf-next/master bpf/master linus/master v6.14-rc3 next-20250219] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/JP-Kobryn/cgroup-move-rstat-pointers-into-struct-of-their-own/20250218-111725 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next patch link: https://lore.kernel.org/r/20250218031448.46951-9-inwardvessel%40gmail.com patch subject: [PATCH 08/11] cgroup: rstat cpu lock indirection config: arc-randconfig-002-20250219 (https://download.01.org/0day-ci/archive/20250219/202502191619.0t8nOsuQ-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250219/202502191619.0t8nOsuQ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202502191619.0t8nOsuQ-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/cgroup/rstat.c:266: warning: Function parameter or struct member 'ops' not described in 'cgroup_rstat_push_children' kernel/cgroup/rstat.c:326: warning: Function parameter or struct member 'ops' not described in 'cgroup_rstat_updated_list' >> kernel/cgroup/rstat.c:326: warning: Function parameter or struct member 'cpu_lock' not described in 'cgroup_rstat_updated_list' kernel/cgroup/rstat.c:532: warning: Function parameter or struct member 'ops' not described in '__cgroup_rstat_flush_release' >> kernel/cgroup/rstat.c:532: warning: Function parameter or struct member 'lock' not described in '__cgroup_rstat_flush_release' kernel/cgroup/rstat.c:532: warning: expecting prototype for cgroup_rstat_flush_release(). Prototype was for __cgroup_rstat_flush_release() instead vim +326 kernel/cgroup/rstat.c d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 304 d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 305 /** d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 306 * cgroup_rstat_updated_list - return a list of updated cgroups to be flushed d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 307 * @root: root of the cgroup subtree to traverse d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 308 * @cpu: target cpu d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 309 * Return: A singly linked list of cgroups to be flushed d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 310 * d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 311 * Walks the updated rstat_cpu tree on @cpu from @root. During traversal, d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 312 * each returned cgroup is unlinked from the updated tree. 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 313 * 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 314 * The only ordering guarantee is that, for a parent and a child pair d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 315 * covered by a given traversal, the child is before its parent in d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 316 * the list. d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 317 * d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 318 * Note that updated_children is self terminated and points to a list of d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 319 * child cgroups if not empty. Whereas updated_next is like a sibling link d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 320 * within the children list and terminated by the parent cgroup. An exception d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 321 * here is the cgroup root whose updated_next can be self terminated. 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 322 */ 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 323 static struct cgroup_rstat *cgroup_rstat_updated_list( 85c7ff288b9391 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 324 struct cgroup_rstat *root, int cpu, struct cgroup_rstat_ops *ops, 85c7ff288b9391 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 325 raw_spinlock_t *cpu_lock) 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 @326 { 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 327 struct cgroup_rstat_cpu *rstatc = rstat_cpu(root, cpu); 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 328 struct cgroup_rstat *head = NULL, *parent, *child; d67ed623c585f2 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 329 struct cgroup *cgrp; d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 330 unsigned long flags; 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 331 d67ed623c585f2 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 332 cgrp = ops->cgroup_fn(root); 85c7ff288b9391 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 333 flags = _cgroup_rstat_cpu_lock(cpu_lock, cpu, cgrp, false); 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 334 d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 335 /* Return NULL if this subtree is not on-list */ d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 336 if (!rstatc->updated_next) d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 337 goto unlock_ret; 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 338 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 339 /* d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 340 * Unlink @root from its parent. As the updated_children list is 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 341 * singly linked, we have to walk it to find the removal point. 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 342 */ d67ed623c585f2 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 343 parent = ops->parent_fn(root); dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 344 if (parent) { dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 345 struct cgroup_rstat_cpu *prstatc; 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 346 struct cgroup_rstat **nextp; 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 347 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 348 prstatc = rstat_cpu(parent, cpu); c58632b3631cb2 kernel/cgroup/rstat.c Tejun Heo 2018-04-26 349 nextp = &prstatc->updated_children; d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 350 while (*nextp != root) { dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 351 struct cgroup_rstat_cpu *nrstatc; dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 352 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 353 nrstatc = rstat_cpu(*nextp, cpu); 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 354 WARN_ON_ONCE(*nextp == parent); c58632b3631cb2 kernel/cgroup/rstat.c Tejun Heo 2018-04-26 355 nextp = &nrstatc->updated_next; 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 356 } c58632b3631cb2 kernel/cgroup/rstat.c Tejun Heo 2018-04-26 357 *nextp = rstatc->updated_next; dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 358 } 9a9e97b2f1f27e kernel/cgroup/rstat.c Tejun Heo 2018-04-26 359 dc26532aed0ab2 kernel/cgroup/rstat.c Johannes Weiner 2021-04-29 360 rstatc->updated_next = NULL; e76d28bdf9ba53 kernel/cgroup/rstat.c Waiman Long 2023-11-03 361 d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 362 /* Push @root to the list first before pushing the children */ d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 363 head = root; 3d844899ba042a kernel/cgroup/rstat.c JP Kobryn 2025-02-17 364 root->rstat_flush_next = NULL; d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 365 child = rstatc->updated_children; d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 366 rstatc->updated_children = root; d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 367 if (child != root) d67ed623c585f2 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 368 head = cgroup_rstat_push_children(head, child, cpu, ops); d499fd418fa159 kernel/cgroup/rstat.c Waiman Long 2023-11-30 369 unlock_ret: 85c7ff288b9391 kernel/cgroup/rstat.c JP Kobryn 2025-02-17 370 _cgroup_rstat_cpu_unlock(cpu_lock, cpu, cgrp, flags, false); e76d28bdf9ba53 kernel/cgroup/rstat.c Waiman Long 2023-11-03 371 return head; 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 372 } 041cd640b2f3c5 kernel/cgroup/stat.c Tejun Heo 2017-09-25 373 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki