From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE33C021AA for ; Wed, 19 Feb 2025 23:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2ABE4401AA; Wed, 19 Feb 2025 18:42:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADB1A4401A8; Wed, 19 Feb 2025 18:42:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C9A54401AA; Wed, 19 Feb 2025 18:42:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CAA44401A8 for ; Wed, 19 Feb 2025 18:42:00 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31BC1B161F for ; Wed, 19 Feb 2025 23:42:00 +0000 (UTC) X-FDA: 83138319600.25.4D35218 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id 64E61C000A for ; Wed, 19 Feb 2025 23:41:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t6oqhi3i; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740008518; a=rsa-sha256; cv=none; b=JjHsnmS1O7YfVc4V1jwkQScEG/A1k6XCwJCq4gMgcXB/6g9vsQZtJXW4j1yHKl31zvaXo/ 8qJ5DEDf01tEQrwksaazEBJSbNR1MU0ZAQr3/IC8E5LnRoHhvSsMhZJXk50tjMpnv7eh2q I9d1Qq24KPOrGlg2AA8ZGvDSyFw+n5c= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=t6oqhi3i; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740008518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WzqtG44HqUnskYHto9LzI6BqQvaz77PzYiVtxgj7XQQ=; b=3Cs5Lnc+sP69eBNOmw6b1bIpRsBPlSf+ea3hEcfGksE2Xw8Op+JVD/nSvpzW5W/ASsY/3e DDGeIbhj1BYCwURYG5D3WPBBxJtiZFWmR8OORggNoQY67D/NCCvcIljf5aI7t1+S9uduyG E/FpmlIl9gXwo1thuS5P6m4lzKl+078= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 24D5261147; Wed, 19 Feb 2025 23:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F406EC4CED1; Wed, 19 Feb 2025 23:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1740008517; bh=LDESUJLpKBJ7BUJ0owRp+Iq4MOUFY1pC4SeiKR8t81g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t6oqhi3iKLF9yHUz6nqtd1KawfwqMaN6HwZRX9TWll83ZvHe/9pYhX1ZBs5QllDTj nYVgyjiPw4p8SbO5qHwA8uv0dM8xpgOf7kw9OVLPSE7iHFphhfWi26p1XYlzlVgWib xyozl5g0RzSbn9oFtlNNZLkQVCC5QEWzDKJg40P0= Date: Wed, 19 Feb 2025 15:41:56 -0800 From: Andrew Morton To: Wupeng Ma Cc: , , , , , , Subject: Re: [PATCH v3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio Message-Id: <20250219154156.2fa7e0f63838e80f8456f1d5@linux-foundation.org> In-Reply-To: <20250219060653.3849083-1-mawupeng1@huawei.com> References: <55e4ad74-752b-65c6-5ceb-b3a7fd7959a1@huawei.com> <20250219060653.3849083-1-mawupeng1@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 64E61C000A X-Stat-Signature: qaiqzhzu6gqmaxmyqxxqdb55ync74faj X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740008518-752276 X-HE-Meta: U2FsdGVkX1/h9iQ35iDK7+7i5k05dDzfHPmKh9RfmA50DzPI3P91gHEA3DHoX8YZYSFw6cC2fao/Z7vpdp/SbII1wb9eUbb4190TpcueK5DMwv1O+/DsnTOTZpiEbzsGKNdYMEqqiiDM6M3VTBVFE0AMC5X3ha7tCWqnMusyw9LRf534VHLarldMv9vFUK0t4BTHnOsIya12iYCuVipVZ08UEL7fdvOwSXIUzx1x1jhlu7XTfZVzopDJXJV6l1lERb6g5HX7Dq184MrWfq4wEp0dJhDc9Y+fSlyNI/s7gi/buferCUC/VIW5oKhqjrB0n8XbECDKT7R8RK1T+Ro/RwcOKD4zqzZxlWrxBtTCT00+jm6jVZmmtCU5SvwlUsBrhcP5Ax6C2eJQgFzCq8EQxN7+psL03mObAjxbVwy05JTn28LH0hfJb9yQpH6LTfzXBxGAMKIY3CrbYX5deuNNUKQeCrFfiYaIzzKzBjl0Zywg7Yq5oFWlHVKNs9nJoGf5Eki6SfmBkHJ2v9Iejib+nIA2w2FY4/3/9XQMq1uwOvUrRHqmBsr4iQ78ZK/MsG2J303B//4HOkLwfhAKPo8LwY3ShZ47Mh99rM4+M2ukAQnWUT/WqjpH3SgaM4jnYTqnGXUWLFPcouaapH16rIl0OPr6MJW3qxQd6obAO1SHN83OA6PVqx8ocTq5Gm8eOpLD2i5X9hxBNLydFX0AOc76n8QiQvNS4dekBugEUmtHaDzFU0OkokApkXEfDiN+OEkCbxIsGQkcFxqyY3Mp0Ds7yNAoRYWg86CJhCYgKJ3foaOnrcbKQXIzZmW467o6QOZxfARRsxwrlXhEKqaLGeY11DO5EeAL6LqLLrCVq0BpFogySAvTxN2IgbhG8yo0kq9ECWIkUXiHj8V7QXLd0QqsbVG5/Hil1P7YPXbLyjDYzlW7ncVu/Vk6kIuWLjgXAQbSKxgtzTArucZh6MFtR5D YdygdTnL kcJTKBYKrtetmeZqGkjKXEPNHJdpGxCuF41k2768NOBxZuGrnKn8d5+lLMYEGlD1XwFeegiAM8cUuyIdTSN0Ix/IWohAvOoIgQ5FNXNekJrxF5INlPxKSaYp/cvIKarjJQMtkgvjn6DHfYjOvLJtVy/CbZHrHmfxktGUmKYZlLFhHGpi4REvJO99O5d9fwMDXi8TUBVqbWpgYEKv545fI0uAny23aWbY1ua2RFStgHkza8pnGiunyr3PJxCSlDKTWPmsx7rNNzyoAV+tQYXKgqlG7hgVmG4LmDZrIgSF0yVua+791iOv/Y95eyj4xF0TfXBrmN/6+0UbwVsN/oBcUxBMISDW5xBS5fDdfjuU9xJsTzr0QisrBu2pR/bz5UNT/H/8vhLGkf2RTO/mJuGdttU42CCYR/jWor+/TDSNFf/54oYNLrKlyNDI8qt83efYSFWbiRrF+wG8/rKMkX+daLgG344+/aby7JSR3C/yycOUM8qNHrHR7PgMI2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 19 Feb 2025 14:06:52 +0800 Wupeng Ma wrote: > > ... > Thanks, I queued the below fix, so people can see what changed from v2: From: Ma Wupeng Subject: mm-memory-failure-update-ttu-flag-inside-unmap_poisoned_folio-v3 Date: Wed, 19 Feb 2025 14:06:52 +0800 unmap_poisoned_folio(): remove shadowed local `mapping', per Miaohe Link: https://lkml.kernel.org/r/20250219060653.3849083-1-mawupeng1@huawei.com Fixes: 6da6b1d4a7df ("mm/hwpoison: convert TTU_IGNORE_HWPOISON to TTU_HWPOISON") Suggested-by: David Hildenbrand Signed-off-by: Ma Wupeng Acked-by: David Hildenbrand Acked-by: Miaohe Lin Signed-off-by: Andrew Morton --- mm/memory-failure.c | 2 -- 1 file changed, 2 deletions(-) --- a/mm/memory-failure.c~mm-memory-failure-update-ttu-flag-inside-unmap_poisoned_folio-v3 +++ a/mm/memory-failure.c @@ -1585,8 +1585,6 @@ int unmap_poisoned_folio(struct folio *f } if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { - struct address_space *mapping; - /* * For hugetlb folios in shared mappings, try_to_unmap * could potentially call huge_pmd_unshare. Because of _